Cover Detail
Show a cover letter.
GET /api/covers/71649/?format=api
http://patches.dpdk.org/api/covers/71649/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20200617063047.1555518-1-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200617063047.1555518-1-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200617063047.1555518-1-jerinj@marvell.com", "date": "2020-06-17T06:30:34", "name": "[00/13] rte_log registration usage improvement", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20200617063047.1555518-1-jerinj@marvell.com/mbox/", "series": [ { "id": 10476, "url": "http://patches.dpdk.org/api/series/10476/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10476", "date": "2020-06-17T06:30:34", "name": "rte_log registration usage improvement", "version": 1, "mbox": "http://patches.dpdk.org/series/10476/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/71649/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C5785A04A5;\n\tWed, 17 Jun 2020 08:30:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 363E629C6;\n\tWed, 17 Jun 2020 08:30:20 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2CFE3FFA\n for <dev@dpdk.org>; Wed, 17 Jun 2020 08:30:18 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 05H6PnxW010482; Tue, 16 Jun 2020 23:30:16 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 31q658jmp1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 16 Jun 2020 23:30:16 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Tue, 16 Jun 2020 23:30:15 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 16 Jun 2020 23:30:15 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id A08DC3F704C;\n Tue, 16 Jun 2020 23:30:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0818; bh=tJMvtWRsFrQCYmPBh2Mkje15fSwa4PEsF8Yz/zUS61A=;\n b=l+hrrcS0cc3zwPI4DmQ9BPb9Tk46aj7vtshaq2DfApjMYzX6DH9BE3l5wMndLnP/q3C7\n VAH7lKPI+/cuVq2t+ITiw8TcRwSEP5zbrbqV6krw495xMCd/pmHwLKnI/7si80rON3T0\n r7tl37FGszpd41oM68/qVxDCf8WLhQFykQMZBhyBJTRsQfWkpLYyZyuVxBmy/vYOYl+V\n XfULc091Yy0jP9VGdtdb1GfzzmbYzyOvYSGN8SDY+f29GZhIyd4ibQ37tKtqsU9nR5nZ\n GG3ZwzFT4syaTk1cAxPrytMPwa4ychmbXCN1LJRYsT0IxoWDXLPo1yx1BP6a22udWWHB ZQ==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>,\n <david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>", "Date": "Wed, 17 Jun 2020 12:00:34 +0530", "Message-ID": "<20200617063047.1555518-1-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687\n definitions=2020-06-16_13:2020-06-16,\n 2020-06-16 signatures=0", "Subject": "[dpdk-dev] [PATCH 00/13] rte_log registration usage improvement", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nThis patch series improves the rte_log registration code snippet by\navoiding duplication of the code around registration by\nintroducing RTE_LOG_REGISTER macro.\n\nPending stuff\n~~~~~~~~~~~~~\nI have converted all existing rte_log_register() to new macro, except\nthe following (as it has different usage style)\n1) drivers/common/mlx5/mlx5_common.c\n2) drivers/net/e1000/e1000_logs.c\n3) drivers/net/sfc/sfc_ethdev.c\n\nExample usage of new macro\n~~~~~~~~~~~~~~~~~~~~~~~~~~\n-/**\n- * @internal\n- */\n-int otx2_logtype_base;\n-/**\n- * @internal\n- */\n-int otx2_logtype_mbox;\n-/**\n- * @internal\n- */\n-int otx2_logtype_npa;\n-/**\n- * @internal\n- */\n-int otx2_logtype_nix;\n-/**\n- * @internal\n- */\n-int otx2_logtype_npc;\n-/**\n- * @internal\n- */\n-int otx2_logtype_tm;\n-/**\n- * @internal\n- */\n-int otx2_logtype_sso;\n-/**\n- * @internal\n- */\n-int otx2_logtype_tim;\n-/**\n- * @internal\n- */\n-int otx2_logtype_dpi;\n-/**\n- * @internal\n- */\n-int otx2_logtype_ep;\n-\n-RTE_INIT(otx2_log_init);\n-static void\n-otx2_log_init(void)\n-{\n- otx2_logtype_base = rte_log_register(\"pmd.octeontx2.base\");\n- if (otx2_logtype_base >= 0)\n- rte_log_set_level(otx2_logtype_base, RTE_LOG_NOTICE);\n-\n- otx2_logtype_mbox = rte_log_register(\"pmd.octeontx2.mbox\");\n- if (otx2_logtype_mbox >= 0)\n- rte_log_set_level(otx2_logtype_mbox, RTE_LOG_NOTICE);\n-\n- otx2_logtype_npa = rte_log_register(\"pmd.mempool.octeontx2\");\n- if (otx2_logtype_npa >= 0)\n- rte_log_set_level(otx2_logtype_npa, RTE_LOG_NOTICE);\n-\n- otx2_logtype_nix = rte_log_register(\"pmd.net.octeontx2\");\n- if (otx2_logtype_nix >= 0)\n- rte_log_set_level(otx2_logtype_nix, RTE_LOG_NOTICE);\n-\n- otx2_logtype_npc = rte_log_register(\"pmd.net.octeontx2.flow\");\n- if (otx2_logtype_npc >= 0)\n- rte_log_set_level(otx2_logtype_npc, RTE_LOG_NOTICE);\n-\n- otx2_logtype_tm = rte_log_register(\"pmd.net.octeontx2.tm\");\n- if (otx2_logtype_tm >= 0)\n- rte_log_set_level(otx2_logtype_tm, RTE_LOG_NOTICE);\n-\n- otx2_logtype_sso = rte_log_register(\"pmd.event.octeontx2\");\n- if (otx2_logtype_sso >= 0)\n- rte_log_set_level(otx2_logtype_sso, RTE_LOG_NOTICE);\n-\n- otx2_logtype_tim =\n rte_log_register(\"pmd.event.octeontx2.timer\");\n- if (otx2_logtype_tim >= 0)\n- rte_log_set_level(otx2_logtype_tim, RTE_LOG_NOTICE);\n-\n- otx2_logtype_dpi = rte_log_register(\"pmd.raw.octeontx2.dpi\");\n- if (otx2_logtype_dpi >= 0)\n- rte_log_set_level(otx2_logtype_dpi, RTE_LOG_NOTICE);\n-\n- otx2_logtype_ep = rte_log_register(\"pmd.raw.octeontx2.ep\");\n- if (otx2_logtype_ep >= 0)\n- rte_log_set_level(otx2_logtype_ep, RTE_LOG_NOTICE);\n-\n-}\n+RTE_LOG_REGISTER(otx2_logtype_base, pmd.octeontx2.base, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_mbox, pmd.octeontx2.mbox, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_npa, pmd.mempool.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_nix, pmd.net.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_npc, pmd.net.octeontx2.flow, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_tm, pmd.net.octeontx2.tm, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_sso, pmd.event.octeontx2, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_tim, pmd.event.octeontx2.timer, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_dpi, pmd.raw.octeontx2.dpi, NOTICE);\n+RTE_LOG_REGISTER(otx2_logtype_ep, pmd.raw.octeontx2.ep, NOTICE);\n\n\n\nJerin Jacob (13):\n eal/log: introduce log register macro\n lib: use log register macro\n drivers/vdpa: use log register macro\n drivers/raw: use log register macro\n drivers/net: use log register macro\n drivers/mempool: use log register macro\n drivers/event: use log register macro\n drivers/crypto: use log register macro\n drivers/compress: use log register macro\n drivers/common: use log register macro\n drivers/bus: use log register macro\n drivers/baseband: use log register macro\n app/test: use log register macro\n\n app/test/test_efd.c | 6 +-\n app/test/test_hash.c | 7 +-\n app/test/test_timer_racecond.c | 7 +-\n .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 17 +---\n drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 18 +---\n drivers/baseband/null/bbdev_null.c | 9 +-\n .../baseband/turbo_sw/bbdev_turbo_software.c | 9 +-\n drivers/bus/dpaa/dpaa_bus.c | 10 +-\n drivers/bus/fslmc/fslmc_bus.c | 11 +--\n drivers/bus/ifpga/ifpga_bus.c | 9 +-\n drivers/bus/vdev/vdev.c | 10 +-\n drivers/bus/vmbus/vmbus_common.c | 9 +-\n drivers/common/dpaax/dpaax_iova_table.c | 10 +-\n drivers/common/iavf/iavf_impl.c | 9 +-\n drivers/common/octeontx/octeontx_mbox.c | 9 +-\n drivers/common/octeontx2/otx2_common.c | 96 ++-----------------\n drivers/common/qat/qat_logs.c | 17 +---\n drivers/compress/isal/isal_compress_pmd.c | 10 +-\n drivers/compress/octeontx/otx_zip_pmd.c | 10 +-\n drivers/compress/zlib/zlib_pmd.c | 10 +-\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 8 +-\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 8 +-\n drivers/crypto/caam_jr/caam_jr.c | 8 +-\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 11 +--\n drivers/crypto/dpaa_sec/dpaa_sec.c | 10 +-\n drivers/crypto/kasumi/rte_kasumi_pmd.c | 6 +-\n drivers/crypto/mvsam/rte_mrvl_pmd.c | 7 +-\n drivers/crypto/nitrox/nitrox_logs.c | 9 +-\n drivers/crypto/null/null_crypto_pmd.c | 7 +-\n drivers/crypto/octeontx/otx_cryptodev.c | 10 +-\n drivers/crypto/octeontx2/otx2_cryptodev.c | 12 +--\n drivers/crypto/openssl/rte_openssl_pmd.c | 7 +-\n .../scheduler/rte_cryptodev_scheduler.c | 8 +-\n drivers/crypto/snow3g/rte_snow3g_pmd.c | 7 +-\n drivers/crypto/virtio/virtio_cryptodev.c | 39 ++------\n drivers/crypto/zuc/rte_zuc_pmd.c | 7 +-\n drivers/event/dpaa/dpaa_eventdev.c | 8 +-\n drivers/event/dpaa2/dpaa2_eventdev.c | 10 +-\n drivers/event/octeontx/ssovf_evdev.c | 8 +-\n drivers/event/octeontx/timvf_evdev.c | 9 +-\n drivers/event/opdl/opdl_evdev.c | 8 +-\n drivers/event/opdl/opdl_ring.c | 2 -\n drivers/event/sw/sw_evdev.c | 11 +--\n drivers/mempool/dpaa/dpaa_mempool.c | 10 +-\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 10 +-\n drivers/mempool/octeontx/octeontx_fpavf.c | 10 +-\n drivers/net/af_packet/rte_eth_af_packet.c | 8 +-\n drivers/net/af_xdp/rte_eth_af_xdp.c | 8 +-\n drivers/net/ark/ark_ethdev.c | 10 +-\n drivers/net/atlantic/atl_ethdev.c | 15 +--\n drivers/net/avp/avp_ethdev.c | 10 +-\n drivers/net/axgbe/axgbe_ethdev.c | 15 +--\n drivers/net/bnx2x/bnx2x_ethdev.c | 15 +--\n drivers/net/bnxt/bnxt_ethdev.c | 9 +-\n drivers/net/bonding/rte_eth_bond_pmd.c | 9 +-\n drivers/net/cxgbe/cxgbe_ethdev.c | 15 +--\n drivers/net/dpaa/dpaa_ethdev.c | 9 +-\n drivers/net/dpaa2/dpaa2_ethdev.c | 9 +-\n drivers/net/ena/ena_ethdev.c | 48 ++--------\n drivers/net/enetc/enetc_ethdev.c | 10 +-\n drivers/net/enic/enic_ethdev.c | 9 +-\n drivers/net/failsafe/failsafe.c | 10 +-\n drivers/net/fm10k/fm10k_ethdev.c | 40 +-------\n drivers/net/hinic/hinic_pmd_ethdev.c | 11 +--\n drivers/net/hns3/hns3_ethdev.c | 15 +--\n drivers/net/i40e/i40e_ethdev.c | 38 +-------\n drivers/net/iavf/iavf_ethdev.c | 40 +-------\n drivers/net/ice/ice_ethdev.c | 38 +-------\n drivers/net/igc/igc_logs.c | 16 +---\n drivers/net/ionic/ionic_ethdev.c | 10 +-\n drivers/net/ipn3ke/ipn3ke_ethdev.c | 10 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 39 ++------\n drivers/net/kni/rte_eth_kni.c | 9 +-\n drivers/net/liquidio/lio_ethdev.c | 15 +--\n drivers/net/memif/rte_eth_memif.c | 9 +-\n drivers/net/mlx4/mlx4.c | 11 +--\n drivers/net/mlx5/mlx5.c | 11 +--\n drivers/net/mvneta/mvneta_ethdev.c | 10 +-\n drivers/net/mvpp2/mrvl_ethdev.c | 10 +-\n drivers/net/netvsc/hn_ethdev.c | 15 +--\n drivers/net/nfp/nfp_net.c | 15 +--\n drivers/net/null/rte_eth_null.c | 8 +-\n drivers/net/octeontx/octeontx_ethdev.c | 21 +---\n drivers/net/pcap/rte_eth_pcap.c | 8 +-\n drivers/net/pfe/pfe_ethdev.c | 10 +-\n drivers/net/qede/qede_ethdev.c | 16 +---\n drivers/net/ring/rte_eth_ring.c | 8 +-\n drivers/net/softnic/rte_eth_softnic.c | 10 +-\n drivers/net/szedata2/rte_eth_szedata2.c | 15 +--\n drivers/net/tap/rte_eth_tap.c | 9 +-\n drivers/net/thunderx/nicvf_ethdev.c | 21 +---\n drivers/net/vdev_netvsc/vdev_netvsc.c | 13 +--\n drivers/net/vhost/rte_eth_vhost.c | 8 +-\n drivers/net/virtio/virtio_ethdev.c | 15 +--\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 15 +--\n drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 11 +--\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 11 +--\n drivers/raw/ifpga/ifpga_rawdev.c | 10 +-\n drivers/raw/ioat/ioat_rawdev.c | 12 +--\n drivers/raw/ioat/rte_ioat_rawdev.h | 2 -\n drivers/raw/ntb/ntb.c | 10 +-\n drivers/raw/skeleton/skeleton_rawdev.c | 11 +--\n drivers/vdpa/ifc/ifcvf_vdpa.c | 10 +-\n drivers/vdpa/mlx5/mlx5_vdpa.c | 7 +-\n lib/librte_bbdev/rte_bbdev.c | 8 +-\n lib/librte_bpf/bpf.c | 9 +-\n lib/librte_cfgfile/rte_cfgfile.c | 8 +-\n lib/librte_compressdev/rte_compressdev.c | 7 +-\n lib/librte_compressdev/rte_compressdev_pmd.c | 2 -\n lib/librte_eal/include/rte_log.h | 25 +++++\n lib/librte_ethdev/rte_ethdev.c | 9 +-\n lib/librte_eventdev/rte_event_timer_adapter.c | 21 +---\n lib/librte_flow_classify/rte_flow_classify.c | 10 +-\n lib/librte_graph/graph.c | 7 +-\n lib/librte_member/rte_member.c | 9 +-\n lib/librte_metrics/rte_metrics_telemetry.c | 5 +-\n lib/librte_node/log.c | 9 +-\n lib/librte_pdump/rte_pdump.c | 9 +-\n lib/librte_rawdev/rte_rawdev.c | 7 +-\n lib/librte_rcu/rte_rcu_qsbr.c | 9 +-\n lib/librte_stack/rte_stack.c | 7 +-\n lib/librte_vhost/vhost.c | 15 +--\n 122 files changed, 229 insertions(+), 1322 deletions(-)" }{ "id": 71649, "url": "