Cover Detail
Show a cover letter.
GET /api/covers/694/?format=api
http://patches.dpdk.org/api/covers/694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-27T05:41:16", "name": "[v6,00/23] stop and remove RTE_MARKER typedefs", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31232, "url": "http://patches.dpdk.org/api/series/31232/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31232", "date": "2024-02-27T05:41:17", "name": "stop and remove RTE_MARKER typedefs", "version": 6, "mbox": "http://patches.dpdk.org/series/31232/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/694/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5867543C03;\n\tTue, 27 Feb 2024 06:42:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB9A442E46;\n\tTue, 27 Feb 2024 06:42:11 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 824E240295\n for <dev@dpdk.org>; Tue, 27 Feb 2024 06:41:41 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id A358D20B74C0; Mon, 26 Feb 2024 21:41:40 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A358D20B74C0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709012500;\n bh=2dElqHsk2Gowl6XlG2S23TYhy0F1nxJxe752neYV7/w=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=R3503XKOY+h8VFzIQnUTXlj2LZLbVRld1F2UyGB1xeDabwZyGgw6bvdL92cJTGYW5\n T6XRx1Zr4KhNxl7GhynZ2sfMvlsVJw3SfnXGsk7A3dW8wJEVcvuKcJGfn56Cqekeo7\n 7htjUVQkgmqhe4DyM0GbbqyALpp3/eRirooY+a0A=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 00/23] stop and remove RTE_MARKER typedefs", "Date": "Mon, 26 Feb 2024 21:41:16 -0800", "Message-Id": "<1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series\nstops referencing and removes the markers.\n\nThis series, does the following.\n\n* RTE_MARKER{,816,32,64} fields are removed from all structures.\n* Moves duplicated assertions referencing marker fields to\n rte_mbuf_core.h and updates them to be based on static_assert\n using non marker field names.\n* Updates prefetch inline functions to calculate the address to\n prefetch for cachline0 and cacheline1 without the markers.\n* Introduces 2 new inline functions for accessing rearm_data\n and rx_descriptor_fields1 descriptor to decouple from use\n of the marker field names so that they can be removed.\n* Updates driver access to use new inline descriptors.\n\nv6:\n * remove all rte marker fields and note their removal in release\n notes.\n * move duplicated assertions to global scope with struct rte_mbuf.\n * calculate cacheline{0,1} addresses without using struct rte_mbuf\n fields.\n * added comments into struct rte_mbuf field directing readers to\n use inline accessors for rearm_data and rx_descriptor_fields1\n descriptors.\n * added checkpatches check to block new additions using RTE_MARKER\n typedefs.\n * switch to using alignas to align cacheline1 in modified structs.\n * removed __rte_marker macro as it was not desired and is now not\n needed.\n\nv5:\n * update existing cacheline{0, 1} inline functions to access actual\n mbuf fields.\n * introduce new inline functions for accessing rearm_data and\n rx_descriptor_fields1 descriptors.\n * adapt drivers to use new inline functions.\n\nprior versions not relevant due to re-work of entire series.\n\nTyler Retzlaff (23):\n mbuf: add accessors for rearm and Rx descriptor fields\n mbuf: consolidate driver asserts for mbuf struct\n common/idpf: use mbuf descriptor accessors\n net/bnxt: use mbuf descriptor accessors\n net/cnxk: use mbuf descriptor accessors\n net/enic: use mbuf descriptor accessors\n net/fm10k: use mbuf descriptor accessors\n net/hns3: use mbuf descriptor accessors\n net/i40e: use mbuf descriptor accessors\n net/iavf: use mbuf descriptor accessors\n net/ice: use mbuf descriptor accessors\n net/ionic: use mbuf descriptor accessors\n net/ixgbe: use mbuf descriptor accessors\n net/mlx5: use mbuf descriptor accessors\n net/octeon_ep: use mbuf descriptor accessors\n net/sfc: use mbuf descriptor accessors\n net/thunderx: use mbuf descriptor accessors\n net/virtio: use mbuf descriptor accessors\n examples/dma: use mbuf descriptor accessor\n mbuf: remove and stop using rte marker fields\n security: remove rte marker fields\n cryptodev: remove rte marker fields\n devtools: forbid new use of rte marker typedefs\n\n devtools/checkpatches.sh | 8 +++\n doc/guides/rel_notes/release_24_03.rst | 15 +++++\n drivers/common/idpf/idpf_common_rxtx.c | 4 +-\n drivers/common/idpf/idpf_common_rxtx_avx512.c | 73 +++++----------------\n drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 32 +++++-----\n drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 +-\n drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 16 ++---\n drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 16 ++---\n drivers/net/cnxk/cn10k_rx.h | 36 +++++------\n drivers/net/cnxk/cn9k_rx.h | 20 +++---\n drivers/net/cnxk/cnxk_ethdev.c | 2 +-\n drivers/net/enic/enic_main.c | 4 +-\n drivers/net/enic/enic_rxtx_vec_avx2.c | 18 +++---\n drivers/net/fm10k/fm10k_rxtx_vec.c | 32 ++--------\n drivers/net/hns3/hns3_rxtx_vec.c | 22 +------\n drivers/net/hns3/hns3_rxtx_vec_neon.h | 24 +++----\n drivers/net/hns3/hns3_rxtx_vec_sve.c | 4 +-\n drivers/net/i40e/i40e_rxtx_vec_altivec.c | 18 ++----\n drivers/net/i40e/i40e_rxtx_vec_avx2.c | 34 +++-------\n drivers/net/i40e/i40e_rxtx_vec_avx512.c | 35 +++-------\n drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +-\n drivers/net/i40e/i40e_rxtx_vec_neon.c | 16 ++---\n drivers/net/i40e/i40e_rxtx_vec_sse.c | 43 +++----------\n drivers/net/iavf/iavf_rxtx_vec_avx2.c | 72 +++++----------------\n drivers/net/iavf/iavf_rxtx_vec_avx512.c | 72 +++++----------------\n drivers/net/iavf/iavf_rxtx_vec_common.h | 4 +-\n drivers/net/iavf/iavf_rxtx_vec_neon.c | 16 ++---\n drivers/net/iavf/iavf_rxtx_vec_sse.c | 85 +++++--------------------\n drivers/net/ice/ice_rxtx_vec_avx2.c | 36 +++--------\n drivers/net/ice/ice_rxtx_vec_avx512.c | 37 +++--------\n drivers/net/ice/ice_rxtx_vec_common.h | 4 +-\n drivers/net/ice/ice_rxtx_vec_sse.c | 44 +++----------\n drivers/net/ionic/ionic_lif.c | 6 +-\n drivers/net/ionic/ionic_rxtx_sg.c | 4 +-\n drivers/net/ionic/ionic_rxtx_simple.c | 2 +-\n drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 4 +-\n drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 12 ++--\n drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 51 ++++-----------\n drivers/net/mlx5/mlx5_rxq.c | 2 +-\n drivers/net/mlx5/mlx5_rxtx_vec.h | 19 ------\n drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 28 ++++----\n drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 20 +++---\n drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 28 ++++----\n drivers/net/octeon_ep/cnxk_ep_rx.h | 2 +-\n drivers/net/octeon_ep/cnxk_ep_rx_avx.c | 2 +-\n drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 8 +--\n drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 8 +--\n drivers/net/octeon_ep/otx_ep_rxtx.c | 5 +-\n drivers/net/sfc/sfc_ef100_rx.c | 7 +-\n drivers/net/sfc/sfc_ef10_rx.c | 10 +--\n drivers/net/thunderx/nicvf_ethdev.c | 4 +-\n drivers/net/thunderx/nicvf_rxtx.h | 4 +-\n drivers/net/virtio/virtio_rxtx_packed.h | 4 +-\n drivers/net/virtio/virtio_rxtx_packed_avx.h | 16 ++---\n drivers/net/virtio/virtio_rxtx_packed_neon.h | 18 +++---\n drivers/net/virtio/virtio_rxtx_simple.c | 4 +-\n drivers/net/virtio/virtio_rxtx_simple.h | 5 +-\n drivers/net/virtio/virtio_rxtx_simple_altivec.c | 16 ++---\n drivers/net/virtio/virtio_rxtx_simple_neon.c | 24 +++----\n drivers/net/virtio/virtio_rxtx_simple_sse.c | 16 ++---\n examples/dma/dmafwd.c | 5 +-\n lib/cryptodev/cryptodev_pmd.h | 5 +-\n lib/mbuf/rte_mbuf.h | 17 ++++-\n lib/mbuf/rte_mbuf_core.h | 50 ++++++++++++---\n lib/security/rte_security_driver.h | 5 +-\n 65 files changed, 445 insertions(+), 816 deletions(-)" }{ "id": 694, "url": "