Cover Detail
Show a cover letter.
GET /api/covers/68/?format=api
http://patches.dpdk.org/api/covers/68/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20230817084226.55327-1-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230817084226.55327-1-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230817084226.55327-1-lihuisong@huawei.com", "date": "2023-08-17T08:42:24", "name": "[v3,0/2] ethdev: add the check for PTP capability", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20230817084226.55327-1-lihuisong@huawei.com/mbox/", "series": [ { "id": 29261, "url": "http://patches.dpdk.org/api/series/29261/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29261", "date": "2023-08-17T08:42:25", "name": "ethdev: add the check for PTP capability", "version": 3, "mbox": "http://patches.dpdk.org/series/29261/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/68/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6234F4308C;\n\tThu, 17 Aug 2023 10:45:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A0DA42D12;\n\tThu, 17 Aug 2023 10:45:26 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id B246340ED9\n for <dev@dpdk.org>; Thu, 17 Aug 2023 10:45:22 +0200 (CEST)", "from kwepemm600004.china.huawei.com (unknown [172.30.72.54])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RRJR12lDYzFqZr;\n Thu, 17 Aug 2023 16:42:21 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Thu, 17 Aug 2023 16:45:19 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>,\n <andrew.rybchenko@oktetlabs.ru>, <liuyonglong@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH v3 0/2] ethdev: add the check for PTP capability", "Date": "Thu, 17 Aug 2023 16:42:24 +0800", "Message-ID": "<20230817084226.55327-1-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220628133959.21381-1-liudongdong3@huawei.com>", "References": "<20220628133959.21381-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemm600004.china.huawei.com (7.193.23.242)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From the first version of ptpclient, it seems that this example assume that\nthe PMDs support the PTP feature and enable PTP by default. Please see\ncommit ab129e9065a5 (\"examples/ptpclient: add minimal PTP client\")\nwhich are introduced in 2015.\n\nAnd two years later, Rx HW timestamp offload was introduced to enable or\ndisable PTP feature in HW via rte_eth_rxmode. Please see\ncommit 42ffc45aa340 (\"ethdev: add Rx HW timestamp capability\"). \n\nAnd then about four years later, ptpclient enable Rx timestamp offload\nbecause some PMDs require this offload to enable. Please see\ncommit 7a04a4f67dca (\"examples/ptpclient: enable Rx timestamp offload\").\n\nBy all the records, this is more like a process of perfecting PTP feature.\nNot all network adaptors support PTP feature. So adding the check for PTP\ncapability in ethdev layer is necessary.\n\n---\nv3:\n - patch [2/3] for hns3 has been applied and so remove it.\n - ops pointer check is closer to usage.\n\nHuisong Li (2):\n examples/ptpclient: add the check for PTP capability\n ethdev: add the check for the valitity of timestamp offload\n\n examples/ptpclient/ptpclient.c | 5 +++\n lib/ethdev/rte_ethdev.c | 57 +++++++++++++++++++++++++++++++++-\n 2 files changed, 61 insertions(+), 1 deletion(-)" }{ "id": 68, "url": "