Cover Detail
Show a cover letter.
GET /api/covers/65690/?format=api
{ "id": 65690, "url": "http://patches.dpdk.org/api/covers/65690/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20200210114009.49590-1-ciara.loftus@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200210114009.49590-1-ciara.loftus@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200210114009.49590-1-ciara.loftus@intel.com", "date": "2020-02-10T11:40:06", "name": "[v3,0/3] AF_XDP PMD Fixes", "submitter": { "id": 144, "url": "http://patches.dpdk.org/api/people/144/?format=api", "name": "Loftus, Ciara", "email": "ciara.loftus@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20200210114009.49590-1-ciara.loftus@intel.com/mbox/", "series": [ { "id": 8484, "url": "http://patches.dpdk.org/api/series/8484/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8484", "date": "2020-02-10T11:40:06", "name": "AF_XDP PMD Fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/8484/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/65690/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 95638A052F;\n\tMon, 10 Feb 2020 12:39:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D8381BDAE;\n\tMon, 10 Feb 2020 12:39:14 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id AC6B3AAD5\n for <dev@dpdk.org>; Mon, 10 Feb 2020 12:39:11 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2020 03:39:11 -0800", "from silpixa00373417.ir.intel.com (HELO\n silpixa00373417.ger.corp.intel.com) ([10.237.223.96])\n by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2020 03:39:10 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,424,1574150400\"; d=\"scan'208\";a=\"431573501\"", "From": "Ciara Loftus <ciara.loftus@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Loftus <ciara.loftus@intel.com>", "Date": "Mon, 10 Feb 2020 11:40:06 +0000", "Message-Id": "<20200210114009.49590-1-ciara.loftus@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v3 0/3] AF_XDP PMD Fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This series introduces some fixes for the zero copy path of the AF_XDP.\nIn zero copy, the mempool objects are mapped directly into the AF_XDP UMEM.\nBelow depicts the layout of an object in a mempool.\n\n+-----+--------+------+------+-----+-------------+\n| mp | struct | mbuf | mbuf | XDP | |\n| hdr | rte_ | priv | hr | hr | payload |\n| obj | mbuf | | | | |\n+-----+--------+------+------+-----+-------------+\n 64 128 * 128 256 *\n\n<---------------- frame size -------------------->\n<---- frame hr ------------->\n\n1: net/af_xdp: fix umem frame size & headroom calculations\n* The previous frame size calculation incorrectly used\nmb_pool->private_data_size and didn't include mb_pool->header_size. Instead\nof performing a manual calculation, use the rte_mempool_calc_obj_size API\nto determine the frame size.\n* The previous frame headroom calculation also incorrectly used\nmb_pool->private_data_size and didn't include mb_pool->header_size or the\nmbuf priv size.\n\n2. net/af_xdp: use correct fill queue addresses\nThe fill queue addresses should start at the beginning of the mempool\nobject instead of the beginning of the mbuf. This is because the umem frame\nheadroom includes the mp hdrobj size. Starting at this point ensures AF_XDP\ndoesn't write past the available room in the frame, in the case of larger\npackets which are close to the size of the mbuf.\n\n3. net/af_xdp: fix maximum MTU value\nThe maximum MTU for af_xdp zero copy is equal to the page size less the\nframe overhead introduced by AF_XDP (XDP HR = 256) and DPDK (frame hr = \n320). The patch updates this value to reflect this, and removes some\nunneeded constants for both zero-copy and copy mode.\n\nv3:\n* Fix send-email issue - use in-reply-to\n\nv2:\n* Include mbuf priv size in rx mbuf data_off calculation\n\nCiara Loftus (3):\n net/af_xdp: fix umem frame size & headroom calculations\n net/af_xdp: use correct fill queue addresses\n net/af_xdp: fix maximum MTU value\n\n drivers/net/af_xdp/rte_eth_af_xdp.c | 61 +++++++++++++++++------------\n 1 file changed, 36 insertions(+), 25 deletions(-)" }