Cover Detail
Show a cover letter.
GET /api/covers/65375/?format=api
{ "id": 65375, "url": "http://patches.dpdk.org/api/covers/65375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1580400880-96628-1-git-send-email-akozyrev@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580400880-96628-1-git-send-email-akozyrev@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580400880-96628-1-git-send-email-akozyrev@mellanox.com", "date": "2020-01-30T16:14:35", "name": "[v5,0/5] net/mlx: assert cleanup in mlx drivers", "submitter": { "id": 1573, "url": "http://patches.dpdk.org/api/people/1573/?format=api", "name": "Alexander Kozyrev", "email": "akozyrev@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1580400880-96628-1-git-send-email-akozyrev@mellanox.com/mbox/", "series": [ { "id": 8359, "url": "http://patches.dpdk.org/api/series/8359/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8359", "date": "2020-01-30T16:14:36", "name": "net/mlx: assert cleanup in mlx drivers", "version": 5, "mbox": "http://patches.dpdk.org/series/8359/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/65375/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5481CA0524;\n\tThu, 30 Jan 2020 17:15:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 02F7B1C0B3;\n\tThu, 30 Jan 2020 17:14:50 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id E18201C031\n for <dev@dpdk.org>; Thu, 30 Jan 2020 17:14:44 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n akozyrev@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 30 Jan 2020 18:14:42 +0200", "from pegasus02.mtr.labs.mlnx. (pegasus02.mtr.labs.mlnx\n [10.210.16.122])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00UGEfJ7009609;\n Thu, 30 Jan 2020 18:14:41 +0200" ], "From": "Alexander Kozyrev <akozyrev@mellanox.com>", "To": "dev@dpdk.org", "Cc": "rasland@mellanox.com, matan@mellanox.com, viacheslavo@mellanox.com,\n ferruh.yigit@intel.com, thomas@monjalon.net", "Date": "Thu, 30 Jan 2020 18:14:35 +0200", "Message-Id": "<1580400880-96628-1-git-send-email-akozyrev@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1579789555-23239-1-git-send-email-akozyrev@mellanox.com>", "References": "<1579789555-23239-1-git-send-email-akozyrev@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v5 0/5] net/mlx: assert cleanup in mlx drivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "net/mlx: assert cleanup in mlx drivers\n\nThe Mellanox PMD uses the NDEBUG definition to control built-in debug\nfeatures including the asserting one. The DPDK uses a bit different\napproach and provides RTE_ASSERT macro and appropriate global\nconfiguration option: CONFIG_RTE_ENABLE_ASSERT.\nThe patch set introduces the MLX_ASSERT macros that allows to follow\nthe DPDK approach in a unified fashion and, at the same time,\nprovides the opportunity to turn on Mellanox PMD assert feature with\ndedicated local configuration options: CONFIG_RTE_LIBRTE_MLX_DEBUG.\nNote that the direct configuration MLX_DEBUG is clearer than\ndouble negation \"ifndef NDEBUG\" used before.\nThis patch set triggers another false positive warning with ICC.\nTo spare future development efforts we disable the treatments of\ncompilation warnings as errors in ICC config. GCC stays as a guard.\n\nSigned-off-by: Alexander Kozyrev <akozyrev@mellanox.com>\n---\nv1: http://patches.dpdk.org/cover/65082/\nv2: http://patches.dpdk.org/cover/65089/ \n - Corrects typos and make commit messages more accurate.\n - Fixes broken compilation due to an undefined function in debug mode.\nv3: http://patches.dpdk.org/cover/65145/\n - Uses RTE_LIBRTE_MLX_DEBUG directly instead of MLX_DEBUG\nv4: http://patches.dpdk.org/cover/65364/\n - Covers a new mlx5 common library driver\nv5:\n - Merges with a new version of mlx5\n\nAlexander Kozyrev (5):\n mk/icc: disable treatment of warnings as errors\n net/mlx4: use mlx4 debug flag instead of NDEBUG\n net/mlx4: introduce the mlx4 version of the assert\n drivers: use mlx5 debug flag instead of NDEBUG\n drivers: introduce the mlx5 version of the assert\n\n drivers/common/mlx5/Makefile | 2 +-\n drivers/common/mlx5/meson.build | 4 +-\n drivers/common/mlx5/mlx5_common.c | 4 +-\n drivers/common/mlx5/mlx5_common.h | 38 ++--\n drivers/common/mlx5/mlx5_devx_cmds.c | 8 +-\n drivers/common/mlx5/mlx5_nl.c | 14 +-\n drivers/common/mlx5/mlx5_prm.h | 3 +-\n drivers/net/mlx4/Makefile | 4 +-\n drivers/net/mlx4/meson.build | 4 +-\n drivers/net/mlx4/mlx4.c | 29 ++-\n drivers/net/mlx4/mlx4_ethdev.c | 5 +-\n drivers/net/mlx4/mlx4_flow.c | 34 ++--\n drivers/net/mlx4/mlx4_intr.c | 3 +-\n drivers/net/mlx4/mlx4_mp.c | 25 ++-\n drivers/net/mlx4/mlx4_mr.c | 74 ++++----\n drivers/net/mlx4/mlx4_rxq.c | 53 +++---\n drivers/net/mlx4/mlx4_rxtx.c | 29 ++-\n drivers/net/mlx4/mlx4_txq.c | 17 +-\n drivers/net/mlx4/mlx4_utils.c | 3 +-\n drivers/net/mlx4/mlx4_utils.h | 15 +-\n drivers/net/mlx5/Makefile | 4 +-\n drivers/net/mlx5/meson.build | 4 +-\n drivers/net/mlx5/mlx5.c | 77 ++++----\n drivers/net/mlx5/mlx5_ethdev.c | 69 ++++----\n drivers/net/mlx5/mlx5_flow.c | 69 ++++----\n drivers/net/mlx5/mlx5_flow_dv.c | 97 ++++++-----\n drivers/net/mlx5/mlx5_flow_meter.c | 12 +-\n drivers/net/mlx5/mlx5_flow_verbs.c | 4 +-\n drivers/net/mlx5/mlx5_mac.c | 5 +-\n drivers/net/mlx5/mlx5_mp.c | 29 ++-\n drivers/net/mlx5/mlx5_mr.c | 71 ++++----\n drivers/net/mlx5/mlx5_rss.c | 3 +-\n drivers/net/mlx5/mlx5_rxq.c | 41 +++--\n drivers/net/mlx5/mlx5_rxtx.c | 291 ++++++++++++++++---------------\n drivers/net/mlx5/mlx5_rxtx.h | 6 +-\n drivers/net/mlx5/mlx5_rxtx_vec.c | 1 -\n drivers/net/mlx5/mlx5_rxtx_vec.h | 7 +-\n drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 11 +-\n drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 11 +-\n drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 11 +-\n drivers/net/mlx5/mlx5_socket.c | 4 +-\n drivers/net/mlx5/mlx5_stats.c | 2 +-\n drivers/net/mlx5/mlx5_txq.c | 59 +++----\n drivers/net/mlx5/mlx5_utils.c | 8 +-\n drivers/net/mlx5/mlx5_utils.h | 20 ---\n drivers/net/mlx5/mlx5_vlan.c | 19 +-\n mk/toolchain/icc/rte.vars.mk | 4 -\n 47 files changed, 638 insertions(+), 669 deletions(-)" }