Cover Detail
Show a cover letter.
GET /api/covers/64915/?format=api
{ "id": 64915, "url": "http://patches.dpdk.org/api/covers/64915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20200120131146.1135-1-adamx.dybkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200120131146.1135-1-adamx.dybkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200120131146.1135-1-adamx.dybkowski@intel.com", "date": "2020-01-20T13:11:43", "name": "[v7,0/3] Refactor crypto unit tests.", "submitter": { "id": 1322, "url": "http://patches.dpdk.org/api/people/1322/?format=api", "name": "Dybkowski, AdamX", "email": "adamx.dybkowski@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20200120131146.1135-1-adamx.dybkowski@intel.com/mbox/", "series": [ { "id": 8218, "url": "http://patches.dpdk.org/api/series/8218/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8218", "date": "2020-01-20T13:11:43", "name": "Refactor crypto unit tests.", "version": 7, "mbox": "http://patches.dpdk.org/series/8218/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/64915/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4E5AA0528;\n\tMon, 20 Jan 2020 14:11:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1139C1252;\n\tMon, 20 Jan 2020 14:11:51 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 4C13A11A4\n for <dev@dpdk.org>; Mon, 20 Jan 2020 14:11:49 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2020 05:11:48 -0800", "from adamdybx-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n ([10.104.125.17])\n by fmsmga002.fm.intel.com with ESMTP; 20 Jan 2020 05:11:47 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,342,1574150400\"; d=\"scan'208\";a=\"258704548\"", "From": "Adam Dybkowski <adamx.dybkowski@intel.com>", "To": "dev@dpdk.org,\n\tfiona.trahe@intel.com,\n\takhil.goyal@nxp.com", "Cc": "Adam Dybkowski <adamx.dybkowski@intel.com>", "Date": "Mon, 20 Jan 2020 14:11:43 +0100", "Message-Id": "<20200120131146.1135-1-adamx.dybkowski@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200117144651.26804-1-adamx.dybkowski@intel.com>", "References": "<20200117144651.26804-1-adamx.dybkowski@intel.com>", "Subject": "[dpdk-dev] [PATCH v7 0/3] Refactor crypto unit tests.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch set is a first step to refactor the overly complex symmetric\ncrypto unit tests. It merges many separate arrays of the tests\nfor these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g,\nsw_kasumi, sw_zuc into one big array that's then used when running\nunit tests on these PMDs.\n\nIndividual test functions check the capabilities and execute the rest\nof the test or skip (return -ENOTSUP) based on the particular test\nrequirements - e.g. test if PMD supports ZUC algo or even a particular\nkey length in few cases. Few edge cases required to check the PMD\nitself (e.g. run on QAT only, or skip on AES NI / AES GCM). \n\nIt's the first step of bigger refactoring. Maintainers of other PMDs\nare encouraged to add their PMD unit tests also into this big central\narray and remove individual test macro arrays.\n\nThis patch doesn't address next refactoring steps to be done in the\nfuture: geting rid of many small (usually 1-2 line) test functions,\ncreated separately for every test case; and simplifying many bigger\nfunctions that currently do similar things but work on different\ntest vector structures.\n\nA simple script to check if symmetric crypto unit tests work properly\non multiple PMDs at once, update the PMDs list to your needs:\n\nfor PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g sw_kasumi sw_zuc\ndo\n echo +++++ $PMD +++++\n echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level=7 | grep ' Tests [Failed|Passed]'\ndone\n\n---\nv2:\n* Update the cover letter, regenerate the patch file.\nv3:\n* Break very large commit into four smaller commits, easier to review.\n* Show in the cover letter how to run unit tests on multiple PMDs at once.\nv4:\n* Rebase.\nv5:\n* Fix a test failing on SW ZUC PMD.\nv6:\n* Rebase again, squash first two commits to allow building individual patches.\nv7:\n* Fix checking of the capabilities in the function test_pdcp_proto\nused by dpaa/dpaa2 PMDs. Check security capabilities instead of crypto. \n\nAdam Dybkowski (3):\n test/crypto: refactor unit tests\n test/crypto: add capability checks\n test/crypto: refactor unit tests into one combined array\n\n app/test/test_cryptodev.c | 15975 +++++++++----------\n app/test/test_cryptodev_blockcipher.c | 2 +-\n app/test/test_cryptodev_des_test_vectors.h | 6 +-\n 3 files changed, 7328 insertions(+), 8655 deletions(-)" }