Cover Detail
Show a cover letter.
GET /api/covers/64872/?format=api
{ "id": 64872, "url": "http://patches.dpdk.org/api/covers/64872/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20200118193247.43831-1-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200118193247.43831-1-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200118193247.43831-1-honnappa.nagarahalli@arm.com", "date": "2020-01-18T19:32:41", "name": "[v10,0/6] lib/ring: APIs to support custom element size", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20200118193247.43831-1-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 8204, "url": "http://patches.dpdk.org/api/series/8204/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8204", "date": "2020-01-18T19:32:41", "name": "lib/ring: APIs to support custom element size", "version": 10, "mbox": "http://patches.dpdk.org/series/8204/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/64872/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4081BA051C;\n\tSat, 18 Jan 2020 20:33:10 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B98A1BE94;\n\tSat, 18 Jan 2020 20:33:09 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id D0C9D1F5\n for <dev@dpdk.org>; Sat, 18 Jan 2020 20:33:07 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D3CC30E;\n Sat, 18 Jan 2020 11:33:07 -0800 (PST)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D04B3F6C4;\n Sat, 18 Jan 2020 11:33:07 -0800 (PST)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n pbhagavatula@marvell.com, konstantin.ananyev@intel.com,\n yipeng1.wang@intel.com, drc@linux.vnet.ibm.com,\n honnappa.nagarahalli@arm.com", "Cc": "dev@dpdk.org, dharmik.thakkar@arm.com, ruifeng.wang@arm.com,\n gavin.hu@arm.com, nd@arm.com", "Date": "Sat, 18 Jan 2020 13:32:41 -0600", "Message-Id": "<20200118193247.43831-1-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>", "References": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v10 0/6] lib/ring: APIs to support custom element\n\tsize", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current rte_ring hard-codes the type of the ring element to 'void *',\nhence the size of the element is hard-coded to 32b/64b. Since the ring\nelement type is not an input to rte_ring APIs, it results in couple\nof issues:\n\n1) If an application requires to store an element which is not 64b, it\n needs to write its own ring APIs similar to rte_event_ring APIs. This\n creates additional burden on the programmers, who end up making\n work-arounds and often waste memory.\n2) If there are multiple libraries that store elements of the same\n type, currently they would have to write their own rte_ring APIs. This\n results in code duplication.\n\nThis patch adds new APIs to support configurable ring element size.\nThe APIs support custom element sizes by allowing to define the ring\nelement to be a multiple of 32b.\n\nThe aim is to achieve same performance as the existing ring\nimplementation.\n\nv10\n - Improved comments in test case files (Olivier)\n - Fixed possible memory leaks (Olivier)\n - Changed 'test_ring_with_exact_size' to use unaligned\n addresses (Konstantin)\n - Changed the commit message for eventdev (Jerin)\n\nv9\n - Split 'test_ring_burst_bulk_tests' test case into 4 smaller\n functions to address clang compilation time issue.\n - Addressed compilation failure in Intel CI in the hash changes.\n\nv8\n - Changed the 128b copy elements inline function to use 'memcpy'\n to generate unaligned load/store instructions for x86. Generic\n copy function results in performance drop. (Konstantin)\n - Changed the API type #defines to be more clear (Konstantin)\n - Removed the code duplication in performance tests (Konstantin)\n - Fixed memory leak, changed test macros to inline functions (Konstantin)\n - Changed functional tests to test for 20B ring element. Fixed\n a bug in 32b element copy code for enqueue/dequeue(ring size\n needs to be normalized for 32b).\n - Squashed the functional and performance tests in their\n respective single commits.\n\nv7\n - Merged the test cases to test both legacy APIs and\n rte_ring_xxx_elem APIs without code duplication (Konstantin, Olivier)\n - Performance test cases are merged as well (Konstantin, Olivier)\n - Macros to copy elements are converted into inline functions (Olivier)\n - Added back the changes to hash and event libraries\n\nv6\n - Labelled as RFC to indicate the better status\n - Added unit tests to test the rte_ring_xxx_elem APIs\n - Corrected 'macro based partial memcpy' (5/6) patch\n - Added Konstantin's method after correction (6/6)\n - Check Patch shows significant warnings and errors mainly due\n copying code from existing test cases. None of them are harmful.\n I will fix them once we have an agreement.\n\nv5\n - Use memcpy for chunks of 32B (Konstantin).\n - Both 'ring_perf_autotest' and 'ring_perf_elem_autotest' are available\n to compare the results easily.\n - Copying without memcpy is also available in 1/3, if anyone wants to\n experiment on their platform.\n - Added other platform owners to test on their respective platforms.\n\nv4\n - Few fixes after more performance testing\n\nv3\n - Removed macro-fest and used inline functions\n (Stephen, Bruce)\n\nv2\n - Change Event Ring implementation to use ring templates\n (Jerin, Pavan)\n\n\nHonnappa Nagarahalli (6):\n test/ring: use division for cycle count calculation\n lib/ring: apis to support configurable element size\n test/ring: add functional tests for rte_ring_xxx_elem APIs\n test/ring: modify perf test cases to use rte_ring_xxx_elem APIs\n lib/hash: use ring with 32b element size to save memory\n eventdev: use custom element size ring for event rings\n\n app/test/test_ring.c | 1383 +++++++++++++-------------\n app/test/test_ring.h | 187 ++++\n app/test/test_ring_perf.c | 476 +++++----\n lib/librte_eventdev/rte_event_ring.c | 147 +--\n lib/librte_eventdev/rte_event_ring.h | 45 +-\n lib/librte_hash/rte_cuckoo_hash.c | 94 +-\n lib/librte_hash/rte_cuckoo_hash.h | 2 +-\n lib/librte_ring/Makefile | 3 +-\n lib/librte_ring/meson.build | 4 +\n lib/librte_ring/rte_ring.c | 41 +-\n lib/librte_ring/rte_ring.h | 1 +\n lib/librte_ring/rte_ring_elem.h | 1003 +++++++++++++++++++\n lib/librte_ring/rte_ring_version.map | 2 +\n 13 files changed, 2279 insertions(+), 1109 deletions(-)\n create mode 100644 app/test/test_ring.h\n create mode 100644 lib/librte_ring/rte_ring_elem.h" }