Cover Detail
Show a cover letter.
GET /api/covers/63853/?format=api
{ "id": 63853, "url": "http://patches.dpdk.org/api/covers/63853/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20191213152245.13477-1-adamx.dybkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191213152245.13477-1-adamx.dybkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191213152245.13477-1-adamx.dybkowski@intel.com", "date": "2019-12-13T15:22:40", "name": "[v3,0/4] Refactor crypto unit tests.", "submitter": { "id": 1322, "url": "http://patches.dpdk.org/api/people/1322/?format=api", "name": "Dybkowski, AdamX", "email": "adamx.dybkowski@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20191213152245.13477-1-adamx.dybkowski@intel.com/mbox/", "series": [ { "id": 7829, "url": "http://patches.dpdk.org/api/series/7829/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7829", "date": "2019-12-13T15:22:40", "name": "Refactor crypto unit tests.", "version": 3, "mbox": "http://patches.dpdk.org/series/7829/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/63853/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C81DA04F1;\n\tFri, 13 Dec 2019 16:22:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 198551BFD8;\n\tFri, 13 Dec 2019 16:22:52 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 6DCE11BFD5\n for <dev@dpdk.org>; Fri, 13 Dec 2019 16:22:50 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 13 Dec 2019 07:22:49 -0800", "from adamdybx-mobl.ger.corp.intel.com (HELO\n addy-VirtualBox.isw.intel.com) ([10.103.104.99])\n by fmsmga002.fm.intel.com with ESMTP; 13 Dec 2019 07:22:45 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,309,1571727600\"; d=\"scan'208\";a=\"246161078\"", "From": "Adam Dybkowski <adamx.dybkowski@intel.com>", "To": "dev@dpdk.org,\n\tfiona.trahe@intel.com,\n\takhil.goyal@nxp.com", "Cc": "ravi1.kumar@amd.com, ruifeng.wang@arm.com, anoobj@marvell.com,\n roy.fan.zhang@intel.com, declan.doherty@intel.com,\n pablo.de.lara.guarch@intel.com, rnagadheeraj@marvell.com,\n adwivedi@marvell.com, g.singh@nxp.com, jianjay.zhou@huawei.com,\n lironh@marvell.com, Adam Dybkowski <adamx.dybkowski@intel.com>", "Date": "Fri, 13 Dec 2019 16:22:40 +0100", "Message-Id": "<20191213152245.13477-1-adamx.dybkowski@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212140942.8210-1-adamx.dybkowski@intel.com>", "References": "<20191212140942.8210-1-adamx.dybkowski@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 0/4] Refactor crypto unit tests.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch set is a first step to refactor the overly complex symmetric\ncrypto unit tests. It merges many separate arrays of the tests\nfor these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g,\nsw_kasumi, sw_zuc into one big array that's then used when running\nunit tests on these PMDs.\n\nIndividual test functions check the capabilities and execute the rest\nof the test or skip (return -ENOTSUP) based on the particular test\nrequirements - e.g. test if PMD supports ZUC algo or even a particular\nkey length in few cases. Few edge cases required to check the PMD\nitself (e.g. run on QAT only, or skip on AES NI / AES GCM). \n\nIt's the first step of bigger refactoring. Maintainers of other PMDs\nare encouraged to add their PMD unit tests also into this big central\narray and remove individual test macro arrays.\n\nThis patch doesn't address next refactoring steps to be done in the\nfuture: geting rid of many small (usually 1-2 line) test functions,\ncreated separately for every test case; and simplifying many bigger\nfunctions that currently do similar things but work on different\ntest vector structures.\n\nNOTICE: This patch set depends on the series\nhttp://patches.dpdk.org/project/dpdk/list/?series=7792\nthat must be applied first.\n\nA simple script to check if symmetric crypto unit tests work properly\non multiple PMDs at once, update the PMDs list to your needs:\n\nfor PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g sw_kasumi sw_zuc\ndo\n echo +++++ $PMD +++++\n echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level=7 | grep ' Tests [Failed|Passed]'\ndone\n\n---\nv2:\n* Update the cover letter, regenerate the patch file.\nv3:\n* Break very large commit into four smaller commits, easier to review.\n* Show in the cover letter how to run unit tests on multiple PMDs at once.\n\nAdam Dybkowski (4):\n test/crypto: refactor unit tests\n test/crypto: refactor unit tests - continuation\n test/crypto: add capability checks\n test/crypto: refactor unit tests into one combined array\n\n app/test/test_cryptodev.c | 15891 +++++++++----------\n app/test/test_cryptodev_blockcipher.c | 2 +-\n app/test/test_cryptodev_des_test_vectors.h | 6 +-\n 3 files changed, 7303 insertions(+), 8596 deletions(-)" }