Cover Detail
Show a cover letter.
GET /api/covers/63079/?format=api
{ "id": 63079, "url": "http://patches.dpdk.org/api/covers/63079/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1574071619-10407-1-git-send-email-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1574071619-10407-1-git-send-email-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1574071619-10407-1-git-send-email-joyce.kong@arm.com", "date": "2019-11-18T10:06:53", "name": "[v3,0/6] implement common rte bit operation APIs in PMDs", "submitter": { "id": 970, "url": "http://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1574071619-10407-1-git-send-email-joyce.kong@arm.com/mbox/", "series": [ { "id": 7500, "url": "http://patches.dpdk.org/api/series/7500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7500", "date": "2019-11-18T10:06:53", "name": "implement common rte bit operation APIs in PMDs", "version": 3, "mbox": "http://patches.dpdk.org/series/7500/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/63079/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 26E41A0351;\n\tMon, 18 Nov 2019 11:07:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68931B62;\n\tMon, 18 Nov 2019 11:07:13 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 54DCF23D\n for <dev@dpdk.org>; Mon, 18 Nov 2019 11:07:12 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A115130E;\n Mon, 18 Nov 2019 02:07:11 -0800 (PST)", "from net-arm-thunderx2-01.test.ast.arm.com\n (net-arm-thunderx2-01.shanghai.arm.com [10.169.40.40])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DFB2F3F703;\n Mon, 18 Nov 2019 02:07:07 -0800 (PST)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, thomas@monjalon.net, jerinj@marvell.com,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n david.marchand@redhat.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com,\n ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com,\n xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,\n zhouguoyang@huawei.com", "Date": "Mon, 18 Nov 2019 18:06:53 +0800", "Message-Id": "<1574071619-10407-1-git-send-email-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "In-Reply-To": "<1571125801-45773-1-git-send-email-joyce.kong@arm.com>", "References": "<1571125801-45773-1-git-send-email-joyce.kong@arm.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 0/6] implement common rte bit operation APIs\n\tin PMDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are a lot functions of bit operations scattered in PMDs,\nconsolidate them into a common API family and applied in different\nPMDs to reduce code duplication.\n\nv3:\n 1. Change the API's head file back to rte_bitops.h, then implement both 32-bit and\n 64-bit operations with and without C11 atomic memory ordering.\n 2. Add multi-core test case for bit operations which implemented with memory ordering.\n 3. Modify the doc of both APIs and test cases.\n\nv2:\n 1. Add doxygen comments for the rte bit operation API(suggested by Stephen Hemminger).\n 2. Add test cases for common rte bit operation API(suggested by Stephen Hemminger).\n 3. Change the header file to rte_io_bitops.h and the operation to rte_io_set_bit()etc.,\n as the API uses barriers inside and the barriers are only needed for IO operations\n (suggested by Jerin Jacob).\n 4. Use an well defined uint_NN_t type(suggested by Morten Brørup).\n\nJoyce Kong (6):\n lib/eal: implement the family of rte bit operation APIs\n test/bitops: add bit operation test case\n net/axgbe: use common rte bit operation APIs instead\n net/bnx2x: use common rte bit operation APIs instead\n net/qede: use common rte bit operation APIs instead\n net/hinic: use common rte bit operation APIs instead\n\n app/test/Makefile | 1 +\n app/test/autotest_data.py | 6 +\n app/test/meson.build | 2 +\n app/test/test_bitops.c | 303 +++++++++++++\n doc/api/doxy-api-index.md | 3 +-\n drivers/net/axgbe/axgbe_common.h | 29 +-\n drivers/net/axgbe/axgbe_ethdev.c | 14 +-\n drivers/net/axgbe/axgbe_mdio.c | 14 +-\n drivers/net/bnx2x/bnx2x.c | 209 ++++-----\n drivers/net/bnx2x/bnx2x.h | 4 -\n drivers/net/bnx2x/ecore_sp.h | 9 +-\n drivers/net/hinic/Makefile | 1 +\n drivers/net/hinic/base/hinic_compat.h | 33 +-\n drivers/net/hinic/hinic_pmd_ethdev.c | 16 +-\n drivers/net/hinic/meson.build | 2 +\n drivers/net/qede/base/bcm_osal.c | 20 -\n drivers/net/qede/base/bcm_osal.h | 10 +-\n lib/librte_eal/common/Makefile | 1 +\n lib/librte_eal/common/include/rte_bitops.h | 474 +++++++++++++++++++++\n lib/librte_eal/common/meson.build | 1 +\n 20 files changed, 919 insertions(+), 233 deletions(-)\n create mode 100644 app/test/test_bitops.c\n create mode 100644 lib/librte_eal/common/include/rte_bitops.h" }