Cover Detail
Show a cover letter.
GET /api/covers/578/?format=api
{ "id": 578, "url": "http://patches.dpdk.org/api/covers/578/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20240123114053.172189-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240123114053.172189-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240123114053.172189-1-bruce.richardson@intel.com", "date": "2024-01-23T11:40:47", "name": "[0/6] remove incorrect code for loading 16B descriptors", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20240123114053.172189-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30884, "url": "http://patches.dpdk.org/api/series/30884/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30884", "date": "2024-01-23T11:40:47", "name": "remove incorrect code for loading 16B descriptors", "version": 1, "mbox": "http://patches.dpdk.org/series/30884/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/578/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F752439A7;\n\tTue, 23 Jan 2024 12:41:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6D0B7410E3;\n\tTue, 23 Jan 2024 12:41:15 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by mails.dpdk.org (Postfix) with ESMTP id 26FB2402B0\n for <dev@dpdk.org>; Tue, 23 Jan 2024 12:41:13 +0100 (CET)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jan 2024 03:41:13 -0800", "from silpixa00400957.ir.intel.com (HELO\n silpixa00401385.ir.intel.com) ([10.237.214.26])\n by orviesa002.jf.intel.com with ESMTP; 23 Jan 2024 03:41:13 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1706010074; x=1737546074;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=h+VCozXtdhAZD2nrjxIp0YmY3N09fqTeTuaBV1gdOWM=;\n b=cKIWcPrY69pqIb9uDlrPlDjfj4fswRodrsvqcFztM+DCe4mMl60PYT3+\n kpGHY5jDUHxi8Qs1aG8sVo6n7DmbaKtie80Nj/yolUtxQacEj7P0q/k4b\n diAK2YAADYw4319ImQPlLJc7cUUA594THBEHhhD7UsP1LVHkBaEs7l0gQ\n qPbpHKYbWYlhp5eM/h13GQvKADMOKeADAoNg0ZZOwHgVXxhVkrL3Bub8n\n wjTMMWRObAD1nhlzRJiyFD6HrOUFYsM4MXQ11LraibcQUJpFfRMKKPuDC\n Hfz/86PxFZgRxu+FDgQXsI2yg+NOujfdVMtqR41UQuOj82Mh9NfNh+HXu A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10961\"; a=\"22965748\"", "E=Sophos;i=\"6.05,214,1701158400\"; d=\"scan'208\";a=\"22965748\"", "E=Sophos;i=\"6.05,214,1701158400\"; d=\"scan'208\";a=\"27722305\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 0/6] remove incorrect code for loading 16B descriptors", "Date": "Tue, 23 Jan 2024 11:40:47 +0000", "Message-Id": "<20240123114053.172189-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inside the AVX2 code paths, there was special case code for loading two\n16-byte descriptors simultaneously, if that build-time feature was\nenabled. As well as not being enabled by default, these code blocks also\nwere incorrect as there is no guarantee of the two descriptors being\nloaded either atomically or in a defined order. If they were loaded in\nan unexpected order the driver logic would break. Therefore we remove\nthese blocks, and do come cleanup of the following code to remove\nindentation.\n\nNOTE: I've split out the removal and subsequent cleanup into separate\npatches for ease of review. These can be merged into a single patch on\nmerge, if so desired.\n\nBruce Richardson (6):\n net/i40e: remove incorrect 16B descriptor read block\n net/i40e: reduce code indentation\n net/iavf: remove incorrect 16B descriptor read block\n net/ice: remove incorrect 16B descriptor read block\n net/ice: reduce code indent\n net/iavf: reduce code indent\n\n drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++-------------\n drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++-------------------\n drivers/net/ice/ice_rxtx_vec_avx2.c | 80 ++++++++-------------------\n 3 files changed, 72 insertions(+), 152 deletions(-)\n\n--\n2.40.1" }