Cover Comment List
List cover comments
GET /api/covers/55753/comments/?format=api
[ { "id": 98070, "web_url": "http://patches.dpdk.org/comment/98070/", "msgid": "<VE1PR04MB66395BA45916F0AEBB5DFA09E6FB0@VE1PR04MB6639.eurprd04.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/VE1PR04MB66395BA45916F0AEBB5DFA09E6FB0@VE1PR04MB6639.eurprd04.prod.outlook.com", "date": "2019-07-03T10:21:10", "subject": "Re: [dpdk-dev] [PATCH v5 0/6] add multiple cores feature\n\tto\ttest-compress-perf", "submitter": { "id": 517, "url": "http://patches.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "content": "Hi Tomasz,\n\nThis series need a rebase.\n\nThanks,\nAkhil\n\n> \n> This patchset adds multiple cores feature to compression perf tool.\n> All structures have been aligned and are consistent\n> with crypto perf tool. All test cases have constructor, runner\n> and destructor and can use more cores and compression devices at\n> the same time.\n> \n> v2 changes:\n> \n> - fixed checkpatch warning\n> - fixed max_nb_queue_pairs detection. Based on compression API\n> if max_nb_queue_pairs = 0 that means there is no limit in\n> maximum number of queue pairs\n> - fixed qp setup on the last device\n> \n> v3 changes:\n> \n> - merged with commit 767350e7ede791932cc050bf2a192f6527b70c15\n> app/compress-perf: add prints for socket id\n> \n> - fixed wrong compression/decompression throughput calculation\n> \n> v4 changes:\n> \n> - moved release notes update to patch 1\n> - removed pmd cyclecount template\n> \n> v5 changes:\n> \n> - changed ctx null ptr detection inside constructors\n> \n> Tomasz Jozwiak (6):\n> app/test-compress-perf: add weak functions for multi-cores test\n> app/test-compress-perf: add ptest command line option\n> app/test-compress-perf: add verification test case\n> app/test-compress-perf: add benchmark test case\n> doc: update dpdk-test-compress-perf description\n> app/test-compress-perf: add force process termination\n> \n> app/test-compress-perf/Makefile | 1 +\n> app/test-compress-perf/comp_perf.h | 50 ++\n> app/test-compress-perf/comp_perf_options.h | 45 +-\n> app/test-compress-perf/comp_perf_options_parse.c | 54 +-\n> app/test-compress-perf/comp_perf_test_benchmark.c | 153 ++++--\n> app/test-compress-perf/comp_perf_test_benchmark.h | 25 +-\n> app/test-compress-perf/comp_perf_test_common.c | 284 ++++++++++\n> app/test-compress-perf/comp_perf_test_common.h | 41 ++\n> app/test-compress-perf/comp_perf_test_verify.c | 137 +++--\n> app/test-compress-perf/comp_perf_test_verify.h | 24 +-\n> app/test-compress-perf/main.c | 605 +++++++++-------------\n> app/test-compress-perf/meson.build | 3 +-\n> doc/guides/rel_notes/release_19_08.rst | 3 +\n> doc/guides/tools/comp_perf.rst | 34 +-\n> 14 files changed, 992 insertions(+), 467 deletions(-)\n> create mode 100644 app/test-compress-perf/comp_perf.h\n> create mode 100644 app/test-compress-perf/comp_perf_test_common.c\n> create mode 100644 app/test-compress-perf/comp_perf_test_common.h\n> \n> --\n> 2.7.4", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 44CD35B34;\n\tWed, 3 Jul 2019 12:21:13 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00043.outbound.protection.outlook.com [40.107.0.43])\n\tby dpdk.org (Postfix) with ESMTP id 9C2565587\n\tfor <dev@dpdk.org>; Wed, 3 Jul 2019 12:21:11 +0200 (CEST)", "from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by\n\tVE1PR04MB6447.eurprd04.prod.outlook.com (20.179.232.216) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.2032.20; Wed, 3 Jul 2019 10:21:10 +0000", "from VE1PR04MB6639.eurprd04.prod.outlook.com\n\t([fe80::a929:3d03:7bb7:d5e0]) by\n\tVE1PR04MB6639.eurprd04.prod.outlook.com\n\t([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2032.019;\n\tWed, 3 Jul 2019 10:21:10 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=qolpfDVE8ST5QbshXtcyHmkGYOIJNDjAx7rSdcQcyu0=;\n\tb=Sqp+MDEp4xBJ0SCflZ1Hz4f291UIhVTEelQ/9AYcKZSWPSCYD6gVhSJzG874sAUtXMohsFwxRm3WcIExEOR23r3+W9K/9MfKol2FD0d3cQJSTP4KGFH3k+axkFNnFwFmmtQgTPLYt9vWyMOTB6BQBOIE5XYbC1e8le0cb3ClsuY=", "From": "Akhil Goyal <akhil.goyal@nxp.com>", "To": "Tomasz Jozwiak <tjozwiakgm@gmail.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n\t\"fiona.trahe@intel.com\" <fiona.trahe@intel.com>, \"shallyv@marvell.com\"\n\t<shallyv@marvell.com>,\n\t\"arturx.trybula@intel.com\" <arturx.trybula@intel.com>", "Thread-Topic": "[dpdk-dev] [PATCH v5 0/6] add multiple cores feature to\n\ttest-compress-perf", "Thread-Index": "AQHVL//aYp/CqgDuTU+uV54GB1PK1aa4seGg", "Date": "Wed, 3 Jul 2019 10:21:10 +0000", "Message-ID": "<VE1PR04MB66395BA45916F0AEBB5DFA09E6FB0@VE1PR04MB6639.eurprd04.prod.outlook.com>", "References": "<1561674337-22086-1-git-send-email-tjozwiakgm@gmail.com>\n\t<1561980385-3223-1-git-send-email-tjozwiakgm@gmail.com>", "In-Reply-To": "<1561980385-3223-1-git-send-email-tjozwiakgm@gmail.com>", "Accept-Language": "en-IN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=akhil.goyal@nxp.com; ", "x-originating-ip": "[92.120.1.65]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "45871045-d6cf-4fd2-71a2-08d6ffa02b30", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6447; ", "x-ms-traffictypediagnostic": "VE1PR04MB6447:", "x-microsoft-antispam-prvs": "<VE1PR04MB64479765BBE7A3EE6315DF10E6FB0@VE1PR04MB6447.eurprd04.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:3383;", "x-forefront-prvs": "00872B689F", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(189003)(199004)(52536014)(76116006)(68736007)(44832011)(74316002)(486006)(7736002)(305945005)(5660300002)(6116002)(66446008)(73956011)(66946007)(33656002)(478600001)(66556008)(2906002)(64756008)(3846002)(66476007)(25786009)(476003)(446003)(110136005)(53936002)(55016002)(229853002)(81166006)(9686003)(6246003)(6436002)(186003)(14454004)(256004)(86362001)(2201001)(99286004)(14444005)(2501003)(71200400001)(11346002)(76176011)(66066001)(316002)(71190400001)(6506007)(26005)(81156014)(102836004)(7696005)(8936002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6447;\n\tH:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "ITMa+l0sR9YnaWgYC5/xmBmm3rnEisk4Or9iEy/6hRRgBc0LsQGPosYfChnZSHMIrzQLCUtw0mtFYmrZJzQx8dpETBefVXwlGVD0c8eFnTF0ycWNln2qhgiFeH1gEmVYCPSAAh5LBA824ZCmFzNfnw0dcJP7OcaJ+Rpfc6jpdA6lIOEDZ2GqhLaoi9bOIX4QfLMudHNcoOlHIBXXRtNCIMv9TG8BDzULvmh9vlm0DWRTlm08ayFVjKYGLukCaLWZvoB0pBtelpCpJgiXXk6Q77On7+bezsa6ZIitC+w44x2xP7uR/xssIo4TyDCDJ5iHmSCbZHrJK+ylcn64unBjrLjgM/jAyeVk31J2N0a7tdcU0nJlISs7eUhZWrQPgPKpVSE+U9yTUECazi57VadwR8rBB53CFoLswC+O+fkIh9s=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "45871045-d6cf-4fd2-71a2-08d6ffa02b30", "X-MS-Exchange-CrossTenant-originalarrivaltime": "03 Jul 2019 10:21:10.3049\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "akhil.goyal@nxp.com", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6447", "Subject": "Re: [dpdk-dev] [PATCH v5 0/6] add multiple cores feature\n\tto\ttest-compress-perf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 98078, "web_url": "http://patches.dpdk.org/comment/98078/", "msgid": "<CAOFtME+12FY3duj2CW3mDs0rY0X_ZVT5S09t2dT84cKE4NX+VA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAOFtME+12FY3duj2CW3mDs0rY0X_ZVT5S09t2dT84cKE4NX+VA@mail.gmail.com", "date": "2019-07-03T12:20:46", "subject": "Re: [dpdk-dev] [PATCH v5 0/6] add multiple cores feature to\n\ttest-compress-perf", "submitter": { "id": 1263, "url": "http://patches.dpdk.org/api/people/1263/?format=api", "name": "Tomasz Jóźwiak", "email": "tjozwiakgm@gmail.com" }, "content": "Hi Akhil,\n\nWas rebased on Monday. Too dynamic head :) , will do Today and add you in\nCc.\n\nThx, Tomek\n\nśr., 3.07.2019, 12:21 użytkownik Akhil Goyal <akhil.goyal@nxp.com> napisał:\n\n> Hi Tomasz,\n>\n> This series need a rebase.\n>\n> Thanks,\n> Akhil\n>\n> >\n> > This patchset adds multiple cores feature to compression perf tool.\n> > All structures have been aligned and are consistent\n> > with crypto perf tool. All test cases have constructor, runner\n> > and destructor and can use more cores and compression devices at\n> > the same time.\n> >\n> > v2 changes:\n> >\n> > - fixed checkpatch warning\n> > - fixed max_nb_queue_pairs detection. Based on compression API\n> > if max_nb_queue_pairs = 0 that means there is no limit in\n> > maximum number of queue pairs\n> > - fixed qp setup on the last device\n> >\n> > v3 changes:\n> >\n> > - merged with commit 767350e7ede791932cc050bf2a192f6527b70c15\n> > app/compress-perf: add prints for socket id\n> >\n> > - fixed wrong compression/decompression throughput calculation\n> >\n> > v4 changes:\n> >\n> > - moved release notes update to patch 1\n> > - removed pmd cyclecount template\n> >\n> > v5 changes:\n> >\n> > - changed ctx null ptr detection inside constructors\n> >\n> > Tomasz Jozwiak (6):\n> > app/test-compress-perf: add weak functions for multi-cores test\n> > app/test-compress-perf: add ptest command line option\n> > app/test-compress-perf: add verification test case\n> > app/test-compress-perf: add benchmark test case\n> > doc: update dpdk-test-compress-perf description\n> > app/test-compress-perf: add force process termination\n> >\n> > app/test-compress-perf/Makefile | 1 +\n> > app/test-compress-perf/comp_perf.h | 50 ++\n> > app/test-compress-perf/comp_perf_options.h | 45 +-\n> > app/test-compress-perf/comp_perf_options_parse.c | 54 +-\n> > app/test-compress-perf/comp_perf_test_benchmark.c | 153 ++++--\n> > app/test-compress-perf/comp_perf_test_benchmark.h | 25 +-\n> > app/test-compress-perf/comp_perf_test_common.c | 284 ++++++++++\n> > app/test-compress-perf/comp_perf_test_common.h | 41 ++\n> > app/test-compress-perf/comp_perf_test_verify.c | 137 +++--\n> > app/test-compress-perf/comp_perf_test_verify.h | 24 +-\n> > app/test-compress-perf/main.c | 605\n> +++++++++-------------\n> > app/test-compress-perf/meson.build | 3 +-\n> > doc/guides/rel_notes/release_19_08.rst | 3 +\n> > doc/guides/tools/comp_perf.rst | 34 +-\n> > 14 files changed, 992 insertions(+), 467 deletions(-)\n> > create mode 100644 app/test-compress-perf/comp_perf.h\n> > create mode 100644 app/test-compress-perf/comp_perf_test_common.c\n> > create mode 100644 app/test-compress-perf/comp_perf_test_common.h\n> >\n> > --\n> > 2.7.4\n>\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4FF865587;\n\tWed, 3 Jul 2019 14:21:00 +0200 (CEST)", "from mail-qk1-f193.google.com (mail-qk1-f193.google.com\n\t[209.85.222.193]) by dpdk.org (Postfix) with ESMTP id 97BBC5424\n\tfor <dev@dpdk.org>; Wed, 3 Jul 2019 14:20:58 +0200 (CEST)", "by mail-qk1-f193.google.com with SMTP id r21so2056771qke.2\n\tfor <dev@dpdk.org>; Wed, 03 Jul 2019 05:20:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=pIrv1rbYvSSd0X9fBYbInrwZt8P3lxNoQwRypROvUiM=;\n\tb=LyY4cfoQiXZf6o1P/y2F6N9PUCUI7X6HUvCExsl1MA4JmFvf/1yWdECqDwi6O1FeTE\n\tp7l6/GxmXny3EsN39MOvbo+7E3otRlCY6buIV87yFI3yHaEbzEV+5VuHkN8Co7wWGiAa\n\tVNhWx9tfdAit5JHsH9HAg3BTVNhDEynrssag0tU0w+AJDZWUpg3zqDXLxPjB1/wIIKSa\n\t14/LWTjw1+M/eczZ0r713H0dCfbla+1yceDU8c5Ij/DIfT7HO13uOmJFoMKk4YDA05GZ\n\tY76zu7QBtwJ35Dq2Lk6+n0oeqzL6IH1vz8SUJBbX+t/Tj1W9BGjmp6aH0D2HEzC+XLPs\n\tf/Bw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=pIrv1rbYvSSd0X9fBYbInrwZt8P3lxNoQwRypROvUiM=;\n\tb=tSUmCeVmA/BoG4B1G1P//o/IZw2itI4eYwCmC2ERqBtSGeyXHMn+2jKX4wmUHMnnWq\n\t6OBEzkd4Bc9OmMGG5xw1FcTMnsrOScVmluuGiN7j/NWR/Zce1SUiC38OXq0J1DIFm4Rf\n\t4Z2zRqyg+5xIR4ZTfg1IATZe/69Ov7DFgfTqXozpjDj/Aby9IeQmz2zDE7g4xvDA952Z\n\tJvKxnBbL3bqdFPVYiUl5d11Doee9GlxGInRsdWtP7hg7tuX25vSJzpvH5MEaFuFB7wQp\n\tHsYp0w3ZUzMQ1T1M/Y5DK505KKLStTTFsw41jqvO1I4ZftbsW80vgr4Vt/vXIKEDBcJc\n\tkG9g==", "X-Gm-Message-State": "APjAAAWtnPZ2PMSzHR9PWNq3OQLNCC09iAIqKrqw+N9Dlg2xNUJJvHkL\n\t5SJbBu3h3mtCux6J0jS8rq08srtkYl07QrM5tjw=", "X-Google-Smtp-Source": "APXvYqyRB00LFrTpJJhO7CVZT/32/REJ2FHQn1eaBOoZb+le1SuBuolyoJDgToUyMuF4Bd4fI7gImMhEp+oZl8eehyk=", "X-Received": "by 2002:a67:6988:: with SMTP id\n\te130mr18996727vsc.197.1562156457940; \n\tWed, 03 Jul 2019 05:20:57 -0700 (PDT)", "MIME-Version": "1.0", "References": "<1561674337-22086-1-git-send-email-tjozwiakgm@gmail.com>\n\t<1561980385-3223-1-git-send-email-tjozwiakgm@gmail.com>\n\t<VE1PR04MB66395BA45916F0AEBB5DFA09E6FB0@VE1PR04MB6639.eurprd04.prod.outlook.com>", "In-Reply-To": "<VE1PR04MB66395BA45916F0AEBB5DFA09E6FB0@VE1PR04MB6639.eurprd04.prod.outlook.com>", "From": "=?utf-8?q?Tomasz_J=C3=B3=C5=BAwiak?= <tjozwiakgm@gmail.com>", "Date": "Wed, 3 Jul 2019 14:20:46 +0200", "Message-ID": "<CAOFtME+12FY3duj2CW3mDs0rY0X_ZVT5S09t2dT84cKE4NX+VA@mail.gmail.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>", "Cc": "dev@dpdk.org, \"Trahe, Fiona\" <fiona.trahe@intel.com>, \n\t\"shallyv@marvell.com\" <shallyv@marvell.com>,\n\t\"arturx.trybula@intel.com\" <arturx.trybula@intel.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "quoted-printable", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v5 0/6] add multiple cores feature to\n\ttest-compress-perf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]