Cover Comment List
List cover comments
GET /api/covers/55653/comments/?format=api
[ { "id": 97805, "web_url": "http://patches.dpdk.org/comment/97805/", "msgid": "<2123522.W70hLPZofc@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2123522.W70hLPZofc@xps", "date": "2019-06-29T17:06:56", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "29/06/2019 13:58, David Marchand:\n> Following the build error reported by Aaron [1], I noticed that some\n> experimental functions could go unnoticed because of a gcc peculiarity.\n> \n> To catch those, I went and added a new check on the object files to\n> ensure that any experimental api flagged in the map files is really\n> exported as such.\n> \n> Then went with my previous idea of only adding the tags on the functions\n> prototypes and enforcing it (a new check in checkpatches.sh).\n> And finally enforcing that the __rte_experimental tag is always the first\n> part of a function prototype which seems to work with both gcc and clang.\n\nApplied, thanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0C2F337B4;\n\tSat, 29 Jun 2019 19:07:02 +0200 (CEST)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0EE5A2C60\n\tfor <dev@dpdk.org>; Sat, 29 Jun 2019 19:07:01 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 40E9321C4D;\n\tSat, 29 Jun 2019 13:07:00 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Sat, 29 Jun 2019 13:07:00 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 58D498005C;\n\tSat, 29 Jun 2019 13:06:57 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=wcyaOOxEL2X0AFUF/CCQT8VJJevaAdB/Uwa6rOu4mAk=; b=WGDx2Bp6mOd5\n\tD0DPC4Lz8oNJUMR84MiSKf8anclch+U6MueX+q+NHxikh3GDmOczUg1zI75VRxPr\n\tr5fhI5xCzdtt4GtbyW2HAnlaHiOB26z7ZjqgAHx6ng1pE8r+kc2Ja0vla38AkhC4\n\tOol7QCvA2Vv2nIMvz7OjDqmEzpSZOoc=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm3; bh=wcyaOOxEL2X0AFUF/CCQT8VJJevaAdB/Uwa6rOu4m\n\tAk=; b=opVO5+VNIQNsqum/pq/ipm+XTMX2wF6OPum8xdMjBiIalPQRF2zLeYYCp\n\tBJMehJSRAoDkZDYAL4WIyhSnqyvFbcHeGf0Sn15admz8CDblvs5WbfqJgRmstiIV\n\teNxIpZvxP95LVPdye/enLEJ1ZeO3saO1AlF4Pbkcb3oYqbI/ny7ywV5nVlzpd2o/\n\tDDUjiRaXXcLS0Py8YsapM12QfeLKjUyLNy9yM7qSb61bteQz3D7PWD4fJORou1z5\n\tI2lu9Jg4OF5esiLOjx6cMobOXSvn3X2IKkJMeqJGrt+PyTa+m789mlP4Fif235ap\n\tCAuUgcKw6T74tVpcGB4yltKia1SMQ==" ], "X-ME-Sender": "<xms:spoXXSNJcSIuGHz-Qn5d9ax_vQeEKGSTYKBeqgCj-fh-PBkPvOe78A>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduvddrvddvgdduuddtucetufdoteggodetrfdotf\n\tfvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n\tuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n\tcujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n\tshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf\n\thppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh\n\tohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:spoXXZRM-PdbjCx2N9tJbQBbRWuBA_1U1CBb4mPzm5tZenyCGM2AAw>\n\t<xmx:spoXXTQaXB3qiDnwZqM548fOyyXymO7aXaRVhvzXeYl_t6GpCVUslQ>\n\t<xmx:spoXXQjKGZmJVZ90ilfyoqfGsiFi1GXiOok2GaDhKurMEjoVTTJPgw>\n\t<xmx:tJoXXdFBomHbxSsj8LREQaa-oTSqtQwpCKIItp5ApPQUpM5FFMSo3g>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org, nhorman@tuxdriver.com, adrien.mazarguil@6wind.com,\n\tstephen@networkplumber.org", "Date": "Sat, 29 Jun 2019 19:06:56 +0200", "Message-ID": "<2123522.W70hLPZofc@xps>", "In-Reply-To": "<1561809533-6545-1-git-send-email-david.marchand@redhat.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97897, "web_url": "http://patches.dpdk.org/comment/97897/", "msgid": "<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com", "date": "2019-07-01T14:15:30", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 6/29/2019 6:06 PM, Thomas Monjalon wrote:\n> 29/06/2019 13:58, David Marchand:\n>> Following the build error reported by Aaron [1], I noticed that some\n>> experimental functions could go unnoticed because of a gcc peculiarity.\n>>\n>> To catch those, I went and added a new check on the object files to\n>> ensure that any experimental api flagged in the map files is really\n>> exported as such.\n>>\n>> Then went with my previous idea of only adding the tags on the functions\n>> prototypes and enforcing it (a new check in checkpatches.sh).\n>> And finally enforcing that the __rte_experimental tag is always the first\n>> part of a function prototype which seems to work with both gcc and clang.\n> \n> Applied, thanks\n> \n\n\nGetting an odd build error with \"i686-native-linuxapp-icc\" [1].\nBeware of the \".\" at the end: \"rte_flow_conv.\"\n\nObjdump shows two symbols with one \".\" at the end and one without it [2].\n\nAnd this seems not the problem of only experimental APIs [3]. But this is only\nhappening with \"i686-native-linuxapp-icc\".\n\nDo you have any idea what is going on here?\n\n\n\n[1]\nBuilding i686-native-linuxapp-icc ...\nrte_flow_conv. is flagged as experimental\nbut is not listed in version map\nPlease add rte_flow_conv. to the version map\n\nrte_eth_dev_is_removed. is flagged as experimental\nbut is not listed in version map\nPlease add rte_eth_dev_is_removed. to the version map\n\n\n\n\n[2]\n$ objdump -x -j '.text.experimental' ./build/build/lib/librte_ethdev/rte_ethdev.o\n\n./build/build/lib/librte_ethdev/rte_ethdev.o: file format elf32-i386\n./build/build/lib/librte_ethdev/rte_ethdev.o\narchitecture: i386, flags 0x00000011:\nHAS_RELOC, HAS_SYMS\nstart address 0x00000000\n\nSections:\nIdx Name Size VMA LMA File off Algn\n 4 .text.experimental 00001b70 00000000 00000000 0000e17d 2**4\n CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE\nSYMBOL TABLE:\n00000000 l d .text.experimental 00000000 .text.experimental\n00000000 g F .text.experimental 00000090 rte_eth_find_next_of\n00000090 g F .text.experimental 000000d0 rte_eth_find_next_sibling\n00000160 g F .text.experimental 00000110 rte_eth_dev_owner_new\n00000270 g F .text.experimental 00000240 rte_eth_dev_owner_set\n000004b0 g F .text.experimental 000002c0 rte_eth_dev_owner_unset\n00000770 g F .text.experimental 000001b0 rte_eth_dev_owner_delete\n00000920 g F .text.experimental 00000190 rte_eth_dev_owner_get\n00000ab0 g F .text.experimental 000000e0 rte_eth_dev_rx_intr_ctl_q_get_fd\n00000b90 g F .text.experimental 000007d0 rte_eth_dev_create\n00001360 g F .text.experimental 000003a0 rte_eth_dev_destroy\n00001700 g F .text.experimental 000000e0 rte_eth_read_clock\n000017e0 g F .text.experimental 00000070 rte_eth_dev_get_module_info\n00001850 g F .text.experimental 00000070 rte_eth_dev_get_module_eeprom\n000018c0 g F .text.experimental 00000040 rte_eth_switch_domain_alloc\n00001900 g F .text.experimental 00000040 rte_eth_switch_domain_free\n00001940 g F .text.experimental 000001a0 rte_eth_devargs_parse\n00001ae0 g F .text.experimental 00000005 rte_eth_dev_is_removed\n00001ae5 g F .text.experimental 0000008b rte_eth_dev_is_removed.\n\n\n\n\n[3]\nobjdump -x ./build/build/lib/librte_ethdev/rte_ethdev.o | grep '\\.$'\n00002075 g F .text 0000006b rte_eth_promiscuous_enable.\n000020e5 g F .text 0000005b rte_eth_promiscuous_get.\n00002145 g F .text 0000006b rte_eth_promiscuous_disable.\n000021b5 g F .text 0000006b rte_eth_allmulticast_enable.\n00002225 g F .text 0000005b rte_eth_allmulticast_get.\n00002285 g F .text 0000006b rte_eth_allmulticast_disable.\n0000458d g F .text 00000bc3 rte_eth_xstats_get_names_by_id.\n00008109 g F .text 00000147 rte_eth_dev_info_get.\n00001ae5 g F .text.experimental 0000008b rte_eth_dev_is_removed.\n000043cf R_386_PC32 rte_eth_xstats_get_names_by_id.\n00004406 R_386_PC32 rte_eth_xstats_get_names_by_id.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9487B1B9C6;\n\tMon, 1 Jul 2019 16:15:35 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id CAE4E1B9C1\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 16:15:33 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jul 2019 07:15:32 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.30])\n\t([10.237.221.30])\n\tby orsmga007.jf.intel.com with ESMTP; 01 Jul 2019 07:15:31 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,439,1557212400\"; d=\"scan'208\";a=\"154094685\"", "To": "Thomas Monjalon <thomas@monjalon.net>,\n\tDavid Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org, nhorman@tuxdriver.com, adrien.mazarguil@6wind.com,\n\tstephen@networkplumber.org, Bruce Richardson <bruce.richardson@intel.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>\n\t<2123522.W70hLPZofc@xps>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE\n\t0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T\n\tYR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q\n\tCgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M\n\t1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I\n\tz+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr\n\tGE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte\n\tHQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG\n\tgMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7\n\tX07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K\n\t/s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1\n\tpBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv\n\tmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T\n\tqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA\n\tONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/\n\tvU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p\n\tiVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ\n\tI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH\n\tfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ\n\tqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi\n\t6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl\n\tRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh\n\tHwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q\n\tMJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp\n\tg0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8\n\tYO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7\n\tsgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY\n\txWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84\n\tQz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa\n\tARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a\n\tN3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv\n\t0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv\n\tVQ==", "Message-ID": "<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>", "Date": "Mon, 1 Jul 2019 15:15:30 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2", "MIME-Version": "1.0", "In-Reply-To": "<2123522.W70hLPZofc@xps>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97902, "web_url": "http://patches.dpdk.org/comment/97902/", "msgid": "<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com", "date": "2019-07-01T14:36:41", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Mon, Jul 1, 2019 at 4:15 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:\n\n> On 6/29/2019 6:06 PM, Thomas Monjalon wrote:\n> > 29/06/2019 13:58, David Marchand:\n> >> Following the build error reported by Aaron [1], I noticed that some\n> >> experimental functions could go unnoticed because of a gcc peculiarity.\n> >>\n> >> To catch those, I went and added a new check on the object files to\n> >> ensure that any experimental api flagged in the map files is really\n> >> exported as such.\n> >>\n> >> Then went with my previous idea of only adding the tags on the functions\n> >> prototypes and enforcing it (a new check in checkpatches.sh).\n> >> And finally enforcing that the __rte_experimental tag is always the\n> first\n> >> part of a function prototype which seems to work with both gcc and\n> clang.\n> >\n> > Applied, thanks\n> >\n>\n>\n> Getting an odd build error with \"i686-native-linuxapp-icc\" [1].\n> Beware of the \".\" at the end: \"rte_flow_conv.\"\n>\n> Objdump shows two symbols with one \".\" at the end and one without it [2].\n>\n> And this seems not the problem of only experimental APIs [3]. But this is\n> only\n> happening with \"i686-native-linuxapp-icc\".\n>\n> Do you have any idea what is going on here?\n>\n>\nLooked at rte_flow_conv, and I can not see anything special about it.\n\nThere might be a subtility in the way symbol names are chosen by ICC.\nCan ICC guys look at this and give us some enlightment?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BD8031B9D9;\n\tMon, 1 Jul 2019 16:36:56 +0200 (CEST)", "from mail-vk1-f180.google.com (mail-vk1-f180.google.com\n\t[209.85.221.180]) by dpdk.org (Postfix) with ESMTP id CFB6A1B9CC\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 16:36:54 +0200 (CEST)", "by mail-vk1-f180.google.com with SMTP id f68so2745355vkf.5\n\tfor <dev@dpdk.org>; Mon, 01 Jul 2019 07:36:54 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Q9qJJaM4mPzpfN8uUYu2WkMX7UCM6ChyxYoEV2mNSpc=;\n\tb=EKt7wFm/wYFxj40dA150+nb3iI8W+pBL0EaByEi4xBggwHiHqyf5PnAYkg2X/QicYH\n\ton3Iy2YfqwW5T3QJlYKksnCViXxcg2i8snPRi8f3gcNSVE5jPMNzVA/PYn+T49nf03Te\n\t7C55nhmCo95hPyRrHiveECowbXYmf0GESm9dMKKpe8A7rRcwEYDujG4Dw+TdQ+xynNfi\n\t6GAaiApb3YMWeu5QYcltzI+iCZNTsujBR7+HE3gNMqcjV48qauNgmaMHnknIZe+eq+c2\n\t3Gi97kdOKvWCm0aiytRxxf4p9h7KYdQmKQnmB5oq5AulYQLgu3J8xzcD/+/OXxMhyA1F\n\tpjKg==", "X-Gm-Message-State": "APjAAAWj2SWAgBcTmFxTdXAkCebTWfrkd94hmW4KKav9MJBDgC9Vpl+O\n\t5bM404dEfP73TC8siN1YzCvaxdj122xdI6CdYofuaA==", "X-Google-Smtp-Source": "APXvYqyRvQRS1oJ/Ma0TG/D/w/rXaCu/V01Idi/A2+uBjp/Dt3jaQx/70tDCOscB5ZIvZZ82gPUSvP9zdjJJCamlk8Q=", "X-Received": "by 2002:a1f:1185:: with SMTP id 127mr8241085vkr.85.1561991813199;\n\tMon, 01 Jul 2019 07:36:53 -0700 (PDT)", "MIME-Version": "1.0", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>\n\t<2123522.W70hLPZofc@xps>\n\t<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>", "In-Reply-To": "<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Mon, 1 Jul 2019 16:36:41 +0200", "Message-ID": "<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, \n\tNeil Horman <nhorman@tuxdriver.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>, \n\tStephen Hemminger <stephen@networkplumber.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97906, "web_url": "http://patches.dpdk.org/comment/97906/", "msgid": "<e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com", "date": "2019-07-01T15:30:03", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/1/2019 3:36 PM, David Marchand wrote:\n> \n> \n> On Mon, Jul 1, 2019 at 4:15 PM Ferruh Yigit <ferruh.yigit@intel.com\n> <mailto:ferruh.yigit@intel.com>> wrote:\n> \n> On 6/29/2019 6:06 PM, Thomas Monjalon wrote:\n> > 29/06/2019 13:58, David Marchand:\n> >> Following the build error reported by Aaron [1], I noticed that some\n> >> experimental functions could go unnoticed because of a gcc peculiarity.\n> >>\n> >> To catch those, I went and added a new check on the object files to\n> >> ensure that any experimental api flagged in the map files is really\n> >> exported as such.\n> >>\n> >> Then went with my previous idea of only adding the tags on the functions\n> >> prototypes and enforcing it (a new check in checkpatches.sh).\n> >> And finally enforcing that the __rte_experimental tag is always the first\n> >> part of a function prototype which seems to work with both gcc and clang.\n> >\n> > Applied, thanks\n> >\n> \n> \n> Getting an odd build error with \"i686-native-linuxapp-icc\" [1].\n> Beware of the \".\" at the end: \"rte_flow_conv.\"\n> \n> Objdump shows two symbols with one \".\" at the end and one without it [2].\n> \n> And this seems not the problem of only experimental APIs [3]. But this is only\n> happening with \"i686-native-linuxapp-icc\".\n> \n> Do you have any idea what is going on here?\n> \n> \n> Looked at rte_flow_conv, and I can not see anything special about it.\n> \n> There might be a subtility in the way symbol names are chosen by ICC.\n> Can ICC guys look at this and give us some enlightment?\n\nThis is the sample disassembler of one of the \".\" functions [1], it looks like\nthis notation is used by compiler to prepend some code at the very begging of\nthe function, Harry (cc'ed) let me know this is may be security feature, not a\ndefect of compiler :)\n\nSo briefly, it looks like compiler can add this \".\" version of the symbols to\nthe \".text.experimental\" section, I believe the solution is detect this notation\nand handle it. What do you think?\n\n\n\n[1]\n00002070 <rte_eth_promiscuous_enable>:\n 2070: 0f b7 44 24 04 movzwl 0x4(%esp),%eax\n\n00002075 <rte_eth_promiscuous_enable.>:\n 2075: 56 push %esi\n 2076: 57 push %edi\n 2077: 83 ec 14 sub $0x14,%esp\n 207a: 0f b7 c0 movzwl %ax,%eax\n 207d: 83 f8 20 cmp $0x20,%eax\n 2080: 7d 14 jge 2096\n<rte_eth_promiscuous_enable.+0x21>\n 2082: 8b f0 mov %eax,%esi\n 2084: 8b f8 mov %eax,%edi\n 2086: c1 e6 06 shl $0x6,%esi\n 2089: c1 e7 0d shl $0xd,%edi\n 208c: 83 bc 3e 28 20 00 00 cmpl $0x0,0x2028(%esi,%edi,1)\n 2093: 00\n 2094: 75 1c jne 20b2\n<rte_eth_promiscuous_enable.+0x3d>\n 2096: 50 push %eax\n 2097: 68 00 00 00 00 push $0x0\n 209c: ff 35 00 00 00 00 pushl 0x0\n 20a2: 6a 04 push $0x4\n 20a4: e8 fc ff ff ff call 20a5\n<rte_eth_promiscuous_enable.+0x30>\n 20a9: 83 c4 10 add $0x10,%esp\n....", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2ED751B9D7;\n\tMon, 1 Jul 2019 17:30:08 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 1462B1B9C5\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 17:30:06 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jul 2019 08:30:06 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.30])\n\t([10.237.221.30])\n\tby fmsmga005.fm.intel.com with ESMTP; 01 Jul 2019 08:30:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,439,1557212400\"; d=\"scan'208\";a=\"361870141\"", "To": "David Marchand <david.marchand@redhat.com>,\n\tBruce Richardson <bruce.richardson@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tNeil Horman <nhorman@tuxdriver.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tHarry Van Haaren <harry.van.haaren@intel.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>\n\t<2123522.W70hLPZofc@xps>\n\t<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>\n\t<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE\n\t0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T\n\tYR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q\n\tCgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M\n\t1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I\n\tz+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr\n\tGE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte\n\tHQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG\n\tgMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7\n\tX07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K\n\t/s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1\n\tpBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv\n\tmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T\n\tqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA\n\tONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/\n\tvU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p\n\tiVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ\n\tI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH\n\tfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ\n\tqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi\n\t6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl\n\tRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh\n\tHwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q\n\tMJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp\n\tg0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8\n\tYO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7\n\tsgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY\n\txWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84\n\tQz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa\n\tARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a\n\tN3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv\n\t0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv\n\tVQ==", "Message-ID": "<e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com>", "Date": "Mon, 1 Jul 2019 16:30:03 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2", "MIME-Version": "1.0", "In-Reply-To": "<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97929, "web_url": "http://patches.dpdk.org/comment/97929/", "msgid": "<CAJFAV8zZNfTcBou--g775hWXGAv2bv8S_SYvDqXe-f45Ds_s2A@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8zZNfTcBou--g775hWXGAv2bv8S_SYvDqXe-f45Ds_s2A@mail.gmail.com", "date": "2019-07-01T19:27:14", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Mon, Jul 1, 2019 at 5:30 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:\n\n> On 7/1/2019 3:36 PM, David Marchand wrote:\n> >\n> >\n> > On Mon, Jul 1, 2019 at 4:15 PM Ferruh Yigit <ferruh.yigit@intel.com\n> > <mailto:ferruh.yigit@intel.com>> wrote:\n> >\n> > On 6/29/2019 6:06 PM, Thomas Monjalon wrote:\n> > > 29/06/2019 13:58, David Marchand:\n> > >> Following the build error reported by Aaron [1], I noticed that\n> some\n> > >> experimental functions could go unnoticed because of a gcc\n> peculiarity.\n> > >>\n> > >> To catch those, I went and added a new check on the object files\n> to\n> > >> ensure that any experimental api flagged in the map files is\n> really\n> > >> exported as such.\n> > >>\n> > >> Then went with my previous idea of only adding the tags on the\n> functions\n> > >> prototypes and enforcing it (a new check in checkpatches.sh).\n> > >> And finally enforcing that the __rte_experimental tag is always\n> the first\n> > >> part of a function prototype which seems to work with both gcc\n> and clang.\n> > >\n> > > Applied, thanks\n> > >\n> >\n> >\n> > Getting an odd build error with \"i686-native-linuxapp-icc\" [1].\n> > Beware of the \".\" at the end: \"rte_flow_conv.\"\n> >\n> > Objdump shows two symbols with one \".\" at the end and one without it\n> [2].\n> >\n> > And this seems not the problem of only experimental APIs [3]. But\n> this is only\n> > happening with \"i686-native-linuxapp-icc\".\n> >\n> > Do you have any idea what is going on here?\n> >\n> >\n> > Looked at rte_flow_conv, and I can not see anything special about it.\n> >\n> > There might be a subtility in the way symbol names are chosen by ICC.\n> > Can ICC guys look at this and give us some enlightment?\n>\n> This is the sample disassembler of one of the \".\" functions [1], it looks\n> like\n> this notation is used by compiler to prepend some code at the very begging\n> of\n> the function, Harry (cc'ed) let me know this is may be security feature,\n> not a\n> defect of compiler :)\n>\n> So briefly, it looks like compiler can add this \".\" version of the symbols\n> to\n> the \".text.experimental\" section, I believe the solution is detect this\n> notation\n> and handle it. What do you think?\n>\n\nIiuc, we would skip the symbols finishing with a '.', is this all?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 10B941B9E5;\n\tMon, 1 Jul 2019 21:27:27 +0200 (CEST)", "from mail-vs1-f68.google.com (mail-vs1-f68.google.com\n\t[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 84F611B9E3\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 21:27:25 +0200 (CEST)", "by mail-vs1-f68.google.com with SMTP id r3so1808639vsr.13\n\tfor <dev@dpdk.org>; Mon, 01 Jul 2019 12:27:25 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=2jA2IENQHbJCPqCe+sqsp+Qee07dYINMnDzJsYMT+9c=;\n\tb=Ci8p/I8BwDAHuLJ2gYOb5B7zcj7YjqtWRtNgORvo4EF8VN+TxJ33w/7ms+iENvzICJ\n\tbEzvx1XDs9NKo5umWH5tld6RkVokv6Rsg3CnWA2TH0cb6lPL7gqaXSfSqQUjfncL+kFt\n\tIDu7CTVY5s7esmiUr49KbNcc3A9nkKLC3SO6W/ZsvxA488ariW5XsSUr5QiqOTfAWg6K\n\tb71VeD858X004RoxAHIOrWN7ErkDCceA7seIfRotMMWZVXkhQIAl5HUtLde1i1FYvIwm\n\tqwzyOnWlJbya4xju2+9WA7vIjdAdzU9nwdBBDD7d1wXKlGhPzU91RjLFlqjjjFnW0wb/\n\tjO8A==", "X-Gm-Message-State": "APjAAAWDpcbCTfBx7/pdxMMuRlF4WrOHhx2H0mcFRpV0Wze2dbsRGBeO\n\tCBd+rtGBe7aQE4zWaV9DZzUs0Icjy5uAgHxa0cypWA==", "X-Google-Smtp-Source": "APXvYqz9QLqQhB6/wVlfWKFUSmlQbrzQBa/BXWicfYgg2ScVg3TABjH9ui9LzgpVMmmVYE+Azk2Q+7UcyLnC4LjLy50=", "X-Received": "by 2002:a67:e9ca:: with SMTP id\n\tq10mr15806867vso.105.1562009244954; \n\tMon, 01 Jul 2019 12:27:24 -0700 (PDT)", "MIME-Version": "1.0", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>\n\t<2123522.W70hLPZofc@xps>\n\t<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>\n\t<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>\n\t<e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com>", "In-Reply-To": "<e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Mon, 1 Jul 2019 21:27:14 +0200", "Message-ID": "<CAJFAV8zZNfTcBou--g775hWXGAv2bv8S_SYvDqXe-f45Ds_s2A@mail.gmail.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, \n\tNeil Horman <nhorman@tuxdriver.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>, \n\tStephen Hemminger <stephen@networkplumber.org>,\n\tHarry Van Haaren <harry.van.haaren@intel.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97935, "web_url": "http://patches.dpdk.org/comment/97935/", "msgid": "<22a528d6-1acd-1014-0831-47589b4090ee@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/22a528d6-1acd-1014-0831-47589b4090ee@intel.com", "date": "2019-07-01T21:12:53", "subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/1/2019 8:27 PM, David Marchand wrote:\n> \n> \n> On Mon, Jul 1, 2019 at 5:30 PM Ferruh Yigit <ferruh.yigit@intel.com\n> <mailto:ferruh.yigit@intel.com>> wrote:\n> \n> On 7/1/2019 3:36 PM, David Marchand wrote:\n> >\n> >\n> > On Mon, Jul 1, 2019 at 4:15 PM Ferruh Yigit <ferruh.yigit@intel.com\n> <mailto:ferruh.yigit@intel.com>\n> > <mailto:ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>> wrote:\n> >\n> > On 6/29/2019 6:06 PM, Thomas Monjalon wrote:\n> > > 29/06/2019 13:58, David Marchand:\n> > >> Following the build error reported by Aaron [1], I noticed that some\n> > >> experimental functions could go unnoticed because of a gcc peculiarity.\n> > >>\n> > >> To catch those, I went and added a new check on the object files to\n> > >> ensure that any experimental api flagged in the map files is really\n> > >> exported as such.\n> > >>\n> > >> Then went with my previous idea of only adding the tags on the\n> functions\n> > >> prototypes and enforcing it (a new check in checkpatches.sh).\n> > >> And finally enforcing that the __rte_experimental tag is always the\n> first\n> > >> part of a function prototype which seems to work with both gcc and\n> clang.\n> > >\n> > > Applied, thanks\n> > >\n> >\n> >\n> > Getting an odd build error with \"i686-native-linuxapp-icc\" [1].\n> > Beware of the \".\" at the end: \"rte_flow_conv.\"\n> >\n> > Objdump shows two symbols with one \".\" at the end and one without it [2].\n> >\n> > And this seems not the problem of only experimental APIs [3]. But this\n> is only\n> > happening with \"i686-native-linuxapp-icc\".\n> >\n> > Do you have any idea what is going on here?\n> >\n> >\n> > Looked at rte_flow_conv, and I can not see anything special about it.\n> >\n> > There might be a subtility in the way symbol names are chosen by ICC.\n> > Can ICC guys look at this and give us some enlightment?\n> \n> This is the sample disassembler of one of the \".\" functions [1], it looks like\n> this notation is used by compiler to prepend some code at the very begging of\n> the function, Harry (cc'ed) let me know this is may be security feature, not a\n> defect of compiler :)\n> \n> So briefly, it looks like compiler can add this \".\" version of the symbols to\n> the \".text.experimental\" section, I believe the solution is detect this notation\n> and handle it. What do you think?\n> \n> \n> Iiuc, we would skip the symbols finishing with a '.', is this all?\n> \n\nyes", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF18F1B996;\n\tMon, 1 Jul 2019 23:13:00 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 212B31B965\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 23:12:58 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jul 2019 14:12:57 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.252.4.59])\n\t([10.252.4.59])\n\tby orsmga007.jf.intel.com with ESMTP; 01 Jul 2019 14:12:53 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,440,1557212400\"; d=\"scan'208\";a=\"154216766\"", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tNeil Horman <nhorman@tuxdriver.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tHarry Van Haaren <harry.van.haaren@intel.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>\n\t<1561809533-6545-1-git-send-email-david.marchand@redhat.com>\n\t<2123522.W70hLPZofc@xps>\n\t<47b0afe9-96ba-eafd-cf37-08c69742b15e@intel.com>\n\t<CAJFAV8zQ2_NOE6Nf6bgTYtoDskim3eAQW9n7fQiMNtrDfJNYtA@mail.gmail.com>\n\t<e4e2d2d7-72fa-0e2b-89d0-0ad61e9ebdba@intel.com>\n\t<CAJFAV8zZNfTcBou--g775hWXGAv2bv8S_SYvDqXe-f45Ds_s2A@mail.gmail.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE\n\t0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T\n\tYR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q\n\tCgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M\n\t1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I\n\tz+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr\n\tGE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte\n\tHQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG\n\tgMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7\n\tX07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K\n\t/s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1\n\tpBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv\n\tmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T\n\tqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA\n\tONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/\n\tvU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p\n\tiVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ\n\tI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH\n\tfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ\n\tqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi\n\t6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl\n\tRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh\n\tHwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q\n\tMJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp\n\tg0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8\n\tYO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7\n\tsgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY\n\txWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84\n\tQz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa\n\tARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a\n\tN3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv\n\t0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv\n\tVQ==", "Message-ID": "<22a528d6-1acd-1014-0831-47589b4090ee@intel.com>", "Date": "Mon, 1 Jul 2019 22:12:53 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2", "MIME-Version": "1.0", "In-Reply-To": "<CAJFAV8zZNfTcBou--g775hWXGAv2bv8S_SYvDqXe-f45Ds_s2A@mail.gmail.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v2 00/10] experimental tags fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]