Cover Comment List
List cover comments
GET /api/covers/55485/comments/?format=api
[ { "id": 97657, "web_url": "http://patches.dpdk.org/comment/97657/", "msgid": "<20190627083603.3ee1e172@hermes.lan>", "list_archive_url": "https://inbox.dpdk.org/dev/20190627083603.3ee1e172@hermes.lan", "date": "2019-06-27T15:36:03", "subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Thu, 27 Jun 2019 12:38:55 +0100\nAnatoly Burakov <anatoly.burakov@intel.com> wrote:\n\n> This patchset removes the shared memory config from public\n> API, and replaces all usages of said config with new API\n> calls.\n> \n> A lot of the patchset is a search-and-replace job and should\n> be pretty easy to review. The rest are pretty trivial EAL\n> changes.\n> \n> This patchset depends on FreeBSD fixes patchset:\n> \n> http://patches.dpdk.org/project/dpdk/list/?series=5196\n> \n> v3:\n> - Rebase on top of latest master\n> \n> v2:\n> - Collapsed all changes into fewer patches\n> - Addressed review comments\n> - Created a new file to store the code\n> - Changed namespace to \"rte_mcfg_\"\n> - Added some unification around config init\n> - Removed \"packed\" attribute from mem config\n> - Removed unnecessary inlining\n> - Added a check to explicitly forbid running multiprocess\n> applications that differ in their DPDK versions\n> \n> Anatoly Burakov (14):\n> eal: add API to lock/unlock memory hotplug\n> drivers: use new memory locking API\n> lib: use new memory locking API\n> eal: add EAL tailq list lock/unlock API\n> lib: use new tailq locking API\n> eal: add new API to lock/unlock mempool list\n> mempool: use new mempool list locking API\n> eal: remove unused macros\n> eal: hide shared memory config\n> eal: remove packed attribute from mcfg structure\n> eal: uninline wait for mcfg complete function\n> eal: unify and move mcfg complete function\n> eal: unify internal config initialization\n> eal: prevent different primary/secondary process versions\n> \n> app/test/test_memzone.c | 1 +\n> app/test/test_tailq.c | 1 +\n> doc/guides/rel_notes/deprecation.rst | 3 -\n> doc/guides/rel_notes/release_19_08.rst | 8 +-\n> drivers/bus/fslmc/fslmc_vfio.c | 8 +-\n> drivers/bus/pci/linux/pci_vfio.c | 1 +\n> drivers/net/mlx4/mlx4_mr.c | 11 +-\n> drivers/net/mlx5/mlx5_mr.c | 11 +-\n> .../net/virtio/virtio_user/virtio_user_dev.c | 7 +-\n> lib/librte_acl/rte_acl.c | 20 +--\n> lib/librte_distributor/rte_distributor.c | 5 +-\n> lib/librte_distributor/rte_distributor_v20.c | 5 +-\n> lib/librte_eal/common/eal_common_mcfg.c | 149 ++++++++++++++++++\n> lib/librte_eal/common/eal_common_memory.c | 44 +++---\n> lib/librte_eal/common/eal_common_memzone.c | 1 +\n> lib/librte_eal/common/eal_common_tailqs.c | 5 +-\n> lib/librte_eal/common/eal_memcfg.h | 93 +++++++++++\n> lib/librte_eal/common/include/rte_eal.h | 10 --\n> .../common/include/rte_eal_memconfig.h | 143 +++++++++--------\n> lib/librte_eal/common/malloc_heap.c | 16 +-\n> lib/librte_eal/common/malloc_mp.c | 1 +\n> lib/librte_eal/common/meson.build | 1 +\n> lib/librte_eal/common/rte_malloc.c | 33 ++--\n> lib/librte_eal/freebsd/eal/Makefile | 3 +-\n> lib/librte_eal/freebsd/eal/eal.c | 22 ++-\n> lib/librte_eal/freebsd/eal/eal_memory.c | 1 +\n> lib/librte_eal/linux/eal/Makefile | 3 +-\n> lib/librte_eal/linux/eal/eal.c | 42 ++---\n> lib/librte_eal/linux/eal/eal_memalloc.c | 1 +\n> lib/librte_eal/linux/eal/eal_memory.c | 1 +\n> lib/librte_eal/linux/eal/eal_vfio.c | 17 +-\n> lib/librte_eal/meson.build | 2 +-\n> lib/librte_eal/rte_eal_version.map | 12 ++\n> lib/librte_efd/rte_efd.c | 15 +-\n> lib/librte_eventdev/rte_event_ring.c | 16 +-\n> lib/librte_hash/rte_cuckoo_hash.c | 17 +-\n> lib/librte_hash/rte_fbk_hash.c | 15 +-\n> lib/librte_kni/rte_kni.c | 16 +-\n> lib/librte_lpm/rte_lpm.c | 25 +--\n> lib/librte_lpm/rte_lpm6.c | 15 +-\n> lib/librte_member/rte_member.c | 17 +-\n> lib/librte_mempool/rte_mempool.c | 27 ++--\n> lib/librte_reorder/rte_reorder.c | 15 +-\n> lib/librte_ring/rte_ring.c | 19 +--\n> lib/librte_stack/rte_stack.c | 18 +--\n> 45 files changed, 566 insertions(+), 330 deletions(-)\n> create mode 100644 lib/librte_eal/common/eal_common_mcfg.c\n> create mode 100644 lib/librte_eal/common/eal_memcfg.h\n> \n\nThis looks good thanks.\n\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9DA84325F;\n\tThu, 27 Jun 2019 17:36:12 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 335CC2BF7\n\tfor <dev@dpdk.org>; Thu, 27 Jun 2019 17:36:11 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id d126so1426957pfd.2\n\tfor <dev@dpdk.org>; Thu, 27 Jun 2019 08:36:11 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt96sm5682026pjb.1.2019.06.27.08.36.09\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 27 Jun 2019 08:36:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hbRmRgTcqHYC76XTaDQ8qxJIp5jVSVtG7QL/G1P3J+0=;\n\tb=q+7p5NTGe/VjqJ/Znl0hfKdDj4uWW4l7zhQ3FAIJbSE9tRfE71KCh4Rr5gcjP97kLe\n\tJsPdDPFD6rPdjI8EfEg4CTBmjaiqql/AkiUJtYZj8igLv5oXos8/jAmYG83O2DhMI5Ar\n\tOWLBQyspBWQyGBS6H3/cQ7B9/MSM2+OyV0MnFOeflyKszZCrBgUET7VZ3yAPlnR2QkJz\n\tYLZdh7RXxIfzZbW+AQ0eNhnVYQkJujtLpRuxsqr107muBg8bE61lRmo6S5C+Lgb55Yvw\n\tfxNkMn7aI4TIXFvU+5iRlbTSkD+Z01o5ia+C/Qj5YSuCaplXG5KUCb0EL4tp3wqMCBB8\n\tIJ6Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hbRmRgTcqHYC76XTaDQ8qxJIp5jVSVtG7QL/G1P3J+0=;\n\tb=lNjWGx+xv/YUC7QB/8HKltc4QmWYM82BGe40xZskELrRGZrtcsC24aMS2mrQVoOpM4\n\tkBDENyZXwVAWDKA7kaG6Q2g6oOnO79SsQ3cHSvJGBdy7wakUiqZUCKcnlEnmQPN9pOhp\n\tuQqvfExvhGXzihu/YO6f7ui3m4iS+ZqoV/Tg0ne/Bf8oVfR1EXsCqko2iwj7Wvp4klw2\n\t/r812e0++gtQdgiEn3123o/da/HchecfQKiYtPdpYv+rR66aZQAJPFFe7jxmzoWTiRsQ\n\tNRS3E6ktCdqMHlZtPqZZYaCclmVmwgvbfGWPOL+ROIBSyDe7G4/AGmtjJK5ulat5sNMt\n\tLh3g==", "X-Gm-Message-State": "APjAAAUofOTEnxaWrvw0niAe5moyvK0KnqGSFiendoFHbed+2Rjy3FOm\n\thUbu/urbBbpp4/1Cv55NQh2R2A==", "X-Google-Smtp-Source": "APXvYqxAZfPlpPdB2KakjR0nhPjel4QBgPYZNevOfn1RwEI+oGTysjDKSfDKE6ishY3SANnmhGYSqA==", "X-Received": "by 2002:a63:5202:: with SMTP id g2mr4356120pgb.386.1561649770179;\n\tThu, 27 Jun 2019 08:36:10 -0700 (PDT)", "Date": "Thu, 27 Jun 2019 08:36:03 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net", "Message-ID": "<20190627083603.3ee1e172@hermes.lan>", "In-Reply-To": "<cover.1561635481.git.anatoly.burakov@intel.com>", "References": "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<cover.1561635481.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 98061, "web_url": "http://patches.dpdk.org/comment/98061/", "msgid": "<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com", "date": "2019-07-03T09:38:02", "subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "Hello Anatoly,\n\nOn Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov <anatoly.burakov@intel.com>\nwrote:\n\n> This patchset removes the shared memory config from public\n> API, and replaces all usages of said config with new API\n> calls.\n>\n> A lot of the patchset is a search-and-replace job and should\n> be pretty easy to review. The rest are pretty trivial EAL\n> changes.\n>\n> This patchset depends on FreeBSD fixes patchset:\n>\n> http://patches.dpdk.org/project/dpdk/list/?series=5196\n>\n> v3:\n> - Rebase on top of latest master\n>\n> v2:\n> - Collapsed all changes into fewer patches\n> - Addressed review comments\n> - Created a new file to store the code\n> - Changed namespace to \"rte_mcfg_\"\n> - Added some unification around config init\n> - Removed \"packed\" attribute from mem config\n> - Removed unnecessary inlining\n> - Added a check to explicitly forbid running multiprocess\n> applications that differ in their DPDK versions\n>\n\n\nFor the parts I already had a look at, I still think the changes are in too\nmany patches.\nA lot of this is just search/replace we can have it with the patch that\nintroduces it.\n- patch 1, 2 and 3 could be squashed as a single one (plus removing the\nunused macro from patch 8)\n- idem with patch 4 and 5\n- idem with patch 6 and 7 (plus removing the unused macro from patch 8)\n\n\nI will look at the rest tomorrow (hopefully).", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C04AC1B95C;\n\tWed, 3 Jul 2019 11:38:17 +0200 (CEST)", "from mail-io1-f67.google.com (mail-io1-f67.google.com\n\t[209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 71A961B94E\n\tfor <dev@dpdk.org>; Wed, 3 Jul 2019 11:38:14 +0200 (CEST)", "by mail-io1-f67.google.com with SMTP id s7so3163124iob.11\n\tfor <dev@dpdk.org>; Wed, 03 Jul 2019 02:38:14 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=iBjCHcXLMstssmX1FSU0KwLvrAg7bCOPbF6cE2NSmSw=;\n\tb=VqFwa2zlr0z9auizhE39htpqe2J9bsvAqdBP2arxEOs3dASBMIU8eW9RmU6qgUZtV3\n\txHRssPVMQvukxbRmAUtaYAK8eotGceKmpuzOhoDCIwKxIHbOBLXcbjnelB5TahEhmitn\n\ty6fiqKDP5yFPGUDjzTZUWZm2hLgu3spNtV71HHp9DCTkFeiicopFep7JELTY7XXuDxOY\n\t60n7bAH6yek9v1zVaT49K/a873/CaKcx0iYeXOlnChbQJdNeVIo3brBe2Krra4We1xvk\n\t5GF6J48/PzevVGge1IWmj6rGzkNAVQBohK6gnXj819fEdoV2BA6AFpC/XXcnLgMBEEp5\n\tUsaA==", "X-Gm-Message-State": "APjAAAUpYfe5Xs03X+kfcLf0Rwj4q5sHml5b6OnR0vM3nd4fvYePwXd7\n\t5Pj9kgHZNJUvmOU+dxDqL+/xmItsPh2C9gptXlZddxXHVqQ=", "X-Google-Smtp-Source": "APXvYqyk9dHzEbuycnEFXpsqAnKijbFe5dogOsv6nd9DRHDfRrjNsrXU6O1McMj3IcCwNhXpDFgEcClk87rE1SdIH5I=", "X-Received": "by 2002:a05:6638:cf:: with SMTP id\n\tw15mr41988531jao.136.1562146693826; \n\tWed, 03 Jul 2019 02:38:13 -0700 (PDT)", "MIME-Version": "1.0", "References": "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<cover.1561635481.git.anatoly.burakov@intel.com>", "In-Reply-To": "<cover.1561635481.git.anatoly.burakov@intel.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 3 Jul 2019 11:38:02 +0200", "Message-ID": "<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, \n\tStephen Hemminger <stephen@networkplumber.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 98074, "web_url": "http://patches.dpdk.org/comment/98074/", "msgid": "<a1e0f387-d08f-5355-4d9b-dc96fcfb1ac5@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a1e0f387-d08f-5355-4d9b-dc96fcfb1ac5@intel.com", "date": "2019-07-03T10:47:19", "subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "content": "On 03-Jul-19 10:38 AM, David Marchand wrote:\n> Hello Anatoly,\n> \n> On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov \n> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:\n> \n> This patchset removes the shared memory config from public\n> API, and replaces all usages of said config with new API\n> calls.\n> \n> A lot of the patchset is a search-and-replace job and should\n> be pretty easy to review. The rest are pretty trivial EAL\n> changes.\n> \n> This patchset depends on FreeBSD fixes patchset:\n> \n> http://patches.dpdk.org/project/dpdk/list/?series=5196\n> \n> v3:\n> - Rebase on top of latest master\n> \n> v2:\n> - Collapsed all changes into fewer patches\n> - Addressed review comments\n> - Created a new file to store the code\n> - Changed namespace to \"rte_mcfg_\"\n> - Added some unification around config init\n> - Removed \"packed\" attribute from mem config\n> - Removed unnecessary inlining\n> - Added a check to explicitly forbid running multiprocess\n> applications that differ in their DPDK versions\n> \n> \n> \n> For the parts I already had a look at, I still think the changes are in \n> too many patches.\n> A lot of this is just search/replace we can have it with the patch that \n> introduces it.\n> - patch 1, 2 and 3 could be squashed as a single one (plus removing the \n> unused macro from patch 8)\n> - idem with patch 4 and 5\n> - idem with patch 6 and 7 (plus removing the unused macro from patch 8)\n> \n> \n> I will look at the rest tomorrow (hopefully).\n> \n> -- \n> David Marchand\n\nSure, i can squash it down into single patches for search/replace if \nthat's the preference.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 83CC01B94E;\n\tWed, 3 Jul 2019 12:47:25 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 8F60B1E25\n\tfor <dev@dpdk.org>; Wed, 3 Jul 2019 12:47:23 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2019 03:47:22 -0700", "from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.126])\n\t([10.237.220.126])\n\tby orsmga008.jf.intel.com with ESMTP; 03 Jul 2019 03:47:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,446,1557212400\"; d=\"scan'208\";a=\"157931233\"", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n\tStephen Hemminger <stephen@networkplumber.org>", "References": "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<cover.1561635481.git.anatoly.burakov@intel.com>\n\t<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "From": "\"Burakov, Anatoly\" <anatoly.burakov@intel.com>", "Message-ID": "<a1e0f387-d08f-5355-4d9b-dc96fcfb1ac5@intel.com>", "Date": "Wed, 3 Jul 2019 11:47:19 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2", "MIME-Version": "1.0", "In-Reply-To": "<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 98129, "web_url": "http://patches.dpdk.org/comment/98129/", "msgid": "<CAJFAV8wwMN+Hcm9ZYdxBbooEe=vxuYk6_CwbZVbEKcxOqG0rqQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8wwMN+Hcm9ZYdxBbooEe=vxuYk6_CwbZVbEKcxOqG0rqQ@mail.gmail.com", "date": "2019-07-04T08:09:11", "subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jul 3, 2019 at 11:38 AM David Marchand <david.marchand@redhat.com>\nwrote:\n\n> Hello Anatoly,\n>\n> On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov <anatoly.burakov@intel.com>\n> wrote:\n>\n>> This patchset removes the shared memory config from public\n>> API, and replaces all usages of said config with new API\n>> calls.\n>>\n>> A lot of the patchset is a search-and-replace job and should\n>> be pretty easy to review. The rest are pretty trivial EAL\n>> changes.\n>>\n>> This patchset depends on FreeBSD fixes patchset:\n>>\n>> http://patches.dpdk.org/project/dpdk/list/?series=5196\n>>\n>> v3:\n>> - Rebase on top of latest master\n>>\n>> v2:\n>> - Collapsed all changes into fewer patches\n>> - Addressed review comments\n>> - Created a new file to store the code\n>> - Changed namespace to \"rte_mcfg_\"\n>> - Added some unification around config init\n>> - Removed \"packed\" attribute from mem config\n>> - Removed unnecessary inlining\n>> - Added a check to explicitly forbid running multiprocess\n>> applications that differ in their DPDK versions\n>>\n>\n>\n> For the parts I already had a look at, I still think the changes are in\n> too many patches.\n> A lot of this is just search/replace we can have it with the patch that\n> introduces it.\n> - patch 1, 2 and 3 could be squashed as a single one (plus removing the\n> unused macro from patch 8)\n> - idem with patch 4 and 5\n> - idem with patch 6 and 7 (plus removing the unused macro from patch 8)\n>\n>\nOverall, I am ok with the changes, once the patch 13 is fixed.\nYou can add my ack on the n+1 patchset.\n\n\nI just want to state two approaches to merge these changes:\n- the first one would be to split this series in two\n - take the first part of this series now, but mark the new API\n\"experimental\"\n - postpone the merge to 19.11 of the second part, which starts at the\nhiding rte_mem_config patch\n- the second one is taking these changes in one go\n\nThe second one is the quicker and the more straightforward but it leaves\nthe risk of having missed something and we must break the ABI again in\n19.11.\nThe risk is quite low, given the changes.\n\n\nThomas, comments?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B0D31B942;\n\tThu, 4 Jul 2019 10:09:25 +0200 (CEST)", "from mail-ua1-f65.google.com (mail-ua1-f65.google.com\n\t[209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 4F76B58C4\n\tfor <dev@dpdk.org>; Thu, 4 Jul 2019 10:09:23 +0200 (CEST)", "by mail-ua1-f65.google.com with SMTP id o2so843690uae.10\n\tfor <dev@dpdk.org>; Thu, 04 Jul 2019 01:09:23 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=m15tln+xSLFAiJwV8sEsy3cEStEvquKvPWdIP8LBDgU=;\n\tb=o1aSIsUhK2z3EYqN8k5N+xSdbZOvPPWxMUKOeXr5OCIx5pLCT39/Eiv9Oa3CDnslB1\n\tHfboZOjDP4aJJ1/ZEA3K2NLbzcVC3cJC/JjRIXAeFommybxf84n1HknPb66VRxUnXrnM\n\tHIqhSQ0yCOVnFXrq4opoFbMKc9GfA1KzwEQhP2eY1hl9ULhC9Zo0jcD5iO3y2OLBIaAl\n\tl23u/z57rAt+2+pHdiY17pQ7+6SWwVDDGlW/D/4dsYfRVFUEO6BVm8jbgP7LnV1Qpk1q\n\tTX8bu3B/lWuUrql4GewUwL0XRNFbpco8e3QYOO+bssbaNUa/rJX+WPdgZzJRIHxuuF42\n\t5hNQ==", "X-Gm-Message-State": "APjAAAXhbUksMvWK+63tI7G8UtLooH7Ps4z5j/+zahPr6LV/qFwIYfN5\n\tqvcbApPlUaRm1wW8rZKmqAS2FwEhZ2xqhdJgPd9n9w==", "X-Google-Smtp-Source": "APXvYqzHXvXLOTCwgZhX5COXJEsNXBNfLaALrqvwP3zI0Bf7iifNSvstNyHPrbUysPshpr8p5NE9ODEjIX3TM8IzsBc=", "X-Received": "by 2002:ab0:45e3:: with SMTP id\n\tu90mr3931282uau.126.1562227762622; \n\tThu, 04 Jul 2019 01:09:22 -0700 (PDT)", "MIME-Version": "1.0", "References": "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<cover.1561635481.git.anatoly.burakov@intel.com>\n\t<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "In-Reply-To": "<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Thu, 4 Jul 2019 10:09:11 +0200", "Message-ID": "<CAJFAV8wwMN+Hcm9ZYdxBbooEe=vxuYk6_CwbZVbEKcxOqG0rqQ@mail.gmail.com>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, \n\tStephen Hemminger <stephen@networkplumber.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 98205, "web_url": "http://patches.dpdk.org/comment/98205/", "msgid": "<2038331.MNQvCC97BZ@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2038331.MNQvCC97BZ@xps", "date": "2019-07-04T19:52:40", "subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "04/07/2019 10:09, David Marchand:\n> I just want to state two approaches to merge these changes:\n> - the first one would be to split this series in two\n> - take the first part of this series now, but mark the new API\n> \"experimental\"\n> - postpone the merge to 19.11 of the second part, which starts at the\n> hiding rte_mem_config patch\n> - the second one is taking these changes in one go\n> \n> The second one is the quicker and the more straightforward but it leaves\n> the risk of having missed something and we must break the ABI again in\n> 19.11.\n> The risk is quite low, given the changes.\n> \n> \n> Thomas, comments?\n\nOK to merge it in one go.\nPlease, can we merge it tomorrow?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 820141E20;\n\tThu, 4 Jul 2019 21:52:46 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 24A8C2BE3\n\tfor <dev@dpdk.org>; Thu, 4 Jul 2019 21:52:44 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 9C08E21550;\n\tThu, 4 Jul 2019 15:52:43 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Thu, 04 Jul 2019 15:52:43 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id E1AF9380089;\n\tThu, 4 Jul 2019 15:52:42 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=FvvfUllztWs+fNFRsYOWMuqpvoKn/xp6x5ZVlCrUgIk=; b=M9uAF0H3pIUF\n\tsSTm8QFiQaDamelOwyxQ7+t/fMOCzC2GFhHorDjjXEvvRfXqKzDTHRZvTR1o+1SC\n\tg0tiF9VTPXc4a4XLy7Fu4/5RLQJ/jqLTdmwMeD9ljNFuXMIvE6Q7P/AIbrEF5igW\n\tvybkkQT+vYy2ymT4ZAESbT/f4i5C/0A=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm3; bh=FvvfUllztWs+fNFRsYOWMuqpvoKn/xp6x5ZVlCrUg\n\tIk=; b=sAkd0rH2SvEoPSEhZg0wKdAYoQ0AJlDrceE28c+z5VB1EM9xho1Al+cpO\n\tAvvLTpK6c2f/WJyRWgQO9UBzuvufdEZqP8HeJXSiCgLmp2rABuzKm6jIrKHsF9rm\n\t5E0d5oZoCB/vmYd6Kkz//W9fktyUyLXviVHNyD5PNTHgeBDtgLgOdbEjBIG84xfk\n\tAXu60nQFXLP6RySeHPeCW6ba1YL3G1T+3jl8vG0TvkEy6dDAIJwflArKcFc3Uont\n\tzoY2lngJxJfxDJ2uhLrN1uHKNC/6WvELBKNOaK+fKl+qiA+ggOIfRTJt9+a5D8Tx\n\t3naV+WdRphE/9P6r2DpgJ0P06UeuQ==" ], "X-ME-Sender": "<xms:C1keXYecrCwzdU5xjV7MugAK9SvNypHmwt126M1wVhLwLMZ8_xXdLg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgddugeehucetufdoteggodetrfdotf\n\tfvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n\tuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n\tcujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n\tshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf\n\thppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh\n\tohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu", "X-ME-Proxy": "<xmx:C1keXfY2FKmACJ09Y69a3LxOSCJGnEjnOjiRL9jdzBr4L4_j5xxmVQ>\n\t<xmx:C1keXc7yLkV9oF1aax1zoetC-nSGCDYp5osKcXL0pPQQTfwZzPb6xQ>\n\t<xmx:C1keXde0KLtFu9hQsOdau67oTUi9HRodnbESRNQlrJRqpjVs01qJnQ>\n\t<xmx:C1keXXmfIFC1TW3yxtayFlES9aIyP2H5DuUJAAoFuRhz9XCQf4tPyA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "David Marchand <david.marchand@redhat.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 04 Jul 2019 21:52:40 +0200", "Message-ID": "<2038331.MNQvCC97BZ@xps>", "In-Reply-To": "<CAJFAV8wwMN+Hcm9ZYdxBbooEe=vxuYk6_CwbZVbEKcxOqG0rqQ@mail.gmail.com>", "References": "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<CAJFAV8wFybm=3Lquem83ry=+oaeSGaFZV48NrQdjotZKKubTFw@mail.gmail.com>\n\t<CAJFAV8wwMN+Hcm9ZYdxBbooEe=vxuYk6_CwbZVbEKcxOqG0rqQ@mail.gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]