Cover Detail
Show a cover letter.
GET /api/covers/55375/?format=api
{ "id": 55375, "url": "http://patches.dpdk.org/api/covers/55375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20190625211520.43181-1-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625211520.43181-1-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625211520.43181-1-honnappa.nagarahalli@arm.com", "date": "2019-06-25T21:15:17", "name": "[0/3] lib/hash: perf improvements for lock-free", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20190625211520.43181-1-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 5166, "url": "http://patches.dpdk.org/api/series/5166/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5166", "date": "2019-06-25T21:15:17", "name": "lib/hash: perf improvements for lock-free", "version": 1, "mbox": "http://patches.dpdk.org/series/5166/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/55375/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C12F41B99B;\n\tTue, 25 Jun 2019 23:15:41 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id BDC1E1B99B\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 23:15:40 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6BF7360;\n\tTue, 25 Jun 2019 14:15:39 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n\t[10.118.12.65])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tD2EE13F246; Tue, 25 Jun 2019 14:15:39 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n\tbruce.richardson@intel.com, pablo.de.lara.guarch@intel.com,\n\thonnappa.nagarahalli@arm.com", "Cc": "gavin.hu@arm.com,\n\truifeng.wang@arm.com,\n\tdev@dpdk.org,\n\tnd@arm.com", "Date": "Tue, 25 Jun 2019 16:15:17 -0500", "Message-Id": "<20190625211520.43181-1-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH 0/3] lib/hash: perf improvements for lock-free", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While using the rte_hash library, there are 2 sets of stores that\nhappen.\n\n1) The application writes its data to memory (whose address\nis provided in rte_hash_add_key_with_hash_data API (or NULL))\n2) The rte_hash library writes to its own internal data structures;\nkey store entry and the hash table.\n\nThe data from both of these stores is available to the readers only\nafter the index of the key store entry (key_index) is written in the\nhash buckets by the library. So, key_index can act as the guard variable\nfor both of these writes.\n\nWhen rte_hash_add_key_with_hash_data is called to update an existing entry,\nthe key_index is not written. But, the store to the application data\nmust complete before the address of the application data (pData) is\nupdated in the key store entry. So, pData alone acts as the guard variable\nfor this case.\n\nHowever, it should be noted that there are no ordering requirements\nbetween 1) and 2), except for one requirement - the store to the\napplication data must complete before the store to key_index.\nIn other words, there are no ordering requirements between the stores to\nthe key store entry/signature and store to application data. So, the\nsynchronization point for application data can be any point between\nthe 'store to application data' and 'store to the key_index'.\n\nThe first patch in this series moves the signature comparison before the\nload-acquire of the key_index. This does not result in any issues because\nof the full key comparison which is done after the load-acquire of\nthe key_index.\nPerformance improvements:\nLookup Hit: 6.16%\nLookup Miss: 8.54%\n\nThe second patch in this series, moves the store-release of pData\nbefore the store to any hash internal data structures. This is not\nnecessary, but just helps to show the non-dependency between application\ndata and hash table data. On the reader side, the pData is loaded\nonly if the keys match, this provides performance benefits.\nPerformance improvements (with patch 1):\nLookup Hit: 6.25%\nLookup Miss: 13.97%\n\nThe third patch moves the table change counter to the beginning of\nthe cache line as it is one of the first fields accessed in the lookup\nfunction. Further work is required to adjust rte_hash structure\nto gain more performance.\nPerformance improvements (with patch 1 and patch 2):\nLookup Hit: 2.13%\nLookup Miss: 1.56%\n\nHonnappa Nagarahalli (3):\n lib/hash: use ordered loads only if signature matches\n lib/hash: load pData after full key compare\n lib/hash: adjust tbl_chng_cnt position\n\n lib/librte_hash/rte_cuckoo_hash.c | 96 ++++++++++++++++---------------\n lib/librte_hash/rte_cuckoo_hash.h | 6 +-\n 2 files changed, 53 insertions(+), 49 deletions(-)" }