Cover Comment List
List cover comments
GET /api/covers/55159/comments/?format=api
[ { "id": 97403, "web_url": "http://patches.dpdk.org/comment/97403/", "msgid": "<f7tk1dfngi8.fsf@dhcp-25.97.bos.redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f7tk1dfngi8.fsf@dhcp-25.97.bos.redhat.com", "date": "2019-06-21T14:46:07", "subject": "Re: [dpdk-dev] [PATCH v5 0/3] Enable rte_flow API in ice driver", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "content": "Qiming Yang <qiming.yang@intel.com> writes:\n\n> This patch set enables the backend of rte_flow, and the generic\n> filter related functions in ice driver. Supported flows include\n> ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch\n> set depends on shared code update.\n>\n> ---\n> v2 changes:\n> - added UDP tunnel port support.\n> - fixed compile issue.\n> - added document update.\n> v3 changes:\n> - removed redundancy parser.\n> - added License.\n> - added VXLAN and NVGRE item support.\n> v4 changes:\n> - fixed some typos.\n> v5 changes:\n> - fixed checkpatch issues.\n>\n\nThanks for fixing up the meson errors. I notice some build issues from\nthe Travis server. Can you take a look?\n\nhttps://travis-ci.com/ovsrobot/dpdk/builds/116409374\n\nI think the errors are introduced with the first patch, actually.\n\nIt might help to use github as an intermediate repository, sign up for\ntravis, push your changes to your github, and then watch the builds to\nensure that they are compiling properly. That can help to isolate\nenvironmental issues (for instance, accidentally omitted header files,\netc).\n\nSome of this is documented at doc/guides/contributing/patches.rst but if\nsomething is unclear or should have more detail to explain, lets improve\nthe docs.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 86D001D524;\n\tFri, 21 Jun 2019 16:46:21 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id F07C91D4B0\n\tfor <dev@dpdk.org>; Fri, 21 Jun 2019 16:46:19 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3F2FD223869;\n\tFri, 21 Jun 2019 14:46:09 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (unknown [10.18.25.84])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D5C46608D0;\n\tFri, 21 Jun 2019 14:46:07 +0000 (UTC)" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "Qiming Yang <qiming.yang@intel.com>", "Cc": "dev@dpdk.org", "References": "<1559552722-8970-1-git-send-email-qiming.yang@intel.com>\n\t<20190621092132.140460-1-qiming.yang@intel.com>", "Date": "Fri, 21 Jun 2019 10:46:07 -0400", "In-Reply-To": "<20190621092132.140460-1-qiming.yang@intel.com> (Qiming Yang's\n\tmessage of \"Fri, 21 Jun 2019 17:21:29 +0800\")", "Message-ID": "<f7tk1dfngi8.fsf@dhcp-25.97.bos.redhat.com>", "User-Agent": "Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Fri, 21 Jun 2019 14:46:14 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH v5 0/3] Enable rte_flow API in ice driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]