List cover comments

GET /api/covers/54974/comments/?format=api
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Link: 
<http://patches.dpdk.org/api/covers/54974/comments/?format=api&page=1>; rel="first",
<http://patches.dpdk.org/api/covers/54974/comments/?format=api&page=1>; rel="last"
Vary: Accept
[ { "id": 97303, "web_url": "http://patches.dpdk.org/comment/97303/", "msgid": "<039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com", "date": "2019-06-20T01:55:19", "subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Rong, Leyi\n> Sent: Wednesday, June 19, 2019 11:18 PM\n> To: Zhang, Qi Z <qi.z.zhang@intel.com>\n> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>\n> Subject: [PATCH v3 00/69] shared code update\n> \n> Main changes:\n> 1. Advanced switch rule support.\n> 2. Add more APIs for tunnel management.\n> 3. Add some minor features.\n> 4. Code clean and bug fix.\n> \n\nAcked-by: Qi Zhang <qi.z.zhang@intel.com>\n\nApplied to dpdk-next-net-intel with below changes\n\n1. patch 66 and 69 fixes patch 54, so merged to patch 54\n patch 64 fixes patch 06, so merged to patch 06\n so totally 66 patch merged.\n2. fix Camel title in patch 27, 39,\n\nThanks\nQi\n\n> ---\n> v3:\n> - Drop some patches which do not used.\n> - Split some patches which include irrelevant code.\n> - Squash some patches which needs to be put together.\n> - Add some new patches from latest shared code release.\n> \n> v2:\n> - Split [03/49] into 2 commits.\n> - Split [27/49] with a standalone commit for code change in ice_osdep.h.\n> - Split [39/48] by kind of changes.\n> - Remove [42/49].\n> - Add some new patches from latest shared code release.\n> \n> \n> Leyi Rong (69):\n> net/ice/base: update standard extr seq to include DIR flag\n> net/ice/base: add API to configure MIB\n> net/ice/base: add another valid DCBx state\n> net/ice/base: add more recipe commands\n> net/ice/base: add funcs to create new switch recipe\n> net/ice/base: programming a new switch recipe\n> net/ice/base: replay advanced rule after reset\n> net/ice/base: code for removing advanced rule\n> net/ice/base: save and post reset replay q bandwidth\n> net/ice/base: rollback AVF RSS configurations\n> net/ice/base: move RSS replay list\n> net/ice/base: cache the data of set PHY cfg AQ in SW\n> net/ice/base: refactor HW table init function\n> net/ice/base: add lock around profile map list\n> net/ice/base: add compatibility check for package version\n> net/ice/base: add API to init FW logging\n> net/ice/base: use macro instead of magic 8\n> net/ice/base: move and redefine ice debug cq API\n> net/ice/base: separate out control queue lock creation\n> net/ice/base: added sibling head to parse nodes\n> net/ice/base: add and fix debuglogs\n> net/ice/base: forbid VSI to remove unassociated ucast filter\n> net/ice/base: update some defines\n> net/ice/base: add hweight32 support\n> net/ice/base: call out dev/func caps when printing\n> net/ice/base: set the max number of TCs per port to 4\n> net/ice/base: make FDID available for FlexDescriptor\n> net/ice/base: use a different debug bit for FW log\n> net/ice/base: always set prefena when configuring a Rx queue\n> net/ice/base: disable Tx pacing option\n> net/ice/base: delete the index for chaining other recipe\n> net/ice/base: cleanup update link info\n> net/ice/base: add rd64 support\n> net/ice/base: track HW stat registers past rollover\n> net/ice/base: implement LLDP persistent settings\n> net/ice/base: check new FD filter duplicate location\n> net/ice/base: correct UDP/TCP PTYPE assignments\n> net/ice/base: calculate rate limit burst size correctly\n> net/ice/base: fix Flow Director VSI count\n> net/ice/base: use more efficient structures\n> net/ice/base: silent semantic parser warnings\n> net/ice/base: fix for signed package download\n> net/ice/base: add new API to dealloc flow entry\n> net/ice/base: check RSS flow profile list\n> net/ice/base: protect list add with lock\n> net/ice/base: fix Rx functionality for ethertype filters\n> net/ice/base: introduce some new macros\n> net/ice/base: new marker to mark func parameters unused\n> net/ice/base: code clean up\n> net/ice/base: cleanup ice flex pipe files\n> net/ice/base: refactor VSI node sched code\n> net/ice/base: add some minor new defines\n> net/ice/base: add vxlan/generic tunnel management\n> net/ice/base: enable additional switch rules\n> net/ice/base: allow forward to Q groups in switch rule\n> net/ice/base: changes for reducing ice add adv rule time\n> net/ice/base: deduce TSA value in the CEE mode\n> net/ice/base: rework API for ice zero bitmap\n> net/ice/base: rework API for ice cp bitmap\n> net/ice/base: use ice zero bitmap instead of ice memset\n> net/ice/base: use the specified size for ice zero bitmap\n> net/ice/base: correct NVGRE header structure\n> net/ice/base: reduce calls to get profile associations\n> net/ice/base: fix for chained recipe switch ID index\n> net/ice/base: update driver unloading field\n> net/ice/base: fix for UDP and TCP related switch rules\n> net/ice/base: changes in flow and profile removal\n> net/ice/base: update Tx context struct\n> net/ice/base: fixes for GRE\n> \n> drivers/net/ice/base/ice_adminq_cmd.h | 103 +-\n> drivers/net/ice/base/ice_bitops.h | 36 +-\n> drivers/net/ice/base/ice_common.c | 482 +++--\n> drivers/net/ice/base/ice_common.h | 18 +-\n> drivers/net/ice/base/ice_controlq.c | 247 ++-\n> drivers/net/ice/base/ice_controlq.h | 4 +-\n> drivers/net/ice/base/ice_dcb.c | 82 +-\n> drivers/net/ice/base/ice_dcb.h | 12 +-\n> drivers/net/ice/base/ice_fdir.c | 11 +-\n> drivers/net/ice/base/ice_fdir.h | 4 -\n> drivers/net/ice/base/ice_flex_pipe.c | 1198 +++++------\n> drivers/net/ice/base/ice_flex_pipe.h | 73 +-\n> drivers/net/ice/base/ice_flex_type.h | 54 +-\n> drivers/net/ice/base/ice_flow.c | 410 +++-\n> drivers/net/ice/base/ice_flow.h | 22 +-\n> drivers/net/ice/base/ice_lan_tx_rx.h | 4 +-\n> drivers/net/ice/base/ice_nvm.c | 18 +-\n> drivers/net/ice/base/ice_osdep.h | 23 +\n> drivers/net/ice/base/ice_protocol_type.h | 12 +-\n> drivers/net/ice/base/ice_sched.c | 219 +-\n> drivers/net/ice/base/ice_sched.h | 24 +-\n> drivers/net/ice/base/ice_switch.c | 2498 +++++++++++++++++++++-\n> drivers/net/ice/base/ice_switch.h | 66 +-\n> drivers/net/ice/base/ice_type.h | 80 +-\n> drivers/net/ice/ice_ethdev.c | 4 +-\n> 25 files changed, 4303 insertions(+), 1401 deletions(-)\n> \n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF5B91D071;\n\tThu, 20 Jun 2019 03:55:28 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id A6DD51D062\n\tfor <dev@dpdk.org>; Thu, 20 Jun 2019 03:55:26 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 18:55:25 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby fmsmga004.fm.intel.com with ESMTP; 19 Jun 2019 18:55:25 -0700", "from fmsmsx161.amr.corp.intel.com (10.18.125.9) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.439.0; Wed, 19 Jun 2019 18:55:25 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server\n\t(TLS) id 14.3.439.0; Wed, 19 Jun 2019 18:55:24 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.83]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.33]) with mapi id\n\t14.03.0439.000; Thu, 20 Jun 2019 09:55:20 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,394,1557212400\"; d=\"scan'208\";a=\"182919487\"", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Rong, Leyi\" <leyi.rong@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v3 00/69] shared code update", "Thread-Index": "AQHVJrKF8P0Z9au47EmvPCOYozipOqajw6kQ", "Date": "Thu, 20 Jun 2019 01:55:19 +0000", "Message-ID": "<039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com>", "References": "<20190611155221.2703-1-leyi.rong@intel.com>\n\t<20190619151846.113820-1-leyi.rong@intel.com>", "In-Reply-To": "<20190619151846.113820-1-leyi.rong@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg4YjM1YjQtYTJiMy00ZTliLThlODQtZjgwYWU5MDM1ZmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibjBZTnh0UHI5RlRkNE82anRKa3MyUUVSQXhJaHFBajR4ZEZibWEzelNYMmhmMkh5RnRlUzdtazZ1REE2MXUrQyJ9", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.600.7", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97372, "web_url": "http://patches.dpdk.org/comment/97372/", "msgid": "<365d5b75-0504-4d6f-dcb3-bcfb01555528@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/365d5b75-0504-4d6f-dcb3-bcfb01555528@intel.com", "date": "2019-06-20T20:18:07", "subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 6/20/2019 2:55 AM, Zhang, Qi Z wrote:\n> \n> \n>> -----Original Message-----\n>> From: Rong, Leyi\n>> Sent: Wednesday, June 19, 2019 11:18 PM\n>> To: Zhang, Qi Z <qi.z.zhang@intel.com>\n>> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>\n>> Subject: [PATCH v3 00/69] shared code update\n>>\n>> Main changes:\n>> 1. Advanced switch rule support.\n>> 2. Add more APIs for tunnel management.\n>> 3. Add some minor features.\n>> 4. Code clean and bug fix.\n>>\n> \n> Acked-by: Qi Zhang <qi.z.zhang@intel.com>\n> \n> Applied to dpdk-next-net-intel with below changes\n> \n> 1. patch 66 and 69 fixes patch 54, so merged to patch 54\n> patch 64 fixes patch 06, so merged to patch 06\n> so totally 66 patch merged.\n> 2. fix Camel title in patch 27, 39,\n> \n> Thanks\n> Qi\n\nThere is a 32 bits build error, can you please check?\n\n\n\nIn file included from .../dpdk/drivers/net/ice/base/ice_flow.c:6:\n.../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_find_entry’:\n.../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\ninteger of different size [-Werror=pointer-to-int-cast]\n 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n | ^\n.../dpdk/drivers/net/ice/base/ice_flow.c:1309:17: note: in expansion of macro\n‘ICE_FLOW_ENTRY_HNDL’\n 1309 | return found ? ICE_FLOW_ENTRY_HNDL(found) : ICE_FLOW_ENTRY_HANDLE_INVAL;\n | ^~~~~~~~~~~~~~~~~~~\n.../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_add_entry’:\n.../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\ninteger of different size [-Werror=pointer-to-int-cast]\n 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n | ^\n.../dpdk/drivers/net/ice/base/ice_flow.c:1387:13: note: in expansion of macro\n‘ICE_FLOW_ENTRY_HNDL’\n 1387 | *entry_h = ICE_FLOW_ENTRY_HNDL(e);\n | ^~~~~~~~~~~~~~~~~~~\n.../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_rem_entry’:\n.../dpdk/drivers/net/ice/base/ice_flow.h:240:32: error: cast to pointer from\ninteger of different size [-Werror=int-to-pointer-cast]\n 240 | #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))\n | ^\n.../dpdk/drivers/net/ice/base/ice_flow.c:1413:10: note: in expansion of macro\n‘ICE_FLOW_ENTRY_PTR’\n 1413 | entry = ICE_FLOW_ENTRY_PTR(entry_h);\n | ^~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors\nmake[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:114: ice_flow.o] Error 1\nmake[7]: *** Waiting for unfinished jobs....\nIn file included from .../dpdk/drivers/net/ice/base/ice_flex_pipe.c:8:\n.../dpdk/drivers/net/ice/base/ice_flex_pipe.c: In function ‘ice_free_flow_profs’:\n.../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\ninteger of different size [-Werror=pointer-to-int-cast]\n 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n | ^\n.../dpdk/drivers/net/ice/base/ice_flex_pipe.c:3027:27: note: in expansion of\nmacro ‘ICE_FLOW_ENTRY_HNDL’\n 3027 | ice_flow_rem_entry(hw, ICE_FLOW_ENTRY_HNDL(e));\n | ^~~~~~~~~~~~~~~~~~~\ncc1: all warnings being treated as errors", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E271A1D49A;\n\tThu, 20 Jun 2019 22:18:12 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 287851B9B1\n\tfor <dev@dpdk.org>; Thu, 20 Jun 2019 22:18:11 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2019 13:18:09 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.252.2.37])\n\t([10.252.2.37])\n\tby fmsmga008.fm.intel.com with ESMTP; 20 Jun 2019 13:18:08 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,398,1557212400\"; d=\"scan'208\";a=\"160781183\"", "To": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>, \"Rong, Leyi\" <leyi.rong@intel.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "References": "<20190611155221.2703-1-leyi.rong@intel.com>\n\t<20190619151846.113820-1-leyi.rong@intel.com>\n\t<039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE\n\t0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T\n\tYR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q\n\tCgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M\n\t1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I\n\tz+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr\n\tGE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte\n\tHQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG\n\tgMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7\n\tX07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K\n\t/s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1\n\tpBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv\n\tmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T\n\tqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA\n\tONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/\n\tvU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p\n\tiVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ\n\tI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH\n\tfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ\n\tqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi\n\t6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl\n\tRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh\n\tHwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q\n\tMJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp\n\tg0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8\n\tYO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7\n\tsgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY\n\txWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84\n\tQz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa\n\tARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a\n\tN3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv\n\t0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv\n\tVQ==", "Message-ID": "<365d5b75-0504-4d6f-dcb3-bcfb01555528@intel.com>", "Date": "Thu, 20 Jun 2019 21:18:07 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.1", "MIME-Version": "1.0", "In-Reply-To": "<039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97378, "web_url": "http://patches.dpdk.org/comment/97378/", "msgid": "<039ED4275CED7440929022BC67E70611533A9953@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E70611533A9953@SHSMSX103.ccr.corp.intel.com", "date": "2019-06-21T01:20:38", "subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Yigit, Ferruh\n> Sent: Friday, June 21, 2019 4:18 AM\n> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v3 00/69] shared code update\n> \n> On 6/20/2019 2:55 AM, Zhang, Qi Z wrote:\n> >\n> >\n> >> -----Original Message-----\n> >> From: Rong, Leyi\n> >> Sent: Wednesday, June 19, 2019 11:18 PM\n> >> To: Zhang, Qi Z <qi.z.zhang@intel.com>\n> >> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>\n> >> Subject: [PATCH v3 00/69] shared code update\n> >>\n> >> Main changes:\n> >> 1. Advanced switch rule support.\n> >> 2. Add more APIs for tunnel management.\n> >> 3. Add some minor features.\n> >> 4. Code clean and bug fix.\n> >>\n> >\n> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>\n> >\n> > Applied to dpdk-next-net-intel with below changes\n> >\n> > 1. patch 66 and 69 fixes patch 54, so merged to patch 54\n> > patch 64 fixes patch 06, so merged to patch 06\n> > so totally 66 patch merged.\n> > 2. fix Camel title in patch 27, 39,\n> >\n> > Thanks\n> > Qi\n> \n> There is a 32 bits build error, can you please check?\n\nMy bad, forgot to check 32 bits\n\nThe reason is some 32 bit fix in 19.05 does not synced, \nMinor fix on patch 40/69 and 41/69 are applied to dpdk-next-net-intel.\n\nThanks\nQi\n\n> \n> \n> \n> In file included from .../dpdk/drivers/net/ice/base/ice_flow.c:6:\n> .../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_find_entry’:\n> .../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\n> integer of different size [-Werror=pointer-to-int-cast]\n> 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n> | ^\n> .../dpdk/drivers/net/ice/base/ice_flow.c:1309:17: note: in expansion of macro\n> ‘ICE_FLOW_ENTRY_HNDL’\n> 1309 | return found ? ICE_FLOW_ENTRY_HNDL(found) :\n> ICE_FLOW_ENTRY_HANDLE_INVAL;\n> | ^~~~~~~~~~~~~~~~~~~\n> .../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_add_entry’:\n> .../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\n> integer of different size [-Werror=pointer-to-int-cast]\n> 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n> | ^\n> .../dpdk/drivers/net/ice/base/ice_flow.c:1387:13: note: in expansion of macro\n> ‘ICE_FLOW_ENTRY_HNDL’\n> 1387 | *entry_h = ICE_FLOW_ENTRY_HNDL(e);\n> | ^~~~~~~~~~~~~~~~~~~\n> .../dpdk/drivers/net/ice/base/ice_flow.c: In function ‘ice_flow_rem_entry’:\n> .../dpdk/drivers/net/ice/base/ice_flow.h:240:32: error: cast to pointer from\n> integer of different size [-Werror=int-to-pointer-cast]\n> 240 | #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))\n> | ^\n> .../dpdk/drivers/net/ice/base/ice_flow.c:1413:10: note: in expansion of macro\n> ‘ICE_FLOW_ENTRY_PTR’\n> 1413 | entry = ICE_FLOW_ENTRY_PTR(entry_h);\n> | ^~~~~~~~~~~~~~~~~~\n> cc1: all warnings being treated as errors\n> make[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:114: ice_flow.o] Error\n> 1\n> make[7]: *** Waiting for unfinished jobs....\n> In file included from .../dpdk/drivers/net/ice/base/ice_flex_pipe.c:8:\n> .../dpdk/drivers/net/ice/base/ice_flex_pipe.c: In function\n> ‘ice_free_flow_profs’:\n> .../dpdk/drivers/net/ice/base/ice_flow.h:239:33: error: cast from pointer to\n> integer of different size [-Werror=pointer-to-int-cast]\n> 239 | #define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)\n> | ^\n> .../dpdk/drivers/net/ice/base/ice_flex_pipe.c:3027:27: note: in expansion of\n> macro ‘ICE_FLOW_ENTRY_HNDL’\n> 3027 | ice_flow_rem_entry(hw, ICE_FLOW_ENTRY_HNDL(e));\n> | ^~~~~~~~~~~~~~~~~~~\n> cc1: all warnings being treated as errors", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A39411D4D5;\n\tFri, 21 Jun 2019 03:20:43 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id C596A1D475\n\tfor <dev@dpdk.org>; Fri, 21 Jun 2019 03:20:41 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2019 18:20:40 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby fmsmga006.fm.intel.com with ESMTP; 20 Jun 2019 18:20:40 -0700", "from fmsmsx118.amr.corp.intel.com (10.18.116.18) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.439.0; Thu, 20 Jun 2019 18:20:40 -0700", "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tfmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP\n\tServer (TLS) id 14.3.439.0; Thu, 20 Jun 2019 18:20:39 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.83]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id\n\t14.03.0439.000; Fri, 21 Jun 2019 09:20:38 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,398,1557212400\"; d=\"scan'208\";a=\"359140619\"", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Yigit, Ferruh\" <ferruh.yigit@intel.com>, \"Rong, Leyi\"\n\t<leyi.rong@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3 00/69] shared code update", "Thread-Index": "AQHVJrKF8P0Z9au47EmvPCOYozipOqajw6kQgACzYYCAANh/4A==", "Date": "Fri, 21 Jun 2019 01:20:38 +0000", "Message-ID": "<039ED4275CED7440929022BC67E70611533A9953@SHSMSX103.ccr.corp.intel.com>", "References": "<20190611155221.2703-1-leyi.rong@intel.com>\n\t<20190619151846.113820-1-leyi.rong@intel.com>\n\t<039ED4275CED7440929022BC67E70611533A909A@SHSMSX103.ccr.corp.intel.com>\n\t<365d5b75-0504-4d6f-dcb3-bcfb01555528@intel.com>", "In-Reply-To": "<365d5b75-0504-4d6f-dcb3-bcfb01555528@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc2OWMzMzAtNjM0ZC00YTFjLWExZWItOGE3ZDQwOGUwNDZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHhtTTZMMjFkdDh5RW1zT0RRRjJqTEJNQU02azNwVUFBUlBySlYrOGdXQm1aS096ZWZTREZmeFlTMU10VVhHZiJ9", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.600.7", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 00/69] shared code update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]