Cover Comment List
List cover comments
GET /api/covers/54331/comments/?format=api
[ { "id": 96691, "web_url": "http://patches.dpdk.org/comment/96691/", "msgid": "<81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com", "date": "2019-06-04T15:49:34", "subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "submitter": { "id": 1214, "url": "http://patches.dpdk.org/api/people/1214/?format=api", "name": "Michael Santana", "email": "msantana@redhat.com" }, "content": "On 6/4/19 4:59 AM, David Marchand wrote:\n> This is a joint effort to make the unit tests ready for CI.\n> The first 8 patches are fixes that I had accumulated.\n> Then the second part of the series focuses on skipping tests when some\n> requirements are not fulfilled so that we can start them in a restrained\n> environment like Travis virtual machines that gives us two cores and does\n> not have specific hw devices.\n>\n> We are still not ready for enabling those tests in Travis.\n> At least, the following issues remain:\n> - some fixes on librte_acl have not been merged yet [1],\n> - the tests on --file-prefix are still ko, and have been isolated in a\n> test that we could disable while waiting for the fixes,\n> - rwlock_autotest and hash_readwrite_lf_autotest are taking a little more\n> than 10s,\nIt would be a good idea to increase timeout. These are probably not the \nonly tests that would pass with just a little bit more time\n> - librte_table unit test crashes on ipv6 [2],\n> - the \"perf\" tests are taking way too long for my taste,\n\nWe should still fix them. However I don't know if we should be running \nthe perf test for every job and every patch on travis. It takes too \nlong. The travis queue will be delayed too far behind for it to be of \nany use.\n\nOTOH we could have one job as part of the travis build dedicated to \nrunning tests (or just perf test). It's still time consuming but better \nthan running the test on every travis job. For this to work we would \nneed to decreased the timeout for the perf tests as the timeout for it \nand the travis are both 10 minutes\n\n> - the shared build unit tests all fail when depending on mempool since\n> the mempool drivers are not loaded,\n>\n> 1: http://patchwork.dpdk.org/project/dpdk/list/?series=4242\n> 2: https://bugs.dpdk.org/show_bug.cgi?id=285\n>\n> Comments/reviews welcome!\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC01B1BC22;\n\tTue, 4 Jun 2019 17:49:51 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 88B841BC14\n\tfor <dev@dpdk.org>; Tue, 4 Jun 2019 17:49:50 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ECE7F83F4C;\n\tTue, 4 Jun 2019 15:49:41 +0000 (UTC)", "from localhost.localdomain (unknown [10.18.25.8])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 90BA56134B;\n\tTue, 4 Jun 2019 15:49:34 +0000 (UTC)" ], "To": "David Marchand <david.marchand@redhat.com>, dev@dpdk.org", "Cc": "thomas@monjalon.net, aconole@redhat.com", "References": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>", "From": "Michael Santana Francisco <msantana@redhat.com>", "Organization": "Red Hat", "Message-ID": "<81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com>", "Date": "Tue, 4 Jun 2019 11:49:34 -0400", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0", "MIME-Version": "1.0", "In-Reply-To": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]); Tue, 04 Jun 2019 15:49:44 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "msantana@redhat.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97666, "web_url": "http://patches.dpdk.org/comment/97666/", "msgid": "<2134880.WhL1dmy7PZ@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2134880.WhL1dmy7PZ@xps", "date": "2019-06-27T16:34:18", "subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "04/06/2019 17:49, Michael Santana Francisco:\n> On 6/4/19 4:59 AM, David Marchand wrote:\n> > - the \"perf\" tests are taking way too long for my taste,\n> \n> We should still fix them. However I don't know if we should be running \n> the perf test for every job and every patch on travis. It takes too \n> long. The travis queue will be delayed too far behind for it to be of \n> any use.\n> \n> OTOH we could have one job as part of the travis build dedicated to \n> running tests (or just perf test). It's still time consuming but better \n> than running the test on every travis job. For this to work we would \n> need to decreased the timeout for the perf tests as the timeout for it \n> and the travis are both 10 minutes\n\n+Cc ci@dpdk.org\n\nI don't think we should run the perf tests in basic CI like Travis.\nWe can run perf tests if the purpose is to compare the performance\nwith previous releases, as some other tests in the community lab.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D07BF58C4;\n\tThu, 27 Jun 2019 18:34:22 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C8A1F2C30;\n\tThu, 27 Jun 2019 18:34:21 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 6D4D6221BD;\n\tThu, 27 Jun 2019 12:34:21 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Thu, 27 Jun 2019 12:34:21 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id F324680063;\n\tThu, 27 Jun 2019 12:34:19 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=z4jqmAwMnmGu4YK1AfVEhtBJjuQ3cIWQYlCfPIxhpik=; b=geqU9eOENYTz\n\tJRgUBMaK19R1CUEVeT4UTFg/yKZGscG8M+x8cZn9u+lz8q9FL7fPUfjOz3/DdXIY\n\tc0HfUxDsIzPDgHlsdPpPNsrLApxnevVOoGMxsyGp+ywKP+QB+mcjGjdohoFB70cn\n\t2HaHjFBGRtoO7kyh2rcxgCkYRfNECe8=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm3; bh=z4jqmAwMnmGu4YK1AfVEhtBJjuQ3cIWQYlCfPIxhp\n\tik=; b=UZMKGdM2l3ykkyxmwfFwXj0ODRIksftizMME7no1KFpgTnfKVFNyldDwZ\n\tj/rwZkzHf5Bg0tlXt5NwH4Ldbb8trZVlqdExxILuEJkTFNNo8lgBkDW0Dwjf/coX\n\txrafg/ty/uyIXc4XRuek463/KLY+Q8gYZDI5J8VUr+5SwTBpxCxCBMkr3zH9USfZ\n\tP8DoMleApQtOCNSRQjsT7Xk8vfi7r83wxjdceDvVAW8t7T/ZEfagwBeB+xgpGtem\n\tI3nIBtHgXeBybt4USlfj1AyYsZorOwJMQKaFzgFThxjUShRTNrqFpA13P26pjF1F\n\t9K3/2ZPfp1CQoDf21k4kNmDvVydtQ==" ], "X-ME-Sender": "<xms:DPAUXcrju879K3Pm0_yIqn0MdZ97bOFQZJvLgkiTCmyNMHyeSSx0Hg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduvddrudekgddutdegucetufdoteggodetrfdotf\n\tfvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n\tuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n\tcujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n\tshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf\n\thppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh\n\tohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:DPAUXVGlaHCEiJbALbIffTHcT84c_1gJiNw2LwR4jqjwoO9w2XnzaQ>\n\t<xmx:DPAUXe4K9pInyg-E6QzQKtq_mUKznoRZf4-v0NRCYaEODGRD5vzyBA>\n\t<xmx:DPAUXTBs446aexgI2rUYi70fEgCoRdtOt_8kjoEsMhR4VsnDwTj05Q>\n\t<xmx:DfAUXXmYVdPmpw-WMuS_opFiT9xtMTecu0jyWWFNL_mrl2NBalDR9g>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "msantana@redhat.com, David Marchand <david.marchand@redhat.com>,\n\taconole@redhat.com", "Cc": "dev@dpdk.org, ci@dpdk.org", "Date": "Thu, 27 Jun 2019 18:34:18 +0200", "Message-ID": "<2134880.WhL1dmy7PZ@xps>", "In-Reply-To": "<81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com>", "References": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>\n\t<81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97880, "web_url": "http://patches.dpdk.org/comment/97880/", "msgid": "<f7tsgrq0x06.fsf@dhcp-25.97.bos.redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f7tsgrq0x06.fsf@dhcp-25.97.bos.redhat.com", "date": "2019-07-01T12:17:45", "subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "content": "Thomas Monjalon <thomas@monjalon.net> writes:\n\n> 04/06/2019 17:49, Michael Santana Francisco:\n>> On 6/4/19 4:59 AM, David Marchand wrote:\n>> > - the \"perf\" tests are taking way too long for my taste,\n\n+1 here.\n\n>> \n>> We should still fix them. However I don't know if we should be running \n>> the perf test for every job and every patch on travis. It takes too \n>> long. The travis queue will be delayed too far behind for it to be of \n>> any use.\n>> \n>> OTOH we could have one job as part of the travis build dedicated to \n>> running tests (or just perf test). It's still time consuming but better \n>> than running the test on every travis job. For this to work we would \n>> need to decreased the timeout for the perf tests as the timeout for it \n>> and the travis are both 10 minutes\n>\n> +Cc ci@dpdk.org\n>\n> I don't think we should run the perf tests in basic CI like Travis.\n> We can run perf tests if the purpose is to compare the performance\n> with previous releases, as some other tests in the community lab.\n\n+1 - some of the perf tests aren't going to complete in any sort of\nreasonable time. While we could claim it's a separate problem, we\nshould also not enable something that will make the travis runs so much\nlonger.\n\nI do like the idea of running tests in the travis build, and I think it\nwould make sense to have just a single job for it (or maybe one for\nclang and one for gcc? maybe even that is overkill).\n\nI would rather not do performance tests during the travis run, though.\nIt doesn't really make sense. Travis isn't any kind of an 'optimized'\nenvironment, so I don't know what 'performance' should mean.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 515261B203;\n\tMon, 1 Jul 2019 14:17:54 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 6B1D4559A;\n\tMon, 1 Jul 2019 14:17:52 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7D6C35AFE3;\n\tMon, 1 Jul 2019 12:17:51 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (ovpn-120-240.rdu2.redhat.com\n\t[10.10.120.240])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4293919C77;\n\tMon, 1 Jul 2019 12:17:46 +0000 (UTC)" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "msantana@redhat.com, David Marchand <david.marchand@redhat.com>,\n\tdev@dpdk.org, ci@dpdk.org", "References": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>\n\t<81c5f665-97ac-c4d0-8281-8f195c63195e@redhat.com>\n\t<2134880.WhL1dmy7PZ@xps>", "Date": "Mon, 01 Jul 2019 08:17:45 -0400", "In-Reply-To": "<2134880.WhL1dmy7PZ@xps> (Thomas Monjalon's message of \"Thu, 27\n\tJun 2019 18:34:18 +0200\")", "Message-ID": "<f7tsgrq0x06.fsf@dhcp-25.97.bos.redhat.com>", "User-Agent": "Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Mon, 01 Jul 2019 12:17:51 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]