List comments

GET /api/covers/54276/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 96697,
        "web_url": "http://patches.dpdk.org/comment/96697/",
        "msgid": "<ced68cd7-167b-83cc-eb1a-16d67ee94445@redhat.com>",
        "date": "2019-06-04T16:56:00",
        "subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
        "submitter": {
            "id": 512,
            "url": "http://patches.dpdk.org/api/people/512/",
            "name": "Maxime Coquelin",
            "email": "maxime.coquelin@redhat.com"
        },
        "content": "Hi Leyi,\n\nOn 6/4/19 7:41 AM, Leyi Rong wrote:\n> Main changes:\n> 1. Advanced switch rule support.\n> 2. Add more APIs for tunnel management.\n> 3. Add some minor features.\n> 4. Code clean and bug fix.\n\nIn order to ease the review process, I think it would be much better\nto split this series in multiple ones, by features. Otherwise, it\nis more difficult to keep track if comments are taken into account\nin the next revision.\n\nAlso, it is suggested to put the fixes first in the series to ease\nthe backporting.\n\nThanks,\nMaxime",
        "headers": {
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Tue, 4 Jun 2019 18:56:00 +0200",
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "To": "Leyi Rong <leyi.rong@intel.com>, qi.z.zhang@intel.com",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1",
            "References": "<20190604054248.68510-1-leyi.rong@intel.com>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BF501BC03;\n\tTue,  4 Jun 2019 18:56:16 +0200 (CEST)",
                "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 61A7B1BB32\n\tfor <dev@dpdk.org>; Tue,  4 Jun 2019 18:56:14 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1CA833082207;\n\tTue,  4 Jun 2019 16:56:03 +0000 (UTC)",
                "from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4354C5B683;\n\tTue,  4 Jun 2019 16:56:02 +0000 (UTC)"
            ],
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15",
            "Subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
            "In-Reply-To": "<20190604054248.68510-1-leyi.rong@intel.com>",
            "MIME-Version": "1.0",
            "Message-ID": "<ced68cd7-167b-83cc-eb1a-16d67ee94445@redhat.com>",
            "Precedence": "list",
            "Content-Transfer-Encoding": "7bit",
            "X-BeenThere": "dev@dpdk.org",
            "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.47]); Tue, 04 Jun 2019 16:56:08 +0000 (UTC)"
        }
    },
    {
        "id": 96825,
        "web_url": "http://patches.dpdk.org/comment/96825/",
        "msgid": "<47ACC7359E973C41ACB0C2477632BC72518B7F28@SHSMSX103.ccr.corp.intel.com>",
        "date": "2019-06-06T05:44:53",
        "subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
        "submitter": {
            "id": 1204,
            "url": "http://patches.dpdk.org/api/people/1204/",
            "name": "Rong, Leyi",
            "email": "leyi.rong@intel.com"
        },
        "content": "> -----Original Message-----\n> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]\n> Sent: Wednesday, June 5, 2019 12:56 AM\n> To: Rong, Leyi <leyi.rong@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 00/49] shared code update\n> \n> Hi Leyi,\n> \n> On 6/4/19 7:41 AM, Leyi Rong wrote:\n> > Main changes:\n> > 1. Advanced switch rule support.\n> > 2. Add more APIs for tunnel management.\n> > 3. Add some minor features.\n> > 4. Code clean and bug fix.\n> \n> In order to ease the review process, I think it would be much better to split this series in multiple ones, by features.\n> Otherwise, it is more difficult to keep track if comments are taken into account in the next revision.\n> \n> Also, it is suggested to put the fixes first in the series to ease the backporting.\n> \n> Thanks,\n> Maxime\n\n+Paul,\n\nHello Maxime,\nThanks for all your constructive comments, but we do the same process for the CVL shared code update to DPDK upstream on the previous release.\nThis series of patches are extracted/reorganized/squashed from the ND released packages, which the shared code difference between 1905 and 1908 can be more than 200 commits from the original shared code repo.\n\nIMHO, there might be some reasons for take all these patches into one patchset.\n\t- the patchset try to keeps the history order as the commits in the original shared code repo.\n\t- the relatively behind patch in the patchset may have dependency on the front patches.\n\t- it's difficult to split this series into multiple ones, since the patches are irregular and squashed.\n\n\nBest Regards,\nLeyi Rong",
        "headers": {
            "dlp-version": "11.2.0.6",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "From": "\"Rong, Leyi\" <leyi.rong@intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Thu, 6 Jun 2019 05:44:53 +0000",
            "X-Mailman-Version": "2.1.15",
            "x-ctpclassification": "CTP_NT",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Delivered-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "X-MS-Has-Attach": "",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "CC": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, \"Zhang, Qi Z\"\n\t<qi.z.zhang@intel.com>, \"Stillwell Jr, Paul M\"\n\t<paul.m.stillwell.jr@intel.com>",
            "dlp-reaction": "no-action",
            "Errors-To": "dev-bounces@dpdk.org",
            "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<ced68cd7-167b-83cc-eb1a-16d67ee94445@redhat.com>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF0761B946;\n\tThu,  6 Jun 2019 07:45:00 +0200 (CEST)",
                "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id DB7382C0C\n\tfor <dev@dpdk.org>; Thu,  6 Jun 2019 07:44:58 +0200 (CEST)",
                "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2019 22:44:57 -0700",
                "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Jun 2019 22:44:57 -0700",
                "from fmsmsx114.amr.corp.intel.com (10.18.116.8) by\n\tfmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Wed, 5 Jun 2019 22:44:57 -0700",
                "from shsmsx106.ccr.corp.intel.com (10.239.4.159) by\n\tFMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server\n\t(TLS) id 14.3.408.0; Wed, 5 Jun 2019 22:44:56 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.120]) by\n\tSHSMSX106.ccr.corp.intel.com ([169.254.10.113]) with mapi id\n\t14.03.0415.000; Thu, 6 Jun 2019 13:44:54 +0800"
            ],
            "Thread-Index": "AQHVGpiCPwgcKV9IzUm5nheaQHUZiaaLMXgAgAE0UGA=",
            "dlp-product": "dlpe-windows",
            "Accept-Language": "en-US",
            "X-Amp-File-Uploaded": "False",
            "Subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
            "In-Reply-To": "<ced68cd7-167b-83cc-eb1a-16d67ee94445@redhat.com>",
            "MIME-Version": "1.0",
            "Message-ID": "<47ACC7359E973C41ACB0C2477632BC72518B7F28@SHSMSX103.ccr.corp.intel.com>",
            "X-ExtLoop1": "1",
            "Content-Language": "en-US",
            "x-originating-ip": "[10.239.127.40]",
            "X-MS-TNEF-Correlator": "",
            "Content-Transfer-Encoding": "base64",
            "X-BeenThere": "dev@dpdk.org",
            "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjFhYTMxYTAtNDczOS00Njg5LTgwMGYtZGU5YzQ0MjQ2NDQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVktTR0FWQUp3KzdqUXpGdUNlelBEbjlObWZ3d3hYQ3FNV0xnand0d0NrS2RsbzVnQ3RlZW1JVysxMkdEZHJUeiJ9",
            "X-Original-To": "patchwork@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Thread-Topic": "[dpdk-dev] [PATCH 00/49] shared code update"
        }
    },
    {
        "id": 96929,
        "web_url": "http://patches.dpdk.org/comment/96929/",
        "msgid": "<65242236-aba7-0b14-9bdc-685fa1e5d6d8@redhat.com>",
        "date": "2019-06-07T12:53:19",
        "subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
        "submitter": {
            "id": 512,
            "url": "http://patches.dpdk.org/api/people/512/",
            "name": "Maxime Coquelin",
            "email": "maxime.coquelin@redhat.com"
        },
        "content": "Hi Leyi,\n\nOn 6/6/19 7:44 AM, Rong, Leyi wrote:\n> \n>> -----Original Message-----\n>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]\n>> Sent: Wednesday, June 5, 2019 12:56 AM\n>> To: Rong, Leyi <leyi.rong@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>\n>> Cc: dev@dpdk.org\n>> Subject: Re: [dpdk-dev] [PATCH 00/49] shared code update\n>>\n>> Hi Leyi,\n>>\n>> On 6/4/19 7:41 AM, Leyi Rong wrote:\n>>> Main changes:\n>>> 1. Advanced switch rule support.\n>>> 2. Add more APIs for tunnel management.\n>>> 3. Add some minor features.\n>>> 4. Code clean and bug fix.\n>>\n>> In order to ease the review process, I think it would be much better to split this series in multiple ones, by features.\n>> Otherwise, it is more difficult to keep track if comments are taken into account in the next revision.\n>>\n>> Also, it is suggested to put the fixes first in the series to ease the backporting.\n>>\n>> Thanks,\n>> Maxime\n> \n> +Paul,\n> \n> Hello Maxime,\n> Thanks for all your constructive comments, but we do the same process for the CVL shared code update to DPDK upstream on the previous release.\n> This series of patches are extracted/reorganized/squashed from the ND released packages, which the shared code difference between 1905 and 1908 can be more than 200 commits from the original shared code repo.\n> \n> IMHO, there might be some reasons for take all these patches into one patchset.\n> \t- the patchset try to keeps the history order as the commits in the original shared code repo.\n> \t- the relatively behind patch in the patchset may have dependency on the front patches.\n> \t- it's difficult to split this series into multiple ones, since the patches are irregular and squashed.\n\nOn the other hand, it means we should just apply the series without even\nreviewing it as it would not be taken into account.\n\nI personally think this is not a sane practice.\n\nThis is not the case of this series, which is almost good to me except\nsome missing errors handling, but imagine there is a security issue in\nit, should we just apply it as-is not to diverge from your internal code\nbase and wait for the next shared code release to get the fix?\n\nNote that my comment is not intended at Intel drivers specifically, as\nit seems a common practice to have the base driver not reviewed and\napplied as-is.\n\nBest regards,\nMaxime\n> \n> \n> Best Regards,\n> Leyi Rong\n>",
        "headers": {
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Fri, 7 Jun 2019 14:53:19 +0200",
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "To": "\"Rong, Leyi\" <leyi.rong@intel.com>, \"Zhang, Qi Z\" <qi.z.zhang@intel.com>,\n\t\"Stillwell Jr, Paul M\" <paul.m.stillwell.jr@intel.com>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1",
            "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<ced68cd7-167b-83cc-eb1a-16d67ee94445@redhat.com>\n\t<47ACC7359E973C41ACB0C2477632BC72518B7F28@SHSMSX103.ccr.corp.intel.com>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8499F1BBDA;\n\tFri,  7 Jun 2019 14:53:33 +0200 (CEST)",
                "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E6EF01BBD3\n\tfor <dev@dpdk.org>; Fri,  7 Jun 2019 14:53:31 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 24F5F308626C;\n\tFri,  7 Jun 2019 12:53:25 +0000 (UTC)",
                "from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 06D0B7D54C;\n\tFri,  7 Jun 2019 12:53:20 +0000 (UTC)"
            ],
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11",
            "Subject": "Re: [dpdk-dev] [PATCH 00/49] shared code update",
            "In-Reply-To": "<47ACC7359E973C41ACB0C2477632BC72518B7F28@SHSMSX103.ccr.corp.intel.com>",
            "MIME-Version": "1.0",
            "Message-ID": "<65242236-aba7-0b14-9bdc-685fa1e5d6d8@redhat.com>",
            "Precedence": "list",
            "Content-Transfer-Encoding": "7bit",
            "X-BeenThere": "dev@dpdk.org",
            "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]); Fri, 07 Jun 2019 12:53:31 +0000 (UTC)"
        }
    }
]