Cover Comment List
List cover comments
GET /api/covers/54176/comments/?format=api
[ { "id": 96676, "web_url": "http://patches.dpdk.org/comment/96676/", "msgid": "<348A99DA5F5B7549AA880327E580B4358977B123@IRSMSX101.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/348A99DA5F5B7549AA880327E580B4358977B123@IRSMSX101.ger.corp.intel.com", "date": "2019-06-04T13:16:27", "subject": "Re: [dpdk-dev] [PATCH 0/9] add QAT support for digest encrypted", "submitter": { "id": 423, "url": "http://patches.dpdk.org/api/people/423/?format=api", "name": "Fiona Trahe", "email": "fiona.trahe@intel.com" }, "content": "Hi Damian,\n\n> -----Original Message-----\n> From: Nowak, DamianX\n> Sent: Monday, June 3, 2019 3:51 PM\n> To: dev@dpdk.org\n> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Nowak,\n> DamianX <damianx.nowak@intel.com>\n> Subject: [PATCH 0/9] add QAT support for digest encrypted\n> \n> From: Damian Nowak <damianx.nowak@intel.com>\n> \n> This patchset adds digest appended and encrypted\n> auth-cipher operations support for QAT, with\n> dedicated feature flag and a set of tests\n> for KASUMI and SNOW3G in-place, out-of-place\n> and SGL using operations. \n[Fiona] As this patchset is not just QAT changes, but includes an API clarification and extension\nit should be renamed something like \ncryptodev: support encrypted-digest use-cases\nand patches should be ordered:\n - API patches\n - QAT driver patches\n - Test code patches\n - Documentation patches - release note patch should be added\n\n> Damian Nowak (9):\n> crypto/qat: check buffer size for oop auth-cipher\n> test/crypto: add snow3g test cases for oop operation\n> test/crypto: add kasumi test cases for oop operation\n> test/crypto: add sgl test cases for ip and oop\n> cryptodev: document usage of digest-appended operations\n> cryptodev: add digest encrypted feature flag\n> crypto/qat: add digest encrypted feature flag\n> test/crypto: add digest encrypted feature flag check\n> test/crypto: return correct value if feature not supported\n> \n> app/test/test_cryptodev.c | 668 ++++++++++++++++++++++----\n> app/test/test_cryptodev_kasumi_test_vectors.h | 98 +++-\n> app/test/test_cryptodev_snow3g_test_vectors.h | 167 ++++++-\n> drivers/crypto/qat/qat_sym.c | 30 +-\n> drivers/crypto/qat/qat_sym_pmd.c | 3 +-\n> lib/librte_cryptodev/rte_crypto_sym.h | 43 ++\n> lib/librte_cryptodev/rte_cryptodev.c | 2 +\n> lib/librte_cryptodev/rte_cryptodev.h | 2 +\n> 8 files changed, 895 insertions(+), 118 deletions(-)\n> \n> --\n> 2.7.4", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2CA111BBE1;\n\tTue, 4 Jun 2019 15:16:32 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 831A71BBD2\n\tfor <dev@dpdk.org>; Tue, 4 Jun 2019 15:16:30 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Jun 2019 06:16:29 -0700", "from irsmsx109.ger.corp.intel.com ([163.33.3.23])\n\tby fmsmga006.fm.intel.com with ESMTP; 04 Jun 2019 06:16:27 -0700", "from irsmsx101.ger.corp.intel.com ([169.254.1.10]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.162]) with mapi id\n\t14.03.0415.000; Tue, 4 Jun 2019 14:16:28 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Trahe, Fiona\" <fiona.trahe@intel.com>", "To": "\"Nowak, DamianX\" <damianx.nowak@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Kusztal, ArkadiuszX\" <arkadiuszx.kusztal@intel.com>, \"Trahe, Fiona\"\n\t<fiona.trahe@intel.com>, \"akhil.goyal@nxp.com\" <akhil.goyal@nxp.com>", "Thread-Topic": "[PATCH 0/9] add QAT support for digest encrypted", "Thread-Index": "AQHVGhxN3F9RAnNtVkaL2MVxWZhc2KaLeFcQ", "Date": "Tue, 4 Jun 2019 13:16:27 +0000", "Message-ID": "<348A99DA5F5B7549AA880327E580B4358977B123@IRSMSX101.ger.corp.intel.com>", "References": "<20190603145048.2596-1-damianx.nowak@intel.com>", "In-Reply-To": "<20190603145048.2596-1-damianx.nowak@intel.com>", "Accept-Language": "en-IE, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdmMmExNzMtYzhiMC00MWI3LWI2NGEtYTUwNzk4ZmZkMGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0NqSXFSQm9MOWt0bENLUUwzZXJUZnFORGJKQjRcL2tNbmlTakxiNTFjdG5Xb21OY2Nqd1RVR1lPUHBvcHYrY3EifQ==", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.600.7", "dlp-reaction": "no-action", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 0/9] add QAT support for digest encrypted", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]