Cover Comment List
List cover comments
GET /api/covers/53752/comments/?format=api
[ { "id": 97251, "web_url": "http://patches.dpdk.org/comment/97251/", "msgid": "<1560870281-30578-1-git-send-email-motih@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560870281-30578-1-git-send-email-motih@mellanox.com", "date": "2019-06-18T15:04:39", "subject": "[dpdk-dev] [PATCH v5 0/2] net/mlx5: remove TCF support from PMD", "submitter": { "id": 748, "url": "http://patches.dpdk.org/api/people/748/?format=api", "name": "Moti Haimovsky", "email": "motih@mellanox.com" }, "content": "Today, it is possible to offload an interface flow rules to the\nhardware using DPDK flow commands.\nWith mlx5 it is also possible to offload a limited set of flow rules\nto the mlxsw (or E-switch) using the same DPDK flow commands.\nA 'transfer' attribute was added to the flow rule creation command in\norder to distinguish between configuring port flows and E-switch\nflows. The commands destined for the E-switch are transposed to\nTC-flower rules and are send, as Netlink messages, to the mlx5 driver,\nor more precisely to the netdev which represent the mlxsw port.\nWith the addition to the PMD of E-switch configuration via DR\n(direct verbs rules) it is now possible to configure the E-switch\nusing these commands instead of using TC-Flower messages.\nDoing so will allow us to remove the TCF support and the dependency\nof libmnl from the PMD.\nThe purpose of this RFC is to propose configuring the E-switch\nflow filtering using DR, to remove the TCF support from the PMD and\nto remove the dependency of the PMD in libmnl.\nAs for today VLAN insertion or removal is not supported in DR, this\nsupport will be added in separate commits.\n\nMoti Haimovsky (2):\n net/mlx5: fix crashing testpmd on null drv opts\n net/mlx5: remove TCF support from PMD\n\n doc/build-sdk-meson.txt | 2 +-\n doc/guides/nics/mlx5.rst | 19 -\n doc/guides/platform/bluefield.rst | 4 -\n drivers/net/mlx5/Makefile | 303 --\n drivers/net/mlx5/meson.build | 123 +-\n drivers/net/mlx5/mlx5.c | 32 -\n drivers/net/mlx5/mlx5.h | 3 -\n drivers/net/mlx5/mlx5_flow.c | 43 +-\n drivers/net/mlx5/mlx5_flow.h | 25 -\n drivers/net/mlx5/mlx5_flow_tcf.c | 6382 -------------------------------------\n mk/rte.app.mk | 2 +-\n 11 files changed, 24 insertions(+), 6914 deletions(-)\n delete mode 100644 drivers/net/mlx5/mlx5_flow_tcf.c", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B633C1BDFA;\n\tTue, 18 Jun 2019 17:04:47 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id EEC141BCB6\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 17:04:45 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tmotih@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 18 Jun 2019 18:04:45 +0300", "from r-vnc11.mtr.labs.mlnx (r-vnc11.mtr.labs.mlnx [10.208.0.123])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x5IF4iVQ022569;\n\tTue, 18 Jun 2019 18:04:44 +0300" ], "From": "Moti Haimovsky <motih@mellanox.com>", "To": "shahafs@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Tue, 18 Jun 2019 18:04:39 +0300", "Message-Id": "<1560870281-30578-1-git-send-email-motih@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1559044929.git.motih@mellanox.com>", "References": "<cover.1559044929.git.motih@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v5 0/2] net/mlx5: remove TCF support from PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97252, "web_url": "http://patches.dpdk.org/comment/97252/", "msgid": "<1560870625-32092-1-git-send-email-motih@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560870625-32092-1-git-send-email-motih@mellanox.com", "date": "2019-06-18T15:10:23", "subject": "[dpdk-dev] [PATCH v5 0/2] net/mlx5: remove TCF support from PMD", "submitter": { "id": 748, "url": "http://patches.dpdk.org/api/people/748/?format=api", "name": "Moti Haimovsky", "email": "motih@mellanox.com" }, "content": "Today, it is possible to offload an interface flow rules to the\nhardware using DPDK flow commands.\nWith mlx5 it is also possible to offload a limited set of flow rules\nto the mlxsw (or E-switch) using the same DPDK flow commands.\nA 'transfer' attribute was added to the flow rule creation command in\norder to distinguish between configuring port flows and E-switch\nflows. The commands destined for the E-switch are transposed to\nTC-flower rules and are send, as Netlink messages, to the mlx5 driver,\nor more precisely to the netdev which represent the mlxsw port.\nWith the addition to the PMD of E-switch configuration via DR\n(direct verbs rules) it is now possible to configure the E-switch\nusing these commands instead of using TC-Flower messages.\nDoing so will allow us to remove the TCF support and the dependency\nof libmnl from the PMD.\nThe purpose of this RFC is to propose configuring the E-switch\nflow filtering using DR, to remove the TCF support from the PMD and\nto remove the dependency of the PMD in libmnl.\nAs for today VLAN insertion or removal is not supported in DR, this\nsupport will be added in separate commits.\n\nMoti Haimovsky (2):\n net/mlx5: fix crashing testpmd on null drv opts\n net/mlx5: remove TCF support from PMD\n\n doc/build-sdk-meson.txt | 2 +-\n doc/guides/nics/mlx5.rst | 19 -\n doc/guides/platform/bluefield.rst | 4 -\n drivers/net/mlx5/Makefile | 303 --\n drivers/net/mlx5/meson.build | 123 +-\n drivers/net/mlx5/mlx5.c | 32 -\n drivers/net/mlx5/mlx5.h | 3 -\n drivers/net/mlx5/mlx5_flow.c | 43 +-\n drivers/net/mlx5/mlx5_flow.h | 25 -\n drivers/net/mlx5/mlx5_flow_tcf.c | 6382 -------------------------------------\n mk/rte.app.mk | 2 +-\n 11 files changed, 24 insertions(+), 6914 deletions(-)\n delete mode 100644 drivers/net/mlx5/mlx5_flow_tcf.c", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CA3211C1AA;\n\tTue, 18 Jun 2019 17:10:30 +0200 (CEST)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n\tby dpdk.org (Postfix) with ESMTP id 4A0441BF8D\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 17:10:30 +0200 (CEST)" ], "From": "Moti Haimovsky <motih@mellanox.com>", "To": "shahafs@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Tue, 18 Jun 2019 18:10:23 +0300", "Message-Id": "<1560870625-32092-1-git-send-email-motih@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1559044929.git.motih@mellanox.com>", "References": "<cover.1559044929.git.motih@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v5 0/2] net/mlx5: remove TCF support from PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]