Comment List
List comments
GET /api/covers/53356/comments/
[ { "id": 96040, "web_url": "http://patches.dpdk.org/comment/96040/", "msgid": "<2469312.dFCSdvozyX@xps>", "date": "2019-05-09T19:24:05", "subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "09/05/2019 19:19, Dharmik Thakkar:\n> This patch series solves 2 bugs reported on Bugzilla (bug-261) within\n> the function rte_hash_free_key_with_postion(). It also adds a test case\n> to catch similar bugs in the future.\n> \n> https://bugs.dpdk.org/show_bug.cgi?id=261\n\nYipeng, Sameh, should it enter in 19.05-rc4?\nAre you sure it does not break things more?\nIf yes, please give your ack.", "headers": { "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "From": "Thomas Monjalon <thomas@monjalon.net>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=kfV2eV3tEZpXnXW+d9S71YJ5OWelCvNI8+Pd+J4T+1Q=; b=NxqD0ox3LYXE\n\tVFlb0OLXSXAA5CfJmMyl3+WnxMMb7iM4LRJlUOSnKIhZmOMGXRJF0Jju2y2vj/uQ\n\tOKCOVFDFAuL2KN8mFPZjWQ2/G2ttob7ehoSYrEKaUjPgB3LDTZSSijtw+O+yeqL3\n\t9T+ALfbXZpep5TNFidPsNc44Tik8p7E=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=kfV2eV3tEZpXnXW+d9S71YJ5OWelCvNI8+Pd+J4T+\n\t1Q=; b=QhMb8yRIzixDmm0F+HUiLyWcnA2awtURlbSxjvpxC1/QEjvKDEIYtY3im\n\tQGNuFZJCnHizUdk4RU7VEqDypwF4HJA7AZ+qzFzNjq/TkzGvuVU0+3fDPAVgHxvQ\n\tMUzi4Fs8am36HYk2g/dxm8fM2XlQODg8w0sqq1ykIWDTK+nYoMYQxvDpOBG8JJyF\n\tThI4l4L3Et2dLJzpSUYJtpZtvO7fyrZP/7sVy2s9UwaMqbA78vZY9uTBkaXyM3C2\n\tRfCBsmExtIh6vN7TxQbDLuCTcY6rNBkp4t3mAbHZuqrarHJqDKaowjno9Wg55UtD\n\tN0CpN7YxDTDbRjoSPZAJ4lGdhL9ZA==" ], "X-Mailman-Version": "2.1.15", "Delivered-To": "patchwork@dpdk.org", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdejiecutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n\tfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n\tucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh\n\thmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr\n\trghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc\n\tevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:V37UXM0ABYn77ZNdygSNRscO9Wphix0jA69eXnnFU45hYO9Qz9z8YQ>\n\t<xmx:V37UXMWO1Ge1B9gpHgy9AaYrGbZQvIm7WaJxLspesEVg7wfYvxyTVQ>\n\t<xmx:V37UXGln9Xmz5LaqOgytVrRua0hmkFElUkPZadqf0dtnyW6o7LHaOg>\n\t<xmx:WH7UXG4NgvBEhX1qPKAJ617DkLRJFID4ueQoEzMp4HloMjrD9dhVgQ>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Cc": "dev@dpdk.org, Dharmik Thakkar <dharmik.thakkar@arm.com>,\n\thonnappa.nagarahalli@arm.com, zhongdahulinfan@163.com", "To": "yipeng1.wang@intel.com, sameh.gobriel@intel.com", "Errors-To": "dev-bounces@dpdk.org", "References": "<20190509133924.7153-1-dharmik.thakkar@arm.com>\n\t<20190509171907.14693-1-dharmik.thakkar@arm.com>", "X-ME-Sender": "<xms:V37UXGB3o7hjTDmIf3IinkXz5nMYzRI__2hsZR_Hj6KN7t8zrT-4TA>", "Return-Path": "<dev-bounces@dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Post": "<mailto:dev@dpdk.org>", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 966995398;\n\tThu, 9 May 2019 21:24:09 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8C8F74F91\n\tfor <dev@dpdk.org>; Thu, 9 May 2019 21:24:08 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 2D44823E47;\n\tThu, 9 May 2019 15:24:08 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Thu, 09 May 2019 15:24:08 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 9689280062;\n\tThu, 9 May 2019 15:24:06 -0400 (EDT)" ], "Date": "Thu, 09 May 2019 21:24:05 +0200", "Content-Type": "text/plain; charset=\"us-ascii\"", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "In-Reply-To": "<20190509171907.14693-1-dharmik.thakkar@arm.com>", "MIME-Version": "1.0", "Message-ID": "<2469312.dFCSdvozyX@xps>", "Precedence": "list", "Content-Transfer-Encoding": "7Bit", "X-BeenThere": "dev@dpdk.org", "X-Original-To": "patchwork@dpdk.org" } }, { "id": 96044, "web_url": "http://patches.dpdk.org/comment/96044/", "msgid": "<D2C4A16CA39F7F4E8E384D204491D7A673E5E973@ORSMSX104.amr.corp.intel.com>", "date": "2019-05-09T19:36:43", "subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "submitter": { "id": 754, "url": "http://patches.dpdk.org/api/people/754/", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "content": ">-----Original Message-----\n>From: Thomas Monjalon [mailto:thomas@monjalon.net]\n>Sent: Thursday, May 9, 2019 12:24 PM\n>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>\n>Cc: dev@dpdk.org; Dharmik Thakkar <dharmik.thakkar@arm.com>; honnappa.nagarahalli@arm.com; zhongdahulinfan@163.com\n>Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'\n>\n>09/05/2019 19:19, Dharmik Thakkar:\n>> This patch series solves 2 bugs reported on Bugzilla (bug-261) within\n>> the function rte_hash_free_key_with_postion(). It also adds a test case\n>> to catch similar bugs in the future.\n>>\n>> https://bugs.dpdk.org/show_bug.cgi?id=261\n>\n>Yipeng, Sameh, should it enter in 19.05-rc4?\n>Are you sure it does not break things more?\n>If yes, please give your ack.\n[Wang, Yipeng] \nPlease go ahead Thomas, I reviewed the code and it will not break other things. The\nchanges are refrained inside an experimental API function.\n\nI haven't done the meson build test though.", "headers": { "dlp-version": "11.0.600.7", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "From": "\"Wang, Yipeng1\" <yipeng1.wang@intel.com>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "Date": "Thu, 9 May 2019 19:36:43 +0000", "X-Mailman-Version": "2.1.15", "x-ctpclassification": "CTP_NT", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "Delivered-To": "patchwork@dpdk.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "X-MS-Has-Attach": "", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Dharmik Thakkar <dharmik.thakkar@arm.com>,\n\t\"honnappa.nagarahalli@arm.com\" <honnappa.nagarahalli@arm.com>,\n\t\"zhongdahulinfan@163.com\" <zhongdahulinfan@163.com>", "X-Amp-Result": "SKIPPED(no attachment in message)", "To": "Thomas Monjalon <thomas@monjalon.net>, \"Gobriel, Sameh\"\n\t<sameh.gobriel@intel.com>", "dlp-reaction": "no-action", "Errors-To": "dev-bounces@dpdk.org", "References": "<20190509133924.7153-1-dharmik.thakkar@arm.com>\n\t<20190509171907.14693-1-dharmik.thakkar@arm.com>\n\t<2469312.dFCSdvozyX@xps>", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "Return-Path": "<dev-bounces@dpdk.org>", "Precedence": "list", "List-Post": "<mailto:dev@dpdk.org>", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C46E4493D;\n\tThu, 9 May 2019 21:36:47 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 7197744C3\n\tfor <dev@dpdk.org>; Thu, 9 May 2019 21:36:46 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 May 2019 12:36:45 -0700", "from orsmsx108.amr.corp.intel.com ([10.22.240.6])\n\tby fmsmga004.fm.intel.com with ESMTP; 09 May 2019 12:36:45 -0700", "from orsmsx163.amr.corp.intel.com (10.22.240.88) by\n\tORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.408.0; Thu, 9 May 2019 12:36:44 -0700", "from orsmsx104.amr.corp.intel.com ([169.254.4.183]) by\n\tORSMSX163.amr.corp.intel.com ([169.254.9.163]) with mapi id\n\t14.03.0415.000; Thu, 9 May 2019 12:36:44 -0700" ], "Thread-Index": "AQHVBot+qfJg49iF1UikbHSpZEYKZqZjocmA//+NSdA=", "dlp-product": "dlpe-windows", "Accept-Language": "en-US", "X-Amp-File-Uploaded": "False", "Subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "In-Reply-To": "<2469312.dFCSdvozyX@xps>", "MIME-Version": "1.0", "Message-ID": "<D2C4A16CA39F7F4E8E384D204491D7A673E5E973@ORSMSX104.amr.corp.intel.com>", "X-ExtLoop1": "1", "Content-Language": "en-US", "x-originating-ip": "[10.22.254.139]", "X-MS-TNEF-Correlator": "", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "dev@dpdk.org", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDlhZjI0ZDctMDkwMS00MDcxLWE2YTAtYzU0MTBhOTZlNzIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOElsUElrTEpUTDMwa25cL2FDQ29LcEY1WUdDR1ZLNktBMm1uQ2l3M2dQdkMzVEd3ZnA1WnIxcjVtZVFIdU54TFMifQ==", "X-Original-To": "patchwork@dpdk.org", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Thread-Topic": "[dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'" } }, { "id": 96054, "web_url": "http://patches.dpdk.org/comment/96054/", "msgid": "<1586488.L0gfE9as30@xps>", "date": "2019-05-09T20:36:00", "subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "09/05/2019 21:36, Wang, Yipeng1:\n> From: Thomas Monjalon [mailto:thomas@monjalon.net]\n> >09/05/2019 19:19, Dharmik Thakkar:\n> >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within\n> >> the function rte_hash_free_key_with_postion(). It also adds a test case\n> >> to catch similar bugs in the future.\n> >>\n> >> https://bugs.dpdk.org/show_bug.cgi?id=261\n> >\n> >Yipeng, Sameh, should it enter in 19.05-rc4?\n> >Are you sure it does not break things more?\n> >If yes, please give your ack.\n> [Wang, Yipeng] \n> Please go ahead Thomas, I reviewed the code and it will not break other things. The\n> changes are refrained inside an experimental API function.\n> \n> I haven't done the meson build test though.\n\nApplied, thanks", "headers": { "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "From": "Thomas Monjalon <thomas@monjalon.net>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=iO+XDLvtSKxIdxyW0xkT3Go9iaLV3W7SNBpnvpvUu9M=; b=L+Di4bozMCUt\n\tkzxPjdImIKdSfIFKm00kuAb0lWVcJcLvQ9XTtlZXodtc6yrPWMLovD7JKwVxACvr\n\tDip5tJ+qyJqf3BwerIpvcKTbAVbXdWdUlUSavVLES/M/ZheJNdiDA2yMO0mDv4uC\n\tcjASWVwaGjwExwTLy/8u2FYS804cg2E=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=iO+XDLvtSKxIdxyW0xkT3Go9iaLV3W7SNBpnvpvUu\n\t9M=; b=7cal+2xvoB6uwmUqT1I5JVtUlpmgj8PqiNf5lqV6wbOxtupFSDeTtGyxF\n\t0+OxVoShKPISgIrfaHo7mc5riShmdWNcKhBl4PRVrmIpqzvu42LJ9yheP4oI/Yli\n\tn/qxF6hgBoG4QJ9xrk7Wq1VYFseyqZ5KakHnOXT9NH781cBAsMWq5daFLEyxJJco\n\tsQZkrq2xM+zUONqxNciPTGr5s7fTvkuPCzGbm0iY0tzikB80+8OgB9HtfeW4FTRC\n\tcDYpvFaPgjiPBrMD2Iz1WFydnxwA5on5AFmv18wA0sfFXAtBG+G0P8Cj2/sJZip/\n\tTnZqc510f5dzq2fAVq9aKz0B+VkUQ==" ], "X-Mailman-Version": "2.1.15", "Delivered-To": "patchwork@dpdk.org", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdeltdcutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n\tfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n\tucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh\n\thmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr\n\trghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc\n\tevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:Mo_UXMvVoZN_G4VKARAZgzvyr35YFpU6HpNGRYA7EAWYsEY3fu11uw>\n\t<xmx:Mo_UXFYoZaxQDVHj8noSqAkhQvTG6FEbWZh0Qc5RZmkRuDVMCDl-dA>\n\t<xmx:Mo_UXN4Mec8hbyH7Ns2t6x6P3eFs6Ztq0uhhWkqt-y1lMXIjhB6K6g>\n\t<xmx:M4_UXM0-6TW2Isi4CABvc3QpUE4loKvfOMLEi5_sBe8xRM38oxYgUA>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Cc": "dev@dpdk.org, \"Wang, Yipeng1\" <yipeng1.wang@intel.com>, \"Gobriel,\n\tSameh\" <sameh.gobriel@intel.com>,\n\t\"honnappa.nagarahalli@arm.com\" <honnappa.nagarahalli@arm.com>,\n\t\"zhongdahulinfan@163.com\" <zhongdahulinfan@163.com>", "To": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "Errors-To": "dev-bounces@dpdk.org", "References": "<20190509133924.7153-1-dharmik.thakkar@arm.com>\n\t<2469312.dFCSdvozyX@xps>\n\t<D2C4A16CA39F7F4E8E384D204491D7A673E5E973@ORSMSX104.amr.corp.intel.com>", "X-ME-Sender": "<xms:Mo_UXEV4q-HJaQjYeq4Hhu4rp2EhiY0gcQzBewH9ghT12TW-KTnP8A>", "Return-Path": "<dev-bounces@dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Post": "<mailto:dev@dpdk.org>", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0630F493D;\n\tThu, 9 May 2019 22:36:05 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D2CD62C18\n\tfor <dev@dpdk.org>; Thu, 9 May 2019 22:36:03 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 78FE42073F;\n\tThu, 9 May 2019 16:36:03 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Thu, 09 May 2019 16:36:03 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id EA5FA80065;\n\tThu, 9 May 2019 16:36:01 -0400 (EDT)" ], "Date": "Thu, 09 May 2019 22:36:00 +0200", "Content-Type": "text/plain; charset=\"us-ascii\"", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with\n\tposition'", "In-Reply-To": "<D2C4A16CA39F7F4E8E384D204491D7A673E5E973@ORSMSX104.amr.corp.intel.com>", "MIME-Version": "1.0", "Message-ID": "<1586488.L0gfE9as30@xps>", "Precedence": "list", "Content-Transfer-Encoding": "7Bit", "X-BeenThere": "dev@dpdk.org", "X-Original-To": "patchwork@dpdk.org" } } ]