Cover Comment List
List cover comments
GET /api/covers/53284/comments/?format=api
[ { "id": 95937, "web_url": "http://patches.dpdk.org/comment/95937/", "msgid": "<AM0PR0502MB379568F0AB8BB09A65F1F904C3320@AM0PR0502MB3795.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR0502MB379568F0AB8BB09A65F1F904C3320@AM0PR0502MB3795.eurprd05.prod.outlook.com", "date": "2019-05-08T04:43:45", "subject": "Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx\n\tfiles", "submitter": { "id": 634, "url": "http://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "content": "Dekel,\n\nSunday, May 5, 2019 4:09 PM, Dekel Peled:\n> Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files\n> \n> During work on Rx feature I did some cleanup actions.\n> This series includes those changes divided by their type.\n> \n> ---\n> v2: Change 2nd patch type to \"fix\".\n> v3: Apply minor code-review comment on 2nd patch.\n> Add Acked-by in all patches.\n> ---\n\nI was trying to apply your patch but hit clang compilation issue, please address:\n\nerror: static function\n 'mlx5_check_mprq_support' is used in an inline function with external linkage [-Werror,-Wstatic-in-inline]\n if (mlx5_check_mprq_support(dev) < 0)\n ^\n/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxtx.h:248:1: note: use 'static' to give inline\n function 'mlx5_mprq_enabled' internal linkage\nint mlx5_mprq_enabled(struct rte_eth_dev *dev);\n^\nstatic \n/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxq.c:69:1: note: 'mlx5_check_mprq_support'\n declared here\nmlx5_check_mprq_support(struct rte_eth_dev *dev)\n\n> \n> Dekel Peled (4):\n> net/mlx5: remove unused functions\n> net/mlx5: fix missing validation of null pointer\n> net/mlx5: fix description of function return value\n> net/mlx5: move locally used functions to static\n> \n> drivers/net/mlx5/mlx5_rxq.c | 220 +++++++++++++++++++-------------------\n> -----\n> drivers/net/mlx5/mlx5_rxtx.h | 20 ---- drivers/net/mlx5/mlx5_txq.c | 13 --\n> -\n> 3 files changed, 95 insertions(+), 158 deletions(-)\n> \n> --\n> 1.8.3.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E44A52B87;\n\tWed, 8 May 2019 06:43:47 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42])\n\tby dpdk.org (Postfix) with ESMTP id E3C49293B\n\tfor <dev@dpdk.org>; Wed, 8 May 2019 06:43:46 +0200 (CEST)", "from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by\n\tAM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1856.12; Wed, 8 May 2019 04:43:46 +0000", "from AM0PR0502MB3795.eurprd05.prod.outlook.com\n\t([fe80::8c0:a6ef:6abc:334d]) by\n\tAM0PR0502MB3795.eurprd05.prod.outlook.com\n\t([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012;\n\tWed, 8 May 2019 04:43:46 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=6SGMvdwWxAwTpMvg1cxkbhRvuqejlgqTmjl38BJplIU=;\n\tb=Ld7s/wr6xhlBcyMSpW+AzxqDtHa/Zddu/jPx72/6I4KBRoyN/NoNR2t+8Nwgu+bHWzyjPnI4FvI+dYnHpu95iPBFcvJmffXnaaOZ4MhPlCIHKROOYRfaJHIIfVu0fG7AK5Cthx8Z6yf0WEsxYnFatz1QcplfJgbKDk8+TwaN2Bw=", "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "Dekel Peled <dekelp@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files", "Thread-Index": "AQHVA0QsunEKrz7aX0yBoNAj04R5/qZgpRaw", "Date": "Wed, 8 May 2019 04:43:45 +0000", "Message-ID": "<AM0PR0502MB379568F0AB8BB09A65F1F904C3320@AM0PR0502MB3795.eurprd05.prod.outlook.com>", "References": "<cover.1556809050.git.dekelp@mellanox.com>\n\t<cover.1557061532.git.dekelp@mellanox.com>", "In-Reply-To": "<cover.1557061532.git.dekelp@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ", "x-originating-ip": "[31.154.10.105]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "bff10650-0d4d-4873-19c1-08d6d36fc17a", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:AM0PR0502MB4001; ", "x-ms-traffictypediagnostic": "AM0PR0502MB4001:", "x-microsoft-antispam-prvs": "<AM0PR0502MB40015B05C666AB114150EE0EC3320@AM0PR0502MB4001.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:5516;", "x-forefront-prvs": "0031A0FFAF", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001;\n\tH:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "KvMzpxFSGRd6ndPlHkbGakeH1IJA5tZinjv8ZR0nKlABFl42J1faZDHQyVA7IIzvBbd54jA+TaiYbsktMbZ535EZ1capmDt9BiG7iRGDW8eEKGQ9r+b23M7nJmMZqr5XlhavdYBVovKikewQhAvthubkdLec4CaAK3kozYyz+bwRqzNJddjibjwXCb+tXz8wVVO6NK8HxuOuLQWtkyeW7tqJ6sV3iXq6AMYWi6mt20DQJyaFd5GSalEdhbbcErwYa7zV5WDs+1s5gbhEDpP4ApKwOroSMyO6PC+/kdoJCepYLcM6Ykp5vsCUAWgoNDjxbKdO1GWM7rwflXBAN5RJrzlWQUO1RBaLYJ3Uh/3Za1otLF6Ib1rPmrZWeeacBd8gCKBz23g1HUUp8zMz7vjZbX/YrLMMZoqVSK202aowBf4=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "bff10650-0d4d-4873-19c1-08d6d36fc17a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 May 2019 04:43:45.9279\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR0502MB4001", "Subject": "Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx\n\tfiles", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]