Cover Comment List
List cover comments
GET /api/covers/53269/comments/?format=api
[ { "id": 96190, "web_url": "http://patches.dpdk.org/comment/96190/", "msgid": "<94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com", "date": "2019-05-15T06:36:10", "subject": "Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "content": "> -----Original Message-----\n> From: Zhang, Qi Z\n> Sent: Saturday, May 4, 2019 5:30 PM\n> To: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo\n> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev,\n> Konstantin <konstantin.ananyev@intel.com>\n> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>\n> Subject: [PATCH 0/3] fix invalid Tx threshhold setup\n> \n> When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an\n> outdated DD status be checked as tx_next_dd, then segment fault happen\n> due to free a NULL mbuf pointer.\n> \n> The issue usually happens with an aggresive tx_free_thresh, for example:\n> \n> ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 --\n> txfreet=1020\n> \n> The patchset fix this issue on i40e, ixgbe and ice.\n> \n> Qi Zhang (3):\n> net/i40e: fix invalid Tx threshold setup\n> net/ice: fix invalid Tx threshold setup\n> net/ixgbe: fix invalid Tx threshold setup\n> \n> drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++--\n> drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++---\n> drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++--\n> 3 files changed, 52 insertions(+), 7 deletions(-)\n> \n> --\n> 2.13.6\n\nAcked-by: Beilei Xing <beilei.xing@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 491342F7D;\n\tWed, 15 May 2019 08:36:16 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 0C85E2C17\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 08:36:13 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 May 2019 23:36:13 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 May 2019 23:36:13 -0700", "from fmsmsx155.amr.corp.intel.com (10.18.116.71) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700", "from shsmsx108.ccr.corp.intel.com (10.239.4.97) by\n\tFMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by\n\tSHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id\n\t14.03.0415.000; Wed, 15 May 2019 14:36:11 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,471,1549958400\"; d=\"scan'208\";a=\"171861220\"", "From": "\"Xing, Beilei\" <beilei.xing@intel.com>", "To": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>, \"Lu, Wenzhuo\"\n\t<wenzhuo.lu@intel.com>, \"Yang, Qiming\" <qiming.yang@intel.com>,\n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH 0/3] fix invalid Tx threshhold setup", "Thread-Index": "AQHVAluc6hLAcViOn02qqmB+fnhmiaZry67w", "Date": "Wed, 15 May 2019 06:36:10 +0000", "Message-ID": "<94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com>", "References": "<20190504092939.25326-1-qi.z.zhang@intel.com>", "In-Reply-To": "<20190504092939.25326-1-qi.z.zhang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 96192, "web_url": "http://patches.dpdk.org/comment/96192/", "msgid": "<039ED4275CED7440929022BC67E7061153381A79@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E7061153381A79@SHSMSX103.ccr.corp.intel.com", "date": "2019-05-15T07:09:49", "subject": "Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Xing, Beilei\n> Sent: Wednesday, May 15, 2019 2:36 PM\n> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo\n> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev,\n> Konstantin <konstantin.ananyev@intel.com>\n> Cc: dev@dpdk.org\n> Subject: RE: [PATCH 0/3] fix invalid Tx threshhold setup\n> \n> \n> \n> > -----Original Message-----\n> > From: Zhang, Qi Z\n> > Sent: Saturday, May 4, 2019 5:30 PM\n> > To: Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo\n> > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Ananyev,\n> > Konstantin <konstantin.ananyev@intel.com>\n> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>\n> > Subject: [PATCH 0/3] fix invalid Tx threshhold setup\n> >\n> > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an\n> > outdated DD status be checked as tx_next_dd, then segment fault happen\n> > due to free a NULL mbuf pointer.\n> >\n> > The issue usually happens with an aggresive tx_free_thresh, for example:\n> >\n> > ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 --\n> > txfreet=1020\n> >\n> > The patchset fix this issue on i40e, ixgbe and ice.\n> >\n> > Qi Zhang (3):\n> > net/i40e: fix invalid Tx threshold setup\n> > net/ice: fix invalid Tx threshold setup\n> > net/ixgbe: fix invalid Tx threshold setup\n> >\n> > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++--\n> > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++---\n> > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++--\n> > 3 files changed, 52 insertions(+), 7 deletions(-)\n> >\n> > --\n> > 2.13.6\n> \n> Acked-by: Beilei Xing <beilei.xing@intel.com>\n\nApplied to dpdk-next-net-intel.\n\nThanks\nQi", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90D2634F0;\n\tWed, 15 May 2019 09:09:55 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 146692C17\n\tfor <dev@dpdk.org>; Wed, 15 May 2019 09:09:53 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 May 2019 00:09:53 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby orsmga004.jf.intel.com with ESMTP; 15 May 2019 00:09:52 -0700", "from fmsmsx111.amr.corp.intel.com (10.18.116.5) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700", "from shsmsx107.ccr.corp.intel.com (10.239.4.96) by\n\tfmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server\n\t(TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by\n\tSHSMSX107.ccr.corp.intel.com ([169.254.9.7]) with mapi id\n\t14.03.0415.000; Wed, 15 May 2019 15:09:50 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Lu, Wenzhuo\"\n\t<wenzhuo.lu@intel.com>, \"Yang, Qiming\" <qiming.yang@intel.com>,\n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH 0/3] fix invalid Tx threshhold setup", "Thread-Index": "AQHVAlucZ3v8ekdrYUuiGOvWZZV/RaZrRiMAgACPa3A=", "Date": "Wed, 15 May 2019 07:09:49 +0000", "Message-ID": "<039ED4275CED7440929022BC67E7061153381A79@SHSMSX103.ccr.corp.intel.com>", "References": "<20190504092939.25326-1-qi.z.zhang@intel.com>\n\t<94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com>", "In-Reply-To": "<94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBkNjkzYWYtOTA4Ni00OGMwLThkZWEtY2VlYjZkYmY0YjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTlhMjI4eTJrYURqcW1uQ2RlcVlsQ2R4d0pFcEFDdEdidHg2ZGRscThyVTloZzdnVU1RRXBmTWFFU0MxOVZFOSJ9", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.600.7", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]