Cover Comment List
List cover comments
GET /api/covers/53213/comments/?format=api
[ { "id": 95942, "web_url": "http://patches.dpdk.org/comment/95942/", "msgid": "<2715295a-43fa-cc8b-8271-ded8b237501a@kth.se>", "list_archive_url": "https://inbox.dpdk.org/dev/2715295a-43fa-cc8b-8271-ded8b237501a@kth.se", "date": "2019-05-08T07:49:59", "subject": "Re: [dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API", "submitter": { "id": 1155, "url": "http://patches.dpdk.org/api/people/1155/?format=api", "name": "Tom Barbette", "email": "barbette@kth.se" }, "content": "Maybe a (last) motivation point.\n\nWe just did a 100G link traffic capture with time-stamping of all \npackets in HW using a Mellanox CX5. SW time-stamping fails to reveal \nqueueing delays, and as multi-queue is needed for writing 100G traffic \nto multiple NVMe drives, does not allow to recover the original ordering \nmixed by multi-queuing.\n\nHere, we timestamped traffic in hardware (FYI, given in ticks of the \ninternal CX5 clock, not in unit of time), and thanks to the new API, \nconverted it to real time value (through frequency + base).\n\nBut precision is not the only improvement. As DPDK is userlevel, calling \nget_timeofday for millions of packets pretty much kills the capture.\nHere we do a simple math per packet to convert the packet's timestamp in \nticks to the real clock time, (very) much cheaper than even a vDSO syscall.\n\nTom\n\n\nOn 2019-05-02 14:11, Tom Barbette wrote:\n> Some NICs allow to timestamp packets, but do not support the full\n> PTP synchronization process. Hence, the value set in the mbuf\n> timestamp field is only the raw value of an internal clock.\n> \n> To make sense of this value, one at least needs to be able to query\n> the current hardware clock value. This patch series adds a new API to do\n> so, rte_eth_read_clock. As with the TSC, from there\n> a frequency can be derieved by querying multiple time the current value of the\n> internal clock with some known delay between the queries (example\n> provided in the API doc).\n> \n> This patch series adds support of read_clock for MLX5.\n> \n> An example app is provided in the rxtx_callback application.\n> It has been updated to display, on top of the software latency\n> in cycles, the total latency since the packet was received in hardware.\n> The API is used to compute a delta in the Tx callback. The raw amount of\n> ticks is converted to cycles using a variation of the technique describe above.\n> \n> Aside from offloading timestamping, which relieve the\n> software from a few operations, this allows to get much more precision\n> when studying the source of the latency in a system.\n> Eg. in our 100G, CX5 setup the rxtx callback application shows\n> SW latency is around 74 cycles (TSC is 3.2Ghz), but the latency\n> including NIC processing, PCIe, and queuing is around 196 cycles.\n> \n> One may think at first this API is overlapping with te_eth_timesync_read_time.\n> rte_eth_timesync_read_time is clearly identified as part of a set of functions\n> to use PTP synchronization.\n> The device raw clock is not \"sync\" in any way. More importantly, the returned\n> value is not a timeval, but an amount of ticks. We could have a cast-based\n> solution, but on top of being an ugly solution, some people seeing the timeval\n> type of rte_eth_timesync_read_time could use it blindly.\n> \n> Change in v2:\n> - Rebase on current master\n> \n> Change in v3:\n> - Address comments from Ferruh Yigit\n> \n> Changes in v4:\n> - Address comments from Keith Wiles and Andrew Rybchenko\n> - Use \"clock\" as argunment name everywhere.\n> - Expand the API description to make clear that read_clock gives an\n> amount in ticks, and that it has no unit.\n> \n> Tom Barbette (3):\n> rte_ethdev: Add API function to read dev clock\n> mlx5: Implement support for read_clock\n> rxtx_callbacks: Add support for HW timestamp\n> \n> doc/guides/nics/features.rst | 1 +\n> doc/guides/sample_app_ug/rxtx_callbacks.rst | 9 ++-\n> drivers/net/mlx5/mlx5.c | 1 +\n> drivers/net/mlx5/mlx5.h | 1 +\n> drivers/net/mlx5/mlx5_ethdev.c | 30 +++++++\n> drivers/net/mlx5/mlx5_glue.c | 8 ++\n> drivers/net/mlx5/mlx5_glue.h | 2 +\n> examples/rxtx_callbacks/Makefile | 3 +\n> examples/rxtx_callbacks/main.c | 87 ++++++++++++++++++++-\n> examples/rxtx_callbacks/meson.build | 3 +\n> lib/librte_ethdev/rte_ethdev.c | 12 +++\n> lib/librte_ethdev/rte_ethdev.h | 47 +++++++++++\n> lib/librte_ethdev/rte_ethdev_core.h | 6 ++\n> lib/librte_ethdev/rte_ethdev_version.map | 1 +\n> lib/librte_mbuf/rte_mbuf.h | 2 +\n> 15 files changed, 208 insertions(+), 5 deletions(-)\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EDBCB34F0;\n\tWed, 8 May 2019 09:50:05 +0200 (CEST)", "from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192])\n\tby dpdk.org (Postfix) with ESMTP id EA67A2BD5\n\tfor <dev@dpdk.org>; Wed, 8 May 2019 09:50:03 +0200 (CEST)", "from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1])\n\tby smtp-3.sys.kth.se (Postfix) with ESMTP id 91A8B9730;\n\tWed, 8 May 2019 09:50:03 +0200 (CEST)", "from smtp-3.sys.kth.se ([127.0.0.1])\n\tby smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith LMTP id olguUk75k4dl; Wed, 8 May 2019 09:50:01 +0200 (CEST)", "from [130.237.20.142] (s2587.it.kth.se [130.237.20.142])\n\tby smtp-3.sys.kth.se (Postfix) with ESMTPSA id B68B09737;\n\tWed, 8 May 2019 09:49:59 +0200 (CEST)" ], "X-Virus-Scanned": "by amavisd-new at kth.se", "X-KTH-Auth": "barbette [130.237.20.142]", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default;\n\tt=1557301801; bh=7hMkxoKCLRISBO4UODUZj7AIPfFPX+bS63mcBaff2JE=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=Lsckg3FO38JkzmISi6wzhkVIhcwviYC5ImrU+t0C8+/a1jcG9mBsgM7vkuCDm8WAA\n\tJ9As2SvucrGV0imBoZA8wBI7EldrmKVzgygH1MFVXZZ/f4ImkDWI49uWo9ZBexfnCb\n\tTlKOLCCrR0Wq+LwWiPoNu+XXBvcvi2tIZo2A69/A=", "X-KTH-mail-from": "barbette@kth.se", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, john.mcnamara@intel.com,\n\tThomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n\t<ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>,\n\tShahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>, \n\tolivier.matz@6wind.com", "References": "<20190502121135.18775-1-barbette@kth.se>", "From": "Tom Barbette <barbette@kth.se>", "Message-ID": "<2715295a-43fa-cc8b-8271-ded8b237501a@kth.se>", "Date": "Wed, 8 May 2019 09:49:59 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1", "MIME-Version": "1.0", "In-Reply-To": "<20190502121135.18775-1-barbette@kth.se>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 96579, "web_url": "http://patches.dpdk.org/comment/96579/", "msgid": "<06a590d0-e0bf-53d2-7b40-94f55ea1f141@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/06a590d0-e0bf-53d2-7b40-94f55ea1f141@intel.com", "date": "2019-05-31T07:46:27", "subject": "Re: [dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 5/2/2019 1:11 PM, Tom Barbette wrote:\n> Some NICs allow to timestamp packets, but do not support the full\n> PTP synchronization process. Hence, the value set in the mbuf\n> timestamp field is only the raw value of an internal clock.\n> \n> To make sense of this value, one at least needs to be able to query\n> the current hardware clock value. This patch series adds a new API to do\n> so, rte_eth_read_clock. As with the TSC, from there\n> a frequency can be derieved by querying multiple time the current value of the\n> internal clock with some known delay between the queries (example\n> provided in the API doc).\n> \n> This patch series adds support of read_clock for MLX5.\n> \n> An example app is provided in the rxtx_callback application.\n> It has been updated to display, on top of the software latency\n> in cycles, the total latency since the packet was received in hardware.\n> The API is used to compute a delta in the Tx callback. The raw amount of\n> ticks is converted to cycles using a variation of the technique describe above.\n> \n> Aside from offloading timestamping, which relieve the\n> software from a few operations, this allows to get much more precision\n> when studying the source of the latency in a system.\n> Eg. in our 100G, CX5 setup the rxtx callback application shows\n> SW latency is around 74 cycles (TSC is 3.2Ghz), but the latency\n> including NIC processing, PCIe, and queuing is around 196 cycles.\n> \n> One may think at first this API is overlapping with te_eth_timesync_read_time.\n> rte_eth_timesync_read_time is clearly identified as part of a set of functions\n> to use PTP synchronization.\n> The device raw clock is not \"sync\" in any way. More importantly, the returned\n> value is not a timeval, but an amount of ticks. We could have a cast-based\n> solution, but on top of being an ugly solution, some people seeing the timeval\n> type of rte_eth_timesync_read_time could use it blindly.\n> \n> Change in v2:\n> - Rebase on current master\n> \n> Change in v3:\n> - Address comments from Ferruh Yigit\n> \n> Changes in v4:\n> - Address comments from Keith Wiles and Andrew Rybchenko\n> - Use \"clock\" as argunment name everywhere.\n> - Expand the API description to make clear that read_clock gives an\n> amount in ticks, and that it has no unit.\n> \n> Tom Barbette (3):\n> rte_ethdev: Add API function to read dev clock\n> mlx5: Implement support for read_clock\n> rxtx_callbacks: Add support for HW timestamp\n\nSeries applied to dpdk-next-net/master, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB2751B947;\n\tFri, 31 May 2019 09:46:32 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id CA8BC1B945\n\tfor <dev@dpdk.org>; Fri, 31 May 2019 09:46:31 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 May 2019 00:46:30 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.36])\n\t([10.237.221.36])\n\tby orsmga002.jf.intel.com with ESMTP; 31 May 2019 00:46:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Tom Barbette <barbette@kth.se>, dev@dpdk.org", "Cc": "bruce.richardson@intel.com, john.mcnamara@intel.com,\n\tThomas Monjalon <thomas@monjalon.net>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>,\n\tShahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>, \n\tolivier.matz@6wind.com", "References": "<20190502121135.18775-1-barbette@kth.se>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE\n\t0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T\n\tYR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q\n\tCgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M\n\t1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I\n\tz+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr\n\tGE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte\n\tHQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG\n\tgMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7\n\tX07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K\n\t/s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1\n\tpBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv\n\tmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T\n\tqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA\n\tONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/\n\tvU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p\n\tiVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ\n\tI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH\n\tfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ\n\tqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi\n\t6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl\n\tRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh\n\tHwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q\n\tMJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp\n\tg0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8\n\tYO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7\n\tsgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY\n\txWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84\n\tQz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa\n\tARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a\n\tN3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv\n\t0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv\n\tVQ==", "Message-ID": "<06a590d0-e0bf-53d2-7b40-94f55ea1f141@intel.com>", "Date": "Fri, 31 May 2019 08:46:27 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0", "MIME-Version": "1.0", "In-Reply-To": "<20190502121135.18775-1-barbette@kth.se>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]