List cover comments

GET /api/covers/53192/comments/?format=api
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Link: 
<http://patches.dpdk.org/api/covers/53192/comments/?format=api&page=1>; rel="first",
<http://patches.dpdk.org/api/covers/53192/comments/?format=api&page=1>; rel="last"
Vary: Accept
[ { "id": 95753, "web_url": "http://patches.dpdk.org/comment/95753/", "msgid": "<8175150.iIoqqa2Iee@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/8175150.iIoqqa2Iee@xps", "date": "2019-05-02T12:18:51", "subject": "Re: [dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "01/05/2019 21:50, Bruce Richardson:\n> This set of changes fixes warnings seen when compiling DPDK on Fedora 30.\n> In most cases these warnings appear to be false positives, which means we\n> have the option to just disable the warning. Because the changes required\n> to the code to silence the warnings are fairly small I've chosen in all cases\n> to change the code rather than disable the warnings, but I'm open to doing\n> the opposite if it's felt it's a better solution. [One thing I didn't like\n> about disabling the warnings is that the disabling flags are not supported\n> by clang, so adding them involves compiler checks :-(]\n> \n> NOTE: this set does not cover all warnings with GCC9, but it does cover\n> those seen when building with meson. There is still one warning disable\n> flag needed when building with make, which will need a follow-on set to\n> fix.\n> \n> Bruce Richardson (4):\n> net/ixgbe: fix warning with GCC 9 on Fedora 30\n> bus/fslmc: fix printf of null pointer\n> raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n\nCc: stable@dpdk.org\n\nApplied, thanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 639D058FA;\n\tThu, 2 May 2019 14:18:58 +0200 (CEST)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0606E4F90;\n\tThu, 2 May 2019 14:18:56 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 9D3A224853;\n\tThu, 2 May 2019 08:18:56 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Thu, 02 May 2019 08:18:56 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 3BFB1103CC;\n\tThu, 2 May 2019 08:18:55 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=p57KIM25GI4qlcNTlJYaRDORpKl6guicnG6LiX4Pr8I=; b=SkdCc8HnOfBY\n\tLzdWXmhfvkYmbubQKTBxOLS5PBWRNGO/RvKKckiHlif6s0YRBC+D8IFnlwZZQ11B\n\tNzHL+oEqyHMs0ZyjMryK47sMoksq46amyQpu8+Ox6P1rt2ypNOd9ae9xoOdjssrV\n\tx1gUy8eQpENlsRRWWmf75vjrZTgJLY0=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=p57KIM25GI4qlcNTlJYaRDORpKl6guicnG6LiX4Pr\n\t8I=; b=ediYTaTvlAW5LR4A02Xh3WAtkmRsmH6U19lUCkArganAfyCxKZYc7Ovur\n\tDMpq+A7yDGDBHXuMGEK4+uReX9N+NtYfR66OYplsmIHUp3KBCBWw9k5F+HCbiQQS\n\tQ25bmTEB/4a9pqCEQvWwEP6NIpKXHgJlxfjth1/0ECFktrNUb6ZUjgxh1nNVErsZ\n\tAZ47T0wdVCBSCQQxU+IjBgS4/qMeW4xF+NzTj8OFOcjI+WwRye+Kfd1riWDFQFx7\n\tSjH5f57JqNVPyy7hpccvTfN5iVH1b9uxC9hThGtpGVSCxF6a1QyxlftidMTSX57j\n\tWiP7fMhazsxEc2PB6aH+b+QIw/AfA==" ], "X-ME-Sender": "<xms:L-DKXEPY1s0VCm883GiqDZcvOU9955MK4-skrce3yX7rI_Cqs5E5Fg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdehudcutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n\tfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n\tucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n\tepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho\n\tmhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd", "X-ME-Proxy": "<xmx:L-DKXPM7r8PRnyD4yW-bQ0Q-EO2HUxtAsrUG9mym6VN1i5sIHuW18g>\n\t<xmx:L-DKXGTFJ4Hun9cImoClD2Mq8l0lz7V7CVH3ODI7m4X-v_JHPqpM1w>\n\t<xmx:L-DKXBDtdXgt7rW2XALC1bsIxsh9u6OkJQhUv8kbMZa7BBq88wjMjw>\n\t<xmx:MODKXADoVSBQfBIO9BXtPXRTK9tESKiXu3AGuYL27iSGrqa1zGl1lw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, stable@dpdk.org", "Date": "Thu, 02 May 2019 14:18:51 +0200", "Message-ID": "<8175150.iIoqqa2Iee@xps>", "In-Reply-To": "<20190501195014.2938-1-bruce.richardson@intel.com>", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95759, "web_url": "http://patches.dpdk.org/comment/95759/", "msgid": "<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com", "date": "2019-05-02T12:32:41", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <thomas@monjalon.net> wrote:\n\n> 01/05/2019 21:50, Bruce Richardson:\n> > This set of changes fixes warnings seen when compiling DPDK on Fedora 30.\n> > In most cases these warnings appear to be false positives, which means we\n> > have the option to just disable the warning. Because the changes required\n> > to the code to silence the warnings are fairly small I've chosen in all\n> cases\n> > to change the code rather than disable the warnings, but I'm open to\n> doing\n> > the opposite if it's felt it's a better solution. [One thing I didn't\n> like\n> > about disabling the warnings is that the disabling flags are not\n> supported\n> > by clang, so adding them involves compiler checks :-(]\n> >\n> > NOTE: this set does not cover all warnings with GCC9, but it does cover\n> > those seen when building with meson. There is still one warning disable\n> > flag needed when building with make, which will need a follow-on set to\n> > fix.\n> >\n> > Bruce Richardson (4):\n> > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > bus/fslmc: fix printf of null pointer\n> > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n>\n> Cc: stable@dpdk.org\n>\n> Applied, thanks\n>\n>\nI had a comment on patch 2, and the bigger problem is\n-Waddress-of-packed-member.\nThe quicker solution for now is to downgrade it to warning only so that we\ncan fix the parts later rather than globally disable it.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2377D5B26;\n\tThu, 2 May 2019 14:32:54 +0200 (CEST)", "from mail-vs1-f68.google.com (mail-vs1-f68.google.com\n\t[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 16CD42B89\n\tfor <dev@dpdk.org>; Thu, 2 May 2019 14:32:53 +0200 (CEST)", "by mail-vs1-f68.google.com with SMTP id j184so1223219vsd.11\n\tfor <dev@dpdk.org>; Thu, 02 May 2019 05:32:53 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=t/OGxO/CU38BLdSYp6D05tDNMWLEJ8Cq38n+NCKUB7E=;\n\tb=rvA+AOuK68WL+UyNM+0wInuJma+/LDGJr6901AvDGhLKXBq0dwfts3TdIoumg7k6WT\n\t5Ew33oKnjvWMsrj54ZwkYc2bX8qrbsrVRQ360QII8iV5YZIFalvDWRAz80cVRLtKcXZd\n\t1ma3SjD6vh2SYPiPk57w660J7PDAWvGXDIV0pGBaKmmSXoJBYn/Jv6Ml22TnMqH43pvz\n\t4/xtZjGm3qjx4Q6+0V9mTyVkfBzKJT6DN7/Gee8gEYu5hchBAE0C/lTpuxfauCOA7I8i\n\to+MYbi9WMdUgLlpOKSsAo5Exo3OlfcHX44L01qmjdaVXFkg3ww4mv0fOO1ygm0gLm0Dq\n\tMJ9w==", "X-Gm-Message-State": "APjAAAVrT9TPOd+F/n2/sPSY6FsCnIWHmjfMJWb6DZO3ovdf45Ol8lFR\n\tW8/h0h4s2VwiRQAHt4rrIm9hwJoosJmVN5AfSK2QBQ==", "X-Google-Smtp-Source": "APXvYqwvpvh4Q2HAvWkcIRQq0qA/vmXUCz/u3v4ld7r+BqwraSa4vQXb8t2k9WFkqfQZAGPACV3mYLxPp3Yh9IYhd4g=", "X-Received": "by 2002:a67:fa95:: with SMTP id\n\tf21mr1748747vsq.180.1556800372498; \n\tThu, 02 May 2019 05:32:52 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>", "In-Reply-To": "<8175150.iIoqqa2Iee@xps>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Thu, 2 May 2019 14:32:41 +0200", "Message-ID": "<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>, \n\tdpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95768, "web_url": "http://patches.dpdk.org/comment/95768/", "msgid": "<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com", "date": "2019-05-02T13:24:33", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:\n> On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]thomas@monjalon.net>\n> wrote:\n> \n> 01/05/2019 21:50, Bruce Richardson:\n> > This set of changes fixes warnings seen when compiling DPDK on\n> Fedora 30.\n> > In most cases these warnings appear to be false positives, which\n> means we\n> > have the option to just disable the warning. Because the changes\n> required\n> > to the code to silence the warnings are fairly small I've chosen\n> in all cases\n> > to change the code rather than disable the warnings, but I'm open\n> to doing\n> > the opposite if it's felt it's a better solution. [One thing I\n> didn't like\n> > about disabling the warnings is that the disabling flags are not\n> supported\n> > by clang, so adding them involves compiler checks :-(]\n> >\n> > NOTE: this set does not cover all warnings with GCC9, but it does\n> cover\n> > those seen when building with meson. There is still one warning\n> disable\n> > flag needed when building with make, which will need a follow-on\n> set to\n> > fix.\n> >\n> > Bruce Richardson (4):\n> > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > bus/fslmc: fix printf of null pointer\n> > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n> Cc: [2]stable@dpdk.org\n> Applied, thanks\n> \n> I had a comment on patch 2, and the bigger problem is\n> -Waddress-of-packed-member.\n> The quicker solution for now is to downgrade it to warning only so that\n> we can fix the parts later rather than globally disable it.\n> --\nWell, it is already a warning, it's just that with make we build by default\nwith -Werror when building from git.\nAlso, that particular warning is already disabled for clang compilation, so\nextending that to being disabled for gcc seems fine for a fix for this\nrelease.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D609F5F1C;\n\tThu, 2 May 2019 15:24:39 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 9E5B15F17;\n\tThu, 2 May 2019 15:24:37 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 May 2019 06:24:36 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.237.221.48])\n\tby fmsmga007.fm.intel.com with SMTP; 02 May 2019 06:24:34 -0700", "by (sSMTP sendmail emulation); Thu, 02 May 2019 14:24:33 +0100" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,421,1549958400\"; d=\"scan'208\";a=\"147663509\"", "Date": "Thu, 2 May 2019 14:24:33 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tdpdk stable <stable@dpdk.org>", "Message-ID": "<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>\n\t<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>", "User-Agent": "Mutt/1.11.4 (2019-03-13)", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95771, "web_url": "http://patches.dpdk.org/comment/95771/", "msgid": "<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com", "date": "2019-05-02T13:32:20", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, May 2, 2019 at 3:24 PM Bruce Richardson <bruce.richardson@intel.com>\nwrote:\n\n> On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:\n> > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]\n> thomas@monjalon.net>\n> > wrote:\n> >\n> > 01/05/2019 21:50, Bruce Richardson:\n> > > This set of changes fixes warnings seen when compiling DPDK on\n> > Fedora 30.\n> > > In most cases these warnings appear to be false positives, which\n> > means we\n> > > have the option to just disable the warning. Because the changes\n> > required\n> > > to the code to silence the warnings are fairly small I've chosen\n> > in all cases\n> > > to change the code rather than disable the warnings, but I'm open\n> > to doing\n> > > the opposite if it's felt it's a better solution. [One thing I\n> > didn't like\n> > > about disabling the warnings is that the disabling flags are not\n> > supported\n> > > by clang, so adding them involves compiler checks :-(]\n> > >\n> > > NOTE: this set does not cover all warnings with GCC9, but it does\n> > cover\n> > > those seen when building with meson. There is still one warning\n> > disable\n> > > flag needed when building with make, which will need a follow-on\n> > set to\n> > > fix.\n> > >\n> > > Bruce Richardson (4):\n> > > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > > bus/fslmc: fix printf of null pointer\n> > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n> > Cc: [2]stable@dpdk.org\n> > Applied, thanks\n> >\n> > I had a comment on patch 2, and the bigger problem is\n> > -Waddress-of-packed-member.\n> > The quicker solution for now is to downgrade it to warning only so\n> that\n> > we can fix the parts later rather than globally disable it.\n> > --\n> Well, it is already a warning, it's just that with make we build by default\n> with -Werror when building from git.\n>\n\nErr, why don't we have -Werror for meson ?\n\n\nAlso, that particular warning is already disabled for clang compilation, so\n> extending that to being disabled for gcc seems fine for a fix for this\n> release.\n>\n\nArf, indeed..", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8072D5F2A;\n\tThu, 2 May 2019 15:32:33 +0200 (CEST)", "from mail-ua1-f66.google.com (mail-ua1-f66.google.com\n\t[209.85.222.66]) by dpdk.org (Postfix) with ESMTP id D97D45F1D\n\tfor <dev@dpdk.org>; Thu, 2 May 2019 15:32:31 +0200 (CEST)", "by mail-ua1-f66.google.com with SMTP id s30so711726uas.8\n\tfor <dev@dpdk.org>; Thu, 02 May 2019 06:32:31 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=HdS87vy/4q4ptadEbIdlOAgeisQhHXmy9nkhcd/2XoE=;\n\tb=NsuUnhYjDObN2S3BhYR7FjWdYQyGDW9SOX+9XYXczcTqgV9i0ZiUXqxMuLD0MkFzIo\n\tU/hS+x960fu8rWSQ/+sAhLeMQYRG4saLEm9LriX5vyXWlAtyA/l4UCr4cOC1O6IN6dsl\n\t151wYMeMH9j/eZ2Rqxj5qDXBIYDVZQJ6lhNjtLJ/JdUalbekZ6ThZMYN7vBgq9ZWO2Sl\n\tzhrJgeTs0PKBdKVKOnMrNrhO2fde2+bTjrVUQVu7Wuv1MxJ8brH+E445ox3OT51HPlTc\n\tnjLxCWNy7IXFZYThsIjeg/RYl1J3/6TL01d8Fw0NlTIzTD8vBQsEbLWqS8D+KR0IdGnW\n\t0jTg==", "X-Gm-Message-State": "APjAAAWm7d3kRVCLjHcIwWaK11/W9+IpFmTH+DFf8EftYKNqRyHjLSFu\n\tUpzk0pQd9wcjN0O6GGxSZ2NF2dVNjYELGzlmZzbRsOr4", "X-Google-Smtp-Source": "APXvYqyYU9xL87QlfBA5b0ixSJUmijPe0GCPRJSYJIRNaaLNkC1HRquJvHIQqX0oxiW7eWVbY+cGZAWjJcN2Ih2ALyk=", "X-Received": "by 2002:ab0:413:: with SMTP id 19mr1766222uav.87.1556803951229; \n\tThu, 02 May 2019 06:32:31 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>\n\t<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>\n\t<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>", "In-Reply-To": "<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Thu, 2 May 2019 15:32:20 +0200", "Message-ID": "<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tdpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95774, "web_url": "http://patches.dpdk.org/comment/95774/", "msgid": "<20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com", "date": "2019-05-02T13:46:32", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:\n> On Thu, May 2, 2019 at 3:24 PM Bruce Richardson\n> <[1]bruce.richardson@intel.com> wrote:\n> \n> On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:\n> > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon\n> <[1][2]thomas@monjalon.net>\n> > wrote:\n> >\n> > 01/05/2019 21:50, Bruce Richardson:\n> > > This set of changes fixes warnings seen when compiling DPDK\n> on\n> > Fedora 30.\n> > > In most cases these warnings appear to be false positives,\n> which\n> > means we\n> > > have the option to just disable the warning. Because the\n> changes\n> > required\n> > > to the code to silence the warnings are fairly small I've\n> chosen\n> > in all cases\n> > > to change the code rather than disable the warnings, but\n> I'm open\n> > to doing\n> > > the opposite if it's felt it's a better solution. [One\n> thing I\n> > didn't like\n> > > about disabling the warnings is that the disabling flags\n> are not\n> > supported\n> > > by clang, so adding them involves compiler checks :-(]\n> > >\n> > > NOTE: this set does not cover all warnings with GCC9, but\n> it does\n> > cover\n> > > those seen when building with meson. There is still one\n> warning\n> > disable\n> > > flag needed when building with make, which will need a\n> follow-on\n> > set to\n> > > fix.\n> > >\n> > > Bruce Richardson (4):\n> > > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > > bus/fslmc: fix printf of null pointer\n> > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n> > Cc: [2][3]stable@dpdk.org\n> > Applied, thanks\n> >\n> > I had a comment on patch 2, and the bigger problem is\n> > -Waddress-of-packed-member.\n> > The quicker solution for now is to downgrade it to warning only\n> so that\n> > we can fix the parts later rather than globally disable it.\n> > --\n> Well, it is already a warning, it's just that with make we build by\n> default\n> with -Werror when building from git.\n> \n> Err, why don't we have -Werror for meson ?\n> \n\nBecause it's generally not a good idea to use -Werror by default. However,\nthe test-meson-build script (which we should all be using for test\ncompilation before upstreaming) sets it for all builds.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EDDD45F2C;\n\tThu, 2 May 2019 15:46:38 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 53B8C5F20;\n\tThu, 2 May 2019 15:46:37 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 May 2019 06:46:36 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.237.221.48])\n\tby orsmga001.jf.intel.com with SMTP; 02 May 2019 06:46:33 -0700", "by (sSMTP sendmail emulation); Thu, 02 May 2019 14:46:33 +0100" ], "X-Amp-Result": "UNSCANNABLE", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,421,1549958400\"; d=\"scan'208\";a=\"228659774\"", "Date": "Thu, 2 May 2019 14:46:32 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tdpdk stable <stable@dpdk.org>", "Message-ID": "<20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com>", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>\n\t<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>\n\t<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>\n\t<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>", "User-Agent": "Mutt/1.11.4 (2019-03-13)", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95776, "web_url": "http://patches.dpdk.org/comment/95776/", "msgid": "<CAJFAV8zZP7d_WNwkoR-B1+PD0L6Tb4OoHJ-88F4EYMHYFRQQeg@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8zZP7d_WNwkoR-B1+PD0L6Tb4OoHJ-88F4EYMHYFRQQeg@mail.gmail.com", "date": "2019-05-02T13:53:36", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, May 2, 2019 at 3:46 PM Bruce Richardson <bruce.richardson@intel.com>\nwrote:\n\n> On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:\n> > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson\n> > <[1]bruce.richardson@intel.com> wrote:\n> >\n> > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:\n> > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon\n> > <[1][2]thomas@monjalon.net>\n> > > wrote:\n> > >\n> > > 01/05/2019 21:50, Bruce Richardson:\n> > > > This set of changes fixes warnings seen when compiling DPDK\n> > on\n> > > Fedora 30.\n> > > > In most cases these warnings appear to be false positives,\n> > which\n> > > means we\n> > > > have the option to just disable the warning. Because the\n> > changes\n> > > required\n> > > > to the code to silence the warnings are fairly small I've\n> > chosen\n> > > in all cases\n> > > > to change the code rather than disable the warnings, but\n> > I'm open\n> > > to doing\n> > > > the opposite if it's felt it's a better solution. [One\n> > thing I\n> > > didn't like\n> > > > about disabling the warnings is that the disabling flags\n> > are not\n> > > supported\n> > > > by clang, so adding them involves compiler checks :-(]\n> > > >\n> > > > NOTE: this set does not cover all warnings with GCC9, but\n> > it does\n> > > cover\n> > > > those seen when building with meson. There is still one\n> > warning\n> > > disable\n> > > > flag needed when building with make, which will need a\n> > follow-on\n> > > set to\n> > > > fix.\n> > > >\n> > > > Bruce Richardson (4):\n> > > > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > > > bus/fslmc: fix printf of null pointer\n> > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30\n> > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30\n> > > Cc: [2][3]stable@dpdk.org\n> > > Applied, thanks\n> > >\n> > > I had a comment on patch 2, and the bigger problem is\n> > > -Waddress-of-packed-member.\n> > > The quicker solution for now is to downgrade it to warning only\n> > so that\n> > > we can fix the parts later rather than globally disable it.\n> > > --\n> > Well, it is already a warning, it's just that with make we build by\n> > default\n> > with -Werror when building from git.\n> >\n> > Err, why don't we have -Werror for meson ?\n> >\n>\n> Because it's generally not a good idea to use -Werror by default. However,\n> the test-meson-build script (which we should all be using for test\n> compilation before upstreaming) sets it for all builds.\n>\n\nYes ok, so that old releases still build on newer toolchains.\nAs for the test-meson-builds.sh and test-build.sh scripts, they are still\nwidely unknown except by maintainers.\nBut at least, the ci build script would catch the errors, since it\nconfigures with \"meson build --werror -Dexamples=all $OPTS\"", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B07D75F17;\n\tThu, 2 May 2019 15:53:49 +0200 (CEST)", "from mail-vs1-f67.google.com (mail-vs1-f67.google.com\n\t[209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 51F101F28\n\tfor <dev@dpdk.org>; Thu, 2 May 2019 15:53:48 +0200 (CEST)", "by mail-vs1-f67.google.com with SMTP id d8so1414396vsp.2\n\tfor <dev@dpdk.org>; Thu, 02 May 2019 06:53:48 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=/C90EyKANOnEMbHIXyjn9gwG2nQtlEbJsMQ80gCVRw0=;\n\tb=KLfU/mmqiPsm/POn0gm6eOv6RUhU7uZbOt5W5HW7IOnHR68GcwJ0+HKqwSbVdosi0U\n\tBIf4FWc+buQV9tIcc5gQ/CnMcFFGexy4L3KZyBIRqGRr33c5AkyFFPO7p7bIH40gcaA2\n\taN732IEj+bMUw3dkdtcm44RL/UBrUj9WDphctGPjlW3GweeU+xEwlhxJSAYL+u92xLBK\n\thPkctLA9t0p1oMKR1H5/WdAPeTA1gpnNLtIhSwmN4aRecfqR1bDXipmrblZKesyYoYQO\n\t+BEuebklEWyqub0VmsC5rJ9BKvx1TEw/6y6hjxdOwU2uxoOXlU7v+oGBvWN9in/NsOSJ\n\tVwng==", "X-Gm-Message-State": "APjAAAV2jS3k35rWbaaJUnedfG2kfkRs972QZVQ5+jKoMSGKxaukZHzp\n\t2aETcI6aN7qEGvnL/ZMtuxeGrvivZSH9T+MAwAMnIQ==", "X-Google-Smtp-Source": "APXvYqyO0R/CoClNylcHyZMXYvdlMkmftPloXpAt4c4N0ngKoveQyJhicx16/dYxjI+Sou+AfmMyix+x1zSArWRuUcc=", "X-Received": "by 2002:a67:7f85:: with SMTP id\n\ta127mr2052399vsd.141.1556805227643; \n\tThu, 02 May 2019 06:53:47 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>\n\t<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>\n\t<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>\n\t<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>\n\t<20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com>", "In-Reply-To": "<20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Thu, 2 May 2019 15:53:36 +0200", "Message-ID": "<CAJFAV8zZP7d_WNwkoR-B1+PD0L6Tb4OoHJ-88F4EYMHYFRQQeg@mail.gmail.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tdpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95778, "web_url": "http://patches.dpdk.org/comment/95778/", "msgid": "<20190502140426.GA2007@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190502140426.GA2007@bricha3-MOBL.ger.corp.intel.com", "date": "2019-05-02T14:04:26", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, May 02, 2019 at 03:53:36PM +0200, David Marchand wrote:\n> On Thu, May 2, 2019 at 3:46 PM Bruce Richardson\n> <[1]bruce.richardson@intel.com> wrote:\n> \n> On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:\n> > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson\n> > <[1][2]bruce.richardson@intel.com> wrote:\n> >\n> > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand\n> wrote:\n> > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon\n> > <[1][2][3]thomas@monjalon.net>\n> > > wrote:\n> > >\n> > > 01/05/2019 21:50, Bruce Richardson:\n> > > > This set of changes fixes warnings seen when\n> compiling DPDK\n> > on\n> > > Fedora 30.\n> > > > In most cases these warnings appear to be false\n> positives,\n> > which\n> > > means we\n> > > > have the option to just disable the warning. Because\n> the\n> > changes\n> > > required\n> > > > to the code to silence the warnings are fairly small\n> I've\n> > chosen\n> > > in all cases\n> > > > to change the code rather than disable the warnings,\n> but\n> > I'm open\n> > > to doing\n> > > > the opposite if it's felt it's a better solution.\n> [One\n> > thing I\n> > > didn't like\n> > > > about disabling the warnings is that the disabling\n> flags\n> > are not\n> > > supported\n> > > > by clang, so adding them involves compiler checks\n> :-(]\n> > > >\n> > > > NOTE: this set does not cover all warnings with\n> GCC9, but\n> > it does\n> > > cover\n> > > > those seen when building with meson. There is still\n> one\n> > warning\n> > > disable\n> > > > flag needed when building with make, which will need\n> a\n> > follow-on\n> > > set to\n> > > > fix.\n> > > >\n> > > > Bruce Richardson (4):\n> > > > net/ixgbe: fix warning with GCC 9 on Fedora 30\n> > > > bus/fslmc: fix printf of null pointer\n> > > > raw/skeleton_rawdev: fix warnings with GCC 9 on\n> Fedora 30\n> > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora\n> 30\n> > > Cc: [2][3][4]stable@dpdk.org\n> > > Applied, thanks\n> > >\n> > > I had a comment on patch 2, and the bigger problem is\n> > > -Waddress-of-packed-member.\n> > > The quicker solution for now is to downgrade it to\n> warning only\n> > so that\n> > > we can fix the parts later rather than globally disable\n> it.\n> > > --\n> > Well, it is already a warning, it's just that with make we\n> build by\n> > default\n> > with -Werror when building from git.\n> >\n> > Err, why don't we have -Werror for meson ?\n> >\n> Because it's generally not a good idea to use -Werror by default.\n> However,\n> the test-meson-build script (which we should all be using for test\n> compilation before upstreaming) sets it for all builds.\n> \n> Yes ok, so that old releases still build on newer toolchains.\n> As for the test-meson-builds.sh and test-build.sh scripts, they are\n> still widely unknown except by maintainers.\n> But at least, the ci build script would catch the errors, since it\n> configures with \"meson build --werror -Dexamples=all $OPTS\"\n> --\n\nYep, that's the idea. So long as it's easy enough for maintainers and CI to\nuse werror, we should be covered.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4342E7D4A;\n\tThu, 2 May 2019 16:04:33 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 3CFEA5F2C;\n\tThu, 2 May 2019 16:04:31 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 May 2019 07:04:30 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.237.221.48])\n\tby orsmga006.jf.intel.com with SMTP; 02 May 2019 07:04:27 -0700", "by (sSMTP sendmail emulation); Thu, 02 May 2019 15:04:27 +0100" ], "X-Amp-Result": "UNSCANNABLE", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,421,1549958400\"; d=\"scan'208\";a=\"140679307\"", "Date": "Thu, 2 May 2019 15:04:26 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,\n\tdpdk stable <stable@dpdk.org>", "Message-ID": "<20190502140426.GA2007@bricha3-MOBL.ger.corp.intel.com>", "References": "<20190501195014.2938-1-bruce.richardson@intel.com>\n\t<8175150.iIoqqa2Iee@xps>\n\t<CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com>\n\t<20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com>\n\t<CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com>\n\t<20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com>\n\t<CAJFAV8zZP7d_WNwkoR-B1+PD0L6Tb4OoHJ-88F4EYMHYFRQQeg@mail.gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<CAJFAV8zZP7d_WNwkoR-B1+PD0L6Tb4OoHJ-88F4EYMHYFRQQeg@mail.gmail.com>", "User-Agent": "Mutt/1.11.4 (2019-03-13)", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on\n\tFedora 30", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]