List comments

GET /api/covers/53079/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 95832,
        "web_url": "http://patches.dpdk.org/comment/95832/",
        "msgid": "<3401531.dNvLWj16ye@xps>",
        "date": "2019-05-03T08:34:16",
        "subject": "Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks",
        "submitter": {
            "id": 685,
            "url": "http://patches.dpdk.org/api/people/685/",
            "name": "Thomas Monjalon",
            "email": "thomas@monjalon.net"
        },
        "content": "25/04/2019 14:48, Herakliusz Lipiec:\n> When sending multiple requests, rte_mp_request_sync\n> can succeed sending a few of those requests, but then\n> fail on a later one and in the end return with rc=-1.\n> The upper layers - e.g. device hotplug - currently\n> handles this case as if no messages were sent and no\n> memory for response buffers was allocated, which is\n> not true. Fixed by always initializing message buffer\n> to NULL and calling free everytime rte_mp_request_sync\n> is used.\n> \n> v2:\n> - resending as patchset to make it easier to review it.\n\nHeraliusz, it's a total mess.\nThere were 8 patches in v2. Why they disappeared?\nThe title prefixes are often wrong, so it's harder to classify them.\n\nShould I merge all these patches?\n  ipc: fix rte_mp_request_sync memleak\n  ipc: fix hotplug memleak\n  ipc: fix vdev memleak\n  ipc: fix vfio memleak\n  ipc: fix pdump memleak\n  ipc: fix tap pmd memleak\n  ipc: fix net/mlx4 memleak\n  ipc: fix net/mlx5 memleak",
        "headers": {
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "From": "Thomas Monjalon <thomas@monjalon.net>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "DKIM-Signature": [
                "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj1I=; b=ofsTN3oOO2br\n\tL/Aqrv4DAYj3GMFIdUfh4y7SBseUrXrXwCYhnVlaIvL4+pFNS6Pze+uKeE+wY/uq\n\tQmNt5OhmKXdfhAbSFIwtQ0zF4XisusOFVuqbKg7oyK8C0onsJpV+KhERu5cGJEkv\n\ttKzib91w2C+K3gHXdBt+yHc1Oc+rTHk=",
                "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=Wgk18VB8zYmoy+YC3ui8wCPMeiPgu2tnWL2i7rLOj\n\t1I=; b=x6t2Y9zYTuBdfhPAkAVOBsSorxryfHFTu4xTG+8VKi3NY4eOsanHVBH51\n\t4Ruo6UPgnPLqmlvSIHj41Gah1K57TGk6Xn0fxHTjWjk1zTzF4WpQWL+HUQeV5RwC\n\tCpL+Ax15apT3cS4AYS45JbwFT7WYSNUffSfGOPLtP6fS55QMPCfXTbC0DnLRjzsz\n\tPEyL26KSjeZMRCUrlQpEjhu33RbCjOJ6d2HWmNgnjf3YWvhzQgVqiyVw//zjLP9Y\n\tKlJzYGyznKFXu2lz/gVQ7sqvtbmzTR3AZ5FWlhcV/+Gaxd007voZfetjepEEAH1E\n\tIQUEQ6WdcgELW/uBrwlTRrnVgpbgA=="
            ],
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrjedugddtjecutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n\tfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n\tucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n\tepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho\n\tmhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd",
            "X-ME-Proxy": "<xmx:Cv3LXHT41_-2afQVXhdorZdTYrnSetrDjKC0YqoeMvipEgIea8l9nw>\n\t<xmx:Cv3LXKSd_l2D7-N4Bnz6myiB6rFafxHGJKPEO-dNoN7PFXzgDVbKZw>\n\t<xmx:Cv3LXKdP4HSizwfWBfUV53xETpblMS3a81gfkvtm7TpBiVZDpEFbYw>\n\t<xmx:Cv3LXG-hvz8H4NkO7ijbmDsYAzY8uso-kQPot43ZSxa9lQTjSmMa7Q>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org, anatoly.burakov@intel.com",
            "To": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "References": "<20190425114324.611-1-herakliusz.lipiec@intel.com>\n\t<20190425124817.28409-1-herakliusz.lipiec@intel.com>",
            "X-ME-Sender": "<xms:Cv3LXKErKrckv3OY1ym_ckIpFttWFcFoHNUqZ7pxgXVR2WLV7ZmjIw>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3BAD92BCE;\n\tFri,  3 May 2019 10:34:21 +0200 (CEST)",
                "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 42FC32BB1\n\tfor <dev@dpdk.org>; Fri,  3 May 2019 10:34:19 +0200 (CEST)",
                "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E01882221C;\n\tFri,  3 May 2019 04:34:18 -0400 (EDT)",
                "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Fri, 03 May 2019 04:34:18 -0400",
                "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id CD99110369;\n\tFri,  3 May 2019 04:34:17 -0400 (EDT)"
            ],
            "Date": "Fri, 03 May 2019 10:34:16 +0200",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks",
            "In-Reply-To": "<20190425124817.28409-1-herakliusz.lipiec@intel.com>",
            "MIME-Version": "1.0",
            "Message-ID": "<3401531.dNvLWj16ye@xps>",
            "Precedence": "list",
            "Content-Transfer-Encoding": "7Bit",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org"
        }
    },
    {
        "id": 95833,
        "web_url": "http://patches.dpdk.org/comment/95833/",
        "msgid": "<173ee033-e181-6ea8-b567-c683ce2c5028@intel.com>",
        "date": "2019-05-03T08:38:41",
        "subject": "Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks",
        "submitter": {
            "id": 4,
            "url": "http://patches.dpdk.org/api/people/4/",
            "name": "Burakov, Anatoly",
            "email": "anatoly.burakov@intel.com"
        },
        "content": "On 03-May-19 9:34 AM, Thomas Monjalon wrote:\n> 25/04/2019 14:48, Herakliusz Lipiec:\n>> When sending multiple requests, rte_mp_request_sync\n>> can succeed sending a few of those requests, but then\n>> fail on a later one and in the end return with rc=-1.\n>> The upper layers - e.g. device hotplug - currently\n>> handles this case as if no messages were sent and no\n>> memory for response buffers was allocated, which is\n>> not true. Fixed by always initializing message buffer\n>> to NULL and calling free everytime rte_mp_request_sync\n>> is used.\n>>\n>> v2:\n>> - resending as patchset to make it easier to review it.\n> \n> Heraliusz, it's a total mess.\n> There were 8 patches in v2. Why they disappeared?\n> The title prefixes are often wrong, so it's harder to classify them.\n> \n> Should I merge all these patches?\n>    ipc: fix rte_mp_request_sync memleak\n>    ipc: fix hotplug memleak\n>    ipc: fix vdev memleak\n>    ipc: fix vfio memleak\n>    ipc: fix pdump memleak\n>    ipc: fix tap pmd memleak\n>    ipc: fix net/mlx4 memleak\n>    ipc: fix net/mlx5 memleak\n> \n\nHi Thomas,\n\nyou've also skipped the following:\n\n > v3:\n > - rework of the patchset\n > - caller is no longer responsible for freeing buffers on failure\n > - caller still has to free response buffers on success\n\nthe v3 was where the 8 patch patchset was reworked into two-patch \npatchset, because we've changed our approach.\n\nSo no, those 8 patches should not be merged - they're superseded by v3 \n(well, v4 now).",
        "headers": {
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "From": "\"Burakov, Anatoly\" <anatoly.burakov@intel.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Date": "Fri, 3 May 2019 09:38:41 +0100",
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Cc": "dev@dpdk.org",
            "To": "Thomas Monjalon <thomas@monjalon.net>,\n\tHerakliusz Lipiec <herakliusz.lipiec@intel.com>",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1",
            "References": "<20190425114324.611-1-herakliusz.lipiec@intel.com>\n\t<20190425124817.28409-1-herakliusz.lipiec@intel.com>\n\t<3401531.dNvLWj16ye@xps>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A1E22B9C;\n\tFri,  3 May 2019 10:38:46 +0200 (CEST)",
                "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id A613C2A6C\n\tfor <dev@dpdk.org>; Fri,  3 May 2019 10:38:44 +0200 (CEST)",
                "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2019 01:38:43 -0700",
                "from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.90.134])\n\t([10.251.90.134])\n\tby orsmga002.jf.intel.com with ESMTP; 03 May 2019 01:38:42 -0700"
            ],
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "X-Amp-File-Uploaded": "False",
            "Subject": "Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks",
            "In-Reply-To": "<3401531.dNvLWj16ye@xps>",
            "MIME-Version": "1.0",
            "Message-ID": "<173ee033-e181-6ea8-b567-c683ce2c5028@intel.com>",
            "X-ExtLoop1": "1",
            "Content-Transfer-Encoding": "7bit",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org"
        }
    }
]