Cover Comment List
List cover comments
GET /api/covers/52265/comments/?format=api
[ { "id": 94491, "web_url": "http://patches.dpdk.org/comment/94491/", "msgid": "<6a63d9fa-0634-8184-252e-40e0ff5ce203@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6a63d9fa-0634-8184-252e-40e0ff5ce203@intel.com", "date": "2019-04-04T16:13:05", "subject": "Re: [dpdk-dev] [PATCH v11 0/1] Introduce AF_XDP PMD", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 4/4/2019 9:51 AM, Xiaolong Ye wrote:\n> Overview\n> ========\n> \n> This patchset adds a new PMD driver for AF_XDP which is a proposed\n> faster version of AF_PACKET interface in Linux, see below links [1] [2] for\n> details of AF_XDP introduction:\n> \n> AF_XDP roadmap\n> ==============\n> - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support\n> in libbpf has been merged in v5.1-rc1.\n> - Now i40e and ixgbe drivers have supported zero copy mode.\n> \n> Change logs\n> ===========\n> v11:\n> \n> - fix the meson build issue\n> \n> v10:\n> \n> - refine the Makefile, remove RTE_KERNELDIR related CFLAGS \n> - add a new internal file af_xdp_deps.h to handle the dependency for\n> asm/barrier.h\n> - fix a typo observed by Stephen\n> - rename xsk.h to bpf/xsk.h as xsk.h is assumed to be installed in\n> /usr/local/include/bpf\n> - add libbpf build steps in af_xdp.rst\n> \n> \n> v9:\n> - adjust header files order according to Stephen's suggestion\n> \n> v8:\n> - address Ferruh's comments on V7\n> - replace posix_memalign with rte_memzone_reserve_aligned to get better\n> performance\n> - keep the first patch only as Oliver suggested as zero copy part\n> implementation is still in suspense, we may provide the related patch\n> later.\n> \n> v7:\n> - mention mtu limitation in af_xdp.rst\n> - fix the vdev name in af_xdp.rst\n> \n> V6:\n> \n> - remove the newline in AF_XDP_LOG definition to avoid double new lines\n> issue.\n> - rename MEMPOOL_F_PAGE_ALIGN to MEMPOOL_CHUNK_F_PAGE_ALIGN.\n> \n> V5:\n> \n> - disable AF_XDP pmd by default due to it requires kernel more recent\n> than minimum kernel version supported by DPDK\n> - address other review comments of Maxime\n> \n> V4:\n> \n> - change vdev name to net_af_xdp\n> - adopt dynamic log type for all logging\n> - Fix other style issues raised by Stephen\n> \n> V3:\n> \n> - Fix all style issues pointed by Stephen, Mattias, David.\n> - Drop the testpmd change as we'll adopt Jerin's suggestion to add a new\n> mempool driver to handle the application use of AF_XDP's zero copy feature.\n> \n> V2:\n> - Fix a NULL pointer reference crash issue\n> - Fix txonly stop sending traffic in zc mode\n> - Refactor rte_mbuf.c to avoid ABI breakage.\n> - Fix multiple style issues pointed by Ferruh, David, Stephen, Luca.\n> \n> changes vs RFC sent by Qi last Aug:\n> \n> - Re-work base on AF_XDP's interface changes since the new libbpf has\n> provided higher-level APIs that hide many of the details of the AP_XDP\n> uapi. After the rework, it helps to reduce 300+ lines of code.\n> \n> - multi-queues is not supported due to current libbpf doesn't support\n> multi-sockets on a single umem.\n> \n> - No extra steps to load xdp program manually, since the current behavior of\n> libbpf would load a default xdp program when user calls xsk_socket__create.\n> userspace application only needs to handle the cleanup.\n> \n> How to try\n> ==========\n> \n> 1. take the kernel >= v5.1-rc1, build kernel and replace your host\n> kernel with it.\n> \n> make sure you turn on XDP sockets when compiling\n> \n> Networking support -->\n> Networking options -->\n> [ * ] XDP sockets\n> \n> 2. build & install libbpf in tools/lib/bpf\n> \n> cd tools/lib/bpf\n> make install_lib\n> make install_headers\n> \n> 3. ethtool -L enp59s0f0 combined 1\n> \n> 4. extra step to build dpdk\n> \n> explicitly enable AF_XDP pmd by adding below line to\n> config/common_linux\n> \n> CONFIG_RTE_LIBRTE_PMD_AF_XDP=y\n> \n> 5. start testpmd\n> \n> ./build/app/testpmd -c 0xc -n 4 --vdev net_af_xdp,iface=enp59s0f0,queue=0 -- -i --rxq=1 --txq=1\n> \n> in this case, default xdp program will be loaded and linked to queue 0 of enp59s0f0,\n> network traffics travel to queue 0 will be redirected to af_xdp socket.\n> \n> Xiaolong Ye (1):\n> net/af_xdp: introduce AF XDP PMD driver\n\nReviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B2C701B212;\n\tThu, 4 Apr 2019 18:13:13 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id BAD971B20D\n\tfor <dev@dpdk.org>; Thu, 4 Apr 2019 18:13:11 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Apr 2019 09:13:10 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46])\n\t([10.237.221.46])\n\tby orsmga001.jf.intel.com with ESMTP; 04 Apr 2019 09:13:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,308,1549958400\"; d=\"scan'208\";a=\"220582034\"", "To": "Xiaolong Ye <xiaolong.ye@intel.com>, dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tLuca Boccassi <bluca@debian.org>", "Cc": "Qi Zhang <qi.z.zhang@intel.com>,\n\tKarlsson Magnus <magnus.karlsson@intel.com>,\n\tTopel Bjorn <bjorn.topel@intel.com>,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tAnanyev Konstantin <konstantin.ananyev@intel.com>,\n\tDavid Marchand <david.marchand@redhat.com>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>,\n\tOlivier Matz <olivier.matz@6wind.com>", "References": "<20190301080947.91086-1-xiaolong.ye@intel.com>\n\t<20190404085113.16732-1-xiaolong.ye@intel.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\tmQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE\n\tFgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf\n\tE2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e\n\tmRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL\n\tSXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx\n\tNub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl\n\t1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK\n\tH2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ\n\trmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste\n\tZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p\n\tfXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx\n\t5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB\n\tL5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd\n\tU6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y\n\tgDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt\n\tv71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+\n\taYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj\n\t0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G\n\tB31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ\n\tmasOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4\n\tYuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy\n\tZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T\n\tYR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7\n\tllafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86\n\tlxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6\n\tLY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo\n\tV8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D\n\t2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i\n\tmPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W\n\tK3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE\n\t56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP\n\tY7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+\n\tvM8=", "Message-ID": "<6a63d9fa-0634-8184-252e-40e0ff5ce203@intel.com>", "Date": "Thu, 4 Apr 2019 17:13:05 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1", "MIME-Version": "1.0", "In-Reply-To": "<20190404085113.16732-1-xiaolong.ye@intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v11 0/1] Introduce AF_XDP PMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]