Cover Comment List
List cover comments
GET /api/covers/52198/comments/?format=api
[ { "id": 94383, "web_url": "http://patches.dpdk.org/comment/94383/", "msgid": "<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com", "date": "2019-04-03T14:57:49", "subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "submitter": { "id": 166, "url": "http://patches.dpdk.org/api/people/166/?format=api", "name": "Wiles, Keith", "email": "keith.wiles@intel.com" }, "content": "> On Apr 3, 2019, at 9:45 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:\n> \n> There are quite a few instances remaining in DPDK where snprintf is being\n> used for string copying. These were not being picked up by our existing\n> coccinelle script, but that can be fixed by editing the script and running\n> it against our code. In the process a bug was found and fixed in the\n> bonding pmd, where we were incorrectly specifiying the buffer length\n> parameter to snprintf.\n> \n> The actual replacement was done in two phases - first replacing all\n> instances where only the snprintf line in question needed changing, then\n> fixing the other instances where we also needed to add in the header\n> include. [Using two stages allowed the header addition to be automated too,\n> since we had a list of files where every one needed the header inclusion]\n> \n> \n> Bruce Richardson (5):\n> net/bonding: fix buffer length when printing strings\n> devtools/cocci: make strlcpy replacement smarter\n> devtools/cocci: create safer version of strlcpy script\n> replace snprintf with strlcpy without adding extra include\n> replace snprintf with strlcpy\n> \n\nShould we not be testing the return values from strlcpy and snprintf, which means we need to create a macro or inline function. We could use a macro and only enable with DEBUG support if we think performance or code size if a problem.\n\nI am surprised none of the tools are catching these types of problems.\n\nNot to make Bruce do that change for this patch, but we need to look at it for a later patch IMO.\n\nRegards,\nKeith", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BEE21B475;\n\tWed, 3 Apr 2019 16:57:54 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id B3D0F1B450\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 16:57:52 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 07:57:51 -0700", "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby orsmga006.jf.intel.com with ESMTP; 03 Apr 2019 07:57:51 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Wed, 3 Apr 2019 07:57:51 -0700", "from fmsmsx117.amr.corp.intel.com ([169.254.3.142]) by\n\tFMSMSX154.amr.corp.intel.com ([169.254.6.237]) with mapi id\n\t14.03.0415.000; Wed, 3 Apr 2019 07:57:50 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,304,1549958400\"; d=\"scan'208\";a=\"132656786\"", "From": "\"Wiles, Keith\" <keith.wiles@intel.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "Thread-Index": "AQHU6ivsTgsdTBAINEa+aarG3SRS86Yq/DUA", "Date": "Wed, 3 Apr 2019 14:57:49 +0000", "Message-ID": "<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "References": "<20190403144505.46234-1-bruce.richardson@intel.com>", "In-Reply-To": "<20190403144505.46234-1-bruce.richardson@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.254.102.28]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-ID": "<E4A87FA944AA584C9DF525744A36CF86@intel.com>", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 94390, "web_url": "http://patches.dpdk.org/comment/94390/", "msgid": "<20190403151349.GA1325@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190403151349.GA1325@bricha3-MOBL.ger.corp.intel.com", "date": "2019-04-03T15:13:49", "subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Wed, Apr 03, 2019 at 03:57:49PM +0100, Wiles, Keith wrote:\n> \n> \n> > On Apr 3, 2019, at 9:45 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:\n> > \n> > There are quite a few instances remaining in DPDK where snprintf is being\n> > used for string copying. These were not being picked up by our existing\n> > coccinelle script, but that can be fixed by editing the script and running\n> > it against our code. In the process a bug was found and fixed in the\n> > bonding pmd, where we were incorrectly specifiying the buffer length\n> > parameter to snprintf.\n> > \n> > The actual replacement was done in two phases - first replacing all\n> > instances where only the snprintf line in question needed changing, then\n> > fixing the other instances where we also needed to add in the header\n> > include. [Using two stages allowed the header addition to be automated too,\n> > since we had a list of files where every one needed the header inclusion]\n> > \n> > \n> > Bruce Richardson (5):\n> > net/bonding: fix buffer length when printing strings\n> > devtools/cocci: make strlcpy replacement smarter\n> > devtools/cocci: create safer version of strlcpy script\n> > replace snprintf with strlcpy without adding extra include\n> > replace snprintf with strlcpy\n> > \n> \n> Should we not be testing the return values from strlcpy and snprintf, which means we need to create a macro or inline function. We could use a macro and only enable with DEBUG support if we think performance or code size if a problem.\n> \n\nYes, I think in some/many cases we should be checking the return value, but\nunfortunately I don't think it's the case that we always should or should\nnot do so. In some cases, truncation is fine. Therefore, I don't think an\nautomated solution can work here, and I don't see much point in wrapping\nany of these functions in macros, since the action to take on truncation\nprobably varies from place to place.\n\n> I am surprised none of the tools are catching these types of problems.\n> \nYes. It would be useful to have a tool to flag this, so we can see under\nwhat circumstances it may be a problem.\n\n> Not to make Bruce do that change for this patch, but we need to look at it for a later patch IMO.\n> \nPhew! :-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 554331B490;\n\tWed, 3 Apr 2019 17:13:55 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7F4D71B46A\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 17:13:53 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 08:13:52 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.237.221.35])\n\tby orsmga007.jf.intel.com with SMTP; 03 Apr 2019 08:13:50 -0700", "by (sSMTP sendmail emulation); Wed, 03 Apr 2019 16:13:49 +0100" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,304,1549958400\"; d=\"scan'208\";a=\"128331600\"", "Date": "Wed, 3 Apr 2019 16:13:49 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "\"Wiles, Keith\" <keith.wiles@intel.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Message-ID": "<20190403151349.GA1325@bricha3-MOBL.ger.corp.intel.com>", "References": "<20190403144505.46234-1-bruce.richardson@intel.com>\n\t<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "User-Agent": "Mutt/1.11.4 (2019-03-13)", "Subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 94393, "web_url": "http://patches.dpdk.org/comment/94393/", "msgid": "<20190403082714.377f372a@shemminger-XPS-13-9360>", "list_archive_url": "https://inbox.dpdk.org/dev/20190403082714.377f372a@shemminger-XPS-13-9360", "date": "2019-04-03T15:27:14", "subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Wed, 3 Apr 2019 14:57:49 +0000\n\"Wiles, Keith\" <keith.wiles@intel.com> wrote:\n\n> > On Apr 3, 2019, at 9:45 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:\n> > \n> > There are quite a few instances remaining in DPDK where snprintf is being\n> > used for string copying. These were not being picked up by our existing\n> > coccinelle script, but that can be fixed by editing the script and running\n> > it against our code. In the process a bug was found and fixed in the\n> > bonding pmd, where we were incorrectly specifiying the buffer length\n> > parameter to snprintf.\n> > \n> > The actual replacement was done in two phases - first replacing all\n> > instances where only the snprintf line in question needed changing, then\n> > fixing the other instances where we also needed to add in the header\n> > include. [Using two stages allowed the header addition to be automated too,\n> > since we had a list of files where every one needed the header inclusion]\n> > \n> > \n> > Bruce Richardson (5):\n> > net/bonding: fix buffer length when printing strings\n> > devtools/cocci: make strlcpy replacement smarter\n> > devtools/cocci: create safer version of strlcpy script\n> > replace snprintf with strlcpy without adding extra include\n> > replace snprintf with strlcpy\n> > \n> \n> Should we not be testing the return values from strlcpy and snprintf, which means we need to create a macro or inline function. We could use a macro and only enable with DEBUG support if we think performance or code size if a problem.\n> \n> I am surprised none of the tools are catching these types of problems.\n> \n> Not to make Bruce do that change for this patch, but we need to look at it for a later patch IMO.\n> \n> Regards,\n> Keith\n> \n\nIn a lot of cases the error checking should be earlier in the input path.\nDetecting overflow late in making a string is unhelpful. But rejecting\ninput where the name is too long to start with is safer and better.\n\nIt is one of those cases where static checkers tell you there is a\nproblem but the right solution is farther back in the code, not just\nright where the error is reported.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 355C11B4A6;\n\tWed, 3 Apr 2019 17:27:21 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id B43881B49B\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 17:27:19 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id t16so6334278plo.0\n\tfor <dev@dpdk.org>; Wed, 03 Apr 2019 08:27:19 -0700 (PDT)", "from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tp2sm1142928pfb.80.2019.04.03.08.27.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 03 Apr 2019 08:27:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IzQTYub1eqF0BOcAodHo1cthIWPn93ftjF0koNyymg0=;\n\tb=ZF5ZUVQqOZVbYYiqG8cjJ4aj5oHI+7wroIfhdq0QKeR6QhCPIckoD4VG6ZEcj3PXYF\n\t/WqzVNCzXlfjbQxkYtXA2Zlo8mC8yTO7A2iMzSTszITG2Iet/BeqoBjLOxJFb22gJ9np\n\tp8Dn/Ce1VeRqYwdVmpAQD7TA/K4XYe2dwslQ0VpepZM1T0JxThNs+wftxTqhKm7td7YE\n\tvyj1AbUNBc5ijeuAT4oy15Xfi48eM7oCx7lP+vzwA/5KxwsTA5KowOHNyqzNGy9SFvls\n\tDkI/qeP8ywt2slF1eLFQ+CGuOOsiH50jlJsB7sxybm2Q5DxK2coDgAuihU8nofUP8+wJ\n\tfKNA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IzQTYub1eqF0BOcAodHo1cthIWPn93ftjF0koNyymg0=;\n\tb=tkEagNl6fd+EzVRbLvnLyRsxqNtkUt9Xk+UFKKCG1PrTzI9T6A7nyDWgsbeiheqAQo\n\tUqiKSgyX/0+0Dw4j0Oq9dOsnhh/6t1ziEfwoepayEb/ekvxCnmaPMMimJdqHT3xCOrhp\n\tE+FyvdtLqI1PIL3QDlvZhZp5+4Y/Xx3mbVK6LQTgewTclbOxgFuyIXQrelrPB3WPcKxW\n\t4vlbYf6z2I+6x+dnk5x+DzNnJ6xBIHY4mNAU6A3WwhnH5Y0cWdPHKd6edeJiZwuoQKMu\n\toawjPUbU89viEk3SzotjorfN8B2vXjoEw/qlr8jAdh+p7VmI8Mo0EtfqRB3BdQnY+VJZ\n\thDmA==", "X-Gm-Message-State": "APjAAAW8CWffWFVNbuAINGZqVwL4YVINTQWLft6jZuCW9wrVgaEYhXdr\n\tu+qbpgf165dxy0iss2h1Uc1uUA==", "X-Google-Smtp-Source": "APXvYqyZ8WOGUr0hJ9gCquKArFvBC7R/PgXJo25+gYpNS0Ky9gaE66XfcisPb394IuPJi+vg9+WtLA==", "X-Received": "by 2002:a17:902:16a4:: with SMTP id\n\th33mr536272plh.23.1554305238529; \n\tWed, 03 Apr 2019 08:27:18 -0700 (PDT)", "Date": "Wed, 3 Apr 2019 08:27:14 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "\"Wiles, Keith\" <keith.wiles@intel.com>", "Cc": "\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Message-ID": "<20190403082714.377f372a@shemminger-XPS-13-9360>", "In-Reply-To": "<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "References": "<20190403144505.46234-1-bruce.richardson@intel.com>\n\t<5F7D9EB2-AD8D-475B-852C-D8B25475F25C@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 94510, "web_url": "http://patches.dpdk.org/comment/94510/", "msgid": "<2985695.VAqBOLQO3E@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2985695.VAqBOLQO3E@xps", "date": "2019-04-04T20:11:31", "subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "03/04/2019 16:45, Bruce Richardson:\n> There are quite a few instances remaining in DPDK where snprintf is being\n> used for string copying. These were not being picked up by our existing\n> coccinelle script, but that can be fixed by editing the script and running\n> it against our code. In the process a bug was found and fixed in the\n> bonding pmd, where we were incorrectly specifiying the buffer length\n> parameter to snprintf.\n> \n> The actual replacement was done in two phases - first replacing all\n> instances where only the snprintf line in question needed changing, then\n> fixing the other instances where we also needed to add in the header\n> include. [Using two stages allowed the header addition to be automated too,\n> since we had a list of files where every one needed the header inclusion]\n> \n> \n> Bruce Richardson (5):\n> net/bonding: fix buffer length when printing strings\n> devtools/cocci: make strlcpy replacement smarter\n> devtools/cocci: create safer version of strlcpy script\n> replace snprintf with strlcpy without adding extra include\n> replace snprintf with strlcpy\n\nApplied (with 2 rebase changes), thanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B717B1B3D7;\n\tThu, 4 Apr 2019 22:11:35 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n\t[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 076871B3C0\n\tfor <dev@dpdk.org>; Thu, 4 Apr 2019 22:11:34 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 8FE8D27FA4;\n\tThu, 4 Apr 2019 16:11:33 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Thu, 04 Apr 2019 16:11:33 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 8B86AE45F3;\n\tThu, 4 Apr 2019 16:11:32 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=yFQI3gn4zLUrXqFg6RnWIHUVaCjkHZElY6bDVpoYGQk=; b=k+MaTOgETLcp\n\tRkjOnFC2QsdYbDx9ARXxiU9MZvWbltqlvYFd0SDXoult3jnpi4JDuPHC2JOok8/8\n\te854NCLD6gdPcO3sLb9pxT2DNpFZKfpPC6SZO/htnEt1YPCZ5TM1nnjTl89ExRaR\n\tcM+gKQDkupvlObbamI/ZJ4H0i7k+LpM=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=yFQI3gn4zLUrXqFg6RnWIHUVaCjkHZElY6bDVpoYG\n\tQk=; b=4Xjrxpa7b6Mgh3N0MF0jclucECr5j5c9OR5H/ezUgRssZGF6we30/b60D\n\tnuaUufuQoK6sIXY/4ks3tHMlOIyfR+lYmf2wn/9PEBsoY9QCB6PaNEFpT0AHnoe/\n\tsVlTToEeI1QLR8/IgzsBmkoviLzkc2DeN3iSUuhQwAzO03JFo1ujlpU/+0uP48Kh\n\tQqLYFsIi7hRsDJG/mB/t6tG6tJT5KEY/0/igzieK7teNmA9WH1T1MxgeDknS9D/X\n\tOSMQXV3GqAXXFBXMWFUK3VsBEbXfyddGOQT4rL0WYoxeeILdVU548FRVf+QzDN36\n\tU2xnIkb04RcEjHGVYQgfbJS0ROwnw==" ], "X-ME-Sender": "<xms:9WSmXE9iQq5El8z7ctBh9sbjFpJgxyNTeaTaUk-1g0Sf_vUgoukdtg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgddugeegucdltddurdeguddtrddttd\n\tdmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv\n\tpdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih\n\tgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv\n\tnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh\n\tgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm\n\tpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush\n\thtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:9WSmXFjkxUmSK-RZXbDCO0_7xggx4GxaDKEduw5r8wor1kLaS2LhEg>\n\t<xmx:9WSmXAk3sJWSTqwQvEJzKrB07WV_P-yqYkdxU4WVdzQzF5zYQ6zOxg>\n\t<xmx:9WSmXB0ayYcfLaB3CrYhWmBwsL9oZI4X-bCQAMNEz2-JUY_hQj1kVA>\n\t<xmx:9WSmXD0CefzlM8WPVxcjbvuXlNZVh4HbLWUkFN7j_xIefr4UU5r5RQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org", "Date": "Thu, 04 Apr 2019 22:11:31 +0200", "Message-ID": "<2985695.VAqBOLQO3E@xps>", "In-Reply-To": "<20190403144505.46234-1-bruce.richardson@intel.com>", "References": "<20190403144505.46234-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]