Cover Comment List
List cover comments
GET /api/covers/45242/comments/?format=api
[ { "id": 86154, "web_url": "http://patches.dpdk.org/comment/86154/", "msgid": "<81f90cf6-40c9-b89a-b610-e46045dbe37e@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/81f90cf6-40c9-b89a-b610-e46045dbe37e@redhat.com", "date": "2018-09-26T13:51:29", "subject": "Re: [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "Hi Nikolay,\n\nOn 09/24/2018 10:16 PM, Nikolay Nikolaev wrote:\n> vhost: vhost_user.c code cleanup\n> \n> This patchesries introduce a set of code redesigns in vhost_user.c.\n> \n> The goal is to unify and simplify vhost-user message handling. The\n> patches do not intend to introduce any functional changes.\n> \n> v6 changes:\n> - Even more fixes to the usage of struct VhostUserMsg in\n> the patches (Anatoly Burakov)\n> \n> v5 changes:\n> - fixed the usage of struct VhostUserMsg in all patches (Anatoly Burakov)\n> \n> v4 changes:\n> - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)\n> - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)\n> \n> v3 changes:\n> - rebased on top of git://dpdk.org/next/dpdk-next-virtio dead0602\n> - introduce VH_RESULT_FATAL (Maxime Coquelin)\n> - vhost_user_set_features return VH_RESULT_FATAL on failure.\n> This allows keeping the propagate error logic (Ilya Maximets)\n> - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features\n> return VH_RESULT_ERR upon failure\n> - fixed missing break in case VH_RESULT_ERR (Ilya Maximets)\n> - fixed a type on the description of 2/5 patch (Maxime Coquelin)\n> \n> v2 changes:\n> - Fix the comments by Tiwei Bie\n> - Keep the old behavior\n> - Fall through when the callback returns VH_RESULT_ERR\n> - Fall through if the request is out of range\n> \n> ---\n> \n> Nikolay Nikolaev (5):\n> vhost: unify struct VhostUserMsg usage\n> vhost: make message handling functions prepare the reply\n> vhost: handle unsupported message types in functions\n> vhost: unify message handling function signature\n> vhost: message handling implemented as a callback array\n> \n> \n> lib/librte_vhost/vhost_user.c | 394 ++++++++++++++++++++++-------------------\n> 1 file changed, 209 insertions(+), 185 deletions(-)\n> \n> --\n> Signature\n> \n\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nSeries applied to dpdk-next-virtio with small change I suggested in\npatch 5.\n\nThanks for your contribution!\nMaxime", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE3E37D04;\n\tWed, 26 Sep 2018 15:51:35 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 19BCA1E34\n\tfor <dev@dpdk.org>; Wed, 26 Sep 2018 15:51:34 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 655613001244;\n\tWed, 26 Sep 2018 13:51:33 +0000 (UTC)", "from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 78B433091384;\n\tWed, 26 Sep 2018 13:51:31 +0000 (UTC)" ], "To": "Nikolay Nikolaev <nicknickolaev@gmail.com>, anatoly.burakov@intel.com,\n\ttiwei.bie@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org", "References": "<153782013094.27450.17651924330876922486.stgit@T460>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Message-ID": "<81f90cf6-40c9-b89a-b610-e46045dbe37e@redhat.com>", "Date": "Wed, 26 Sep 2018 15:51:29 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<153782013094.27450.17651924330876922486.stgit@T460>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.26", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.45]); Wed, 26 Sep 2018 13:51:33 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]