List comments

GET /api/covers/45242/comments/
Content-Type: application/json
Vary: Accept

        "id": 86154,
        "web_url": "",
        "msgid": "<>",
        "date": "2018-09-26T13:51:29",
        "subject": "Re: [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup",
        "submitter": {
            "id": 512,
            "url": "",
            "name": "Maxime Coquelin",
            "email": ""
        "content": "Hi Nikolay,\n\nOn 09/24/2018 10:16 PM, Nikolay Nikolaev wrote:\n> vhost: vhost_user.c code cleanup\n> \n> This patchesries introduce a set of code redesigns in vhost_user.c.\n> \n> The goal is to unify and simplify vhost-user message handling. The\n> patches do not intend to introduce any functional changes.\n> \n> v6 changes:\n>   - Even more fixes to the usage of struct VhostUserMsg in\n>     the patches (Anatoly Burakov)\n> \n> v5 changes:\n>   - fixed the usage of struct VhostUserMsg in all patches (Anatoly Burakov)\n> \n> v4 changes:\n>   - use struct VhostUserMsg as the coding style guide suggests (Anatoly Burakov)\n>   - VH_RESULT_FATAL is removed as not needed anymore (Maxime Coquelin)\n> \n> v3 changes:\n>   - rebased on top of git:// dead0602\n>   - introduce VH_RESULT_FATAL (Maxime Coquelin)\n>   - vhost_user_set_features return VH_RESULT_FATAL on failure.\n>     This allows keeping the propagate error logic (Ilya Maximets)\n>   - fixed vhost_user_set_vring_kick and vhost_user_set_protocol_features\n>     return VH_RESULT_ERR upon failure\n>   - fixed missing break in case VH_RESULT_ERR (Ilya Maximets)\n>   - fixed a type on the description of 2/5 patch (Maxime Coquelin)\n> \n> v2 changes:\n>   - Fix the comments by Tiwei Bie\n>   - Keep the old behavior\n>     - Fall through when the callback returns VH_RESULT_ERR\n>     - Fall through if the request is out of range\n> \n> ---\n> \n> Nikolay Nikolaev (5):\n>        vhost: unify struct VhostUserMsg usage\n>        vhost: make message handling functions prepare the reply\n>        vhost: handle unsupported message types in functions\n>        vhost: unify message handling function signature\n>        vhost: message handling implemented as a callback array\n> \n> \n>   lib/librte_vhost/vhost_user.c |  394 ++++++++++++++++++++++-------------------\n>   1 file changed, 209 insertions(+), 185 deletions(-)\n> \n> --\n> Signature\n> \n\nReviewed-by: Maxime Coquelin <>\n\nSeries applied to dpdk-next-virtio with small change I suggested in\npatch 5.\n\nThanks for your contribution!\nMaxime",
        "headers": {
            "List-Subscribe": "<>,\n\t<>",
            "Cc": "",
            "X-Original-To": "",
            "Date": "Wed, 26 Sep 2018 15:51:29 +0200",
            "List-Help": "<>",
            "In-Reply-To": "<153782013094.27450.17651924330876922486.stgit@T460>",
            "X-Scanned-By": "MIMEDefang 2.84 on",
            "Message-ID": "<>",
            "X-BeenThere": "",
            "List-Unsubscribe": "<>,\n\t<>",
            "References": "<153782013094.27450.17651924330876922486.stgit@T460>",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "To": "Nikolay Nikolaev <>,,\n\,",
            "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t( []); Wed, 26 Sep 2018 13:51:33 +0000 (UTC)",
            "Errors-To": "",
            "MIME-Version": "1.0",
            "Received": [
                "from [] (localhost [])\n\tby (Postfix) with ESMTP id BE3E37D04;\n\tWed, 26 Sep 2018 15:51:35 +0200 (CEST)",
                "from ( [])\n\tby (Postfix) with ESMTP id 19BCA1E34\n\tfor <>; Wed, 26 Sep 2018 15:51:34 +0200 (CEST)",
                "from\n\t( [])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby (Postfix) with ESMTPS id 655613001244;\n\tWed, 26 Sep 2018 13:51:33 +0000 (UTC)",
                "from [] ( [])\n\tby (Postfix) with ESMTPS id 78B433091384;\n\tWed, 26 Sep 2018 13:51:31 +0000 (UTC)"
            "From": "Maxime Coquelin <>",
            "Precedence": "list",
            "List-Post": "<>",
            "Sender": "\"dev\" <>",
            "Content-Transfer-Encoding": "7bit",
            "Subject": "Re: [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup",
            "List-Archive": "<>",
            "List-Id": "DPDK patches and discussions <>",
            "Content-Language": "en-US",
            "Return-Path": "<>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1",
            "Delivered-To": "",
            "X-Mailman-Version": "2.1.15"