List comments

GET /api/covers/44680/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 85912,
        "web_url": "http://patches.dpdk.org/comment/85912/",
        "msgid": "<9afcf69d-48f6-e0d6-7ea3-e748c713c218@intel.com>",
        "date": "2018-09-21T14:20:51",
        "subject": "Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G\n\tNIC Family DPDK PMD driver",
        "submitter": {
            "id": 324,
            "url": "http://patches.dpdk.org/api/people/324/",
            "name": "Ferruh Yigit",
            "email": "ferruh.yigit@intel.com"
        },
        "content": "On 9/13/2018 1:22 PM, Igor Russkikh wrote:\n> Hello DPDK community!\n> \n> Aquantia would like to contribute PMD for aQtion AQC10X NIC family:\n> https://www.aquantia.com/products/aqtion/chips/\n> These are 10G ethernet NICs with various features.\n> \n> We do base this work on parts of the existing native linux kernel\n> driver source (atlantic). Shared code is hw_atl hardware and registers access module.\n> \n> We'd like to target this driver for 18.11 DPDK release timeline,\n> it'd be good to hear comments from the community on how feasible is this.\n> \n> This patchset implements basic driver infrastructure,\n> vlan offloads, checksumm offloads, rss control,\n> multiring, jumbo frames and other features.\n> \n> Later on, we plan to share HW MACSEC offloads, rxflows and other features.\n\nHello!\n\nWelcome to DPDK, thanks for contributing.\n\nI have checked first patch, there are some fundamental build issues related to\nhow patch split. I will stop reviewing for now until next version which can be\nbuilt.\n\nPlease check comments on first patch.\n\nThanks,\nferruh",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<1536841371-12431-1-git-send-email-igor.russkikh@aquantia.com>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.54,285,1534834800\"; d=\"scan'208\";a=\"71844210\"",
            "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1",
            "Openpgp": "preference=signencrypt",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=utf-8",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F26732BA3;\n\tFri, 21 Sep 2018 16:20:54 +0200 (CEST)",
                "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 391E71DA4\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 16:20:54 +0200 (CEST)",
                "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Sep 2018 07:20:52 -0700",
                "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39])\n\t([10.237.221.39])\n\tby fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 07:20:51 -0700"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G\n\tNIC Family DPDK PMD driver",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Content-Language": "en-US",
            "Message-ID": "<9afcf69d-48f6-e0d6-7ea3-e748c713c218@intel.com>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Fri, 21 Sep 2018 15:20:51 +0100",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "pavel.belous@aquantia.com",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "In-Reply-To": "<1536841371-12431-1-git-send-email-igor.russkikh@aquantia.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Igor Russkikh <igor.russkikh@aquantia.com>, dev@dpdk.org",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Errors-To": "dev-bounces@dpdk.org"
        }
    },
    {
        "id": 85918,
        "web_url": "http://patches.dpdk.org/comment/85918/",
        "msgid": "<7d4268da-6e8c-6e3c-47f4-c99f0a53d83f@redhat.com>",
        "date": "2018-09-21T14:43:12",
        "subject": "Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G\n\tNIC Family DPDK PMD driver",
        "submitter": {
            "id": 598,
            "url": "http://patches.dpdk.org/api/people/598/",
            "name": "Kevin Traynor",
            "email": "ktraynor@redhat.com"
        },
        "content": "On 09/13/2018 01:22 PM, Igor Russkikh wrote:\n> Hello DPDK community!\n> \n> Aquantia would like to contribute PMD for aQtion AQC10X NIC family:\n> https://www.aquantia.com/products/aqtion/chips/\n> These are 10G ethernet NICs with various features.\n> \n> We do base this work on parts of the existing native linux kernel\n> driver source (atlantic). Shared code is hw_atl hardware and registers access module.\n> \n\nHi Igor,\n\nThe link in the contributing guide [1] says \"The DPDK uses the Open\nSource BSD-3-Clause license for the core libraries and drivers.\" There\nseems to be some GPL only licensed files in the patchset. There are\nother examples where dual licensing is used, so perhaps that's an option\nfor you.\n\n[1] http://doc.dpdk.org/guides/contributing/patches.html#source-license\nhttp://git.dpdk.org/dpdk/tree/license/README\n\n+cc Hemant\n\nKevin.\n\n\n> We'd like to target this driver for 18.11 DPDK release timeline,\n> it'd be good to hear comments from the community on how feasible is this.\n> \n> This patchset implements basic driver infrastructure,\n> vlan offloads, checksumm offloads, rss control,\n> multiring, jumbo frames and other features.\n> \n> Later on, we plan to share HW MACSEC offloads, rxflows and other features.\n> \n> version 2 changes:\n> - fixed build on freebsd (no ETIME const)\n> - fixed a bunch of checkpatch failures and warnings\n> - removed extra CFLAGS disabled warning\n> - making static arrays const\n> \n> Igor Russkikh (11):\n>   net/atlantic: documentation and rel notes\n>   net/atlantic: logging macroes and some typedefs\n>   net/atlantic: hw_atl register declarations\n>   net/atlantic: b0 hardware layer main logic\n>   net/atlantic: firmware operations layer\n>   net/atlantic: hardware register access routines\n>   net/atlantic: rte device start, stop, initial configuration\n>   net/atlantic: RSS and RETA manipulation API\n>   net/atlantic: LED control DPDK and private APIs\n>   net/atlantic: device statistics, xstats\n>   net/atlantic: RX side structures and implementation\n> \n> Pavel Belous (10):\n>   net/atlantic: atlantic PMD driver skeleton\n>   net/atlantic: link status and interrupt management\n>   net/atlantic: add hw adapter structures and defines\n>   net/atlantic: flow control configuration\n>   net/atlantic: MAC address manipulations\n>   net/atlantic: eeprom and register manipulation routines\n>   net/atlantic: promisc and allmulti configuration\n>   net/atlantic: VLAN filters and offloads\n>   net/atlantic: device MTU and statuses\n>   net/atlantic: TX side structures and implementation\n> \n>  config/common_base                                |    9 +\n>  doc/guides/nics/atlantic.rst                      |   59 +\n>  doc/guides/nics/features/atlantic.ini             |   37 +\n>  doc/guides/nics/index.rst                         |    1 +\n>  doc/guides/rel_notes/release_18_11.rst            |    5 +\n>  drivers/net/Makefile                              |    2 +\n>  drivers/net/atlantic/Makefile                     |   46 +\n>  drivers/net/atlantic/atl_common.h                 |   96 +\n>  drivers/net/atlantic/atl_ethdev.c                 | 1751 +++++++++++++++\n>  drivers/net/atlantic/atl_ethdev.h                 |  133 ++\n>  drivers/net/atlantic/atl_hw_regs.c                |   52 +\n>  drivers/net/atlantic/atl_hw_regs.h                |   53 +\n>  drivers/net/atlantic/atl_logs.h                   |   68 +\n>  drivers/net/atlantic/atl_rxtx.c                   | 1365 ++++++++++++\n>  drivers/net/atlantic/atl_types.h                  |  235 ++\n>  drivers/net/atlantic/hw_atl/hw_atl_b0.c           |  510 +++++\n>  drivers/net/atlantic/hw_atl/hw_atl_b0.h           |   40 +\n>  drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h  |  145 ++\n>  drivers/net/atlantic/hw_atl/hw_atl_llh.c          | 1490 +++++++++++++\n>  drivers/net/atlantic/hw_atl/hw_atl_llh.h          |  714 ++++++\n>  drivers/net/atlantic/hw_atl/hw_atl_llh_internal.h | 2407 +++++++++++++++++++++\n>  drivers/net/atlantic/hw_atl/hw_atl_utils.c        |  942 ++++++++\n>  drivers/net/atlantic/hw_atl/hw_atl_utils.h        |  510 +++++\n>  drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c   |  618 ++++++\n>  drivers/net/atlantic/meson.build                  |   28 +\n>  drivers/net/atlantic/rte_pmd_atlantic.c           |   19 +\n>  drivers/net/atlantic/rte_pmd_atlantic.h           |   44 +\n>  drivers/net/atlantic/rte_pmd_atlantic_version.map |    4 +\n>  drivers/net/meson.build                           |    1 +\n>  mk/rte.app.mk                                     |    1 +\n>  30 files changed, 11385 insertions(+)\n>  create mode 100644 doc/guides/nics/atlantic.rst\n>  create mode 100644 doc/guides/nics/features/atlantic.ini\n>  create mode 100644 drivers/net/atlantic/Makefile\n>  create mode 100644 drivers/net/atlantic/atl_common.h\n>  create mode 100644 drivers/net/atlantic/atl_ethdev.c\n>  create mode 100644 drivers/net/atlantic/atl_ethdev.h\n>  create mode 100644 drivers/net/atlantic/atl_hw_regs.c\n>  create mode 100644 drivers/net/atlantic/atl_hw_regs.h\n>  create mode 100644 drivers/net/atlantic/atl_logs.h\n>  create mode 100644 drivers/net/atlantic/atl_rxtx.c\n>  create mode 100644 drivers/net/atlantic/atl_types.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.c\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh.c\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh_internal.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.c\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.h\n>  create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\n>  create mode 100644 drivers/net/atlantic/meson.build\n>  create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.c\n>  create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.h\n>  create mode 100644 drivers/net/atlantic/rte_pmd_atlantic_version.map\n>",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<1536841371-12431-1-git-send-email-igor.russkikh@aquantia.com>",
            "X-Mailman-Version": "2.1.15",
            "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13",
            "Date": "Fri, 21 Sep 2018 15:43:12 +0100",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=utf-8",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]); Fri, 21 Sep 2018 14:43:15 +0000 (UTC)",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0CF2920BD;\n\tFri, 21 Sep 2018 16:43:18 +0200 (CEST)",
                "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id C2D561DA4\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 16:43:15 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1ED80C04F4C4;\n\tFri, 21 Sep 2018 14:43:15 +0000 (UTC)",
                "from ktraynor.remote.csb (ovpn-117-185.ams2.redhat.com\n\t[10.36.117.185])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CC1B860924;\n\tFri, 21 Sep 2018 14:43:13 +0000 (UTC)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G\n\tNIC Family DPDK PMD driver",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Message-ID": "<7d4268da-6e8c-6e3c-47f4-c99f0a53d83f@redhat.com>",
            "Precedence": "list",
            "From": "Kevin Traynor <ktraynor@redhat.com>",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Organization": "Red Hat",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "pavel.belous@aquantia.com, Hemant Agrawal <hemant.agrawal@nxp.com>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<1536841371-12431-1-git-send-email-igor.russkikh@aquantia.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Igor Russkikh <igor.russkikh@aquantia.com>, dev@dpdk.org"
        }
    }
]