Cover Comment List
List cover comments
GET /api/covers/43868/comments/?format=api
[ { "id": 84945, "web_url": "http://patches.dpdk.org/comment/84945/", "msgid": "<20180824074627.3415e05b@xeon-e3>", "list_archive_url": "https://inbox.dpdk.org/dev/20180824074627.3415e05b@xeon-e3", "date": "2018-08-24T14:46:27", "subject": "Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live\n\tchanges allowed", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Fri, 24 Aug 2018 15:25:34 +0100\nAlejandro Lucero <alejandro.lucero@netronome.com> wrote:\n\n> The original patch assumes all NICs can safely change or set the MAC\n> in any case. However, this is not always true. NFP depends on the firmware\n> capabilities and this is not always supported. There are other NICs with\n> this same limitation, although, as far as I know, not in DPDK. Linux kernel\n> has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for\n> allowing or not live MAC changes\n\nThe semantic in Linux is different than what I think you are trying to do.\nSome devices can not change MAC address at all because of hardware or hypervisor\nrestrictions. Other devices can not change address while device is up (started\nin DPDK API).\n\nWith Linux the policy was to assume by default device could change address while up.\nAnd then let a few virtual devices allow it.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 820605F21;\n\tFri, 24 Aug 2018 16:46:32 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 73B465F17\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 16:46:30 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id d9-v6so1194038plr.2\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 07:46:30 -0700 (PDT)", "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tz22-v6sm12500623pgc.67.2018.08.24.07.46.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 24 Aug 2018 07:46:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=WmnSHU3HBqq+79oxXffq5oA1L1saZiA1A8zlJchhVDk=;\n\tb=0O2+TYFLRj1NL/lfRkm9I1grrCS6cixXcOgxOrCiLRBpWtJFZIl0NktW1Txg1GAfvE\n\tNKMPi7iZZhmm7rnSURT2GD5/c7Jkgb/0ZdLb13N0l+aBPdw1uNu/2659SREKUNKmPaDt\n\t2Picj2g8O5u5HF6fBMJBQE8rU5uspDDKrbm0s3fDT2DxvQJWhPmaWR1l0V+B6lblEAX0\n\tipSRGXFwpyxg22W8/4NC3JlDXZTIXJlEbGkvsBb69FKNvJIgGr98T9g2hj7vr1GUvKZN\n\tADlE/HsdbTbtM1ItzQUZR//cel3eJBypGprkuR32OKJIWfsD6QHZZ8tn5HToG5mkSDr/\n\tY9IA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=WmnSHU3HBqq+79oxXffq5oA1L1saZiA1A8zlJchhVDk=;\n\tb=jdBr0bw/suwgWC3yM4J4RyL77SHEM1bLg/lfk1SYo7djX33z5EIF2tkeIsWZkB+cPN\n\twcie9BeT7BZXT/8l8psQY6Lw4tkWT3/jlryvOo/0/KSw0sxVzK9yXol6jV4660QJRgf/\n\t9K+rE3ALL4lcBV2SbykB/DV7+Z6QcdSYfN3gTouQyfOEsU+tAXu/kMe3PtHVrLvpJeg+\n\t8G2ixp58vjGJKCRuR/2Cf161F3mv/B8F7XSiwjzDI9DKvlsAISujpZ3SEQnmyEJRKEce\n\tDX8R1RXWPluUfdC+n9APBtFjNU0xcrBpLR1vSxsUU6J02q9Q7bNvqxP8SNUfgvx8gqc/\n\t3SKw==", "X-Gm-Message-State": "APzg51CbKoiqs2oce8HZdtPRy2oAC3BcnyxMNGQpIaqHfx/w8vW2E9xx\n\thRkRbGrY6lh3j6Duyh1clrV1RQ==", "X-Google-Smtp-Source": "ANB0VdbqYa1wvFgcV5T7Yq5WyTkZehn/o1XJq+/KICACv4ZWBtSEvs9UNQsPfXl6uqtWBEXMT7rKWA==", "X-Received": "by 2002:a17:902:934c:: with SMTP id\n\tg12-v6mr2012535plp.67.1535121989675; \n\tFri, 24 Aug 2018 07:46:29 -0700 (PDT)", "Date": "Fri, 24 Aug 2018 07:46:27 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Alejandro Lucero <alejandro.lucero@netronome.com>", "Cc": "dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com", "Message-ID": "<20180824074627.3415e05b@xeon-e3>", "In-Reply-To": "<1535120736-785-1-git-send-email-alejandro.lucero@netronome.com>", "References": "<1535120736-785-1-git-send-email-alejandro.lucero@netronome.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live\n\tchanges allowed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84974, "web_url": "http://patches.dpdk.org/comment/84974/", "msgid": "<ba5919c7-bd56-9ffb-f644-c91c92c99385@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ba5919c7-bd56-9ffb-f644-c91c92c99385@intel.com", "date": "2018-08-27T12:37:59", "subject": "Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live\n\tchanges allowed", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 8/24/2018 3:25 PM, Alejandro Lucero wrote:\n> This is a patched to fix a functionality coming with the first public\n> release: changing/setting MAC address.\n> \n> The original patch assumes all NICs can safely change or set the MAC\n> in any case. However, this is not always true. NFP depends on the firmware\n> capabilities and this is not always supported. There are other NICs with\n> this same limitation, although, as far as I know, not in DPDK. Linux kernel\n> has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for\n> allowing or not live MAC changes.\n> \n> The flag proposed in this patch is just the opposite: advertise if live\n> change not supported and assuming it is supported other way.\n> \n> Although most NICs support rte_eth_dev_default_mac_addr_set and this\n> function returns and error when live change is not supported, note that\n> this function is invoked during port start but the value returned is not\n> checked. It is likely this is good enough for most of the cases, but\n> bonding is relying on this start then mac set/change, and a PMD ports is\n> not properly configured for being used as an slave port in some bonding\n> modes.\n> \n> v2:\n> - add RTE_ETH_DEV_NOLIVE_MAC_ADDR comment in rte_eth_dev_default_mac_addr_set doc\n> - add rte_eth_dev_start change in release API changes\n> \n> v3:\n> - merge doc API changes with first patch\n> - comment behaviour change in rte_eth_dev_start\n> - remove comment on rte_eth_dev_default_mac_addr_set\n\nSeries applied to dpdk-next-net/master, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 188D158FA;\n\tMon, 27 Aug 2018 14:38:05 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 7E26158CB;\n\tMon, 27 Aug 2018 14:38:03 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2018 05:38:01 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56])\n\t([10.237.221.56])\n\tby orsmga007.jf.intel.com with ESMTP; 27 Aug 2018 05:38:00 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,295,1531810800\"; d=\"scan'208\";a=\"68165168\"", "To": "Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org", "Cc": "stable@dpdk.org", "References": "<1535120736-785-1-git-send-email-alejandro.lucero@netronome.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Message-ID": "<ba5919c7-bd56-9ffb-f644-c91c92c99385@intel.com>", "Date": "Mon, 27 Aug 2018 13:37:59 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<1535120736-785-1-git-send-email-alejandro.lucero@netronome.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live\n\tchanges allowed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]