Cover Comment List
List cover comments
GET /api/covers/43776/comments/?format=api
[ { "id": 84799, "web_url": "http://patches.dpdk.org/comment/84799/", "msgid": "<20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com", "date": "2018-08-20T09:15:33", "subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "content": "Hi Jeff,\n\nOn Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote:\n> As we may know that the process of hotplug is different between igb_uio\n> and vfio. For igb_uio, it could use uevent notification and memory\n> failure handle mechanism for hotplug. But for vfio, when device is be\n> hotplug-out, the uevent can not be detected immediately, because of the\n> vfio kernel module will use a special mechanism to guaranty the pci\n> device would not be deleted until the user space release the resources,\n> so it will use another event “req notifier” at first to notify user space\n> to release resources for hotplug.\n> \n> This patch will add a new interrupt type of req notifier in eal interrupt,\n> and add the new interrupt handler in pci device to handle the req device\n> event. When the req notifier be detected, it can trigger the device event\n> callback process to process for hotplug. With this mechanism, hotplug\n> could be enable in vfio.\n> \n\nThe REQ event seems VFIO specific.\nWhy not leave it within the PCI bus, around the vfio glue, and leave the\nEAL unmodified?\n\n> Jeff Guo (5):\n> eal: add a new req notifier to eal interrupt\n> eal: add a new req event to device event\n> eal: modify device event callback process func\n> pci: add req handler field to generic pci device\n> vfio: enable vfio hotplug by req notifier handler\n> \n> drivers/bus/pci/linux/pci_vfio.c | 104 +++++++++++++++++++++\n> drivers/bus/pci/pci_common.c | 10 ++\n> drivers/bus/pci/rte_bus_pci.h | 1 +\n> lib/librte_eal/common/eal_common_dev.c | 5 +-\n> lib/librte_eal/common/eal_private.h | 12 ---\n> lib/librte_eal/common/include/rte_dev.h | 20 +++-\n> lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n> lib/librte_eal/linuxapp/eal/eal_dev.c | 2 +-\n> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++++++++++++++\n> lib/librte_ethdev/rte_ethdev.c | 3 +-\n> 10 files changed, 212 insertions(+), 17 deletions(-)\n> \n> -- \n> 2.7.4\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A84B3230;\n\tMon, 20 Aug 2018 11:15:54 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 051A52E41\n\tfor <dev@dpdk.org>; Mon, 20 Aug 2018 11:15:52 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id k5-v6so822533wre.10\n\tfor <dev@dpdk.org>; Mon, 20 Aug 2018 02:15:52 -0700 (PDT)", "from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t185-v6sm16710629wmy.38.2018.08.20.02.15.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 20 Aug 2018 02:15:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Sp/ZJJQlf1c+54yMJTIkEI9IrZEERctdqRmc0Ctv5Dg=;\n\tb=o+Mk+jiOom7c+oTnrp76p13fYNlQ37Gp20ng3aXIHJadwMc1gwDs5l4IXurZpyDJnA\n\tCYBV6yHACg55ghJD+1YtmGoAyGre0WMkqy7nRMW/lU3Dh2mANkqWxruKJQ4ECTU7YeFy\n\tf8e7M7EYkTdfGr3sQyVFPyJM8jQceU4hXX1O1Op3AYxTtuklJExRCxApFdvSg6r1qaeM\n\tG0jauZTucPcX43X5dZVMNh4G6bFHutj+9+zW77bds//D7nBX6DSdGhiYLHnJ4vQG3upD\n\tF/PDYIX44UrFb8uRuqFLSDfOe2L/RvibOZZ2SHzo1seE8cbc4r/UxfBKe40+3JU35joq\n\tvHkw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Sp/ZJJQlf1c+54yMJTIkEI9IrZEERctdqRmc0Ctv5Dg=;\n\tb=IOy78/Ib6RSwvhSyAtYWNzudXLSQmyjya8+TLNQNxspN+rOd3tg5FqUd2yIyMJSHBY\n\tGlTauhvc0ACAEh7qVoglHqWesDSTpo4kJLfrKfn0k53YfDVXLAPFNvhexecbZ3cKb75D\n\tcVxbTwn/Hz811PGNBxof0xkFy7Ive4it7iPSWQvCTaWglF3eNIKLweRpbOhhFg1SRVY2\n\tebl0OYrK4cSItx8U+/U3uj+atP5uw0ajV8Hx7BnvqpIiV0ho7hDdnkFS5gSVTWLo2sLr\n\t+2fuFqWBwQ99+Ekk7cM9UMwE/tFGrzM0IzahtHAtuykpd9rjw7jCMkm2qYvG1AFBBEw7\n\tNrAw==", "X-Gm-Message-State": "APzg51CauNYN47SzHL+Vz+7kYuZi3V54xDzWondFicjTrq1OUtoKjSO1\n\t9vdwkvHo8JepubSPWiXCP0BTsQ==", "X-Google-Smtp-Source": "ANB0VdYhVuJet0yzV5R1n1TQVuw74xkTLc/ZsgO3qxbAwpDOA8vYtfxZK03a0IcPsr11eFvR6E7cig==", "X-Received": "by 2002:adf:ce90:: with SMTP id\n\tr16-v6mr6743013wrn.112.1534756552485; \n\tMon, 20 Aug 2018 02:15:52 -0700 (PDT)", "Date": "Mon, 20 Aug 2018 11:15:33 +0200", "From": "=?iso-8859-1?q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>", "To": "Jeff Guo <jia.guo@intel.com>", "Cc": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tjingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com,\n\tmatan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, arybchenko@solarflare.com,\n\tjblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\thelin.zhang@intel.com", "Message-ID": "<20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "User-Agent": "NeoMutt/20170113 (1.7.2)", "Subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84812, "web_url": "http://patches.dpdk.org/comment/84812/", "msgid": "<1c5769b1-e196-a209-e19e-b0ea4cb51c4a@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1c5769b1-e196-a209-e19e-b0ea4cb51c4a@intel.com", "date": "2018-08-21T06:45:32", "subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "hi, gaetan\n\n\nOn 8/20/2018 5:15 PM, Gaëtan Rivet wrote:\n> Hi Jeff,\n>\n> On Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote:\n>> As we may know that the process of hotplug is different between igb_uio\n>> and vfio. For igb_uio, it could use uevent notification and memory\n>> failure handle mechanism for hotplug. But for vfio, when device is be\n>> hotplug-out, the uevent can not be detected immediately, because of the\n>> vfio kernel module will use a special mechanism to guaranty the pci\n>> device would not be deleted until the user space release the resources,\n>> so it will use another event “req notifier” at first to notify user space\n>> to release resources for hotplug.\n>>\n>> This patch will add a new interrupt type of req notifier in eal interrupt,\n>> and add the new interrupt handler in pci device to handle the req device\n>> event. When the req notifier be detected, it can trigger the device event\n>> callback process to process for hotplug. With this mechanism, hotplug\n>> could be enable in vfio.\n>>\n> The REQ event seems VFIO specific.\n> Why not leave it within the PCI bus, around the vfio glue, and leave the\n> EAL unmodified?\n\nSorry i don' t see if there are any problem. Firstly, as we can see the \neal interrupt type, it cover the ext/uio/vfio/dev event types, which are \nnot general for all platform/bus/driver type.\nso i think base on the current framework, the interrupt type structure \nshould be considerate as combined set, it could extend for other adding \ninterrupts case by case. And secondly, i don't know what\nis your way about leave it within the PCI bus, because i need to use the \neal interrupt epoll to process this req interrupt which is familiar with \nother interrupts. What do you think about that, if you still\nhave better suggestion, please detail it for clarify.\n\n>> Jeff Guo (5):\n>> eal: add a new req notifier to eal interrupt\n>> eal: add a new req event to device event\n>> eal: modify device event callback process func\n>> pci: add req handler field to generic pci device\n>> vfio: enable vfio hotplug by req notifier handler\n>>\n>> drivers/bus/pci/linux/pci_vfio.c | 104 +++++++++++++++++++++\n>> drivers/bus/pci/pci_common.c | 10 ++\n>> drivers/bus/pci/rte_bus_pci.h | 1 +\n>> lib/librte_eal/common/eal_common_dev.c | 5 +-\n>> lib/librte_eal/common/eal_private.h | 12 ---\n>> lib/librte_eal/common/include/rte_dev.h | 20 +++-\n>> lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n>> lib/librte_eal/linuxapp/eal/eal_dev.c | 2 +-\n>> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++++++++++++++\n>> lib/librte_ethdev/rte_ethdev.c | 3 +-\n>> 10 files changed, 212 insertions(+), 17 deletions(-)\n>>\n>> -- \n>> 2.7.4\n>>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A52552BF1;\n\tTue, 21 Aug 2018 08:45:41 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 9024298\n\tfor <dev@dpdk.org>; Tue, 21 Aug 2018 08:45:40 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Aug 2018 23:45:39 -0700", "from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.71])\n\t([10.67.68.71])\n\tby orsmga001.jf.intel.com with ESMTP; 20 Aug 2018 23:45:34 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,268,1531810800\"; d=\"scan'208\";a=\"83538370\"", "To": "=?utf-8?q?Ga=C3=ABtan_Rivet?= <gaetan.rivet@6wind.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>\n\t<20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com>", "Cc": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tjingjing.wu@intel.com, \n\tthomas@monjalon.net, motih@mellanox.com, matan@mellanox.com,\n\tharry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, \n\tbernard.iremonger@intel.com, arybchenko@solarflare.com,\n\tjblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\thelin.zhang@intel.com", "From": "Jeff Guo <jia.guo@intel.com>", "Message-ID": "<1c5769b1-e196-a209-e19e-b0ea4cb51c4a@intel.com>", "Date": "Tue, 21 Aug 2018 14:45:32 +0800", "User-Agent": "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0", "MIME-Version": "1.0", "In-Reply-To": "<20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84817, "web_url": "http://patches.dpdk.org/comment/84817/", "msgid": "<20180821081742.admyo7ba4evqho2u@bidouze.vm.6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180821081742.admyo7ba4evqho2u@bidouze.vm.6wind.com", "date": "2018-08-21T08:17:42", "subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "content": "On Tue, Aug 21, 2018 at 02:45:32PM +0800, Jeff Guo wrote:\n> hi, gaetan\n> \n> \n> On 8/20/2018 5:15 PM, Gaëtan Rivet wrote:\n> > Hi Jeff,\n> > \n> > On Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote:\n> > > As we may know that the process of hotplug is different between igb_uio\n> > > and vfio. For igb_uio, it could use uevent notification and memory\n> > > failure handle mechanism for hotplug. But for vfio, when device is be\n> > > hotplug-out, the uevent can not be detected immediately, because of the\n> > > vfio kernel module will use a special mechanism to guaranty the pci\n> > > device would not be deleted until the user space release the resources,\n> > > so it will use another event “req notifier” at first to notify user space\n> > > to release resources for hotplug.\n> > > \n> > > This patch will add a new interrupt type of req notifier in eal interrupt,\n> > > and add the new interrupt handler in pci device to handle the req device\n> > > event. When the req notifier be detected, it can trigger the device event\n> > > callback process to process for hotplug. With this mechanism, hotplug\n> > > could be enable in vfio.\n> > > \n> > The REQ event seems VFIO specific.\n> > Why not leave it within the PCI bus, around the vfio glue, and leave the\n> > EAL unmodified?\n> \n> Sorry i don' t see if there are any problem. Firstly, as we can see the eal\n> interrupt type, it cover the ext/uio/vfio/dev event types, which are not\n> general for all platform/bus/driver type.\n> so i think base on the current framework, the interrupt type structure\n> should be considerate as combined set, it could extend for other adding\n> interrupts case by case. And secondly, i don't know what\n> is your way about leave it within the PCI bus, because i need to use the eal\n> interrupt epoll to process this req interrupt which is familiar with other\n> interrupts. What do you think about that, if you still\n> have better suggestion, please detail it for clarify.\n> \n\nAh, yes, unfortunately you're right.\nThere is a genericization effort going on for the EAL, but these parts\nare still depending on the interrupts being reworked. So for now, not\nmuch can be done to avoid it.\n\n> > > Jeff Guo (5):\n> > > eal: add a new req notifier to eal interrupt\n> > > eal: add a new req event to device event\n> > > eal: modify device event callback process func\n> > > pci: add req handler field to generic pci device\n> > > vfio: enable vfio hotplug by req notifier handler\n> > > \n> > > drivers/bus/pci/linux/pci_vfio.c | 104 +++++++++++++++++++++\n> > > drivers/bus/pci/pci_common.c | 10 ++\n> > > drivers/bus/pci/rte_bus_pci.h | 1 +\n> > > lib/librte_eal/common/eal_common_dev.c | 5 +-\n> > > lib/librte_eal/common/eal_private.h | 12 ---\n> > > lib/librte_eal/common/include/rte_dev.h | 20 +++-\n> > > lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n> > > lib/librte_eal/linuxapp/eal/eal_dev.c | 2 +-\n> > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++++++++++++++\n> > > lib/librte_ethdev/rte_ethdev.c | 3 +-\n> > > 10 files changed, 212 insertions(+), 17 deletions(-)\n> > > \n> > > -- \n> > > 2.7.4\n> > > \n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DBB672C38;\n\tTue, 21 Aug 2018 10:18:02 +0200 (CEST)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n\t[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 75B1D98\n\tfor <dev@dpdk.org>; Tue, 21 Aug 2018 10:18:01 +0200 (CEST)", "by mail-wr1-f65.google.com with SMTP id u12-v6so15067634wrr.4\n\tfor <dev@dpdk.org>; Tue, 21 Aug 2018 01:18:01 -0700 (PDT)", "from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tw4-v6sm10427236wrl.46.2018.08.21.01.17.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 21 Aug 2018 01:18:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=4M6AkwTPw3M8F7a+/r96ysDjf4lfK+Q/iDM0MUc1nQ8=;\n\tb=SGe1PlFEZS+LHBMP3l9WAV3aisO70hGa3Jxh4jNF3oeK+HlVD/pC7jea/024eyYtT4\n\tajaz6YavUGMIvMWbQfFznDUoQB9VHq557/O/yLtl5mfIt7D830vbvcjeNYsn2AUOq8cE\n\tjQC4B8AS3tbzgBkAI7PKE2UVh+GnhmUl8InL3Ey7Qbb3lTRSs9hRYQ21okkFJytInvZP\n\tRCqqC2dTYdmPL77oaD0V091jBgFH1KHWMbxrwVorWy7Gx47Ns66jQpzQicQRZqfXQ9R6\n\tbTMYebZVIrGwWfPn/9mH8pGsDO7MNLHHp3Lg2FruSo5y+O+abvZxglXIJ3zZsOi4Gebw\n\t6Ndg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=4M6AkwTPw3M8F7a+/r96ysDjf4lfK+Q/iDM0MUc1nQ8=;\n\tb=JEt1zfkxTxXlamoGjP9Oml3ztTIucBesS9j0I4qYzmvrfLDkr4qvxQTxm191FAkrf7\n\t58EG/Wfe3PS76/d0fnnI4UQQUGeGfcV9L7TZ/dzJ9UhJ0XTBymIs3qTholRQoQ2sNZpW\n\t29C3EOu3stl4tGz3gtBbEEMc8cRBrwRCDFrkObPMu+fB7EZZobFvC5dlH4BHBz+gJUJP\n\tQRigsLUKio48Tj61PDfOYzAF3di3bwrcEZR2MDcr7t8UlZsapYMIrZLV94xOviU3zKaf\n\t2keKC6eZvyxqVlCadub6taO+o9RQHmtzqXpiSgENsR+wVp6v+gEOzLfAxGEYnHj2OYhP\n\tYveA==", "X-Gm-Message-State": "AOUpUlEsUzCgoL/VoDU8ukOT9DYNCMhSl1pEl3rmXqisbZEjY3rcA/DG\n\tgA6j/4RhP0pL12llkDIAdwwslQ==", "X-Google-Smtp-Source": "AA+uWPwDHxI8XC8hjmQRhCXNR6C4jVS8S9le+4Dv1PjmbdUk+v1Er1q4QNz4UU3szt1pjFH8BfQWJQ==", "X-Received": "by 2002:adf:a789:: with SMTP id\n\tj9-v6mr31146126wrc.277.1534839481088; \n\tTue, 21 Aug 2018 01:18:01 -0700 (PDT)", "Date": "Tue, 21 Aug 2018 10:17:42 +0200", "From": "=?iso-8859-1?q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>", "To": "Jeff Guo <jia.guo@intel.com>", "Cc": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tjingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com,\n\tmatan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, arybchenko@solarflare.com,\n\tjblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\thelin.zhang@intel.com", "Message-ID": "<20180821081742.admyo7ba4evqho2u@bidouze.vm.6wind.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>\n\t<20180820091533.yl2wzmvzfxqwo2po@bidouze.vm.6wind.com>\n\t<1c5769b1-e196-a209-e19e-b0ea4cb51c4a@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<1c5769b1-e196-a209-e19e-b0ea4cb51c4a@intel.com>", "User-Agent": "NeoMutt/20170113 (1.7.2)", "Subject": "Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86530, "web_url": "http://patches.dpdk.org/comment/86530/", "msgid": "<1538484140-96886-1-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538484140-96886-1-git-send-email-jia.guo@intel.com", "date": "2018-10-02T12:42:16", "subject": "[dpdk-dev] [PATCH v2 0/4] Enable hotplug in vfio", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "As we may know that the process of hotplug is different between igb_uio\nand vfio. For igb_uio, it could use uevent notification and memory\nfailure handle mechanism for hot-unplug. But for vfio, when device is be\nhot-unplugged, the uevent can not be detected immediately, because of the\nvfio kernel module will use a special mechanism to guaranty the pci\ndevice would not be deleted until the user space release the resources,\nso it will use another event “req notifier” at first to notify user space\nto release resources for hotplug.\n\nThis patch will add a new interrupt type of req notifier in eal interrupt,\nand add the new interrupt handler in pci device to handle the req device\nevent. When the req notifier be detected, it can trigger the device event\ncallback process to process for hot-unplug. With this mechanism, hotplug\ncould be enable in vfio.\n\npatchset history:\nv3->v2:\nchange some commit log and coding style and typo.\n\nv2->v1:\nchange the rte_dev_event_callback_prcess from internal to external api\nfor bus or app usage.\nchange some code logic.\n\nJeff Guo (4):\n eal: add a new req notifier to eal interrupt\n eal: modify device event callback process func\n pci: add req handler field to generic pci device\n vfio: enable vfio hotplug by req notifier handler\n\n app/test-pmd/testpmd.c | 4 +-\n drivers/bus/pci/linux/pci_vfio.c | 111 +++++++++++++++++++++\n drivers/bus/pci/pci_common.c | 10 ++\n drivers/bus/pci/rte_bus_pci.h | 1 +\n lib/librte_eal/bsdapp/eal/eal_dev.c | 8 ++\n lib/librte_eal/common/eal_common_dev.c | 5 +-\n lib/librte_eal/common/eal_private.h | 12 ---\n lib/librte_eal/common/include/rte_dev.h | 18 +++-\n lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n lib/librte_eal/linuxapp/eal/eal_dev.c | 2 +-\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 +++++++++++++\n lib/librte_eal/rte_eal_version.map | 1 +\n 12 files changed, 226 insertions(+), 18 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 692324CA6;\n\tTue, 2 Oct 2018 14:38:40 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id D40E44C96\n\tfor <dev@dpdk.org>; Tue, 2 Oct 2018 14:38:38 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2018 05:38:37 -0700", "from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.110.10])\n\tby fmsmga008.fm.intel.com with ESMTP; 02 Oct 2018 05:38:34 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,331,1534834800\"; d=\"scan'208\";a=\"75507759\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, \n\tarybchenko@solarflare.com, anatoly.burakov@intel.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com", "Date": "Tue, 2 Oct 2018 20:42:16 +0800", "Message-Id": "<1538484140-96886-1-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 0/4] Enable hotplug in vfio", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86533, "web_url": "http://patches.dpdk.org/comment/86533/", "msgid": "<1538485138-98076-1-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538485138-98076-1-git-send-email-jia.guo@intel.com", "date": "2018-10-02T12:58:54", "subject": "[dpdk-dev] [PATCH v3 0/4] Enable hotplug in vfio", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "As we may know that the process of hotplug is different between igb_uio\nand vfio. For igb_uio, it could use uevent notification and memory\nfailure handle mechanism for hot-unplug. But for vfio, when device is be\nhot-unplugged, the uevent can not be detected immediately, because of the\nvfio kernel module will use a special mechanism to guaranty the pci\ndevice would not be deleted until the user space release the resources,\nso it will use another event “req notifier” at first to notify user space\nto release resources for hotplug.\n\nThis patch will add a new interrupt type of req notifier in eal interrupt,\nand add the new interrupt handler in pci device to handle the req device\nevent. When the req notifier be detected, it can trigger the device event\ncallback process to process for hot-unplug. With this mechanism, hotplug\ncould be enable in vfio.\n\npatchset history:\nv3->v2:\nchange some commit log and coding style and typo.\n\nv2->v1:\nchange the rte_dev_event_callback_prcess from internal to external api\nfor bus or app usage.\nchange some code logic.\n\nJeff Guo (4):\n eal: add a new req notifier to eal interrupt\n eal: modify device event callback process func\n pci: add req handler field to generic pci device\n vfio: enable vfio hotplug by req notifier handler\n\n app/test-pmd/testpmd.c | 4 +-\n drivers/bus/pci/linux/pci_vfio.c | 111 +++++++++++++++++++++\n drivers/bus/pci/pci_common.c | 10 ++\n drivers/bus/pci/rte_bus_pci.h | 1 +\n lib/librte_eal/bsdapp/eal/eal_dev.c | 8 ++\n lib/librte_eal/common/eal_common_dev.c | 5 +-\n lib/librte_eal/common/eal_private.h | 12 ---\n lib/librte_eal/common/include/rte_dev.h | 18 +++-\n lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n lib/librte_eal/linuxapp/eal/eal_dev.c | 2 +-\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 +++++++++++++\n lib/librte_eal/rte_eal_version.map | 1 +\n 12 files changed, 226 insertions(+), 18 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 746B84F90;\n\tTue, 2 Oct 2018 14:55:18 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id C9B842C19\n\tfor <dev@dpdk.org>; Tue, 2 Oct 2018 14:55:16 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2018 05:55:15 -0700", "from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.110.10])\n\tby fmsmga001.fm.intel.com with ESMTP; 02 Oct 2018 05:55:12 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,332,1534834800\"; d=\"scan'208\";a=\"95315491\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, \n\tarybchenko@solarflare.com, anatoly.burakov@intel.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com", "Date": "Tue, 2 Oct 2018 20:58:54 +0800", "Message-Id": "<1538485138-98076-1-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 0/4] Enable hotplug in vfio", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]