Cover Comment List
List cover comments
GET /api/covers/43561/comments/?format=api
[ { "id": 84530, "web_url": "http://patches.dpdk.org/comment/84530/", "msgid": "<10744998.R0yrloUo0b@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/10744998.R0yrloUo0b@xps", "date": "2018-08-03T14:06:31", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "03/08/2018 15:36, Adrien Mazarguil:\n> Adrien Mazarguil (7):\n> ethdev: add flow API object converter\n> ethdev: add flow API item/action name conversion\n> app/testpmd: rely on flow API conversion function\n> net/failsafe: switch to flow API object conversion function\n> net/bonding: switch to flow API object conversion function\n> ethdev: deprecate rte_flow_copy function\n> ethdev: add missing item/actions to flow object converter\n\nThis series will be considered for 18.11.\n\nAs you plan to deprecate rte_flow_copy function, please send a deprecation\nnotice which could enter in 18.08 release notes.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EBC031B5DC;\n\tFri, 3 Aug 2018 16:06:40 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 844B71B5E2\n\tfor <dev@dpdk.org>; Fri, 3 Aug 2018 16:06:38 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 19938219E6;\n\tFri, 3 Aug 2018 10:06:38 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Fri, 03 Aug 2018 10:06:38 -0400", "from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 07389E4AEE;\n\tFri, 3 Aug 2018 10:06:36 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=mesmtp; bh=CrZdE/SV8uD2EIZL765CghFcGg\n\tmhVUj6jnd3IbzVsYM=; b=juCz1Z/52LCI8goswwP0je+jiwVamK0uYdtpEKWOgH\n\tzZE4uqkUue5ItyfIKHFN95QnBuk5WhdvSurMbfYzzuvSYIqybIQXXdG0J2C3pzq6\n\t6N10c3lgu8klTVCjsKW970FGiIrvVvKb8ewI+KvW9MLTmo50sDZH2SVbCzTWUID+\n\tg=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CrZdE/\n\tSV8uD2EIZL765CghFcGgmhVUj6jnd3IbzVsYM=; b=RDDE2Acq3UiSEoGZNJq7qW\n\tZwRjytDEHB3ZntLzyJ5ZBODP9BDg8T9ntwJxJfFQRAbuiXObMQuCX7QAhZbDDZH7\n\tvdGYn/cj08GpV7RmGjE2Ugkr+AsJ/0fLem7jNVgTkbWvdbpEEM9By8ihWU8fcURu\n\tTzb5cKcMcbE+OrlXYzXZuaLLlW1+eBMXZ5lrXIPZs4DJ1X3y3xabO4OETp7Z8uvY\n\t74iIM++G/cwvh63Du+/0Yg0nC8xlK98/c7K25gcUpAb0vYkpQDeQcQL1QuEaKbJA\n\tFtA/qcXiK8f/8GS+vkiZhSX9ZNH8s9nnKmUWBQwbpVdyc9QvapLG2PhzcOVPntPA\n\t==" ], "X-ME-Proxy": "<xmx:bWFkW6r7FTCFnPZjf7GAagkXolW6ixlYxSBLw5psbJMs1RCpbc5Ldg>\n\t<xmx:bWFkW_nkwZ8g-V4srahjj95cfcF6ZLcvoWq4ekBi8JAcaaSFYRN8pA>\n\t<xmx:bWFkW1rfksgKCUuVH8tr57Z2clS5NWJ5elfhT1PmV0Wf7WjWqR0pjg>\n\t<xmx:bWFkW4b-no_YRyo_ahw-VZ-x-JDbEfVSR14lW7df8Dt2xBE6lsRQNg>\n\t<xmx:bWFkW7HyqwRMDNgy2PO6edTPgTwaDKlBH8AlXjwoM9Gpfcp6kwR0NQ>\n\t<xmx:bmFkWz3dswxrsYVqVipa6gYqp5mX7eEkEfaEP9DIVQCD3L75fOiUiQ>", "X-ME-Sender": "<xms:bWFkW385jFcvCZ-dJP39tY2n11I32KciWCJFCC2zGjD0ViObLYHHkw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tarybchenko@solarflare.com", "Date": "Fri, 03 Aug 2018 16:06:31 +0200", "Message-ID": "<10744998.R0yrloUo0b@xps>", "In-Reply-To": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84883, "web_url": "http://patches.dpdk.org/comment/84883/", "msgid": "<30a6f2d0-1f0c-c549-9fd1-7e1782990943@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/30a6f2d0-1f0c-c549-9fd1-7e1782990943@intel.com", "date": "2018-08-23T13:48:37", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 8/3/2018 2:36 PM, Adrien Mazarguil wrote:\n> This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> almost a year ago [1]. The new title is due to the reduced scope of this\n> version.\n> \n> rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> temporary solution pending something better [2]. It replaces a lot of\n> duplicated code found in testpmd and removes some of the maintenance burden\n> that developers tend to forget (me included) when modifying pattern\n> item or actions (updating app/test-pmd/config.c to be clear).\n> \n> This series was unearthed in order to complete the implementation of\n> RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> duplicate existing code once again.\n> \n> See individual patches for specific changes in this version.\n> \n> v2 changes:\n> \n> - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact.\n> - Updated bonding PMD.\n> - No more automatic generation of rte_flow_conv.h.\n> \n> [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html\n> [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html\n> [3] Currently the command-line parser (cmdline_flow.c) is aware of these\n> actions, however config.c isn't. Flow rules with such actions cannot\n> be created and cannot be validated with PMDs that implement them.\n> \n> Adrien Mazarguil (7):\n> ethdev: add flow API object converter\n> ethdev: add flow API item/action name conversion\n> app/testpmd: rely on flow API conversion function\n> net/failsafe: switch to flow API object conversion function\n> net/bonding: switch to flow API object conversion function\n> ethdev: deprecate rte_flow_copy function\n> ethdev: add missing item/actions to flow object converter\n\nPatch needs to be rebased to target v18.11 (in map file), and indeed new APIs\n(rte_flow_conv) needs to be experimental.\n\nAnd needs to remove deprecation notice in this patchset.\nAlso do you think does make sense to announce this change in release notes?\n\nApart from above, any volunteer for reviewing actual implementation?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9D6692C4F;\n\tThu, 23 Aug 2018 15:48:42 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 376762C38\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 15:48:40 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2018 06:48:39 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56])\n\t([10.237.221.56])\n\tby orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 06:48:37 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,278,1531810800\"; d=\"scan'208\";a=\"84306745\"", "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "dev@dpdk.org", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Message-ID": "<30a6f2d0-1f0c-c549-9fd1-7e1782990943@intel.com>", "Date": "Thu, 23 Aug 2018 14:48:37 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84932, "web_url": "http://patches.dpdk.org/comment/84932/", "msgid": "<d73363e1-198a-cfa6-8152-c8777d75c884@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d73363e1-198a-cfa6-8152-c8777d75c884@intel.com", "date": "2018-08-24T10:58:39", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 8/3/2018 2:36 PM, Adrien Mazarguil wrote:\n> This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> almost a year ago [1]. The new title is due to the reduced scope of this\n> version.\n> \n> rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> temporary solution pending something better [2]. It replaces a lot of\n> duplicated code found in testpmd and removes some of the maintenance burden\n> that developers tend to forget (me included) when modifying pattern\n> item or actions (updating app/test-pmd/config.c to be clear).\n> \n> This series was unearthed in order to complete the implementation of\n> RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> duplicate existing code once again.\n> \n> See individual patches for specific changes in this version.\n> \n> v2 changes:\n> \n> - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact.\n> - Updated bonding PMD.\n> - No more automatic generation of rte_flow_conv.h.\n> \n> [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html\n> [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html\n> [3] Currently the command-line parser (cmdline_flow.c) is aware of these\n> actions, however config.c isn't. Flow rules with such actions cannot\n> be created and cannot be validated with PMDs that implement them.\n> \n> Adrien Mazarguil (7):\n> ethdev: add flow API object converter\n> ethdev: add flow API item/action name conversion\n> app/testpmd: rely on flow API conversion function\n> net/failsafe: switch to flow API object conversion function\n> net/bonding: switch to flow API object conversion function\n> ethdev: deprecate rte_flow_copy function\n> ethdev: add missing item/actions to flow object converter\n\nCausing build error for arm, it looks like related to rte_memcpy macro:\n\n.../lib/librte_ethdev/rte_flow.c: In function ‘rte_flow_conv_item_spec’:\n.../lib/librte_ethdev/rte_flow.c:373:58: error: macro \"rte_memcpy\" passed 9\narguments, but takes just 3\n (size > sizeof(*dst.raw) ? sizeof(*dst.raw) : size));\n ^", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 57DA82C4F;\n\tFri, 24 Aug 2018 12:58:44 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 8ADFF2C0C\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 12:58:42 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Aug 2018 03:58:41 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56])\n\t([10.237.221.56])\n\tby orsmga007.jf.intel.com with ESMTP; 24 Aug 2018 03:58:40 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,281,1531810800\"; d=\"scan'208\";a=\"67547100\"", "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,\n\tGavin Hu <gavin.hu@linaro.org>", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Message-ID": "<d73363e1-198a-cfa6-8152-c8777d75c884@intel.com>", "Date": "Fri, 24 Aug 2018 11:58:39 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84981, "web_url": "http://patches.dpdk.org/comment/84981/", "msgid": "<20180827141219.GE3695@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180827141219.GE3695@6wind.com", "date": "2018-08-27T14:12:19", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "submitter": { "id": 165, "url": "http://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "content": "On Fri, Aug 24, 2018 at 11:58:39AM +0100, Ferruh Yigit wrote:\n> On 8/3/2018 2:36 PM, Adrien Mazarguil wrote:\n> > This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> > almost a year ago [1]. The new title is due to the reduced scope of this\n> > version.\n> > \n> > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> > temporary solution pending something better [2]. It replaces a lot of\n> > duplicated code found in testpmd and removes some of the maintenance burden\n> > that developers tend to forget (me included) when modifying pattern\n> > item or actions (updating app/test-pmd/config.c to be clear).\n> > \n> > This series was unearthed in order to complete the implementation of\n> > RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> > duplicate existing code once again.\n> > \n> > See individual patches for specific changes in this version.\n> > \n> > v2 changes:\n> > \n> > - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact.\n> > - Updated bonding PMD.\n> > - No more automatic generation of rte_flow_conv.h.\n> > \n> > [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html\n> > [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html\n> > [3] Currently the command-line parser (cmdline_flow.c) is aware of these\n> > actions, however config.c isn't. Flow rules with such actions cannot\n> > be created and cannot be validated with PMDs that implement them.\n> > \n> > Adrien Mazarguil (7):\n> > ethdev: add flow API object converter\n> > ethdev: add flow API item/action name conversion\n> > app/testpmd: rely on flow API conversion function\n> > net/failsafe: switch to flow API object conversion function\n> > net/bonding: switch to flow API object conversion function\n> > ethdev: deprecate rte_flow_copy function\n> > ethdev: add missing item/actions to flow object converter\n> \n> Causing build error for arm, it looks like related to rte_memcpy macro:\n> \n> .../lib/librte_ethdev/rte_flow.c: In function ‘rte_flow_conv_item_spec’:\n> .../lib/librte_ethdev/rte_flow.c:373:58: error: macro \"rte_memcpy\" passed 9\n> arguments, but takes just 3\n> (size > sizeof(*dst.raw) ? sizeof(*dst.raw) : size));\n\nThanks, noticed it after sending v2. I'll fix it for v3.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD63D4CAB;\n\tMon, 27 Aug 2018 16:12:37 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 672FD4CA7\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 16:12:36 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id z96-v6so13784452wrb.8\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 07:12:36 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t20-v6sm16679351wmu.21.2018.08.27.07.12.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 27 Aug 2018 07:12:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=RkDKs1yc8Z8AaH4AYzo7rurU7taV/7iyKrDJYElDCyg=;\n\tb=HDBSh9SL7D3Ji0NVKIVeu2eUeGg1WO1gtrqm2mHl0Le5NMHzj9JSZBibVl1j7lHDY7\n\tUyoj8MHvaiqaVOlIGVikCf5ips7sWLLAFW0eFFLvfLXFgGl1YsRMs/iApRC6cxRpgRBw\n\tr0mAZdOPrWSwy6lOrH0jd6mamptx8B0u9ypoYrKTbWDo6i1z53FXUCJyjSIe0uXzZGnS\n\tP75GF0S9UhcGj7ot+HATRYJFcMYLg0Wd2IZZMz6Pp2/ZATBRBzE0WLJFWqyTVNMZsxVm\n\tZRrGkwiDF068t9iCaiZrvkvjfED7bmqzoooTUi8Q2X6ukKN/Z0wch94j/w/crI1g0ya7\n\tA/Yw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=RkDKs1yc8Z8AaH4AYzo7rurU7taV/7iyKrDJYElDCyg=;\n\tb=o+WpSDZmHPLd726Cpnf5SVHvp9Ejnoy4Lmr7/uHCK0t4R+Q1ieAmtUzgz4x6SdQBnQ\n\tPMJ4Y0uI2awyjOy2dpdYohTWtkx53I8xQnBd+76JixGq2LMdB91mb7gq4iv3V5r6LbLp\n\tBVggPFoR8yfq0JgMt6juXW2n/5BKXh8HCo04tWkt/YyZX4QKgx+E4Q/G4PuklRd9hrc8\n\t8FY5eLGcBXTRT925xAUSpJZQ1e7BGPSO7NpnN4zmWwitcbJ+qrYeK8RVeJXIyCJUHbmb\n\tjH2JHNF9wacFeTaBIjxrp/nFUU7DVMd4zvYBkObLngjAyXbYhtnYuUjjubJsgTRnnOsw\n\ttlGg==", "X-Gm-Message-State": "APzg51BBeX28noQnQV6dd4FY7KKGugji/J+ZfUowozXMYv3vcOSHQJeO\n\tpffbhbYveHw5noVXOjXTnlnWsA==", "X-Google-Smtp-Source": "ANB0VdaJWMorgJZPYJKN0k97egxWwH/QLNGCM9Nld9kMVFscY0VLHmipjv/LD/OfEUgvYssO4p2kDQ==", "X-Received": "by 2002:a5d:5248:: with SMTP id\n\tp8-v6mr8866677wrv.198.1535379156226; \n\tMon, 27 Aug 2018 07:12:36 -0700 (PDT)", "Date": "Mon, 27 Aug 2018 16:12:19 +0200", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,\n\tGavin Hu <gavin.hu@linaro.org>", "Message-ID": "<20180827141219.GE3695@6wind.com>", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>\n\t<d73363e1-198a-cfa6-8152-c8777d75c884@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<d73363e1-198a-cfa6-8152-c8777d75c884@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 84984, "web_url": "http://patches.dpdk.org/comment/84984/", "msgid": "<20180827151402.GF3695@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180827151402.GF3695@6wind.com", "date": "2018-08-27T15:14:02", "subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "submitter": { "id": 165, "url": "http://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "content": "On Thu, Aug 23, 2018 at 02:48:37PM +0100, Ferruh Yigit wrote:\n> On 8/3/2018 2:36 PM, Adrien Mazarguil wrote:\n> > This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> > almost a year ago [1]. The new title is due to the reduced scope of this\n> > version.\n> > \n> > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> > temporary solution pending something better [2]. It replaces a lot of\n> > duplicated code found in testpmd and removes some of the maintenance burden\n> > that developers tend to forget (me included) when modifying pattern\n> > item or actions (updating app/test-pmd/config.c to be clear).\n> > \n> > This series was unearthed in order to complete the implementation of\n> > RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> > duplicate existing code once again.\n> > \n> > See individual patches for specific changes in this version.\n> > \n> > v2 changes:\n> > \n> > - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact.\n> > - Updated bonding PMD.\n> > - No more automatic generation of rte_flow_conv.h.\n> > \n> > [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html\n> > [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html\n> > [3] Currently the command-line parser (cmdline_flow.c) is aware of these\n> > actions, however config.c isn't. Flow rules with such actions cannot\n> > be created and cannot be validated with PMDs that implement them.\n> > \n> > Adrien Mazarguil (7):\n> > ethdev: add flow API object converter\n> > ethdev: add flow API item/action name conversion\n> > app/testpmd: rely on flow API conversion function\n> > net/failsafe: switch to flow API object conversion function\n> > net/bonding: switch to flow API object conversion function\n> > ethdev: deprecate rte_flow_copy function\n> > ethdev: add missing item/actions to flow object converter\n> \n> Patch needs to be rebased to target v18.11 (in map file),\n\nRight, will do it for v3.\n\n> and indeed new APIs\n> (rte_flow_conv) needs to be experimental.\n\nThis is what I did at first. Problem is that experimental APIs cannot be\nused in internal code without triggering a compilation error unless\nALLOW_EXPERIMENTAL_API is defined (bonding cannot rely on an API marked as\nexperimental).\n\nSince this series reimplements rte_flow_copy() as a wrapper to\nrte_flow_conv(), I thought it didn't make sense for internal code to keep\nusing the former either.\n\nConsidering this, shall I add -DDALLOW_EXPERIMENTAL_API to bonding PMD or\nkeep things not experimental?\n\n> And needs to remove deprecation notice in this patchset.\n\nDoesn't it make sense to deprecate this function immediately after providing\na replacement on top of which it is reimplemented? Users end up using the\nnew function whether they want it or not. I don't think maintaining the\nold duplicated code around is the right thing to do either.\n\n> Also do you think does make sense to announce this change in release notes?\n\nI'm not sure it's worth a release note. It's a rather obscure helper\nfunction part of rte_flow. We didn't do it for rte_flow_copy() for\ninstance. Please confirm if you think it's needed.\n\n> Apart from above, any volunteer for reviewing actual implementation?\n\nI hope Gaetan will take a look, he added rte_flow_copy() after all :)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B904B4F93;\n\tMon, 27 Aug 2018 17:14:21 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B16F94F90\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 17:14:19 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id u12-v6so12675396wrr.4\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 08:14:19 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\ts2-v6sm14009307wrn.83.2018.08.27.08.14.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 27 Aug 2018 08:14:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=FGfa/v4vGHlqtf4nalFXN+z3wzjV3MA/yVviLWGK+tw=;\n\tb=kCDLgy/p5kBXAWRf9QQ10e2bbrd6ouPO4DfiEHjZDQOr2fr8awJ8UkLuFCyV/Jixfc\n\tsQWoiMUM+Q119fb4CClKYPXrmwp1k23cdG+w5fB9tPszrbOPvMUUqAna55javV0HHcEI\n\tApAw+15ihyM87qoNml7PIe9M6DMpqdbPneqV5+fTDLqaHoGfQ7mPLfXWGcz8d/oreimI\n\tGYLE3UDUb96v98JzxrdtIKVfIWz4X42mpcGimtmVNERY7GrT/geVUiOlrBUPbJkOAVPx\n\t2RR0eBDRUP6VF7VdYxnFsWVYXnuzlZDsguPzVEai4cwl12dcCagkEFvh50/mjGPVj01l\n\tZukw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=FGfa/v4vGHlqtf4nalFXN+z3wzjV3MA/yVviLWGK+tw=;\n\tb=rfhBKfVT4TDTgbDngR5Z6wRwjA8fw7TSvXZCNd9wvxkdI3JYeASn0hUNxDTiVV7lsN\n\t3TfxcPBchhySSjTNWlC5b3hvXnnPkPet/y2ykSop3cLW87D+UP5YJnnFo1UAE/ExcTOZ\n\tZaf2xEoDSBEXQ8pBhv/5bjZFVlw8nBMD1KlqDNRr40+0Yy7oQlM0EsxSQ9WhU53pTqNH\n\t9l2+N/APRi4WEK7KcIhSE9ux5fyLEJGRHdcr4jqVJqD6Vxa1eGphA3k40lwVmW/LLRK9\n\tDv2/01gbDtvMTRyZLTYq26hirVcc0D8ubDZrRkWzC9gSAtKqJSgVjTiXgZ4xshU/USW+\n\tJTUQ==", "X-Gm-Message-State": "APzg51Bh7IurgUYk4dlbwLh3IWEuAYDTxZU/cl0fC5EAWuFgyrvYGILu\n\tyGLMJP+coHr0/ttv6BTgP36bqA==", "X-Google-Smtp-Source": "ANB0VdaUqoksbnHONoyTBmL89EBrs61CCWTlZ8AfHYUEoEsVyAXZuW4dcTTT8hwCLwwXqaefAhIyYQ==", "X-Received": "by 2002:adf:a11c:: with SMTP id\n\to28-v6mr9131851wro.169.1535382859401; \n\tMon, 27 Aug 2018 08:14:19 -0700 (PDT)", "Date": "Mon, 27 Aug 2018 17:14:02 +0200", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org", "Message-ID": "<20180827151402.GF3695@6wind.com>", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>\n\t<30a6f2d0-1f0c-c549-9fd1-7e1782990943@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<30a6f2d0-1f0c-c549-9fd1-7e1782990943@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]