List comments

GET /api/covers/43472/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 84367,
        "web_url": "http://patches.dpdk.org/comment/84367/",
        "msgid": "<20180731164840.GD5211@6wind.com>",
        "date": "2018-07-31T16:48:40",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 165,
            "url": "http://patches.dpdk.org/api/people/165/",
            "name": "Adrien Mazarguil",
            "email": "adrien.mazarguil@6wind.com"
        },
        "content": "On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:\n> Declaring variables as register in C is a leftover from an earlier\n> era (like cassette tape decks in cars).\n\nI don't agree here. It's a hint for compilers and developers that the\naddress of such variables won't be needed (and cannot be taken) to enable\nwhatever optimizations are possible knowing this.\n\nSomewhat like inline functions, it's not a forced optimization, just a\nuseful hint that shouldn't hurt if used wisely.\n\nBesides, cassette decks are not dead yet :)",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>",
            "X-Mailman-Version": "2.1.15",
            "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=us-ascii",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=uL1VVgjjzSI+8IBoVSMPH3MJYL7NrD3FdohNXPllgYY=;\n\tb=dOXYOhHpBIYXQc9Wbi19v3ZUyms3+Z3x0mENR70wJ9WG4xVmUl+xWSlSUDst49pgNb\n\tUpw+XEQ9e77+lQlVDtZjkRnEPhO7zb2W3LxXOMswgbxEkxHfQyZMssyDL4zXICfUBoRW\n\tYD7JirnJpvagVNOAuj5Nuqd2y93luSHei0HAx6wHWCxLg5tMD9NVEav/5daJvKDxtFJ3\n\t9S8vTncgzRH8MBXu/7piStgZkWGfGdWHC14gbLdZQLp1+o/wkAGIZZuJ1FoaSMm4QMsd\n\tRZgOo7mVXNOQEN70S06manrUoasdt/4VlKqA9/1kYd52eBbUY25kk8UVM6/tQLKiE9pJ\n\tozPw==",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 054B5324D;\n\tTue, 31 Jul 2018 18:48:59 +0200 (CEST)",
                "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 87BD514EC\n\tfor <dev@dpdk.org>; Tue, 31 Jul 2018 18:48:58 +0200 (CEST)",
                "by mail-wm0-f65.google.com with SMTP id r24-v6so11529544wmh.0\n\tfor <dev@dpdk.org>; Tue, 31 Jul 2018 09:48:58 -0700 (PDT)",
                "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\td7-v6sm17234791wro.92.2018.07.31.09.48.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 31 Jul 2018 09:48:57 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "X-Received": "by 2002:a1c:8893:: with SMTP id\n\tk141-v6mr339113wmd.36.1533055738237; \n\tTue, 31 Jul 2018 09:48:58 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=uL1VVgjjzSI+8IBoVSMPH3MJYL7NrD3FdohNXPllgYY=;\n\tb=yba7ubctbI9GHM4c+GlZxM6+t4evT7TwS9c1Khw2smqhrt2hE3Sz60gTD1t6G7HfVQ\n\t9y3HUvWtieJd/qlgLqfsRqFaicbAgy/HAfADYhJlr2Dtsw1Ldf+mGNq0bjsNSDwyec91\n\tZoG3QaGJ4Ml06VZ7TweKwZxNYhM/ifjdaOsrTtSu6FrSxLtWgAR/0JAHR9X7BVrQOimj\n\twXOv8d+toq9msl9zLEi9hE7UDhgUoaP84WraRKsBFoAWp83zDBDKULhLjAZRliRFoZzq\n\tJT2o/SA6yWwcSevbgtje0/OspqqCyLiB0sD/R+a0lQww4zTusXpeMdfn4T/iVt9aONhN\n\thlkA==",
            "Message-ID": "<20180731164840.GD5211@6wind.com>",
            "Precedence": "list",
            "X-Gm-Message-State": "AOUpUlHFh2kQRYHvwUYwsikuQ7KhZL82EKlcwKCncBsNn//t69WZnrbP\n\tCbLu9lXahk0TtztLsCHjUw+QgfkM9MhGTQ==",
            "Date": "Tue, 31 Jul 2018 18:48:40 +0200",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Google-Smtp-Source": "AAOMgpfdxNZhXR486usTCMYKUn76IbB3j9555XcfBupol6Mqh9QA0IFmsshb6caVJo+coV6rkQduZA==",
            "Cc": "dev@dpdk.org",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<20180731163059.27085-1-stephen@networkplumber.org>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "To": "Stephen Hemminger <stephen@networkplumber.org>",
            "Content-Disposition": "inline"
        }
    },
    {
        "id": 84370,
        "web_url": "http://patches.dpdk.org/comment/84370/",
        "msgid": "<20180731110737.38555f02@xeon-e3>",
        "date": "2018-07-31T18:07:37",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 27,
            "url": "http://patches.dpdk.org/api/people/27/",
            "name": "Stephen Hemminger",
            "email": "stephen@networkplumber.org"
        },
        "content": "On Tue, 31 Jul 2018 18:48:40 +0200\nAdrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n\n> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:\n> > Declaring variables as register in C is a leftover from an earlier\n> > era (like cassette tape decks in cars).  \n> \n> I don't agree here. It's a hint for compilers and developers that the\n> address of such variables won't be needed (and cannot be taken) to enable\n> whatever optimizations are possible knowing this.\n> \n> Somewhat like inline functions, it's not a forced optimization, just a\n> useful hint that shouldn't hurt if used wisely.\n> \n> Besides, cassette decks are not dead yet :)\n\nIf you look at the code, that is not how register is being used (ie. don't take\naddress of this). It seems like an attempt at optimization.",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Stephen Hemminger <stephen@networkplumber.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=US-ASCII",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=BfVeCSUVgUb14JJV4iLqIZuDJZ+8I+XYo3XVtmo4vJo=;\n\tb=QRlfh+pNmZLuWbd6VW1rr86YbDecyJNC8MhehSElTDIRWV4hA2p4BtQ1EjbfyUd4Ks\n\tXLNM9HY1+lRHLy2Jz7dsznsxqXZ26gidE2wzWrQp7TUIlyAlcHDCz4zLuQ3AgfojoI26\n\tF//sBquWGNULa/ceM+7PqCWnn+BHVd9tmPtqifLM0nHRIM87+bmjWCyuYdt87Zzh57qo\n\t2XC3EfN+KqqGUpXbdGCpIxWep5s7KJ5mf7/pJRL4h7di8+rP9NtGajv1ssQ0+907zLa9\n\t/dKMt3WOPMh+/EPrPgvJIA/UwicEP1TAXiG41PXi90UlLovRAM0+r6MRtkvuRvooUMso\n\tIAXQ==",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 017EB44C3;\n\tTue, 31 Jul 2018 20:07:44 +0200 (CEST)",
                "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 3818D37A2\n\tfor <dev@dpdk.org>; Tue, 31 Jul 2018 20:07:42 +0200 (CEST)",
                "by mail-pg1-f195.google.com with SMTP id f1-v6so9463686pgq.12\n\tfor <dev@dpdk.org>; Tue, 31 Jul 2018 11:07:42 -0700 (PDT)",
                "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tj191-v6sm31526711pfc.136.2018.07.31.11.07.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 31 Jul 2018 11:07:40 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "X-Received": "by 2002:a63:5fc1:: with SMTP id\n\tt184-v6mr20749079pgb.183.1533060461187; \n\tTue, 31 Jul 2018 11:07:41 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=BfVeCSUVgUb14JJV4iLqIZuDJZ+8I+XYo3XVtmo4vJo=;\n\tb=xNhXq3CuvkRJdgPk0Sr8oLwE9jeN+p1V3c/4ftUFoMsiz6CdIn6agkaeluttJ4Ddib\n\tN6NDhGRPwHF/CDUj7lc6gmRw2sgiovoKhBTygpS9L3/1y2lOoFFn1k7xjVXkj/5ttgfT\n\tuJP7F01MinGgqTZLYQoQ0idGm1bCqDfeVufFr5RYv05wqSskB2D+vZj3SaQeSg353/la\n\tsIB17kpF3ddySlMwbTkKqL+265KljOMCNk4TfcNP0bJ+w5lVEB8dNqAgKM3ZIXRiew/H\n\tDSd0BamPpnPU+nR7G6Pd2VmMcKSKqBs626fNYYMHyBgUlyqT8cbpqeC6RNJIuvnMYMdH\n\t4p5w==",
            "Message-ID": "<20180731110737.38555f02@xeon-e3>",
            "Precedence": "list",
            "X-Gm-Message-State": "AOUpUlEgxftsnVAgB8BTSz01P3KBQDAevoRMwZP9ytgQK3jQX6KwgfNF\n\tFstuVnK03gvWjffsmhmFDpVw4XJ5Z7c=",
            "Date": "Tue, 31 Jul 2018 11:07:37 -0700",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Google-Smtp-Source": "AAOMgpfVZnGEBUd5O8VKwyNaFNlygf6guTr0PR1tgICLXKfgjZDpmIwoFbkB+0mIwMTpQRsHHMOM/Q==",
            "Cc": "dev@dpdk.org",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<20180731164840.GD5211@6wind.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>"
        }
    },
    {
        "id": 84389,
        "web_url": "http://patches.dpdk.org/comment/84389/",
        "msgid": "<VI1PR0501MB260884B5F17DF586B9C08BCFD22D0@VI1PR0501MB2608.eurprd05.prod.outlook.com>",
        "date": "2018-08-01T10:18:33",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 796,
            "url": "http://patches.dpdk.org/api/people/796/",
            "name": "Matan Azrad",
            "email": "matan@mellanox.com"
        },
        "content": "Hi Stephen\n\nCan you elaborate more?\nCan you add references?\n\n\n> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger\n> Sent: Tuesday, July 31, 2018 7:31 PM\n> To: dev@dpdk.org\n> Cc: Stephen Hemminger <stephen@networkplumber.org>\n> Subject: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C\n> \n> Declaring variables as register in C is a leftover from an earlier era (like\n> cassette tape decks in cars).\n> \n> Stephen Hemminger (5):\n>   qat: remove redundant C register keyword\n>   qede: remove register from declaraitons\n>   ark: remove register keyword\n>   mlx5: no need for register keyword\n>   mlx4: remove redunant register keyword\n> \n>  drivers/common/qat/qat_qp.c     | 10 +++++-----\n>  drivers/crypto/qat/qat_sym.c    |  2 +-\n>  drivers/net/ark/ark_ethdev_rx.c |  4 ++--\n>  drivers/net/mlx4/mlx4_mr.c      |  2 +-\n>  drivers/net/mlx5/mlx5_mr.c      |  2 +-\n>  drivers/net/qede/qede_rxtx.c    |  8 ++++----\n>  6 files changed, 14 insertions(+), 14 deletions(-)\n> \n> --\n> 2.18.0",
        "headers": {
            "X-OriginatorOrg": "Mellanox.com",
            "x-ms-office365-filtering-correlation-id": "c3952a75-0af8-4e8e-8a3f-08d5f79822a0",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>",
            "X-Mailman-Version": "2.1.15",
            "Thread-Index": "AQHUKOvkYHwn2YGO8US4jQgaXcZ946Sqr8yA",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0501MB2096; ",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AA8027CD9;\n\tWed,  1 Aug 2018 12:18:35 +0200 (CEST)",
                "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10048.outbound.protection.outlook.com [40.107.1.48])\n\tby dpdk.org (Postfix) with ESMTP id 454795F65\n\tfor <dev@dpdk.org>; Wed,  1 Aug 2018 12:18:34 +0200 (CEST)",
                "from VI1PR0501MB2608.eurprd05.prod.outlook.com (10.168.137.20) by\n\tVI1PR0501MB2096.eurprd05.prod.outlook.com (10.167.196.12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1017.15; Wed, 1 Aug 2018 10:18:33 +0000",
                "from VI1PR0501MB2608.eurprd05.prod.outlook.com\n\t([fe80::dd44:4544:a34b:7e1d]) by\n\tVI1PR0501MB2608.eurprd05.prod.outlook.com\n\t([fe80::dd44:4544:a34b:7e1d%10]) with mapi id 15.20.1017.010;\n\tWed, 1 Aug 2018 10:18:33 +0000"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ",
            "x-ms-traffictypediagnostic": "VI1PR0501MB2096:",
            "x-exchange-antispam-report-test": "UriScan:;",
            "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016);\n\tSRVR:VI1PR0501MB2096; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2096; ",
            "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
            "Precedence": "list",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "x-ms-office365-filtering-ht": "Tenant",
            "spamdiagnosticoutput": "1:99",
            "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(376002)(346002)(39860400002)(396003)(189003)(199004)(13464003)(316002)(53546011)(6506007)(110136005)(99286004)(186003)(7696005)(106356001)(5660300001)(476003)(102836004)(26005)(446003)(11346002)(74316002)(6116002)(8936002)(3846002)(256004)(2900100001)(486006)(7736002)(305945005)(86362001)(8676002)(81156014)(81166006)(68736007)(25786009)(5250100002)(97736004)(6246003)(14454004)(6436002)(229853002)(2501003)(478600001)(53936002)(105586002)(76176011)(55016002)(9686003)(33656002)(66066001)(2906002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2096;\n\tH:VI1PR0501MB2608.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "x-ms-exchange-antispam-srfa-diagnostics": "SOS;",
            "x-microsoft-antispam-prvs": "<VI1PR0501MB2096353C12652CA7E3462587D22D0@VI1PR0501MB2096.eurprd05.prod.outlook.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Stephen Hemminger <stephen@networkplumber.org>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-microsoft-antispam-message-info": "wpHVqMwY5DACdrO/nZCQ7IcquvfxEWMs0uFkEJhELI3Yrw/X/OX9+7wDWmZMJ44hNljjYHKsKwFpq2JCXwMu5BMNItfNKU6yeyMXDXWng86/APK2Lcikq8wrV90vup0OM92Dc9Ka802LTnAwerSVZO8oG1Us4jCkD1luEf1PvkCcI91W6ZVYwhVuHY27CsRXbMAJ06I67Aj1e43itJM3p2lxq92K/8X6Rw5eSOV/4myYiTbCDV9UIltn3s+D3f3mcofqUgxyciNOxmtj71YybUR9wQZEf/yfRu+qDZ4Whfd7g/zucrXyGZfuAKDwCwlXWAzhG47sjRWnPn4RKHwBCruT3IQ8xqjvNfYZ1VRXsQQ=",
            "MIME-Version": "1.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Date": "Wed, 1 Aug 2018 10:18:33 +0000",
            "x-originating-ip": "[193.47.165.251]",
            "x-ms-publictraffictype": "Email",
            "X-BeenThere": "dev@dpdk.org",
            "Accept-Language": "en-US, he-IL",
            "Message-ID": "<VI1PR0501MB260884B5F17DF586B9C08BCFD22D0@VI1PR0501MB2608.eurprd05.prod.outlook.com>",
            "x-ms-exchange-senderadcheck": "1",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "c3952a75-0af8-4e8e-8a3f-08d5f79822a0",
            "x-microsoft-exchange-diagnostics": "1; VI1PR0501MB2096;\n\t6:bZRTQOZV5PCRTLBp1/KpXsQuzH5HEg9eSNG7EG2f0ddNEbIrecrZ5idXjDPPitE90c2G52RMTmoVA6PROls/N1M8JFzt2rBaPzTVfDXn6lZ5GCMQlCbsvqmr0lnN+n5Itk0tQAwyMVMikdLAc3EFn1RxKju91y5aLV2vyJAHOPnZrXUos2pLYbquP5zOr0rvLRPQQCdjK4HilziDVjYaRr0ydmxHqXkcCehQIBOdmvRKq7goLK7ZlVIEZeCIR2/kXBonbCq4UKpdRbyOuk3rNjSvfvwprxv68iaXpJjtO0Qjyd18qdFLP9iAA5PGXTeUBekPMiJIraJEp6Bdz1RRj/q5KEJm5Sj7i0/YXzz57sTBMtZa/ISnqFXA+vL9TNqDllnLOqk3aR3XzgaPflxzfTVcIesAiTk/J4hAGKw62E65ASBsdTrb3LF0DTmDUMOgAtPVsKjkP2cjhTfDpeu6aA==;\n\t5:dRXsdAoYYSlahvpJFEO+OJHZWGrnDJgc7ldFpFQiz9agb1wWKiPrtjosT3CG/BdZcrQzZ19LNu2wXyGOM88slwIPWT+xinyS8Jf8tz8BE6mjX+Fdhm1e+jDINxQvtibSg0kRs7eqsIQWJjcc1zMOoKeL+W8gGyUXHTcXdnr6O3Y=;\n\t7:yk/nveS5wWiJ98l7BA1EwMLTUOohwAU1Kj69CEnoU6LdQzCD5nbzF85IoeneF2RYh38VHDLpRjF3ZXqMd2TXXDDqCZ3RqYZHz6fo9yyELUuO3NKgyObqRy8YgEz0sNTf/WcpDShB1MestqWbAJS+TE4YOYFWfaTEYzxfMHSDZTrjlbEEeBnRHjKOA1ZlQT8FFZcWtpnnVOoUMUQp+xFYa6RGSid6wOCkj16Zs6A8T+aNJM1nqi1xD6FqDXqVnWa7",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "Content-Language": "en-US",
            "From": "Matan Azrad <matan@mellanox.com>",
            "X-MS-Has-Attach": "",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0501MB2096",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=5gbbVe6kAU6mNdPSnvCSE0+01VuytiEdSMlgYMAif1k=;\n\tb=JDSZzfufXqOLccCato6q6oTwglWH323ElXjkX92b2E4aGrlMWS83XG4fQp19dRLqcP9/8Rj2NlOvo65Yl0zXszykRDttAKrlp9OqiM+pW80C2oYhk67miqWp2urB1UP3HooGP2mHEG6jMe+nbhqOwgU6aZybCQHBQkqpie40gIE=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "spamdiagnosticmetadata": "NSPM",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "01 Aug 2018 10:18:33.0399\n\t(UTC)",
            "Thread-Topic": "[dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "In-Reply-To": "<20180731163059.27085-1-stephen@networkplumber.org>",
            "x-forefront-prvs": "0751474A44"
        }
    },
    {
        "id": 84435,
        "web_url": "http://patches.dpdk.org/comment/84435/",
        "msgid": "<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>",
        "date": "2018-08-01T18:03:04",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 636,
            "url": "http://patches.dpdk.org/api/people/636/",
            "name": "Yongseok Koh",
            "email": "yskoh@mellanox.com"
        },
        "content": "> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:\n> \n> On Tue, 31 Jul 2018 18:48:40 +0200\n> Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n> \n>> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:\n>>> Declaring variables as register in C is a leftover from an earlier\n>>> era (like cassette tape decks in cars).  \n>> \n>> I don't agree here. It's a hint for compilers and developers that the\n>> address of such variables won't be needed (and cannot be taken) to enable\n>> whatever optimizations are possible knowing this.\n>> \n>> Somewhat like inline functions, it's not a forced optimization, just a\n>> useful hint that shouldn't hurt if used wisely.\n>> \n>> Besides, cassette decks are not dead yet :)\n> \n> If you look at the code, that is not how register is being used (ie. don't take\n> address of this). It seems like an attempt at optimization.\n\nI know compilers are smart enough and the occurrences in mlx4/5 were made from\nmy old fashioned habit. But, I don't see any urgency to push this patch in RC\nstage even though I'm 99% sure that it is harmless. And in general I don't even\nunderstand why we can't live with that if it isn't harmful (or a violation) but\ninformative. I mean no badness but at least one goodness :-)\n\nThanks,\nYongseok",
        "headers": {
            "X-OriginatorOrg": "Mellanox.com",
            "x-ms-office365-filtering-correlation-id": "477acb64-3285-40f6-08af-08d5f7d90737",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>",
            "X-Mailman-Version": "2.1.15",
            "Thread-Index": "AQHUKOvm8fvVdThTyUaSyf8D4BmtkaSpitIAgAAWD4CAAZENAA==",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "CC": "Adrien Mazarguil <adrien.mazarguil@6wind.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:HE1PR0501MB2252; ",
            "Content-ID": "<785EDC668DA45540ADD4AC321F73F944@eurprd05.prod.outlook.com>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 543411B295;\n\tWed,  1 Aug 2018 20:03:08 +0200 (CEST)",
                "from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57])\n\tby dpdk.org (Postfix) with ESMTP id 424FA1B1FB\n\tfor <dev@dpdk.org>; Wed,  1 Aug 2018 20:03:06 +0200 (CEST)",
                "from HE1PR0501MB2043.eurprd05.prod.outlook.com (10.167.245.149) by\n\tHE1PR0501MB2252.eurprd05.prod.outlook.com (10.168.33.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1017.14; Wed, 1 Aug 2018 18:03:04 +0000",
                "from HE1PR0501MB2043.eurprd05.prod.outlook.com\n\t([fe80::d522:78b6:d5c7:c16a]) by\n\tHE1PR0501MB2043.eurprd05.prod.outlook.com\n\t([fe80::d522:78b6:d5c7:c16a%3]) with mapi id 15.20.0995.020;\n\tWed, 1 Aug 2018 18:03:04 +0000"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=yskoh@mellanox.com; ",
            "x-ms-traffictypediagnostic": "HE1PR0501MB2252:",
            "x-exchange-antispam-report-test": "UriScan:;",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "01 Aug 2018 18:03:04.3053\n\t(UTC)",
            "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
            "Precedence": "list",
            "From": "Yongseok Koh <yskoh@mellanox.com>",
            "x-ms-office365-filtering-ht": "Tenant",
            "spamdiagnosticoutput": "1:99",
            "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(136003)(189003)(199004)(256004)(68736007)(7736002)(6916009)(82746002)(106356001)(66066001)(8936002)(6116002)(105586002)(25786009)(305945005)(5250100002)(3846002)(2906002)(6486002)(229853002)(86362001)(33656002)(486006)(2616005)(476003)(11346002)(446003)(99286004)(14454004)(81166006)(81156014)(6512007)(54906003)(6436002)(478600001)(6246003)(83716003)(97736004)(53936002)(5660300001)(2900100001)(8676002)(4326008)(26005)(36756003)(6506007)(53546011)(316002)(186003)(102836004)(76176011);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2252;\n\tH:HE1PR0501MB2043.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "x-ms-exchange-antispam-srfa-diagnostics": "SOS;",
            "x-microsoft-antispam-prvs": "<HE1PR0501MB225236EC4042B33F391EA10FC32D0@HE1PR0501MB2252.eurprd05.prod.outlook.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Stephen Hemminger <stephen@networkplumber.org>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-microsoft-antispam-message-info": "YQ3AR+6c0xYhLAMzuU/NHMgY53lZOzlAve3KpeRHE+8KYF5i4CfP4r4C2ok2Sp9zJJ7eNd2qsLCyL7Yt7GGmg9pwxLQkrx0MxM1+ho+JEZYz5W6qN4GRbj9jVlakHT8NczuqULQ5j8NbByswn1WyirX9Bjy5/i9IzDGLY11vfAw+bPH+8Im63R38ZZ4kgxHzFakUvIm/0cC4fERmAvEYdrXJ+dY6Nt68TQ770ylwSXFUGAFT+LsTM69Obn1sq/1ZVDfXPY9IioW16EmiGCRVyt874Hgw/+NJEYymQP7Vi4TQWBD8U5HpDSXFXx6Q+qx0llvSHRlizaA2s0VbVfNFDPElcW1Nu3VTbZxCpGwhNrI=",
            "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr",
            "MIME-Version": "1.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Date": "Wed, 1 Aug 2018 18:03:04 +0000",
            "x-originating-ip": "[209.116.155.178]",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "x-ms-publictraffictype": "Email",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "Accept-Language": "en-US",
            "Message-ID": "<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>",
            "x-ms-exchange-senderadcheck": "1",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "477acb64-3285-40f6-08af-08d5f7d90737",
            "x-microsoft-exchange-diagnostics": "1; HE1PR0501MB2252;\n\t6:R4WIjsR6PDfDGCnjWSUqFGMzqv7n4pq3m5oFKvv73kWqgZMjH9by27L3AVgga+RFIbnBiYcs/pzdsV0uFw26vHozZAtsIDmqgMV+jIQP13fmHTu8d9oSX4iEUP/7Sx7fekTIWz4ruvRs4pQTHZBQ57Ar79gLGcQKGu4Yfu//loN/8yli3PwdN58EJfQC+Mb6LpIIVwJcyhgxfv5jjXDXyNjibV20AyGTbKOtoYTdDLTQM/yI1FZh+VxOXN+ul8g6dLoMntB2OMGwxhJ/+4t1miUhOuIfGCgNj1ggY7fYpdFidRYWkH9yXukb5Svy/T/JpfxSmNscVERG/uQkI1fp2cKuZShKYCHYhrP+CnEZ6DkXF/lJAcy3xLzb1RsIUTEO0p9WE6qrDAMFVAnia6S3bVPvVXaVJtcbBNusuxaA8Pb90+XOi8ypq3dnQlodDzWancsO3EzwLdK1R2BVJQZ1AA==;\n\t5:scbt8lOBvDN11pQ0NXWRzspKdl+dnt1GXlPwFFKm/NTRjgS4tFSzuiBIRiThbRsvZz2yuDik8LJESPasIXOeVOGcQO5LxlwVi9AGJO0XGNdXUNmqKfRLIhKA8NTT/OWtcdCE3YyF/7P8CqQE777MPjVHmFlF4CmlACXS0oqEsuY=;\n\t7:A3FzoKf00E5IB5npt/DxkDEe4wSSkr/SF8gk+N0NLYTIVT/HtknF/Iy7aqaJJqYc0PUN49vHDgzyE5JrabvfTHBbNaT85uKpyWmqCKA23G4bxXqavOWGEeVlRaiLEkb/7ryCKAdDfaifjjIhKckTvITIHX1Drp9co3bqFbPlTjgcqAKfAvvjhirHFWrDep261Eslv5OhX/L/k8eQA6SRXx27Bqo4ZCk2NU71UjBgSw43u4Id5GqMIGCL+0WbeII2",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "Content-Language": "en-US",
            "X-MS-Has-Attach": "",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0501MB2252",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ufki42htoctEjg6TFARAoI7pMjkIA9Cj5eO7DCKNq24=;\n\tb=K6D2Tnk/MYm5aARrd1K45LE0xa4zcIWZ5dtmMC+EiByshiQSM42XFywylMC22r28emZ3NmcLdqydfV99Jnb4w0onmxtxdFCkN15S6q75zjet9yK1sjJgo/dzBF27Tjm6MYnlOl3Aj+QoEA36LHUeR0rs6DtZMggvGLZEZUDHZEA=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "spamdiagnosticmetadata": "NSPM",
            "Errors-To": "dev-bounces@dpdk.org",
            "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);\n\tSRVR:HE1PR0501MB2252; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2252; ",
            "Thread-Topic": "[dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "In-Reply-To": "<20180731110737.38555f02@xeon-e3>",
            "x-forefront-prvs": "0751474A44"
        }
    },
    {
        "id": 84438,
        "web_url": "http://patches.dpdk.org/comment/84438/",
        "msgid": "<20180801140356.5ac88c43@xeon-e3>",
        "date": "2018-08-01T21:03:56",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 27,
            "url": "http://patches.dpdk.org/api/people/27/",
            "name": "Stephen Hemminger",
            "email": "stephen@networkplumber.org"
        },
        "content": "On Wed, 1 Aug 2018 18:03:04 +0000\nYongseok Koh <yskoh@mellanox.com> wrote:\n\n> > On Jul 31, 2018, at 11:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:\n> > \n> > On Tue, 31 Jul 2018 18:48:40 +0200\n> > Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n> >   \n> >> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:  \n> >>> Declaring variables as register in C is a leftover from an earlier\n> >>> era (like cassette tape decks in cars).    \n> >> \n> >> I don't agree here. It's a hint for compilers and developers that the\n> >> address of such variables won't be needed (and cannot be taken) to enable\n> >> whatever optimizations are possible knowing this.\n> >> \n> >> Somewhat like inline functions, it's not a forced optimization, just a\n> >> useful hint that shouldn't hurt if used wisely.\n> >> \n> >> Besides, cassette decks are not dead yet :)  \n> > \n> > If you look at the code, that is not how register is being used (ie. don't take\n> > address of this). It seems like an attempt at optimization.  \n> \n> I know compilers are smart enough and the occurrences in mlx4/5 were made from\n> my old fashioned habit. But, I don't see any urgency to push this patch in RC\n> stage even though I'm 99% sure that it is harmless. And in general I don't even\n> understand why we can't live with that if it isn't harmful (or a violation) but\n> informative. I mean no badness but at least one goodness :-)\n> \n> Thanks,\n> Yongseok\n> \n\nSure, this is intended for next release not rc stage.\nJust trying to clean up code base where I see it.",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Stephen Hemminger <stephen@networkplumber.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=US-ASCII",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pCXCi2TZaKq0wSLBVQHEWLMX/2hwpVDiZhlJW2xOczg=;\n\tb=kZfroxpv+MJBZlsjpIy4wmrghJXjNB00SQVwAWQbSqurtz22kKQQLBtDV3FiHRW+74\n\tYJ05XPiF+vsvBG2L9Cxm9QboeroE+1ZVil9q6UHQPGvFPwXVpZw+pVee7qLHTmTI7tXB\n\tPFEnXecpiUh3ka0r5uDJ7utqZN1eVSDRw0yTBE58zTEl8YPVHeojXZ0kne2MXsbqDM3z\n\tkhTdFLhTdGoDxAh9/lbuHWMsuvCcG532uZDv4fTB6UDMgaJPDsSLR7uofdz6dJP0Juj7\n\tAPUjEXRVFQ8tGW2rNECAhwsXw3Nqs+cYk+A44NUm0YEBJa5maNvrj6UBdMt0wK9h9AXX\n\tjtiA==",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B39F1B3A2;\n\tWed,  1 Aug 2018 23:04:00 +0200 (CEST)",
                "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id BA26F1B3A1\n\tfor <dev@dpdk.org>; Wed,  1 Aug 2018 23:03:59 +0200 (CEST)",
                "by mail-pg1-f194.google.com with SMTP id n7-v6so4117pgq.4\n\tfor <dev@dpdk.org>; Wed, 01 Aug 2018 14:03:59 -0700 (PDT)",
                "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\te14-v6sm20699057pff.128.2018.08.01.14.03.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 01 Aug 2018 14:03:58 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "X-Received": "by 2002:a63:d946:: with SMTP id e6-v6mr14549pgj.24.1533157438758;\n\tWed, 01 Aug 2018 14:03:58 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pCXCi2TZaKq0wSLBVQHEWLMX/2hwpVDiZhlJW2xOczg=;\n\tb=J82naYrJ6+MnRNHxHWNEa5/K1jB8Dlf/ujxF3gIk72mFDlP0hAJQ/iMdnsMBoFK8L3\n\tkO82lmdZ0PsFyHlNCjq+/Mz6uMWPeyElk1KpDLXljAJcrLtp7q6l6R9Ch1YQFcUs9lcD\n\tfeYh1cEEsSusTEy5XCEL/QOr91GebF+RiahYl3NkskW1PtueG6WdyXd7Cz/i0r7r+VsS\n\t1MD/f1XehrY9z4sskkrD/lJ5q/vf8enneQ3zpfBYD1jMZg0BRcUKjKzG/xGp+ZejeQub\n\tR7EDr/NTT5tuKrvyRvAvhryeSnrhLJe4hTTP6itmR6exzT3EE9VkqZBCbSnhuB9thS7y\n\tA0aQ==",
            "Message-ID": "<20180801140356.5ac88c43@xeon-e3>",
            "Precedence": "list",
            "X-Gm-Message-State": "AOUpUlFwE/dABZyLo2pa/MhlFzxjP+ZRk9BcUkCweNc8VkLrNQAtbfwM\n\t/IfwckME6MtF1iTw+A0oFYccOQ==",
            "Date": "Wed, 1 Aug 2018 14:03:56 -0700",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Google-Smtp-Source": "AAOMgpf7CH/BP8ORcOxqJfbs10He3+BVEhybARKhUgNZTr1t4CnqpqNUCVc/qh96r7weeKSLG5Y71w==",
            "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Yongseok Koh <yskoh@mellanox.com>"
        }
    },
    {
        "id": 84880,
        "web_url": "http://patches.dpdk.org/comment/84880/",
        "msgid": "<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>",
        "date": "2018-08-23T13:07:18",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 324,
            "url": "http://patches.dpdk.org/api/people/324/",
            "name": "Ferruh Yigit",
            "email": "ferruh.yigit@intel.com"
        },
        "content": "On 8/1/2018 10:03 PM, Stephen Hemminger wrote:\n> On Wed, 1 Aug 2018 18:03:04 +0000\n> Yongseok Koh <yskoh@mellanox.com> wrote:\n> \n>>> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:\n>>>\n>>> On Tue, 31 Jul 2018 18:48:40 +0200\n>>> Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n>>>   \n>>>> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:  \n>>>>> Declaring variables as register in C is a leftover from an earlier\n>>>>> era (like cassette tape decks in cars).    \n>>>>\n>>>> I don't agree here. It's a hint for compilers and developers that the\n>>>> address of such variables won't be needed (and cannot be taken) to enable\n>>>> whatever optimizations are possible knowing this.\n>>>>\n>>>> Somewhat like inline functions, it's not a forced optimization, just a\n>>>> useful hint that shouldn't hurt if used wisely.\n>>>>\n>>>> Besides, cassette decks are not dead yet :)  \n>>>\n>>> If you look at the code, that is not how register is being used (ie. don't take\n>>> address of this). It seems like an attempt at optimization.  \n>>\n>> I know compilers are smart enough and the occurrences in mlx4/5 were made from\n>> my old fashioned habit. But, I don't see any urgency to push this patch in RC\n>> stage even though I'm 99% sure that it is harmless. And in general I don't even\n>> understand why we can't live with that if it isn't harmful (or a violation) but\n>> informative. I mean no badness but at least one goodness :-)\n>>\n>> Thanks,\n>> Yongseok\n>>\n> \n> Sure, this is intended for next release not rc stage.\n> Just trying to clean up code base where I see it.\n\nI agree with Yongseok, at worst they show the intention of the developer, I\ndon't see motivation to remove them unless they are doing something wrong, which\nseems not the reason of this patch.\n\nAnd although I found some information that says \"register\" ignored completely\nfor gcc, I can see it differs when optimization disabled.\nI am not saying practically it differs, since we enable optimization expect from\ndebugging, most probably there is no practical difference between having the\nkeyword or not, but what I am trying to say is it not completely ignored either.",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.53,278,1531810800\"; d=\"scan'208\";a=\"84295446\"",
            "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1",
            "Openpgp": "preference=signencrypt",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=utf-8",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 17D734C94;\n\tThu, 23 Aug 2018 15:07:26 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 497572C4F\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 15:07:24 +0200 (CEST)",
                "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2018 06:07:23 -0700",
                "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56])\n\t([10.237.221.56])\n\tby orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 06:07:19 -0700"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Content-Language": "en-US",
            "Message-ID": "<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Thu, 23 Aug 2018 14:07:18 +0100",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "In-Reply-To": "<20180801140356.5ac88c43@xeon-e3>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Stephen Hemminger <stephen@networkplumber.org>,\n\tYongseok Koh <yskoh@mellanox.com>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Errors-To": "dev-bounces@dpdk.org"
        }
    },
    {
        "id": 87095,
        "web_url": "http://patches.dpdk.org/comment/87095/",
        "msgid": "<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>",
        "date": "2018-10-09T09:19:13",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 324,
            "url": "http://patches.dpdk.org/api/people/324/",
            "name": "Ferruh Yigit",
            "email": "ferruh.yigit@intel.com"
        },
        "content": "On 8/23/2018 2:07 PM, Ferruh Yigit wrote:\n> On 8/1/2018 10:03 PM, Stephen Hemminger wrote:\n>> On Wed, 1 Aug 2018 18:03:04 +0000\n>> Yongseok Koh <yskoh@mellanox.com> wrote:\n>>\n>>>> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:\n>>>>\n>>>> On Tue, 31 Jul 2018 18:48:40 +0200\n>>>> Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n>>>>   \n>>>>> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:  \n>>>>>> Declaring variables as register in C is a leftover from an earlier\n>>>>>> era (like cassette tape decks in cars).    \n>>>>>\n>>>>> I don't agree here. It's a hint for compilers and developers that the\n>>>>> address of such variables won't be needed (and cannot be taken) to enable\n>>>>> whatever optimizations are possible knowing this.\n>>>>>\n>>>>> Somewhat like inline functions, it's not a forced optimization, just a\n>>>>> useful hint that shouldn't hurt if used wisely.\n>>>>>\n>>>>> Besides, cassette decks are not dead yet :)  \n>>>>\n>>>> If you look at the code, that is not how register is being used (ie. don't take\n>>>> address of this). It seems like an attempt at optimization.  \n>>>\n>>> I know compilers are smart enough and the occurrences in mlx4/5 were made from\n>>> my old fashioned habit. But, I don't see any urgency to push this patch in RC\n>>> stage even though I'm 99% sure that it is harmless. And in general I don't even\n>>> understand why we can't live with that if it isn't harmful (or a violation) but\n>>> informative. I mean no badness but at least one goodness :-)\n>>>\n>>> Thanks,\n>>> Yongseok\n>>>\n>>\n>> Sure, this is intended for next release not rc stage.\n>> Just trying to clean up code base where I see it.\n> \n> I agree with Yongseok, at worst they show the intention of the developer, I\n> don't see motivation to remove them unless they are doing something wrong, which\n> seems not the reason of this patch.\n> \n> And although I found some information that says \"register\" ignored completely\n> for gcc, I can see it differs when optimization disabled.\n> I am not saying practically it differs, since we enable optimization expect from\n> debugging, most probably there is no practical difference between having the\n> keyword or not, but what I am trying to say is it not completely ignored either.\n\nI am for marking this set as rejected, any objection?",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>\n\t<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.54,359,1534834800\"; d=\"scan'208\";a=\"239744442\"",
            "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1",
            "Openpgp": "preference=signencrypt",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Message-ID": "<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>",
            "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\txsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE\n\tFgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf\n\tE2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e\n\tmRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL\n\tSXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx\n\tNub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl\n\t1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK\n\tH2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ\n\trmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste\n\tZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p\n\tfXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx\n\t5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLzsFNBFfWTL4BEACnNA29e8TarUsB\n\tL5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd\n\tU6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y\n\tgDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt\n\tv71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+\n\taYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj\n\t0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G\n\tB31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ\n\tmasOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4\n\tYuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy\n\tZUa+6CLR7GdImusFkPJUJwARAQABwsF8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T\n\tYR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7\n\tllafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86\n\tlxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6\n\tLY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo\n\tV8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D\n\t2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i\n\tmPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W\n\tK3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE\n\t56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP\n\tY7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+\n\tvM8=",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B9F3B1B0FA;\n\tTue,  9 Oct 2018 11:20:05 +0200 (CEST)",
                "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 864057EE3\n\tfor <dev@dpdk.org>; Tue,  9 Oct 2018 11:20:03 +0200 (CEST)",
                "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Oct 2018 02:20:02 -0700",
                "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49])\n\t([10.237.221.49])\n\tby orsmga004.jf.intel.com with ESMTP; 09 Oct 2018 02:19:15 -0700"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=utf-8",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Tue, 9 Oct 2018 10:19:13 +0100",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Stephen Hemminger <stephen@networkplumber.org>,\n\tYongseok Koh <yskoh@mellanox.com>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Errors-To": "dev-bounces@dpdk.org"
        }
    },
    {
        "id": 92009,
        "web_url": "http://patches.dpdk.org/comment/92009/",
        "msgid": "<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>",
        "date": "2019-01-31T08:02:36",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 1155,
            "url": "http://patches.dpdk.org/api/people/1155/",
            "name": "Tom Barbette",
            "email": "barbette@kth.se"
        },
        "content": "Hi all,\n\nHas there been any change regarding this? I'm still at DPDK 18.11. Maybe \nautomatically add -Wno-register when C++17 is enabled? Or have a some \nregister macro which gets undefined if C++17 is enabled?\n\nThe \"warning: ISO C++1z does not allow ‘register’ storage class \nspecifier\" is annoying. And vim always goes to some DPDK header when \n\":make\" fails because of the warning...\n\nThanks,\nTom\n\nOn 2018-10-09 11:19, Ferruh Yigit wrote:\n> On 8/23/2018 2:07 PM, Ferruh Yigit wrote:\n>> On 8/1/2018 10:03 PM, Stephen Hemminger wrote:\n>>> On Wed, 1 Aug 2018 18:03:04 +0000\n>>> Yongseok Koh <yskoh@mellanox.com> wrote:\n>>>\n>>>>> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:\n>>>>>\n>>>>> On Tue, 31 Jul 2018 18:48:40 +0200\n>>>>> Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:\n>>>>>    \n>>>>>> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote:\n>>>>>>> Declaring variables as register in C is a leftover from an earlier\n>>>>>>> era (like cassette tape decks in cars).\n>>>>>>\n>>>>>> I don't agree here. It's a hint for compilers and developers that the\n>>>>>> address of such variables won't be needed (and cannot be taken) to enable\n>>>>>> whatever optimizations are possible knowing this.\n>>>>>>\n>>>>>> Somewhat like inline functions, it's not a forced optimization, just a\n>>>>>> useful hint that shouldn't hurt if used wisely.\n>>>>>>\n>>>>>> Besides, cassette decks are not dead yet :)\n>>>>>\n>>>>> If you look at the code, that is not how register is being used (ie. don't take\n>>>>> address of this). It seems like an attempt at optimization.\n>>>>\n>>>> I know compilers are smart enough and the occurrences in mlx4/5 were made from\n>>>> my old fashioned habit. But, I don't see any urgency to push this patch in RC\n>>>> stage even though I'm 99% sure that it is harmless. And in general I don't even\n>>>> understand why we can't live with that if it isn't harmful (or a violation) but\n>>>> informative. I mean no badness but at least one goodness :-)\n>>>>\n>>>> Thanks,\n>>>> Yongseok\n>>>>\n>>>\n>>> Sure, this is intended for next release not rc stage.\n>>> Just trying to clean up code base where I see it.\n>>\n>> I agree with Yongseok, at worst they show the intention of the developer, I\n>> don't see motivation to remove them unless they are doing something wrong, which\n>> seems not the reason of this patch.\n>>\n>> And although I found some information that says \"register\" ignored completely\n>> for gcc, I can see it differs when optimization disabled.\n>> I am not saying practically it differs, since we enable optimization expect from\n>> debugging, most probably there is no practical difference between having the\n>> keyword or not, but what I am trying to say is it not completely ignored either.\n> \n> I am for marking this set as rejected, any objection?\n>",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>\n\t<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>\n\t<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Tom Barbette <barbette@kth.se>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1",
            "X-KTH-Auth": "barbette [130.237.20.142]",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Virus-Scanned": "by amavisd-new at kth.se",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 509F11B3B5;\n\tThu, 31 Jan 2019 09:02:42 +0100 (CET)",
                "from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193])\n\tby dpdk.org (Postfix) with ESMTP id C79E91B3AF\n\tfor <dev@dpdk.org>; Thu, 31 Jan 2019 09:02:40 +0100 (CET)",
                "from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1])\n\tby smtp-4.sys.kth.se (Postfix) with ESMTP id 5516D2970;\n\tThu, 31 Jan 2019 09:02:40 +0100 (CET)",
                "from smtp-4.sys.kth.se ([127.0.0.1])\n\tby smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith LMTP id oVjWv-U47k6b; Thu, 31 Jan 2019 09:02:39 +0100 (CET)",
                "from [130.237.20.142] (s2587.it.kth.se [130.237.20.142])\n\tby smtp-4.sys.kth.se (Postfix) with ESMTPSA id E098F25E1;\n\tThu, 31 Jan 2019 09:02:36 +0100 (CET)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "X-KTH-mail-from": "barbette@kth.se",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Message-ID": "<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default;\n\tt=1548921759; bh=npXoTW2i29XdYFqEYCFdRogVzpU8UfR07hK2rwRBMLU=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=bQvKW3w3/EyXoS+DEUcEKRkv510vPBd8dAocPRACtxlkfiyzc1nuBW2EveQr54j2n\n\tLsuSpPOITSpyu6GyWYJ9Q9amsSfwoKVMdp8CRYk4gARGANJxoZz0X5aifK9CPnAeq5\n\tcy858uRPViDBlpwaffhkU4l20Fn1e2QX74cI9wvQ=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Date": "Thu, 31 Jan 2019 09:02:36 +0100",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "In-Reply-To": "<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "8bit",
            "To": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tYongseok Koh <yskoh@mellanox.com>"
        }
    },
    {
        "id": 92012,
        "web_url": "http://patches.dpdk.org/comment/92012/",
        "msgid": "<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
        "date": "2019-01-31T09:11:28",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 20,
            "url": "http://patches.dpdk.org/api/people/20/",
            "name": "Bruce Richardson",
            "email": "bruce.richardson@intel.com"
        },
        "content": "On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote:\n> Hi all,\n> \n> Has there been any change regarding this? I'm still at DPDK 18.11. Maybe\n> automatically add -Wno-register when C++17 is enabled? Or have a some\n> register macro which gets undefined if C++17 is enabled?\n> \n> The \"warning: ISO C++1z does not allow ‘register’ storage class specifier\"\n> is annoying. And vim always goes to some DPDK header when \":make\" fails\n> because of the warning...\n> \n> Thanks,\n> Tom\n> \nWhat header is that? From what I see the patchset only makes changes to .c\nfiles rather than any .h files, so not sure it would help in your case.\n\nFor what it's worth on the general discussion, I'm in favour of applying\nthis patchset. I view marking variables as \"register\" as completely\nunncessary. If someone can demonstrate a place where it actually makes a\ndifference, then we can keep that use of the keywork, otherwise I think the\ncode is as well off without it.\n\n/Bruce",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>\n\t<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>\n\t<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>\n\t<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.56,543,1539673200\"; d=\"scan'208\";a=\"134688233\"",
            "From": "Bruce Richardson <bruce.richardson@intel.com>",
            "User-Agent": "Mutt/1.11.2 (2019-01-07)",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=utf-8",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 13DDE1B419;\n\tThu, 31 Jan 2019 10:11:36 +0100 (CET)",
                "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 1A3871B415\n\tfor <dev@dpdk.org>; Thu, 31 Jan 2019 10:11:33 +0100 (CET)",
                "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jan 2019 01:11:32 -0800",
                "from bricha3-mobl.ger.corp.intel.com ([10.237.221.54])\n\tby orsmga001.jf.intel.com with SMTP; 31 Jan 2019 01:11:30 -0800",
                "by  (sSMTP sendmail emulation); Thu, 31 Jan 2019 09:11:28 +0000"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Message-ID": "<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
            "X-Amp-Original-Verdict": "FILE UNKNOWN",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Thu, 31 Jan 2019 09:11:28 +0000",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tYongseok Koh <yskoh@mellanox.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Precedence": "list",
            "In-Reply-To": "<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "8bit",
            "To": "Tom Barbette <barbette@kth.se>",
            "X-Amp-Result": "UNKNOWN",
            "Content-Disposition": "inline"
        }
    },
    {
        "id": 92017,
        "web_url": "http://patches.dpdk.org/comment/92017/",
        "msgid": "<2b7c87e5-5855-4ab2-7efd-5bfeb30480a5@kth.se>",
        "date": "2019-01-31T09:39:42",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 1155,
            "url": "http://patches.dpdk.org/api/people/1155/",
            "name": "Tom Barbette",
            "email": "barbette@kth.se"
        },
        "content": "On 2019-01-31 10:11, Bruce Richardson wrote:\n> What header is that? From what I see the patchset only makes changes to .c\n> files rather than any .h files, so not sure it would help in your case.\n\nYes you're right. There are other occurrences of register indeed.\n\nI got the warning from rte_common.h:308 : rte_combine64ms1b(register \nuint64_t v) but it may not be the only one?\n\nTom",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>\n\t<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>\n\t<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>\n\t<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>\n\t<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Tom Barbette <barbette@kth.se>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1",
            "X-KTH-Auth": "barbette [130.237.20.142]",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Virus-Scanned": "by amavisd-new at kth.se",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9153D1B427;\n\tThu, 31 Jan 2019 10:39:47 +0100 (CET)",
                "from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193])\n\tby dpdk.org (Postfix) with ESMTP id 0DC5A28FD\n\tfor <dev@dpdk.org>; Thu, 31 Jan 2019 10:39:47 +0100 (CET)",
                "from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1])\n\tby smtp-4.sys.kth.se (Postfix) with ESMTP id B7B632BF7;\n\tThu, 31 Jan 2019 10:39:46 +0100 (CET)",
                "from smtp-4.sys.kth.se ([127.0.0.1])\n\tby smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith LMTP id bh3tc0_dWs5x; Thu, 31 Jan 2019 10:39:46 +0100 (CET)",
                "from [130.237.20.142] (s2587.it.kth.se [130.237.20.142])\n\tby smtp-4.sys.kth.se (Postfix) with ESMTPSA id 54F1829BF;\n\tThu, 31 Jan 2019 10:39:43 +0100 (CET)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "X-KTH-mail-from": "barbette@kth.se",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Message-ID": "<2b7c87e5-5855-4ab2-7efd-5bfeb30480a5@kth.se>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default;\n\tt=1548927586; bh=OW8W8igfJjutpVzmJRs1gk1KfIe+XOq4J2DkCyyBOy8=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=fH3AC2caXmY0o3aNVCLU4GDFUMaSHo5kLwLbU47D7gFPiZxg69zeKKdm9qDZRIc11\n\tnRzStNevUCCsIyK3fyCzP5R6O+Eopral6o4xY+JHPAWHJWswR9+a+Inz7Qpz3isuWJ\n\t4faxFo6+Em4jZwAjhgbAdIr+QhggITRX1dRmxoj8=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Date": "Thu, 31 Jan 2019 10:39:42 +0100",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tYongseok Koh <yskoh@mellanox.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "In-Reply-To": "<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Bruce Richardson <bruce.richardson@intel.com>"
        }
    },
    {
        "id": 92035,
        "web_url": "http://patches.dpdk.org/comment/92035/",
        "msgid": "<984B12F3-591B-4022-8D5D-34564F9737EF@intel.com>",
        "date": "2019-01-31T17:34:32",
        "subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
        "submitter": {
            "id": 166,
            "url": "http://patches.dpdk.org/api/people/166/",
            "name": "Wiles, Keith",
            "email": "keith.wiles@intel.com"
        },
        "content": "I agree using register for todays compilers is unnecessary and can actually be wrong in some cases. The compilers can pick the correct registers better then we can normally and restricting the compiler makes no sense. \n\nSent from my iPhone\n\n> On Jan 31, 2019, at 3:11 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:\n> \n>> On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote:\n>> Hi all,\n>> \n>> Has there been any change regarding this? I'm still at DPDK 18.11. Maybe\n>> automatically add -Wno-register when C++17 is enabled? Or have a some\n>> register macro which gets undefined if C++17 is enabled?\n>> \n>> The \"warning: ISO C++1z does not allow ‘register’ storage class specifier\"\n>> is annoying. And vim always goes to some DPDK header when \":make\" fails\n>> because of the warning...\n>> \n>> Thanks,\n>> Tom\n>> \n> What header is that? From what I see the patchset only makes changes to .c\n> files rather than any .h files, so not sure it would help in your case.\n> \n> For what it's worth on the general discussion, I'm in favour of applying\n> this patchset. I view marking variables as \"register\" as completely\n> unncessary. If someone can demonstrate a place where it actually makes a\n> difference, then we can keep that use of the keywork, otherwise I think the\n> code is as well off without it.\n> \n> /Bruce",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20180731163059.27085-1-stephen@networkplumber.org>\n\t<20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>\n\t<50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>\n\t<20180801140356.5ac88c43@xeon-e3>\n\t<bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>\n\t<a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>\n\t<2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>,\n\t<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.56,545,1539673200\"; d=\"scan'208\";a=\"271515532\"",
            "From": "\"Wiles, Keith\" <keith.wiles@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Thread-Index": "AQHUuTt06tcH7ywiaEyddQ8UbzL1M6XJnYoAgAAGci4=",
            "Message-ID": "<984B12F3-591B-4022-8D5D-34564F9737EF@intel.com>",
            "X-ExtLoop1": "1",
            "CC": "Tom Barbette <barbette@kth.se>, \"Yigit, Ferruh\" <ferruh.yigit@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>, Yongseok Koh\n\t<yskoh@mellanox.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>, \n\t\"dev@dpdk.org\" <dev@dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7FE91B46E;\n\tThu, 31 Jan 2019 18:34:36 +0100 (CET)",
                "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 2EF911B464\n\tfor <dev@dpdk.org>; Thu, 31 Jan 2019 18:34:35 +0100 (CET)",
                "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jan 2019 09:34:34 -0800",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby orsmga004.jf.intel.com with ESMTP; 31 Jan 2019 09:34:33 -0800",
                "from fmsmsx121.amr.corp.intel.com (10.18.125.36) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Thu, 31 Jan 2019 09:34:32 -0800",
                "from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by\n\tfmsmsx121.amr.corp.intel.com ([169.254.6.18]) with mapi id\n\t14.03.0415.000; Thu, 31 Jan 2019 09:34:32 -0800"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Accept-Language": "en-US",
            "Content-Type": "text/plain; charset=\"Windows-1252\"",
            "X-MS-Has-Attach": "",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Thu, 31 Jan 2019 17:34:32 +0000",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-Amp-File-Uploaded": "False",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Precedence": "list",
            "Thread-Topic": "[dpdk-dev] [PATCH 0/5] remove usage of register keyword in C",
            "In-Reply-To": "<20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "X-MS-TNEF-Correlator": ""
        }
    }
]