List comments

GET /api/covers/43218/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 85381,
        "web_url": "http://patches.dpdk.org/comment/85381/",
        "msgid": "<952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com>",
        "date": "2018-09-11T09:38:24",
        "subject": "Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup",
        "submitter": {
            "id": 512,
            "url": "http://patches.dpdk.org/api/people/512/",
            "name": "Maxime Coquelin",
            "email": "maxime.coquelin@redhat.com"
        },
        "content": "Hi Nikolay,\n\nOn 07/19/2018 09:13 PM, Nikolay Nikolaev wrote:\n> vhost: vhost_user.c code cleanup\n> \n> This patchesries introduce a set of code redesigns in vhost_user.c.\n> \n> The goal is to unify and simplify vhost-user message handling. The\n> patches do not intend to introduce any functional changes.\n> \n> v2 changes:\n>   - Fix the comments by Tiwei Bie\n>   - Keep the old behavior\n>     - Fall through when the callback returns VH_RESULT_ERR\n>     - Fall through if the request is out of range\n> \n> ---\n> \n> Nikolay Nikolaev (5):\n>        vhost: unify VhostUserMsg usage\n>        vhost: make message handling functions prepare the reply\n>        vhost: handle unsupported message types in functions\n>        vhost: unify message handling function signature\n>        vhost: message handling implemented as a callback array\n> \n> \n>   lib/librte_vhost/vhost_user.c |  392 ++++++++++++++++++++++-------------------\n>   1 file changed, 208 insertions(+), 184 deletions(-)\n> \n> --\n> Signature\n> \n\nCould you please rebase and fix the series (see Iliya comments) on top\nof git://dpdk.org/next/dpdk-next-virtio master branch?\n\nThanks,\nMaxime",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Tue, 11 Sep 2018 11:38:24 +0200",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<153202755842.21481.1772155561595981441.stgit@T460>",
            "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6",
            "Message-ID": "<952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "References": "<153202755842.21481.1772155561595981441.stgit@T460>",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "To": "Nikolay Nikolaev <nicknickolaev@gmail.com>, tiwei.bie@intel.com,\n\tzhihong.wang@intel.com",
            "X-Greylist": [
                "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.7]); Tue, 11 Sep 2018 09:38:27 +0000 (UTC)",
                "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.7]); \n\tTue, 11 Sep 2018 09:38:27 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''"
            ],
            "Errors-To": "dev-bounces@dpdk.org",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8B8E4C92;\n\tTue, 11 Sep 2018 11:38:28 +0200 (CEST)",
                "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id E394E4C74\n\tfor <dev@dpdk.org>; Tue, 11 Sep 2018 11:38:27 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 67C23406F8B9;\n\tTue, 11 Sep 2018 09:38:27 +0000 (UTC)",
                "from [10.36.112.31] (ovpn-112-31.ams2.redhat.com [10.36.112.31])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3E1E32156701;\n\tTue, 11 Sep 2018 09:38:25 +0000 (UTC)"
            ],
            "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Content-Transfer-Encoding": "7bit",
            "Subject": "Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 85458,
        "web_url": "http://patches.dpdk.org/comment/85458/",
        "msgid": "<CAL7hd5KjpXYZTfUSqgG0bs3eQGiDiKrrmVAQ6f3CyUAzgHC6sg@mail.gmail.com>",
        "date": "2018-09-12T15:34:27",
        "subject": "Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup",
        "submitter": {
            "id": 1062,
            "url": "http://patches.dpdk.org/api/people/1062/",
            "name": "Nikolay Nikolaev",
            "email": "nicknickolaev@gmail.com"
        },
        "content": "Hello Maxime,\n\nI'll rebase and fix Ilya's comments. Thanks for the reviews.\n\nregards,\nNikolay Nikolaev\n\nOn Tue, Sep 11, 2018 at 12:38 PM Maxime Coquelin <maxime.coquelin@redhat.com>\nwrote:\n\n> Hi Nikolay,\n>\n> On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote:\n> > vhost: vhost_user.c code cleanup\n> >\n> > This patchesries introduce a set of code redesigns in vhost_user.c.\n> >\n> > The goal is to unify and simplify vhost-user message handling. The\n> > patches do not intend to introduce any functional changes.\n> >\n> > v2 changes:\n> >   - Fix the comments by Tiwei Bie\n> >   - Keep the old behavior\n> >     - Fall through when the callback returns VH_RESULT_ERR\n> >     - Fall through if the request is out of range\n> >\n> > ---\n> >\n> > Nikolay Nikolaev (5):\n> >        vhost: unify VhostUserMsg usage\n> >        vhost: make message handling functions prepare the reply\n> >        vhost: handle unsupported message types in functions\n> >        vhost: unify message handling function signature\n> >        vhost: message handling implemented as a callback array\n> >\n> >\n> >   lib/librte_vhost/vhost_user.c |  392\n> ++++++++++++++++++++++-------------------\n> >   1 file changed, 208 insertions(+), 184 deletions(-)\n> >\n> > --\n> > Signature\n> >\n>\n> Could you please rebase and fix the series (see Iliya comments) on top\n> of git://dpdk.org/next/dpdk-next-virtio master branch?\n>\n> Thanks,\n> Maxime\n>",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
            "Date": "Wed, 12 Sep 2018 18:34:27 +0300",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=07FRncT6yHV0hkquLsg1d+JpMlkV0iHiBFxWsYad49M=;\n\tb=XMv+EIUwbYhWFOPKpZn72H8I1K9cCpYan9h8p7k5JvqkHoTFTVAmosHaaybVkrRWpj\n\tprOYR9PXa3hNxOSitXPeA2K0K13AMqa+xXfpemhwMkSSuSUCncGGUDPbnjO/hEnkvmYC\n\tUzyi/5D4fOPJpdvkRAkUD9qOHheRJpd+evVGCapGY5z5CH4D2bzWRjHgLSW/dqPa+8v3\n\tkcrlx6ANXG6GvmKimkns3g7KE5Odrur7OOvTFUOHUIRNdJkQ4yEmPwK7FSrnAxLdJ4Wb\n\tsf2DI2P8uKiK9LM0txRqGznpgH6giiNEl4AugPqNS8OKvYZhH/kEBnEheEl1Xm3Ynr/l\n\tdjkQ==",
            "Message-ID": "<CAL7hd5KjpXYZTfUSqgG0bs3eQGiDiKrrmVAQ6f3CyUAzgHC6sg@mail.gmail.com>",
            "X-BeenThere": "dev@dpdk.org",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=07FRncT6yHV0hkquLsg1d+JpMlkV0iHiBFxWsYad49M=;\n\tb=uP+3frDjShll+TiBbdeBPaQFwrSa1WSoQvyvkAl71CJxSzk9cj5p/mu5m762z0N+yS\n\tr8yPJiSk8e6QQtHJzWqsql8E+c7IBCZBi4BWDBbXYQdkbaJHRlfQkoP3vWSe6JFmY7f0\n\t5gFFHVI64mE4e2q1+YMfgpyK6QnXh4OxoIfuLj/stgKBOVfGnqt/fHwGAczHo0Z2dPWO\n\tnS6wHxNgj9ZM5F1tzDghsqucwrshrZYW2UMctVQOIlnqMeMzoY/ei13WM4BM3q7k76/7\n\t1h9IQOPSHm0E9hz0ufZUWO/wSmUrvQ5B4uptmgTBmAMMfHCN25WBCZ1F6juP8L7p4Sk9\n\tmFcw==",
            "References": "<153202755842.21481.1772155561595981441.stgit@T460>\n\t<952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com>",
            "In-Reply-To": "<952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com>",
            "X-Gm-Message-State": "APzg51AP16nEosivjduJyIhmeY8u9NZUoxKej7Y8Z60sCwUaZy7JQd1z\n\tPOWePR9YSw4J+2i48ui91kklJHaxTDcT9u9QVv4=",
            "Content-Type": "text/plain; charset=\"UTF-8\"",
            "To": "maxime.coquelin@redhat.com, Ilya Maximets <i.maximets@samsung.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-Google-Smtp-Source": "ANB0Vdb+RIexnf72jQA0ZSFNf7Dr4uNZ+Fwng7yD6X125JJP2fhg82y7hew50evBre1OJOZoOD6QiWzI+J8PBZxx8Tk=",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AABFA4C9F;\n\tWed, 12 Sep 2018 17:35:05 +0200 (CEST)",
                "from mail-io1-f52.google.com (mail-io1-f52.google.com\n\t[209.85.166.52]) by dpdk.org (Postfix) with ESMTP id B7F274C95\n\tfor <dev@dpdk.org>; Wed, 12 Sep 2018 17:35:04 +0200 (CEST)",
                "by mail-io1-f52.google.com with SMTP id y10-v6so520822ioa.10\n\tfor <dev@dpdk.org>; Wed, 12 Sep 2018 08:35:04 -0700 (PDT)"
            ],
            "From": "Nikolay Nikolaev <nicknickolaev@gmail.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Cc": "tiwei.bie@intel.com, zhihong.wang@intel.com, dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Received": "by 2002:a6b:6209:: with SMTP id\n\tf9-v6mr2207636iog.11.1536766503983; \n\tWed, 12 Sep 2018 08:35:03 -0700 (PDT)",
            "X-Mailman-Version": "2.1.15"
        }
    }
]