List comments

GET /api/covers/43005/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 84017,
        "web_url": "http://patches.dpdk.org/comment/84017/",
        "msgid": "<DB7PR05MB442601E2D3C64946E62506A6C3570@DB7PR05MB4426.eurprd05.prod.outlook.com>",
        "date": "2018-07-22T11:21:17",
        "subject": "Re: [dpdk-dev] [PATCH v2 0/6] net/mlx5: add support for switch flow\n\trules",
        "submitter": {
            "id": 634,
            "url": "http://patches.dpdk.org/api/people/634/",
            "name": "Shahaf Shuler",
            "email": "shahafs@mellanox.com"
        },
        "content": "Hi Adrien,\n\nFriday, July 13, 2018 12:41 PM, Adrien Mazarguil:\n> Subject: [PATCH v2 0/6] net/mlx5: add support for switch flow rules\n> \n> This series adds support for switch flow rules, that is, rte_flow rules applied\n> to mlx5 devices at the switch level.\n> \n> It allows applications to offload traffic redirection between DPDK ports in\n> hardware, while optionally modifying it (e.g. performing encap/decap).\n> \n> For this to work, involved DPDK ports must be part of the same switch\n> domain, as is the case with port representors, and the transfer attribute\n> must be requested on flow rules.\n> \n> Also since the mlx5 switch is controlled through Netlink instead of Verbs, and\n> given how tedious formatting Netlink messages is, a new dependency is\n> added to mlx5: libmnl. See relevant patch.\n\nThere are some checkpatch[1] warning, but those are safe to ignore. \n\nAdrien, one thing which is missing is a documentation update for mlx5 doc on the new dependency of libmnl. \nJust like rdma-core: how to get it, how to install it, version required..\n\nI won't postpone the series acceptance due to this (since I want to avoid big changes after the rc2), but we must have such doc before 18.08 release. \n\nSeries applied to next-net-mlx, thanks!\n\n[1]\n\n### net/mlx5: add framework for switch flow rules\n\nERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses\n#307: FILE: drivers/net/mlx5/mlx5_nl_flow.c:60:\n+#define PATTERN_COMMON \\\n+       ITEM_VOID, ACTIONS\n\nERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses\n#309: FILE: drivers/net/mlx5/mlx5_nl_flow.c:62:\n+#define ACTIONS_COMMON \\\n+       ACTION_VOID, END\n\ntotal: 2 errors, 0 warnings, 0 checks, 537 lines checked\n\n### net/mlx5: add fate actions to switch flow rules\n\nERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses\n#55: FILE: drivers/net/mlx5/mlx5_nl_flow.c:68:\n+#define ACTIONS_FATE \\\n+       ACTION_PORT_ID, ACTION_DROP\n\nERROR:ASSIGN_IN_IF: do not use assignment in if condition\n#136: FILE: drivers/net/mlx5/mlx5_nl_flow.c:277:\n+               if (!mnl_attr_put_check(buf, size, TCA_MIRRED_PARMS,\n\nERROR:ASSIGN_IN_IF: do not use assignment in if condition\n#159: FILE: drivers/net/mlx5/mlx5_nl_flow.c:300:\n+               if (!mnl_attr_put_check(buf, size, TCA_GACT_PARMS,\n\ntotal: 3 errors, 0 warnings, 0 checks, 134 lines checked\n\n### net/mlx5: add VLAN item and actions to switch flow rules\n\nERROR:ASSIGN_IN_IF: do not use assignment in if condition\n#367: FILE: drivers/net/mlx5/mlx5_nl_flow.c:930:\n+               if (!mnl_attr_put_check(buf, size, TCA_VLAN_PARMS,\n\ntotal: 1 errors, 0 warnings, 0 checks, 358 lines checked\n\n\n> \n> v2 changes:\n> \n> - Mostly compilation fixes for missing Netlink definitions on older systems.\n> - Reduced stack consumption.\n> - Adapted series to rely on mlx5_dev_to_port_id() instead of\n>   mlx5_dev_to_domain_id().\n> - See relevant patches for more information.\n> \n> Adrien Mazarguil (6):\n>   net/mlx5: lay groundwork for switch offloads\n>   net/mlx5: add framework for switch flow rules\n>   net/mlx5: add fate actions to switch flow rules\n>   net/mlx5: add L2-L4 pattern items to switch flow rules\n>   net/mlx5: add VLAN item and actions to switch flow rules\n>   net/mlx5: add port ID pattern item to switch flow rules\n> \n>  drivers/net/mlx5/Makefile       |  142 ++++\n>  drivers/net/mlx5/mlx5.c         |   32 +\n>  drivers/net/mlx5/mlx5.h         |   28 +\n>  drivers/net/mlx5/mlx5_flow.c    |  111 +++\n>  drivers/net/mlx5/mlx5_nl_flow.c | 1247\n> ++++++++++++++++++++++++++++++++++\n>  mk/rte.app.mk                   |    2 +-\n>  6 files changed, 1561 insertions(+), 1 deletion(-)  create mode 100644\n> drivers/net/mlx5/mlx5_nl_flow.c\n> \n> --\n> 2.11.0",
        "headers": {
            "X-OriginatorOrg": "Mellanox.com",
            "x-ms-office365-filtering-correlation-id": "3a786312-56e8-4093-afde-08d5efc53e37",
            "References": "<20180627173355.4718-1-adrien.mazarguil@6wind.com>\n\t<20180713092910.26276-1-adrien.mazarguil@6wind.com>",
            "X-Mailman-Version": "2.1.15",
            "Thread-Index": "AQHUGo2YsjC/gxm8QEamay2sNtnqVaSazu/A",
            "Content-Type": "text/plain; charset=\"iso-8859-1\"",
            "CC": "=?iso-8859-1?q?N=E9lio_Laranjeiro?=\n\t<nelio.laranjeiro@6wind.com>, Yongseok Koh <yskoh@mellanox.com>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>, Guillaume Gaudonville\n\t<guillaume.gaudonville@6wind.com>, Raslan Darawsheh\n\t<rasland@mellanox.com>, Wael Abualrub <waela@mellanox.com>",
            "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:DB7PR05MB4987; ",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5FA4B3238;\n\tSun, 22 Jul 2018 13:21:26 +0200 (CEST)",
                "from EUR01-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur01hn0213.outbound.protection.outlook.com [104.47.2.213])\n\tby dpdk.org (Postfix) with ESMTP id 8FEE12BE6\n\tfor <dev@dpdk.org>; Sun, 22 Jul 2018 13:21:25 +0200 (CEST)",
                "from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by\n\tDB7PR05MB4987.eurprd05.prod.outlook.com (20.176.236.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.973.21; Sun, 22 Jul 2018 11:21:17 +0000",
                "from DB7PR05MB4426.eurprd05.prod.outlook.com\n\t([fe80::52a:650b:ae10:fc3]) by\n\tDB7PR05MB4426.eurprd05.prod.outlook.com\n\t([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022;\n\tSun, 22 Jul 2018 11:21:17 +0000"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v2 0/6] net/mlx5: add support for switch flow\n\trules",
            "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ",
            "x-ms-traffictypediagnostic": "DB7PR05MB4987:|DB7PR05MB4987:",
            "x-exchange-antispam-report-test": "UriScan:(278428928389397)(66839620246622);",
            "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231311)(2232096)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016);\n\tSRVR:DB7PR05MB4987; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4987; ",
            "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)",
            "Precedence": "list",
            "From": "Shahaf Shuler <shahafs@mellanox.com>",
            "x-ms-office365-filtering-ht": "Tenant",
            "spamdiagnosticoutput": "1:22",
            "x-forefront-antispam-report": "SFV:SPM;\n\tSFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(189003)(199004)(102836004)(9686003)(6506007)(478600001)(76176011)(5250100002)(186003)(97736004)(26005)(33656002)(107886003)(66066001)(81166006)(105586002)(14454004)(81156014)(74316002)(4326008)(256004)(6246003)(99286004)(476003)(486006)(14444005)(11346002)(446003)(25786009)(7696005)(53936002)(68736007)(229853002)(2906002)(6116002)(2900100001)(3846002)(106356001)(6916009)(6436002)(55016002)(8676002)(305945005)(8936002)(54906003)(5660300001)(7736002)(316002)(86362001)(59010400001);\n\tDIR:OUT; SFP:1501; SCL:5; SRVR:DB7PR05MB4987;\n\tH:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "x-ms-exchange-antispam-srfa-diagnostics": "SOS;",
            "x-microsoft-antispam-prvs": "<DB7PR05MB49872D88E1DD46F663CA94DCC3570@DB7PR05MB4987.eurprd05.prod.outlook.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
            "X-MS-TNEF-Correlator": "",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-microsoft-antispam-message-info": "N4T0bs1uVGSoPMVfwNCE3NvIr+5yPjHS1D0LYWCiE3hNsbCdEaMyYpGZe9CaXOCffAANdRfitKiwzzMGzFEuJqa298CIRxOm68GEiiNYmUohj9bwbu/zvjqpfyf11vd7/vF4+iac4yP2C4cLzLYA4OZIAhjqmUcFuOhrUfzE2s1OmaVWJMzhhBDLWY/n3fe5/aGyJ53P+FRyY2kRIGxpxcqK6kSDzn6qcoWZpk7bzLs0I22YWigqp8H7uTMxvg0pNt1ikGWOoJ26HNN5ix/NcaUSSTDrOJ7cQJ9qu/dRAtw3t0ed4LC+hJm4urfFY+Y9sjUeTPm3WEPDdhwiwYidn4DaIVn8UkMKh0G9v7LTTmm52uKqxCERbIIPTQ5u2IzLzGfUPOLI0kSe3acBKeZms2ixZ8kH+Tq6qdyEuuIR6SFcrbiYD6vdEk+znbDOhrfO3nMeRMUsyk0swljdumAnGIacQi64eRFCGbesHoXINpg2FBadG5JRw3p85BosKBWG5PFMDEGisL+aH+KYbzvpVy7EtGLVnHx24NBc1FIu4MBAzJXvAVbrizWtxuqcCO1K6/4l9LsfdHoPARWyIZFz4zdo173rLP8MTlugWgETyUMVwFG1lz2Sh9IBRUASMZfMuQSElJ6tn5Z9lUCXc3vkNTOFx8E1XQKeuaPnFdg6VbXQn/ssXVd4jAJQ8KCvKppIdXjuOJ4LoGr2OsCkrY3NLw==",
            "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr",
            "MIME-Version": "1.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Date": "Sun, 22 Jul 2018 11:21:17 +0000",
            "x-originating-ip": "[31.154.10.105]",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "x-ms-publictraffictype": "Email",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "Accept-Language": "en-US",
            "Message-ID": "<DB7PR05MB442601E2D3C64946E62506A6C3570@DB7PR05MB4426.eurprd05.prod.outlook.com>",
            "x-ms-exchange-senderadcheck": "1",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "3a786312-56e8-4093-afde-08d5efc53e37",
            "x-microsoft-exchange-diagnostics": "1; DB7PR05MB4987;\n\t7:ISJU+azrwnkfxLU7m++tdKc4zl9dmgDepQ44s6+WQ4Y7FuK6++4K5ZJ28yNX7+rouErU/acciUKMB+Vu3JMaLvQ5nMxXKTt6errqoG6P2Z30vlxeQR8o2BTIxesfUcPmFg8bFl3WN+U1b9MmAjnw0RuMUIAgHRzI0yOvtOMoFOCttKixHVxSVNCYEl/rHUbYyW3az2hwzmMLgRqoid6nYHFOx/S/Fk7CBjTVM1nQjcrL6aARE5etchyakMUkjlRZ",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "Content-Language": "en-US",
            "X-MS-Has-Attach": "",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR05MB4987",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=WGg7z8SuGeQ3wif0+V8X5uQWJOmKlV1oajuzPGrJH4Q=;\n\tb=hvCSblvKaPKygP5zGFatpQSzbIlWMpP2xz2jKpC/jS8G2lA/ho/e6olNsY1tPQJhrTSLpz7Ea2b3dmhAL8sf366mBws0ooF6pzCySFHe/4gjjzizRM2pPCZXwUz2hOMLKj/JhB+ZQm+cPaEEdi5RofJ2RxSqAvKlFZunkA0sTxA=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2018 11:21:17.2975\n\t(UTC)",
            "Thread-Topic": "[PATCH v2 0/6] net/mlx5: add support for switch flow rules",
            "In-Reply-To": "<20180713092910.26276-1-adrien.mazarguil@6wind.com>",
            "x-forefront-prvs": "0741C77572"
        }
    }
]