List comments

GET /api/covers/42462/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 83365,
        "web_url": "http://patches.dpdk.org/comment/83365/",
        "msgid": "<20180709012847.GA5859@debian>",
        "date": "2018-07-09T01:28:48",
        "subject": "Re: [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring\n\tlayout",
        "submitter": {
            "id": 617,
            "url": "http://patches.dpdk.org/api/people/617/",
            "name": "Tiwei Bie",
            "email": "tiwei.bie@intel.com"
        },
        "content": "On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:\n> This series is a handover from Jen's \"[PATCH v4 00/20]\n> implement packed virtqueues\", which only implements the\n> vhost side. Virtio PMD implementation will follow in a \n> next series.\n> \n> The series applies on top of previous reworks I posted\n> during this cycle that merges mergeable and non-mergeable\n> receive paths, and refactors transmit path to re-use\n> vector buffers.\n> \n> I haven't run performance tests for now as the Virtio PMD\n> side isn't ready.\n> \n> The series has been tested with Tiwei's series implementing\n> packed ring support to Kernel's virtio-net driver, and\n> with Wei series implementing the Qemu side.\n> \n> To test it, I have used testpmd on host side with a vhost\n> vdev and a tap vdev forwarding to each other. Transferts\n> of big random files have been done in both ways with\n> integrity verified.\n> \n> Tests have been run with Rx mrg ON/OFF and events suppression\n> ON/OFF.\n> \n> Tests have also been run with legacy split ring layout to\n> ensure no regression have been introduced.\n> \n> Changes since v8:\n> =================\n> - Fix indents (Tiwei)\n> - Rename struct vring_desc_packed to vring_packed_desc (Tiwei)\n> \n> Changes since v7:\n> =================\n> - Align structs and defines naming with Kernel header (Tiwei)\n> - Fix event based notifications (Tiwei)\n> - Fix Clang build issues caused by unused symbols (Tiwei)\n> \n> Changes since v6:\n> =================\n> - Various style cleanups (Tiwei, Jason)\n> - Simplify event based notification (Jason)\n> - Build support with future kernels (Tiwei)\n> - Prevent buffer vectors overflow in map_one_desc (Tiwei)\n> \n> Changes since v5:\n> =================\n> - Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei)\n> - Fix vq_is_ready (Maxime)\n> - Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei)\n> - Make desc_is_avail() a bool (Tiwei)\n> - Improve desc_is_avail() logic (Tiwei)\n> - Remove split rings addr NULL assignment in the right patch (Tiwei)\n> - Make buffer id a uint16_t (Tiwei)\n> \n> Jens Freimann (2):\n>   vhost: add virtio packed virtqueue defines\n>   vhost: add helpers for packed virtqueues\n> \n> Maxime Coquelin (12):\n>   vhost: clear shadow used table index at flush time\n>   vhost: make indirect desc table copy desc type agnostic\n>   vhost: clear batch copy index at copy time\n>   vhost: extract split ring handling from Rx and Tx functions\n>   vhost: append shadow used ring function names with split\n>   vhost: add shadow used ring support for packed rings\n>   vhost: create descriptor mapping function\n>   vhost: add vector filling support for packed ring\n>   vhost: add Rx support for packed ring\n>   vhost: add Tx support for packed ring\n>   vhost: add notification for packed ring\n>   vhost: advertize packed ring layout support\n> \n> Yuanhan Liu (1):\n>   vhost: vring address setup for packed queues\n> \n>  lib/librte_vhost/vhost.c      | 115 ++++++-\n>  lib/librte_vhost/vhost.h      | 130 ++++++-\n>  lib/librte_vhost/vhost_user.c | 127 +++++--\n>  lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++---------\n>  4 files changed, 939 insertions(+), 209 deletions(-)\n> \n> -- \n> 2.14.4\n> \n\nFor the series:\nAcked-by: Tiwei Bie <tiwei.bie@intel.com>",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,\n\tmst@redhat.com, jasowang@redhat.com, wexu@redhat.com",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Mon, 9 Jul 2018 09:28:48 +0800",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<20180706070722.2043-1-maxime.coquelin@redhat.com>",
            "Message-ID": "<20180709012847.GA5859@debian>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20180706070722.2043-1-maxime.coquelin@redhat.com>",
            "Content-Disposition": "inline",
            "Content-Type": "text/plain; charset=utf-8",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "User-Agent": "Mutt/1.10.0 (2018-05-17)",
            "X-Amp-Result": "UNSCANNABLE",
            "Errors-To": "dev-bounces@dpdk.org",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF0FB5B3C;\n\tMon,  9 Jul 2018 03:29:05 +0200 (CEST)",
                "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 79F775B1A\n\tfor <dev@dpdk.org>; Mon,  9 Jul 2018 03:29:03 +0200 (CEST)",
                "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2018 18:29:02 -0700",
                "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby orsmga004.jf.intel.com with ESMTP; 08 Jul 2018 18:29:00 -0700"
            ],
            "From": "Tiwei Bie <tiwei.bie@intel.com>",
            "Precedence": "list",
            "X-ExtLoop1": "1",
            "X-Amp-File-Uploaded": "False",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring\n\tlayout",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-IronPort-AV": "E=Sophos;i=\"5.51,327,1526367600\"; d=\"scan'208\";a=\"214388465\""
        }
    },
    {
        "id": 83378,
        "web_url": "http://patches.dpdk.org/comment/83378/",
        "msgid": "<20180709070400.GA5900@debian>",
        "date": "2018-07-09T07:04:00",
        "subject": "Re: [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring\n\tlayout",
        "submitter": {
            "id": 617,
            "url": "http://patches.dpdk.org/api/people/617/",
            "name": "Tiwei Bie",
            "email": "tiwei.bie@intel.com"
        },
        "content": "On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:\n> This series is a handover from Jen's \"[PATCH v4 00/20]\n> implement packed virtqueues\", which only implements the\n> vhost side. Virtio PMD implementation will follow in a \n> next series.\n> \n> The series applies on top of previous reworks I posted\n> during this cycle that merges mergeable and non-mergeable\n> receive paths, and refactors transmit path to re-use\n> vector buffers.\n> \n> I haven't run performance tests for now as the Virtio PMD\n> side isn't ready.\n> \n> The series has been tested with Tiwei's series implementing\n> packed ring support to Kernel's virtio-net driver, and\n> with Wei series implementing the Qemu side.\n> \n> To test it, I have used testpmd on host side with a vhost\n> vdev and a tap vdev forwarding to each other. Transferts\n> of big random files have been done in both ways with\n> integrity verified.\n> \n> Tests have been run with Rx mrg ON/OFF and events suppression\n> ON/OFF.\n> \n> Tests have also been run with legacy split ring layout to\n> ensure no regression have been introduced.\n> \n> Changes since v8:\n> =================\n> - Fix indents (Tiwei)\n> - Rename struct vring_desc_packed to vring_packed_desc (Tiwei)\n> \n> Changes since v7:\n> =================\n> - Align structs and defines naming with Kernel header (Tiwei)\n> - Fix event based notifications (Tiwei)\n> - Fix Clang build issues caused by unused symbols (Tiwei)\n> \n> Changes since v6:\n> =================\n> - Various style cleanups (Tiwei, Jason)\n> - Simplify event based notification (Jason)\n> - Build support with future kernels (Tiwei)\n> - Prevent buffer vectors overflow in map_one_desc (Tiwei)\n> \n> Changes since v5:\n> =================\n> - Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei)\n> - Fix vq_is_ready (Maxime)\n> - Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei)\n> - Make desc_is_avail() a bool (Tiwei)\n> - Improve desc_is_avail() logic (Tiwei)\n> - Remove split rings addr NULL assignment in the right patch (Tiwei)\n> - Make buffer id a uint16_t (Tiwei)\n> \n> Jens Freimann (2):\n>   vhost: add virtio packed virtqueue defines\n>   vhost: add helpers for packed virtqueues\n> \n> Maxime Coquelin (12):\n>   vhost: clear shadow used table index at flush time\n>   vhost: make indirect desc table copy desc type agnostic\n>   vhost: clear batch copy index at copy time\n>   vhost: extract split ring handling from Rx and Tx functions\n>   vhost: append shadow used ring function names with split\n>   vhost: add shadow used ring support for packed rings\n>   vhost: create descriptor mapping function\n>   vhost: add vector filling support for packed ring\n>   vhost: add Rx support for packed ring\n>   vhost: add Tx support for packed ring\n>   vhost: add notification for packed ring\n>   vhost: advertize packed ring layout support\n> \n> Yuanhan Liu (1):\n>   vhost: vring address setup for packed queues\n> \n>  lib/librte_vhost/vhost.c      | 115 ++++++-\n>  lib/librte_vhost/vhost.h      | 130 ++++++-\n>  lib/librte_vhost/vhost_user.c | 127 +++++--\n>  lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++---------\n>  4 files changed, 939 insertions(+), 209 deletions(-)\n> \n> -- \n> 2.14.4\n> \n\nApplied to dpdk-next-virtio/master, thanks.",
        "headers": {
            "X-Amp-Original-Verdict": "FILE UNKNOWN",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,\n\tmst@redhat.com, jasowang@redhat.com, wexu@redhat.com",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Mon, 9 Jul 2018 15:04:00 +0800",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<20180706070722.2043-1-maxime.coquelin@redhat.com>",
            "Message-ID": "<20180709070400.GA5900@debian>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20180706070722.2043-1-maxime.coquelin@redhat.com>",
            "Content-Disposition": "inline",
            "Content-Type": "text/plain; charset=utf-8",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "User-Agent": "Mutt/1.10.0 (2018-05-17)",
            "X-Amp-Result": "UNKNOWN",
            "Errors-To": "dev-bounces@dpdk.org",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D9A97EC7;\n\tMon,  9 Jul 2018 09:04:18 +0200 (CEST)",
                "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id DF0242BF5\n\tfor <dev@dpdk.org>; Mon,  9 Jul 2018 09:04:16 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jul 2018 00:04:15 -0700",
                "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby FMSMGA003.fm.intel.com with ESMTP; 09 Jul 2018 00:04:13 -0700"
            ],
            "From": "Tiwei Bie <tiwei.bie@intel.com>",
            "Precedence": "list",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Amp-File-Uploaded": "False",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring\n\tlayout",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "X-ExtLoop1": "1",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-IronPort-AV": "E=Sophos;i=\"5.51,329,1526367600\"; d=\"scan'208\";a=\"63239446\""
        }
    }
]