List comments

GET /api/covers/42054/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 83006,
        "web_url": "http://patches.dpdk.org/comment/83006/",
        "msgid": "<6dea99a3-4b26-be52-e524-94de3f4fda64@redhat.com>",
        "date": "2018-07-02T08:33:28",
        "subject": "Re: [dpdk-dev] [PATCH v5 0/9] support in-order feature",
        "submitter": {
            "id": 512,
            "url": "http://patches.dpdk.org/api/people/512/",
            "name": "Maxime Coquelin",
            "email": "maxime.coquelin@redhat.com"
        },
        "content": "On 07/02/2018 03:56 PM, Marvin Liu wrote:\n> In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> When this feature has been negotiated, virtio driver will use\n> descriptors in ring order: starting from offset 0 in the table, and\n> wrapping around at the end of the table. Vhost devices will always use\n> descriptors in the same order in which they have been made available.\n> This can reduce virtio accesses to used ring.\n> \n> Based on updated virtio-spec, this series realized IN_ORDER prototype\n> in virtio driver. Due to new [RT]x path added into selection, also add\n> two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> list. This will allow user to configure feature bits thus can impact\n> [RT]x path selection.\n> \n> Performance of virtio user with IN_ORDER feature:\n> \n>      Platform: Purely\n>      CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n>      DPDK baseline: 18.05\n>      Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> \n>      +--------------+----------+----------+---------+\n>      |Vhost->Virtio |1 Queue   |2 Queues  |4 Queues |\n>      +--------------+----------+----------+---------+\n>      |Inorder       |12.0Mpps  |24.2Mpps  |26.0Mpps |\n>      |Normal        |12.1Mpps  |18.5Mpps  |18.9Mpps |\n>      +--------------+----------+----------+---------+\n>      \n>      +--------------+----------+----------------+---------+\n>      |Virtio->Vhost |1 Queue   |2 Queues        |4 Queues |\n>      +--------------+----------+----------------+---------+\n>      |Inorder       |13.8Mpps  |10.7 ~ 15.2Mpps |11.5Mpps |\n>      |Normal        |13.3Mpps  |9.8 ~ 14Mpps    |10.5Mpps |\n>      +--------------+----------+----------------+---------+\n>      \n>      +---------+----------+----------------+----------------+\n>      |Loopback |1 Queue   |2 Queues        |4 Queues        |\n>      +---------+----------+----------------+----------------+\n>      |Inorder  |7.4Mpps   |9.1 ~ 11.6Mpps  |10.5 ~ 11.3Mpps |\n>      +---------+----------+----------------+----------------+\n>      |Normal   |7.5Mpps   |7.7 ~ 9.0Mpps   |7.6 ~ 7.8Mpps   |\n>      +---------+----------+----------------+----------------+\n> \n> v5:\n> - disable simple Tx when in-order negotiated\n> - doc update\n> \n> v4:\n> - disable simple [RT]x function for ARM\n> - squash doc update into relevant patches\n> - fix git-check-log and checkpatch errors\n> \n> v3:\n> - refine [RT]x function selection logic\n> - fix in-order mergeable packets index error\n> - combine unsupport mask patch\n> - doc virtio in-order update\n> - fix checkpatch error\n> \n> v2:\n> - merge to latest dpdk-net-virtio\n> - not use in_direct for normal xmit packets\n> - update available ring for each descriptor\n> - clean up IN_ORDER xmit function\n> - unmask feature bits when disabled in_order or mgr_rxbuf\n> - extract common part between IN_ORDER and normal functions\n> - update performance result\n> \n> Marvin Liu (9):\n>    vhost: advertise support in-order feature\n>    net/virtio: add in-order feature bit definition\n>    net/virtio-user: add unsupported features mask\n>    net/virtio-user: add mrg-rxbuf and in-order vdev parameters\n>    net/virtio: free in-order descriptors before device start\n>    net/virtio: extract common part for in-order functions\n>    net/virtio: support in-order Rx and Tx\n>    net/virtio: add in-order Rx/Tx into selection\n>    net/virtio: advertise support in-order feature\n> \n>   doc/guides/nics/virtio.rst                    |  23 +-\n>   drivers/net/virtio/virtio_ethdev.c            |  32 +-\n>   drivers/net/virtio/virtio_ethdev.h            |   7 +\n>   drivers/net/virtio/virtio_pci.h               |   8 +\n>   drivers/net/virtio/virtio_rxtx.c              | 639 ++++++++++++++++--\n>   .../net/virtio/virtio_user/virtio_user_dev.c  |  30 +-\n>   .../net/virtio/virtio_user/virtio_user_dev.h  |   4 +-\n>   drivers/net/virtio/virtio_user_ethdev.c       |  47 +-\n>   drivers/net/virtio/virtqueue.c                |   8 +\n>   drivers/net/virtio/virtqueue.h                |   2 +\n>   lib/librte_vhost/socket.c                     |   6 +\n>   lib/librte_vhost/vhost.h                      |  10 +-\n>   12 files changed, 736 insertions(+), 80 deletions(-)\n> \n\nApplied to dpdk-next-virtio/master.\n\nThanks,\nMaxime",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "zhihong.wang@intel.com, dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Mon, 2 Jul 2018 10:33:28 +0200",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<20180702135642.52577-1-yong.liu@intel.com>",
            "X-Scanned-By": "MIMEDefang 2.79 on 10.11.54.5",
            "Message-ID": "<6dea99a3-4b26-be52-e524-94de3f4fda64@redhat.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "References": "<20180702135642.52577-1-yong.liu@intel.com>",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "To": "Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com",
            "X-Greylist": [
                "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Mon, 02 Jul 2018 08:33:31 +0000 (UTC)",
                "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tMon, 02 Jul 2018 08:33:31 +0000 (UTC) for IP:'10.11.54.5'\n\tDOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''"
            ],
            "Errors-To": "dev-bounces@dpdk.org",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 699BB5F34;\n\tMon,  2 Jul 2018 10:33:33 +0200 (CEST)",
                "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id F3E7C5F33\n\tfor <dev@dpdk.org>; Mon,  2 Jul 2018 10:33:31 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5980F4022905;\n\tMon,  2 Jul 2018 08:33:31 +0000 (UTC)",
                "from [10.36.112.41] (ovpn-112-41.ams2.redhat.com [10.36.112.41])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4AD71178B7;\n\tMon,  2 Jul 2018 08:33:30 +0000 (UTC)"
            ],
            "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Content-Transfer-Encoding": "7bit",
            "Subject": "Re: [dpdk-dev] [PATCH v5 0/9] support in-order feature",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Mailman-Version": "2.1.15"
        }
    }
]