List comments

GET /api/covers/41848/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 82951,
        "web_url": "http://patches.dpdk.org/comment/82951/",
        "msgid": "<c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com>",
        "date": "2018-06-29T13:10:24",
        "subject": "Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature",
        "submitter": {
            "id": 512,
            "url": "http://patches.dpdk.org/api/people/512/",
            "name": "Maxime Coquelin",
            "email": "maxime.coquelin@redhat.com"
        },
        "content": "Hi,\n\nI was about to apply it, but there are quite a few checkpatch and\ngit-check-log.sh issues reported.\n\nCould you please resent with this fixed?\nAlso, I think it would be  better to squash the doc patches in relevant\nones.\n\nThanks,\nMaxime\nOn 06/28/2018 11:52 PM, Marvin Liu wrote:\n> In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> When this feature has been negotiated, virtio driver will use\n> descriptors in ring order: starting from offset 0 in the table, and\n> wrapping around at the end of the table. Vhost devices will always use\n> descriptors in the same order in which they have been made available.\n> This can reduce virtio accesses to used ring.\n> \n> Based on updated virtio-spec, this series realized IN_ORDER prototype\n> in virtio driver. Due to new [RT]x path added into selection, also add\n> two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> list. This will allow user to configure feature bits thus can impact\n> [RT]x path selection.\n> \n> Performance of virtio user with IN_ORDER feature:\n> \n>      Platform: Purely\n>      CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n>      DPDK baseline: 18.05\n>      Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> \n>      +--------------+----------+----------+---------+\n>      |Vhost->Virtio |1 Queue   |2 Queues  |4 Queues |\n>      +--------------+----------+----------+---------+\n>      |Inorder       |12.0Mpps  |24.2Mpps  |26.0Mpps |\n>      |Normal        |12.1Mpps  |18.5Mpps  |18.9Mpps |\n>      +--------------+----------+----------+---------+\n>      \n>      +--------------+----------+----------------+---------+\n>      |Virtio->Vhost |1 Queue   |2 Queues        |4 Queues |\n>      +--------------+----------+----------------+---------+\n>      |Inorder       |13.8Mpps  |10.7 ~ 15.2Mpps |11.5Mpps |\n>      |Normal        |13.3Mpps  |9.8 ~ 14Mpps    |10.5Mpps |\n>      +--------------+----------+----------------+---------+\n>      \n>      +---------+----------+----------------+----------------+\n>      |Loopback |1 Queue   |2 Queues        |4 Queues        |\n>      +---------+----------+----------------+----------------+\n>      |Inorder  |7.4Mpps   |9.1 ~ 11.6Mpps  |10.5 ~ 11.3Mpps |\n>      +---------+----------+----------------+----------------+\n>      |Normal   |7.5Mpps   |7.7 ~ 9.0Mpps   |7.6 ~ 7.8Mpps   |\n>      +---------+----------+----------------+----------------+\n> \n> v3:\n> - refine [RT]x function selection logic\n> - fix in-order mergable packets index error\n> - combine unsupport mask patch\n> - doc virtio in-order update\n> - fix checkpatch error\n> \n> v2:\n> - merge to latest dpdk-net-virtio\n> - not use in_direct for normal xmit packets\n> - update available ring for each descriptor\n> - clean up IN_ORDER xmit function\n> - unmask feature bits when disabled in_order or mgr_rxbuf\n> - extract common part between IN_ORDER and normal functions\n> - update performance result\n> \n> Marvin Liu (11):\n>    vhost: advertise support in-order feature\n>    net/virtio: add in-order feature bit definition\n>    net/virtio-user: add unsupported features mask\n>    net/virtio-user: add mrg_rxbuf and in_order vdev parameters\n>    net/virtio: free in-order descriptors before device start\n>    net/virtio: extract common part for in-order functions\n>    net/virtio: support in-order Rx and Tx\n>    net/virtio: add in-order Rx/Tx into selection\n>    net/virtio: advertise support in-order feature\n>    doc: add mrg_rxbuf and in_order parameters for virtio device\n>    doc: add in-order funciton for virtio device\n> \n>   doc/guides/nics/virtio.rst                    |  27 +-\n>   drivers/net/virtio/virtio_ethdev.c            |  29 +-\n>   drivers/net/virtio/virtio_ethdev.h            |   7 +\n>   drivers/net/virtio/virtio_pci.h               |   8 +\n>   drivers/net/virtio/virtio_rxtx.c              | 635 ++++++++++++++++--\n>   .../net/virtio/virtio_user/virtio_user_dev.c  |  26 +-\n>   .../net/virtio/virtio_user/virtio_user_dev.h  |   4 +-\n>   drivers/net/virtio/virtio_user_ethdev.c       |  45 +-\n>   drivers/net/virtio/virtqueue.c                |   8 +\n>   drivers/net/virtio/virtqueue.h                |   2 +\n>   lib/librte_vhost/socket.c                     |   6 +\n>   lib/librte_vhost/vhost.h                      |  10 +-\n>   12 files changed, 723 insertions(+), 84 deletions(-)\n>",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "zhihong.wang@intel.com, dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Fri, 29 Jun 2018 15:10:24 +0200",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<20180628215235.106069-1-yong.liu@intel.com>",
            "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6",
            "Message-ID": "<c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "References": "<20180628215235.106069-1-yong.liu@intel.com>",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "To": "Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com",
            "X-Greylist": [
                "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.8]); Fri, 29 Jun 2018 13:10:27 +0000 (UTC)",
                "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.8]); \n\tFri, 29 Jun 2018 13:10:27 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''"
            ],
            "Errors-To": "dev-bounces@dpdk.org",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 913645F65;\n\tFri, 29 Jun 2018 15:10:28 +0200 (CEST)",
                "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 028DC5F16\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 15:10:27 +0200 (CEST)",
                "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 682B6818F037;\n\tFri, 29 Jun 2018 13:10:27 +0000 (UTC)",
                "from [10.36.112.15] (unknown [10.36.112.15])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 653CD21565E1;\n\tFri, 29 Jun 2018 13:10:26 +0000 (UTC)"
            ],
            "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Content-Transfer-Encoding": "7bit",
            "Subject": "Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Content-Language": "en-US",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Mailman-Version": "2.1.15"
        }
    },
    {
        "id": 82995,
        "web_url": "http://patches.dpdk.org/comment/82995/",
        "msgid": "<86228AFD5BCD8E4EBFD2B90117B5E81E630D016D@SHSMSX103.ccr.corp.intel.com>",
        "date": "2018-06-30T16:07:25",
        "subject": "Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature",
        "submitter": {
            "id": 17,
            "url": "http://patches.dpdk.org/api/people/17/",
            "name": "Liu, Yong",
            "email": "yong.liu@intel.com"
        },
        "content": "Thanks, Maxime. I have sent v4 with checkpatch and commit log warnings fixed.\n\nRegards,\nMarvin \n\n> -----Original Message-----\n> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]\n> Sent: Friday, June 29, 2018 9:10 PM\n> To: Liu, Yong <yong.liu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>\n> Cc: Wang, Zhihong <zhihong.wang@intel.com>; dev@dpdk.org\n> Subject: Re: [PATCH v3 00/11] support in-order feature\n> \n> Hi,\n> \n> I was about to apply it, but there are quite a few checkpatch and\n> git-check-log.sh issues reported.\n> \n> Could you please resent with this fixed?\n> Also, I think it would be  better to squash the doc patches in relevant\n> ones.\n> \n> Thanks,\n> Maxime\n> On 06/28/2018 11:52 PM, Marvin Liu wrote:\n> > In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> > When this feature has been negotiated, virtio driver will use\n> > descriptors in ring order: starting from offset 0 in the table, and\n> > wrapping around at the end of the table. Vhost devices will always use\n> > descriptors in the same order in which they have been made available.\n> > This can reduce virtio accesses to used ring.\n> >\n> > Based on updated virtio-spec, this series realized IN_ORDER prototype\n> > in virtio driver. Due to new [RT]x path added into selection, also add\n> > two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> > list. This will allow user to configure feature bits thus can impact\n> > [RT]x path selection.\n> >\n> > Performance of virtio user with IN_ORDER feature:\n> >\n> >      Platform: Purely\n> >      CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n> >      DPDK baseline: 18.05\n> >      Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> >\n> >      +--------------+----------+----------+---------+\n> >      |Vhost->Virtio |1 Queue   |2 Queues  |4 Queues |\n> >      +--------------+----------+----------+---------+\n> >      |Inorder       |12.0Mpps  |24.2Mpps  |26.0Mpps |\n> >      |Normal        |12.1Mpps  |18.5Mpps  |18.9Mpps |\n> >      +--------------+----------+----------+---------+\n> >\n> >      +--------------+----------+----------------+---------+\n> >      |Virtio->Vhost |1 Queue   |2 Queues        |4 Queues |\n> >      +--------------+----------+----------------+---------+\n> >      |Inorder       |13.8Mpps  |10.7 ~ 15.2Mpps |11.5Mpps |\n> >      |Normal        |13.3Mpps  |9.8 ~ 14Mpps    |10.5Mpps |\n> >      +--------------+----------+----------------+---------+\n> >\n> >      +---------+----------+----------------+----------------+\n> >      |Loopback |1 Queue   |2 Queues        |4 Queues        |\n> >      +---------+----------+----------------+----------------+\n> >      |Inorder  |7.4Mpps   |9.1 ~ 11.6Mpps  |10.5 ~ 11.3Mpps |\n> >      +---------+----------+----------------+----------------+\n> >      |Normal   |7.5Mpps   |7.7 ~ 9.0Mpps   |7.6 ~ 7.8Mpps   |\n> >      +---------+----------+----------------+----------------+\n> >\n> > v3:\n> > - refine [RT]x function selection logic\n> > - fix in-order mergable packets index error\n> > - combine unsupport mask patch\n> > - doc virtio in-order update\n> > - fix checkpatch error\n> >\n> > v2:\n> > - merge to latest dpdk-net-virtio\n> > - not use in_direct for normal xmit packets\n> > - update available ring for each descriptor\n> > - clean up IN_ORDER xmit function\n> > - unmask feature bits when disabled in_order or mgr_rxbuf\n> > - extract common part between IN_ORDER and normal functions\n> > - update performance result\n> >\n> > Marvin Liu (11):\n> >    vhost: advertise support in-order feature\n> >    net/virtio: add in-order feature bit definition\n> >    net/virtio-user: add unsupported features mask\n> >    net/virtio-user: add mrg_rxbuf and in_order vdev parameters\n> >    net/virtio: free in-order descriptors before device start\n> >    net/virtio: extract common part for in-order functions\n> >    net/virtio: support in-order Rx and Tx\n> >    net/virtio: add in-order Rx/Tx into selection\n> >    net/virtio: advertise support in-order feature\n> >    doc: add mrg_rxbuf and in_order parameters for virtio device\n> >    doc: add in-order funciton for virtio device\n> >\n> >   doc/guides/nics/virtio.rst                    |  27 +-\n> >   drivers/net/virtio/virtio_ethdev.c            |  29 +-\n> >   drivers/net/virtio/virtio_ethdev.h            |   7 +\n> >   drivers/net/virtio/virtio_pci.h               |   8 +\n> >   drivers/net/virtio/virtio_rxtx.c              | 635 ++++++++++++++++--\n> >   .../net/virtio/virtio_user/virtio_user_dev.c  |  26 +-\n> >   .../net/virtio/virtio_user/virtio_user_dev.h  |   4 +-\n> >   drivers/net/virtio/virtio_user_ethdev.c       |  45 +-\n> >   drivers/net/virtio/virtqueue.c                |   8 +\n> >   drivers/net/virtio/virtqueue.h                |   2 +\n> >   lib/librte_vhost/socket.c                     |   6 +\n> >   lib/librte_vhost/vhost.h                      |  10 +-\n> >   12 files changed, 723 insertions(+), 84 deletions(-)\n> >",
        "headers": {
            "dlp-reaction": "no-action",
            "X-Amp-File-Uploaded": "False",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Thread-Index": "AQHUDulG2hfMjK99Bkm+3VO6BG6gfaR2sSUAgAJJqqA=",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-MS-Has-Attach": "",
            "dlp-version": "11.0.200.100",
            "X-Original-To": "patchwork@dpdk.org",
            "Date": "Sat, 30 Jun 2018 16:07:25 +0000",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "In-Reply-To": "<c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com>",
            "x-ctpclassification": "CTP_NT",
            "Message-ID": "<86228AFD5BCD8E4EBFD2B90117B5E81E630D016D@SHSMSX103.ccr.corp.intel.com>",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "zh-CN, en-US",
            "References": "<20180628215235.106069-1-yong.liu@intel.com>\n\t<c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com>",
            "X-MS-TNEF-Correlator": "",
            "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjExNWJiNzItMThiNC00Yzc5LTg3ODgtMmI3ODFmMDAzMjMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic1VpUmI4ZTljcjZkVVpcLzNBbjJxVkxWVUdqMWw4alFnd3p3TElHcG8rYzZ4ZW5KZ3NpMEVKcVY4V3JiUmM3cVkifQ==",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, \"Bie, Tiwei\"\n\t<tiwei.bie@intel.com>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Post": "<mailto:dev@dpdk.org>",
            "MIME-Version": "1.0",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 54C131BE9B;\n\tSat, 30 Jun 2018 18:07:42 +0200 (CEST)",
                "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 4B6861BE04\n\tfor <dev@dpdk.org>; Sat, 30 Jun 2018 18:07:41 +0200 (CEST)",
                "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Jun 2018 09:07:40 -0700",
                "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby orsmga003.jf.intel.com with ESMTP; 30 Jun 2018 09:07:39 -0700",
                "from FMSMSX109.amr.corp.intel.com (10.18.116.9) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Sat, 30 Jun 2018 09:07:39 -0700",
                "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tfmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Sat, 30 Jun 2018 09:07:39 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id\n\t14.03.0319.002; Sun, 1 Jul 2018 00:07:26 +0800"
            ],
            "From": "\"Liu, Yong\" <yong.liu@intel.com>",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "X-ExtLoop1": "1",
            "CC": "\"Wang, Zhihong\" <zhihong.wang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "dlp-product": "dlpe-windows",
            "Content-Transfer-Encoding": "base64",
            "Subject": "Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "x-originating-ip": "[10.239.127.40]",
            "Content-Language": "en-US",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "Delivered-To": "patchwork@dpdk.org",
            "Thread-Topic": "[PATCH v3 00/11] support in-order feature",
            "X-IronPort-AV": "E=Sophos;i=\"5.51,291,1526367600\"; d=\"scan'208\";a=\"63434890\""
        }
    }
]