Cover Comment List
List cover comments
GET /api/covers/41657/comments/?format=api
[ { "id": 83011, "web_url": "http://patches.dpdk.org/comment/83011/", "msgid": "<aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com", "date": "2018-07-02T10:40:21", "subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "submitter": { "id": 482, "url": "http://patches.dpdk.org/api/people/482/?format=api", "name": "Mohammad Abdul Awal", "email": "mohammad.abdul.awal@intel.com" }, "content": "On 27/06/2018 12:45, Nelio Laranjeiro wrote:\n> This series adds an easy and maintainable configuration version support for\n> those two actions for 18.08 by using global variables in testpmd to store the\n> necessary information for the tunnel encapsulation. Those variables are used\n> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily\n> the action for flows.\n>\n> A common way to use it:\n>\n> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n>\n> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n>\n> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n>\n> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n>\n> This also replace the proposal done by Mohammad Abdul Awal [1] which handles\n> in a more complex way for the same work.\n>\n> Note this API has already a modification planned for 18.11 [2] thus those\n> series should have a limited life for a single release.\n>\n> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html\n> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html\n>\n> Changes in v7:\n>\n> - add missing documentation added in v5 and removed in v6 by mistake.\n>\n> Changes in v6:\n>\n> - fix compilation under redhat 7.5 with gcc 4.8.5 20150623\n>\n> Changes in v5:\n>\n> - fix documentation generation.\n> - add more explanation on how to generate several encapsulated flows.\n>\n> Changes in v4:\n>\n> - fix big endian issue on vni and tni.\n> - add samples to the documentation.\n> - set the VXLAN UDP source port to 0 by default to let the driver generate it\n> from the inner hash as described in the RFC 7348.\n> - use default rte flow mask for each item.\n>\n> Changes in v3:\n>\n> - support VLAN in the outer encapsulation.\n> - fix the documentation with missing arguments.\n>\n> Changes in v2:\n>\n> - add default IPv6 values for NVGRE encapsulation.\n> - replace VXLAN to NVGRE in comments concerning NVGRE layer.\n>\n> Nelio Laranjeiro (2):\n> app/testpmd: add VXLAN encap/decap support\n> app/testpmd: add NVGRE encap/decap support\n>\n> app/test-pmd/cmdline.c | 252 ++++++++++++++++++\n> app/test-pmd/cmdline_flow.c | 274 ++++++++++++++++++++\n> app/test-pmd/testpmd.c | 32 +++\n> app/test-pmd/testpmd.h | 32 +++\n> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 82 ++++++\n> 5 files changed, 672 insertions(+)\n\n\nHi,\n\nI have one concern in terms of usability though.\nIn testpmd, the rte_flow command line options have auto-completion with \n\"<item_name> <item_name_value>\" format which make using the command very \nmuch user friendly.\n\nFor the command \"set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 \n11:11:11:11:11:11 22:22:22:22:22:22\", it does not look much user \nfriendly to me. A user may easily lose track of sequence of 9 param \nitems. It would be much user friendly if the options would be like below \nand has auto-completion.\n\nset vxlan ip_ver <ip_ver-value> vni <vni-value> udp_src <udp_src-value> \nudp-dst <udp_dst-value> ip_src <ip_src-value> ip_dst <ip_dst-value> \neth_src <eth_src-value> eth_dst <eth_dst-value>\n\nThis way an user may never feel confused. Can maintainers comment on \nthis point please?\n\nRegards,\nAwal.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CA06F4CE4;\n\tMon, 2 Jul 2018 12:40:26 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 8094F4CC3\n\tfor <dev@dpdk.org>; Mon, 2 Jul 2018 12:40:24 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2018 03:40:23 -0700", "from awalabdu-mobl.ger.corp.intel.com (HELO [163.33.176.189])\n\t([163.33.176.189])\n\tby fmsmga004.fm.intel.com with ESMTP; 02 Jul 2018 03:40:22 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,298,1526367600\"; d=\"scan'208\";a=\"67981232\"", "To": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n\tBernard Iremonger <bernard.iremonger@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Cc": "Ori Kam <orika@mellanox.com>", "References": "<cover.1530093083.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530099631.git.nelio.laranjeiro@6wind.com>", "From": "Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>", "Message-ID": "<aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com>", "Date": "Mon, 2 Jul 2018 11:40:21 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0", "MIME-Version": "1.0", "In-Reply-To": "<cover.1530099631.git.nelio.laranjeiro@6wind.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 83184, "web_url": "http://patches.dpdk.org/comment/83184/", "msgid": "<fe98f4b6-6af0-100d-7f15-a4c7dbb138a7@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/fe98f4b6-6af0-100d-7f15-a4c7dbb138a7@intel.com", "date": "2018-07-04T14:54:32", "subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote:\n> \n> On 27/06/2018 12:45, Nelio Laranjeiro wrote:\n>> This series adds an easy and maintainable configuration version support for\n>> those two actions for 18.08 by using global variables in testpmd to store the\n>> necessary information for the tunnel encapsulation. Those variables are used\n>> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily\n>> the action for flows.\n>>\n>> A common way to use it:\n>>\n>> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n>>\n>> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n>>\n>> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n>>\n>> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n>>\n>> This also replace the proposal done by Mohammad Abdul Awal [1] which handles\n>> in a more complex way for the same work.\n>>\n>> Note this API has already a modification planned for 18.11 [2] thus those\n>> series should have a limited life for a single release.\n>>\n>> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html\n>> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html\n>>\n>> Changes in v7:\n>>\n>> - add missing documentation added in v5 and removed in v6 by mistake.\n>>\n>> Changes in v6:\n>>\n>> - fix compilation under redhat 7.5 with gcc 4.8.5 20150623\n>>\n>> Changes in v5:\n>>\n>> - fix documentation generation.\n>> - add more explanation on how to generate several encapsulated flows.\n>>\n>> Changes in v4:\n>>\n>> - fix big endian issue on vni and tni.\n>> - add samples to the documentation.\n>> - set the VXLAN UDP source port to 0 by default to let the driver generate it\n>> from the inner hash as described in the RFC 7348.\n>> - use default rte flow mask for each item.\n>>\n>> Changes in v3:\n>>\n>> - support VLAN in the outer encapsulation.\n>> - fix the documentation with missing arguments.\n>>\n>> Changes in v2:\n>>\n>> - add default IPv6 values for NVGRE encapsulation.\n>> - replace VXLAN to NVGRE in comments concerning NVGRE layer.\n>>\n>> Nelio Laranjeiro (2):\n>> app/testpmd: add VXLAN encap/decap support\n>> app/testpmd: add NVGRE encap/decap support\n>>\n>> app/test-pmd/cmdline.c | 252 ++++++++++++++++++\n>> app/test-pmd/cmdline_flow.c | 274 ++++++++++++++++++++\n>> app/test-pmd/testpmd.c | 32 +++\n>> app/test-pmd/testpmd.h | 32 +++\n>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 82 ++++++\n>> 5 files changed, 672 insertions(+)\n> \n> \n> Hi,\n> \n> I have one concern in terms of usability though.\n> In testpmd, the rte_flow command line options have auto-completion with \n> \"<item_name> <item_name_value>\" format which make using the command very \n> much user friendly.\n> \n> For the command \"set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 \n> 11:11:11:11:11:11 22:22:22:22:22:22\", it does not look much user \n> friendly to me. A user may easily lose track of sequence of 9 param \n> items. It would be much user friendly if the options would be like below \n> and has auto-completion.\n> \n> set vxlan ip_ver <ip_ver-value> vni <vni-value> udp_src <udp_src-value> \n> udp-dst <udp_dst-value> ip_src <ip_src-value> ip_dst <ip_dst-value> \n> eth_src <eth_src-value> eth_dst <eth_dst-value>\n\nHi Nelio, Adrien,\n\nI tend to agree with Awal here, this is to forget/confuse and key-value pairs\nmakes it easier to use.\n\nMeanwhile this is an usability improvement and I prefer not to block this patch\nfor this.\n\nWhat is your comment on this, how should we proceed?\n\nThanks,\nferruh\n\n> \n> This way an user may never feel confused. Can maintainers comment on \n> this point please?\n> \n> Regards,\n> Awal.\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E69481BF47;\n\tWed, 4 Jul 2018 16:54:36 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id BABF41BF45\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 16:54:35 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Jul 2018 07:54:34 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83])\n\t([10.237.221.83])\n\tby fmsmga002.fm.intel.com with ESMTP; 04 Jul 2018 07:54:32 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,306,1526367600\"; d=\"scan'208\";a=\"64156978\"", "To": "Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>,\n\tNelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n\tBernard Iremonger <bernard.iremonger@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Cc": "Ori Kam <orika@mellanox.com>", "References": "<cover.1530093083.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530099631.git.nelio.laranjeiro@6wind.com>\n\t<aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\txsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE\n\tFgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E\n\tTS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62\n\tFwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4\n\tjQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB\n\tc34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF\n\tHmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd\n\tfmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1\n\tyC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p\n\tmsjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg\n\tHiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW\n\tta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN\n\tipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy\n\tK4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X\n\tpAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq\n\tvOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM\n\tn44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1\n\tEd3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj\n\t8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s\n\tDWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9\n\t+P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB\n\tZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J\n\tEE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG\n\t+jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17\n\tQc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj\n\tccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+\n\tFJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og\n\t77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB\n\tLki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90\n\tNu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa\n\t2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA\n\tQ6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu\n\tUhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG\n\tZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ\n\tzT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU\n\tNyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK\n\tFYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs\n\ttFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC\n\tx41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA\n\tbLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ\n\tqZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3\n\tXphVR5G70mnca1E2vzC77z+XSlTyRA==", "Message-ID": "<fe98f4b6-6af0-100d-7f15-a4c7dbb138a7@intel.com>", "Date": "Wed, 4 Jul 2018 15:54:32 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.0", "MIME-Version": "1.0", "In-Reply-To": "<aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 83242, "web_url": "http://patches.dpdk.org/comment/83242/", "msgid": "<20180705093747.4mwgpoxktifva546@laranjeiro-vm.dev.6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180705093747.4mwgpoxktifva546@laranjeiro-vm.dev.6wind.com", "date": "2018-07-05T09:37:47", "subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "content": "On Wed, Jul 04, 2018 at 03:54:32PM +0100, Ferruh Yigit wrote:\n> On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote:\n> > \n> > On 27/06/2018 12:45, Nelio Laranjeiro wrote:\n> >> This series adds an easy and maintainable configuration version support for\n> >> those two actions for 18.08 by using global variables in testpmd to store the\n> >> necessary information for the tunnel encapsulation. Those variables are used\n> >> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily\n> >> the action for flows.\n> >>\n> >> A common way to use it:\n> >>\n> >> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n> >> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n> >>\n> >> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n> >> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end\n> >>\n> >> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22\n> >> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n> >>\n> >> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22\n> >> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end\n> >>\n> >> This also replace the proposal done by Mohammad Abdul Awal [1] which handles\n> >> in a more complex way for the same work.\n> >>\n> >> Note this API has already a modification planned for 18.11 [2] thus those\n> >> series should have a limited life for a single release.\n> >>\n> >> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html\n> >> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html\n> >>\n> >> Changes in v7:\n> >>\n> >> - add missing documentation added in v5 and removed in v6 by mistake.\n> >>\n> >> Changes in v6:\n> >>\n> >> - fix compilation under redhat 7.5 with gcc 4.8.5 20150623\n> >>\n> >> Changes in v5:\n> >>\n> >> - fix documentation generation.\n> >> - add more explanation on how to generate several encapsulated flows.\n> >>\n> >> Changes in v4:\n> >>\n> >> - fix big endian issue on vni and tni.\n> >> - add samples to the documentation.\n> >> - set the VXLAN UDP source port to 0 by default to let the driver generate it\n> >> from the inner hash as described in the RFC 7348.\n> >> - use default rte flow mask for each item.\n> >>\n> >> Changes in v3:\n> >>\n> >> - support VLAN in the outer encapsulation.\n> >> - fix the documentation with missing arguments.\n> >>\n> >> Changes in v2:\n> >>\n> >> - add default IPv6 values for NVGRE encapsulation.\n> >> - replace VXLAN to NVGRE in comments concerning NVGRE layer.\n> >>\n> >> Nelio Laranjeiro (2):\n> >> app/testpmd: add VXLAN encap/decap support\n> >> app/testpmd: add NVGRE encap/decap support\n> >>\n> >> app/test-pmd/cmdline.c | 252 ++++++++++++++++++\n> >> app/test-pmd/cmdline_flow.c | 274 ++++++++++++++++++++\n> >> app/test-pmd/testpmd.c | 32 +++\n> >> app/test-pmd/testpmd.h | 32 +++\n> >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 82 ++++++\n> >> 5 files changed, 672 insertions(+)\n> > \n> > \n> > Hi,\n> > \n> > I have one concern in terms of usability though.\n> > In testpmd, the rte_flow command line options have auto-completion with \n> > \"<item_name> <item_name_value>\" format which make using the command very \n> > much user friendly.\n> > \n> > For the command \"set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 \n> > 11:11:11:11:11:11 22:22:22:22:22:22\", it does not look much user \n> > friendly to me. A user may easily lose track of sequence of 9 param \n> > items. It would be much user friendly if the options would be like below \n> > and has auto-completion.\n> > \n> > set vxlan ip_ver <ip_ver-value> vni <vni-value> udp_src <udp_src-value> \n> > udp-dst <udp_dst-value> ip_src <ip_src-value> ip_dst <ip_dst-value> \n> > eth_src <eth_src-value> eth_dst <eth_dst-value>\n> \n> Hi Nelio, Adrien,\n> \n> I tend to agree with Awal here, this is to forget/confuse and key-value pairs\n> makes it easier to use.\n> \n> Meanwhile this is an usability improvement and I prefer not to block this patch\n> for this.\n> \n> What is your comment on this, how should we proceed?\n> \n> Thanks,\n> ferruh\n\nHi,\n\nI also agree with this proposal, I'll prepare a v8 with those fix\ntokens.\n\n> > This way an user may never feel confused. Can maintainers comment on \n> > this point please?\n> > \n> > Regards,\n> > Awal.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DC8321C367;\n\tThu, 5 Jul 2018 11:37:50 +0200 (CEST)", "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 0752A1C363\n\tfor <dev@dpdk.org>; Thu, 5 Jul 2018 11:37:49 +0200 (CEST)", "by mail-wm0-f66.google.com with SMTP id s12-v6so10002857wmc.1\n\tfor <dev@dpdk.org>; Thu, 05 Jul 2018 02:37:49 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tm17-v6sm8856950wrg.65.2018.07.05.02.37.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 05 Jul 2018 02:37:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to:openpgp\n\t:user-agent; bh=6Bsw/h+bzLaQct+V3n9pRTaa9H26W4Cq2LOSpiE/Pvs=;\n\tb=aGLtHV5p0ECwjIOytoHDl5r1aKs88cWgE9QSm9WY8eFPKDBWpm0u72sa0jsXc9yq8K\n\tyi2O5H8B/Z3CxYg0xdRGpQmedzQwPSj9lNL3tbhXi0hBZEKFL+6PnsTHYxwce1DhJiPz\n\tRUus/ismU22NUNXvj61Bz+i9UU6pGILpm3h24eLZVmKLI3HwqAiy45IrbkKIJIBV2MeY\n\t8/ACMvqibh5ggr8Rw/3vmM7D1iMmaM0LRNbwMb/P0TJzNPpYMBaGtwLhE+0n8MAU1MVy\n\trRz2hLvvy+J7HLiqM0iJds/pqzFRlkJSSmfLKEMDPRdA83vmEHaXthP1kBzHJlZPXuMm\n\tJl9g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:openpgp:user-agent;\n\tbh=6Bsw/h+bzLaQct+V3n9pRTaa9H26W4Cq2LOSpiE/Pvs=;\n\tb=GlpLUhFcQojq5ZZGMhgGl88MxDjam8s+jBM8mgwVnmWW9llwLkgFIK3H+fX5GAQk/S\n\t6TDQ2PWBubMYwAOT32WYcOntG94TDiXk+0zSKxvtU0AhYKhkmdU0MI7wxijacVhGIZ5r\n\t1dUNZUkOiWDNC9kujzL2kX3eezUi6fRSQuwKrH7/mWeWyr8T9Jnw75Lgxg5RyChfWQx/\n\tTE1w6EmRFN66Kb+14tlV9Tw9JMeqeA/JQ/wZn3hLMfikZmbP8l1A/Nxo2RJRkHTUHgHe\n\tlaKlX/7b873m9bMRK9MsaTrRbYhXT+KxBYspBoA7Zwk/SBGgNfONacU6Xk3y2Hk7QRl3\n\tYRZQ==", "X-Gm-Message-State": "APt69E1GDIf0sg2a1OHMhOl3zBJNpxYTF3b+OQGWryIwnWgN3YsPU+4+\n\tp6QNqDTWbSXEfJ1HLoa1imjR", "X-Google-Smtp-Source": "AAOMgpfRJkqO9keAmWRMHMu+azaKCBPkO/i/8MFLNrcgtUCH5uB018uOoIICyWVAiz5oRM9NweOHEg==", "X-Received": "by 2002:adf:c44c:: with SMTP id\n\ta12-v6mr4224893wrg.20.1530783469764; \n\tThu, 05 Jul 2018 02:37:49 -0700 (PDT)", "Date": "Thu, 5 Jul 2018 11:37:47 +0200", "From": "=?iso-8859-1?q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>, dev@dpdk.org,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n\tBernard Iremonger <bernard.iremonger@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tOri Kam <orika@mellanox.com>", "Message-ID": "<20180705093747.4mwgpoxktifva546@laranjeiro-vm.dev.6wind.com>", "References": "<cover.1530093083.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530099631.git.nelio.laranjeiro@6wind.com>\n\t<aa2b7417-d0f2-8e55-8bd0-b008acc843d5@intel.com>\n\t<fe98f4b6-6af0-100d-7f15-a4c7dbb138a7@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=iso-8859-1", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<fe98f4b6-6af0-100d-7f15-a4c7dbb138a7@intel.com>", "OpenPGP": "id=A0075DA8F66A5949 preference=signencrypt", "User-Agent": "NeoMutt/20170113 (1.7.2)", "Subject": "Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE\n\tEncap/Decap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]