Cover Comment List
List cover comments
GET /api/covers/41469/comments/?format=api
[ { "id": 82604, "web_url": "http://patches.dpdk.org/comment/82604/", "msgid": "<dc9289c1-d51e-2ff2-6a5a-9d83a95c9522@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/dc9289c1-d51e-2ff2-6a5a-9d83a95c9522@redhat.com", "date": "2018-06-26T07:56:13", "subject": "Re: [dpdk-dev] [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "Hi,\n\nOn 06/25/2018 05:17 PM, Marvin Liu wrote:\n> In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> When this feature has been negotiated, virtio driver will use\n> descriptors in ring order: starting from offset 0 in the table, and\n> wrapping around at the end of the table. Vhost devices will always use\n> descriptors in the same order in which they have been made available.\n> This can reduce virtio accesses to used ring.\n> \n> Based on updated virtio-spec, this series realized IN_ORDER prototype\n> in virtio driver. Due to new [RT]x path added into selection, also add\n> two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> list. This will allow user to configure feature bits thus can impact\n> [RT]x path selection.\n> \n> Performance of virtio user with IN_ORDER feature:\n> \n> Platform: Purely\n> CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n> DPDK baseline: 18.05\n> Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> \n> +--------------+----------+----------+---------+\n> |Vhost->Virtio |1 Queue |2 Queues |4 Queues |\n> +--------------+----------+----------+---------+\n> |Inorder |12.0Mpps |24.2Mpps |26.0Mpps |\n> |Normal |12.1Mpps |18.5Mpps |18.9Mpps |\n> +--------------+----------+----------+---------+\n> \n> +--------------+----------+----------------+---------+\n> |Virtio->Vhost |1 Queue |2 Queues |4 Queues |\n> +--------------+----------+----------------+---------+\n> |Inorder |13.8Mpps |10.7 ~ 15.2Mpps |11.5Mpps |\n> |Normal |13.3Mpps |9.8 ~ 14Mpps |10.5Mpps |\n> +--------------+----------+----------------+---------+\n> \n> +---------+----------+----------------+----------------+\n> |Loopback |1 Queue |2 Queues |4 Queues |\n> +---------+----------+----------------+----------------+\n> |Inorder |7.4Mpps |9.1 ~ 11.6Mpps |10.5 ~ 11.3Mpps |\n> +---------+----------+----------------+----------------+\n> |Normal |7.5Mpps |7.7 ~ 9.0Mpps |7.6 ~ 7.8Mpps |\n> +---------+----------+----------------+----------------+\n> \n> v2:\n> - merge to latest dpdk-net-virtio\n> - not use in_direct for normal xmit packets\n> - update available ring for each descriptor\n> - clean up IN_ORDER xmit function\n> - unmask feature bits when disabled in_order or mgr_rxbuf\n> - extract common part between IN_ORDER and normal functions\n> - update performance result\n> \n> Marvin Liu (8):\n> vhost: announce VIRTIO_F_IN_ORDER support\n> net/virtio: add VIRTIO_F_IN_ORDER definition\n> net/virtio-user: add mrg_rxbuf and in_order vdev parameters\n> net/virtio: free IN_ORDER descriptors before device start\n> net/virtio: extract common part for IN_ORDER functions\n> net/virtio: support IN_ORDER Rx and Tx\n> net/virtio: add IN_ORDER Rx/Tx into selection\n> net/virtio: annouce VIRTIO_F_IN_ORDER support\n\nI haven't checked but guess the titles doesn't pass the check-git-log.sh\nscript as they contains underscores.\n\n> drivers/net/virtio/virtio_ethdev.c | 31 +-\n> drivers/net/virtio/virtio_ethdev.h | 7 +\n> drivers/net/virtio/virtio_pci.h | 8 +\n> drivers/net/virtio/virtio_rxtx.c | 635 ++++++++++++++++--\n> .../net/virtio/virtio_user/virtio_user_dev.c | 14 +-\n> .../net/virtio/virtio_user/virtio_user_dev.h | 3 +-\n> drivers/net/virtio/virtio_user_ethdev.c | 33 +-\n> drivers/net/virtio/virtqueue.c | 8 +\n> drivers/net/virtio/virtqueue.h | 2 +\n> lib/librte_vhost/socket.c | 6 +\n> lib/librte_vhost/vhost.h | 10 +-\n> 11 files changed, 688 insertions(+), 69 deletions(-)\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DAFDC5F32;\n\tTue, 26 Jun 2018 09:56:17 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id B3AC55F2A\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 09:56:16 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 53A8981A4EA4;\n\tTue, 26 Jun 2018 07:56:16 +0000 (UTC)", "from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5C775111AF0B;\n\tTue, 26 Jun 2018 07:56:15 +0000 (UTC)" ], "To": "Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com", "Cc": "zhihong.wang@intel.com, dev@dpdk.org", "References": "<20180625151710.29437-1-yong.liu@intel.com>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Message-ID": "<dc9289c1-d51e-2ff2-6a5a-9d83a95c9522@redhat.com>", "Date": "Tue, 26 Jun 2018 09:56:13 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0", "MIME-Version": "1.0", "In-Reply-To": "<20180625151710.29437-1-yong.liu@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.8]); Tue, 26 Jun 2018 07:56:16 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.8]); \n\tTue, 26 Jun 2018 07:56:16 +0000 (UTC) for IP:'10.11.54.3'\n\tDOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "Re: [dpdk-dev] [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 82606, "web_url": "http://patches.dpdk.org/comment/82606/", "msgid": "<86228AFD5BCD8E4EBFD2B90117B5E81E630CA7A5@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/86228AFD5BCD8E4EBFD2B90117B5E81E630CA7A5@SHSMSX103.ccr.corp.intel.com", "date": "2018-06-26T08:01:17", "subject": "Re: [dpdk-dev] [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature", "submitter": { "id": 17, "url": "http://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "content": "> -----Original Message-----\n> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]\n> Sent: Tuesday, June 26, 2018 3:56 PM\n> To: Liu, Yong <yong.liu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>\n> Cc: Wang, Zhihong <zhihong.wang@intel.com>; dev@dpdk.org\n> Subject: Re: [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature\n> \n> Hi,\n> \n> On 06/25/2018 05:17 PM, Marvin Liu wrote:\n> > In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> > When this feature has been negotiated, virtio driver will use\n> > descriptors in ring order: starting from offset 0 in the table, and\n> > wrapping around at the end of the table. Vhost devices will always use\n> > descriptors in the same order in which they have been made available.\n> > This can reduce virtio accesses to used ring.\n> >\n> > Based on updated virtio-spec, this series realized IN_ORDER prototype\n> > in virtio driver. Due to new [RT]x path added into selection, also add\n> > two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> > list. This will allow user to configure feature bits thus can impact\n> > [RT]x path selection.\n> >\n> > Performance of virtio user with IN_ORDER feature:\n> >\n> > Platform: Purely\n> > CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n> > DPDK baseline: 18.05\n> > Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> >\n> > +--------------+----------+----------+---------+\n> > |Vhost->Virtio |1 Queue |2 Queues |4 Queues |\n> > +--------------+----------+----------+---------+\n> > |Inorder |12.0Mpps |24.2Mpps |26.0Mpps |\n> > |Normal |12.1Mpps |18.5Mpps |18.9Mpps |\n> > +--------------+----------+----------+---------+\n> >\n> > +--------------+----------+----------------+---------+\n> > |Virtio->Vhost |1 Queue |2 Queues |4 Queues |\n> > +--------------+----------+----------------+---------+\n> > |Inorder |13.8Mpps |10.7 ~ 15.2Mpps |11.5Mpps |\n> > |Normal |13.3Mpps |9.8 ~ 14Mpps |10.5Mpps |\n> > +--------------+----------+----------------+---------+\n> >\n> > +---------+----------+----------------+----------------+\n> > |Loopback |1 Queue |2 Queues |4 Queues |\n> > +---------+----------+----------------+----------------+\n> > |Inorder |7.4Mpps |9.1 ~ 11.6Mpps |10.5 ~ 11.3Mpps |\n> > +---------+----------+----------------+----------------+\n> > |Normal |7.5Mpps |7.7 ~ 9.0Mpps |7.6 ~ 7.8Mpps |\n> > +---------+----------+----------------+----------------+\n> >\n> > v2:\n> > - merge to latest dpdk-net-virtio\n> > - not use in_direct for normal xmit packets\n> > - update available ring for each descriptor\n> > - clean up IN_ORDER xmit function\n> > - unmask feature bits when disabled in_order or mgr_rxbuf\n> > - extract common part between IN_ORDER and normal functions\n> > - update performance result\n> >\n> > Marvin Liu (8):\n> > vhost: announce VIRTIO_F_IN_ORDER support\n> > net/virtio: add VIRTIO_F_IN_ORDER definition\n> > net/virtio-user: add mrg_rxbuf and in_order vdev parameters\n> > net/virtio: free IN_ORDER descriptors before device start\n> > net/virtio: extract common part for IN_ORDER functions\n> > net/virtio: support IN_ORDER Rx and Tx\n> > net/virtio: add IN_ORDER Rx/Tx into selection\n> > net/virtio: annouce VIRTIO_F_IN_ORDER support\n> \n> I haven't checked but guess the titles doesn't pass the check-git-log.sh\n> script as they contains underscores.\n\nThanks for your reminder, Maxime. I will replace \"IN_ORDER\" to \"in order\" which can pass check.\n> \n> > drivers/net/virtio/virtio_ethdev.c | 31 +-\n> > drivers/net/virtio/virtio_ethdev.h | 7 +\n> > drivers/net/virtio/virtio_pci.h | 8 +\n> > drivers/net/virtio/virtio_rxtx.c | 635 ++++++++++++++++--\n> > .../net/virtio/virtio_user/virtio_user_dev.c | 14 +-\n> > .../net/virtio/virtio_user/virtio_user_dev.h | 3 +-\n> > drivers/net/virtio/virtio_user_ethdev.c | 33 +-\n> > drivers/net/virtio/virtqueue.c | 8 +\n> > drivers/net/virtio/virtqueue.h | 2 +\n> > lib/librte_vhost/socket.c | 6 +\n> > lib/librte_vhost/vhost.h | 10 +-\n> > 11 files changed, 688 insertions(+), 69 deletions(-)\n> >", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7437C7CDA;\n\tTue, 26 Jun 2018 10:01:37 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 6BA277CBC\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 10:01:35 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 01:01:33 -0700", "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby orsmga001.jf.intel.com with ESMTP; 26 Jun 2018 01:01:20 -0700", "from fmsmsx112.amr.corp.intel.com (10.18.116.6) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Tue, 26 Jun 2018 01:01:20 -0700", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tFMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Tue, 26 Jun 2018 01:01:19 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id\n\t14.03.0319.002; Tue, 26 Jun 2018 16:01:18 +0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"67767007\"", "From": "\"Liu, Yong\" <yong.liu@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, \"Bie, Tiwei\"\n\t<tiwei.bie@intel.com>", "CC": "\"Wang, Zhihong\" <zhihong.wang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature", "Thread-Index": "AQHUDFaFRKE4IxpVa0mLpK1QJ/ClIaRxp4SAgACGn/A=", "Date": "Tue, 26 Jun 2018 08:01:17 +0000", "Message-ID": "<86228AFD5BCD8E4EBFD2B90117B5E81E630CA7A5@SHSMSX103.ccr.corp.intel.com>", "References": "<20180625151710.29437-1-yong.liu@intel.com>\n\t<dc9289c1-d51e-2ff2-6a5a-9d83a95c9522@redhat.com>", "In-Reply-To": "<dc9289c1-d51e-2ff2-6a5a-9d83a95c9522@redhat.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzBmY2VkMTYtNDliMC00MjQxLTg3YjMtOTQwNTk2YTQxODM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS1wvYkFxQ2pMWWluV3VyNmdFZGtwKzBtK0Rva0VneVN5b05MTXhwNXo1N2hidFlpeGEwdHdNNDI1eGdYZDk5M2cifQ==", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.200.100", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]