Cover Comment List
List cover comments
GET /api/covers/41363/comments/?format=api
[ { "id": 82502, "web_url": "http://patches.dpdk.org/comment/82502/", "msgid": "<729e7d13-7f92-fafe-1d9e-5ed9c0389099@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/729e7d13-7f92-fafe-1d9e-5ed9c0389099@intel.com", "date": "2018-06-21T14:28:58", "subject": "Re: [dpdk-dev] [PATCH v2 0/8] examples/vm_power: 100% Busy Polling", "submitter": { "id": 743, "url": "http://patches.dpdk.org/api/people/743/?format=api", "name": "Radu Nicolau", "email": "radu.nicolau@intel.com" }, "content": "On 6/21/2018 2:24 PM, David Hunt wrote:\n> This patch set adds the capability to do out-of-band power\n> monitoring on a system. It uses a thread to monitor the branch\n> counters in the targeted cores, and calculates the branch ratio\n> if the running code.\n>\n> If the branch ratop is low (0.01), then\n> the code is most likely running in a tight poll loop and doing\n> nothing, i.e. receiving no packets. In this case we scale down\n> the frequency of that core.\n>\n> If the branch ratio is higher (>0.01), then it is likely that\n> the code is receiving and processing packets. In this case, we\n> scale up the frequency of that core.\n>\n> The cpu counters are read via /dev/cpu/x/msr, so requires the\n> msr kernel module to be loaded. Because this method is used,\n> the patch set is implemented with one file for x86 systems, and\n> another for non-x86 systems, with conditional compilation in\n> the Makefile. The non-x86 functions are stubs, and do not\n> currently implement any functionality.\n>\n> The vm_power_manager app has been modified to take a new parameter\n> --core-list or -l\n> which takes a list of cores in a comma-separated list format,\n> e.g. 1,3,5-7,9, which resolvest to a core list of 1,3,5,6,7,9\n> These cores will then be enabled for oob monitoring. When the\n> OOB monitoring thread starts, it reads the branch hits/miss\n> counters of each monitored core, and scales up/down accordingly.\n>\n> The guest_cli app has also been modified to allow sending of a\n> policy of type BRANCH_RATIO where all of the cores included in\n> the policy will be monitored by the vm_power_manager oob thread.\n>\n> v2 changes:\n> * Add the guest_cli patch into this patch set, including the\n> ability to set the policy to BRANCH_RATIO.\n> http://patches.dpdk.org/patch/40742/\n> * When vm_power_manger receives a policy with type BRANCH_RATIO,\n> add the relevant cores to the monitoring thread.\n>\n> [1/8] examples/vm_power: add check for port count\n> [2/8] examples/vm_power: add core list parameter\n> [3/8] examples/vm_power: add oob monitoring functions\n> [4/8] examples/vm_power: allow greater than 64 cores\n> [5/8] examples/vm_power: add thread for oob core monitor\n> [6/8] examples/vm_power: add port-list to command line\n> [7/8] examples/vm_power: add branch ratio policy type\n> [8/8] examples/vm_power: add cli args to guest app\n>\nSeries Acked-by: Radu Nicolau <radu.nicolau@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 28F231B5F1;\n\tThu, 21 Jun 2018 16:29:09 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 6F95D1B5D2\n\tfor <dev@dpdk.org>; Thu, 21 Jun 2018 16:29:07 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Jun 2018 07:29:06 -0700", "from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.82])\n\t([10.237.221.82])\n\tby fmsmga004.fm.intel.com with ESMTP; 21 Jun 2018 07:28:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,252,1526367600\"; d=\"scan'208\";a=\"65141601\"", "To": "David Hunt <david.hunt@intel.com>, dev@dpdk.org", "References": "<20180607073705.32895-2-david.hunt@intel.com>\n\t<20180621132414.39047-1-david.hunt@intel.com>", "From": "Radu Nicolau <radu.nicolau@intel.com>", "Message-ID": "<729e7d13-7f92-fafe-1d9e-5ed9c0389099@intel.com>", "Date": "Thu, 21 Jun 2018 15:28:58 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.5.0", "MIME-Version": "1.0", "In-Reply-To": "<20180621132414.39047-1-david.hunt@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH v2 0/8] examples/vm_power: 100% Busy Polling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]