Cover Comment List
List cover comments
GET /api/covers/41014/comments/?format=api&order=submitter
[ { "id": 83722, "web_url": "http://patches.dpdk.org/comment/83722/", "msgid": "<2142629.lVosk762JX@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2142629.lVosk762JX@xps", "date": "2018-07-12T19:55:04", "subject": "Re: [dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus\n\tsupport", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "The old offload API has been removed.\nPlease could you adapt this PMD to the new API?\n\nThe errors are:\n../drivers/net/netvsc/hn_ethdev.c:185:4: error: ‘struct rte_eth_txconf’ has no member named ‘txq_flags’\n../drivers/net/netvsc/hn_ethdev.c:185:16: error: ‘ETH_TXQ_FLAGS_NOXSUMS’ undeclared (first use in this function)\n .txq_flags = ETH_TXQ_FLAGS_NOXSUMS,\n\n\nSome checkpatches warnings are remaining:\n\n### [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support\n\nWARNING:AVOID_EXTERNS: externs should be avoided in .c files\n#353: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:\n+extern struct rte_vmbus_bus rte_vmbus_bus;\n\nWARNING:AVOID_EXTERNS: externs should be avoided in .c files\n#2715: FILE: drivers/bus/vmbus/vmbus_common.c:26:\n+extern struct rte_vmbus_bus rte_vmbus_bus;\n\n### [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device\n\nCHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line\n#519: FILE: drivers/net/netvsc/hn_ethdev.c:189:\n+ dev_info->flow_type_rss_offloads\n+ = ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;\n\nCHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line\n#622: FILE: drivers/net/netvsc/hn_ethdev.c:292:\n+ const struct rte_eth_rss_conf *rss_conf\n+ = &dev_conf->rx_adv_conf.rss_conf;\n\nCHECK:CAMELCASE: Avoid CamelCase: <PRIx64>\n#632: FILE: drivers/net/netvsc/hn_ethdev.c:302:\n+ \"unsupported TX offload: %#\" PRIx64,\n\nCHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line\n#788: FILE: drivers/net/netvsc/hn_ethdev.c:458:\n+ const unsigned int nstats\n+ = dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)\n\nCHECK:CAMELCASE: Avoid CamelCase: <PRIx32>\n#2644: FILE: drivers/net/netvsc/hn_rndis.c:720:\n+ PMD_DRV_LOG(ERR, \"exec RNDIS set %#\" PRIx32 \" failed\",\n\nCHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line\n#3500: FILE: drivers/net/netvsc/hn_rxtx.c:441:\n+ struct rte_eth_dev *dev\n+ = &rte_eth_devices[rxq->port_id];", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C5855F4D;\n\tThu, 12 Jul 2018 21:55:09 +0200 (CEST)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n\t[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4D61D5F3B\n\tfor <dev@dpdk.org>; Thu, 12 Jul 2018 21:55:07 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E4DAD223C9;\n\tThu, 12 Jul 2018 15:55:06 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Thu, 12 Jul 2018 15:55:06 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 06A0910279;\n\tThu, 12 Jul 2018 15:55:05 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=mesmtp; bh=cnler709lhMCa0eC6cWVjDM62Q\n\t3gQeUWWO6RV91K//8=; b=erKjfPSWXYVQQsDfBN0X/AlG+LgHAIi0arS7j/Rmef\n\t+3AMUXLDlS8sBFmG9JfLWQWKiauWZukZKG4WdXEV005cFU5oyq29Lt+AwVgzFkmw\n\tyuwKjEPoK3Hp8p0SuFS3yYg3EnDmZAEreaRcv+76eqWUAN2GxwNxzHcM95YlUQth\n\tM=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=cnler7\n\t09lhMCa0eC6cWVjDM62Q3gQeUWWO6RV91K//8=; b=XJ+ipOt9LHL96FIkfU2zbe\n\tGgJbmtHGLr8pIFA/Ak6K/VufQRuWqxQGqmGzNznz3+htSoL0pPdA0t4iXsM8dLS3\n\tQSJiU3UWDhkjnitHuMhx6XUHKdIEnADBf7iyQr1k6EIoReRphh47jTft5IQnEeCu\n\tuq8YZCvqhmMyYLhYhJ89oTia6Jbh0hk6EXZ30zJWzweWRHivwW9Vu7pBaAZVApOk\n\t0ul+wCqKl/SmgqdUKNwZH6I+zsbPl/CznniNxzN/uuSNtWVHwV4WXRrn1eFR4ekp\n\tf00DcmgZJ2cX1covhWH/gGPgQpYuOzgzcd8m1sl8raH4lqv+xQ1aCvafsPoH93+w\n\t==" ], "X-ME-Proxy": "<xmx:GrJHW0oJzeq-nA6nr9MkGONJ-WySREz7-hdd0Oszmxxm9Dc9u9CLWA>\n\t<xmx:GrJHWwIHaDLzyyQxtrzvJuuBoebFNqVVTMgbYU8Mg8EbWRPwBo44cg>\n\t<xmx:GrJHW4SZbUmLKAnvsWhhvfriPCisrkBtW1E9dlnExl20CkFF8h69zw>\n\t<xmx:GrJHWwMD4IJgQ6zmJ6tK6aoZLUK1WqK41ssXK4qYAxlqmEOZIK4bpA>\n\t<xmx:GrJHW9V4RK8pWI2w9YPKWBx5lOssU8JQveBBSZ_UymJNcXkYAM73DQ>\n\t<xmx:GrJHWxODm78_Ts_RXrqiCj2sSvGG9FIGZsolQKm7CEuRBkqzmUOp_g>", "X-ME-Sender": "<xms:GrJHWz-PSJrLXRaaA89ykn5ViQvATLnnN5BaTfc_8JQ_4sCtSMK-2Q>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Stephen Hemminger <stephen@networkplumber.org>", "Cc": "dev@dpdk.org", "Date": "Thu, 12 Jul 2018 21:55:04 +0200", "Message-ID": "<2142629.lVosk762JX@xps>", "In-Reply-To": "<20180612232939.24793-1-stephen@networkplumber.org>", "References": "<20180612232939.24793-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]