List comments

GET /api/covers/40793/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 81966,
        "web_url": "http://patches.dpdk.org/comment/81966/",
        "msgid": "<86228AFD5BCD8E4EBFD2B90117B5E81E630BF9B0@SHSMSX103.ccr.corp.intel.com>",
        "date": "2018-06-08T02:11:46",
        "subject": "Re: [dpdk-dev] [PATCH 0/7] support VIRTIO_F_IN_ORDER feature",
        "submitter": {
            "id": 17,
            "url": "http://patches.dpdk.org/api/people/17/",
            "name": "Liu, Yong",
            "email": "yong.liu@intel.com"
        },
        "content": "Sorry, add missing loopback performance comparison.\n\n    +---------+----------+----------------+----------------+\n    |Loopback |1 Queue   |2 Queues        |4 Queues        |\n    +---------+----------+----------------+----------------+\n    |Inorder  |6.2Mpps   |9.5 ~ 11.9Mpps  |10.6 ~ 11.3Mpps |\n    +---------+----------+----------------+----------------+\n    |Normal   |7.5Mpps   |7.7 ~ 9.0Mpps   |7.6 ~ 7.8Mpps   |\n    +---------+----------+----------------+----------------+\n\nThanks,\nMarvin\n\n> -----Original Message-----\n> From: Liu, Yong\n> Sent: Friday, June 08, 2018 5:07 PM\n> To: maxime.coquelin@redhat.com; Bie, Tiwei <tiwei.bie@intel.com>\n> Cc: Wang, Zhihong <zhihong.wang@intel.com>; dev@dpdk.org; Liu, Yong\n> <yong.liu@intel.com>\n> Subject: [PATCH 0/7] support VIRTIO_F_IN_ORDER feature\n> \n> In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.\n> When this feature has been negotiated, virtio driver will use\n> descriptors in ring order: starting from offset 0 in the table, and\n> wrapping around at the end of the table. Vhost devices will always use\n> descriptors in the same order in which they have been made available.\n> This can simplify vhost and device code as desc/used/avail ring are\n> using same index.\n> \n> Based on updated virtio-spec, this series realized IN_ORDER prototype\n> in virtio driver. Due to new [RT]x path added into selection, also add\n> two new parameters mrg_rx and in_order into virtio-user vdev parameters\n> list. This will allow user to configure feature bits thus can impact\n> [RT]x path selection.\n> \n> IN_ORDER can improve virtio/vhost performance. This patch implement\n> virtio driver part only, we can see significant gain there. As a result\n> it impacts vhost performance a little since there’s no dedicated Rx/Tx\n> implementation on vhost side. This can be added in another patch later.\n> \n> Performance of virtio user with IN_ORDER feature:\n> \n>     Platform: Purely\n>     CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz\n>     DPDK baseline: 18.05\n>     Setup: testpmd with vhost vdev + testpmd with virtio vdev\n> \n>     +--------------+----------+----------+---------+\n>     |Vhost->Virtio |1 Queue   |2 Queues  |4 Queues |\n>     +--------------+----------+----------+---------+\n>     |Inorder       |12.9Mpps  |25.4Mpps  |31.6Mpps |\n>     |Normal        |12.1Mpps  |18.5Mpps  |18.9Mpps |\n>     +--------------+----------+----------+---------+\n> \n>     +--------------+----------+----------------+---------+\n>     |Virtio->Vhost |1 Queue   |2 Queues        |4 Queues |\n>     +--------------+----------+----------------+---------+\n>     |Inorder       |16.4Mpps  |11.9 ~ 19.5Mpps |11.8Mpps |\n>     |Normal        |13.3Mpps  |9.8 ~ 14Mpps    |10.5Mpps |\n>     +--------------+----------+----------------+---------+\n> \n>     +---------+----------+----------------+----------------+\n>     |Loopback |1 Queue   |2 Queues        |4 Queues        |\n>     +---------+----------+----------------+----------------+\n>     |Inorder  |6.2Mpps   |9.5 ~ 11.9Mpps  |10.6 ~ 11.3Mpps |\n>     +---------+----------+----------------+----------------+\n> \n> Marvin Liu (7):\n>   vhost: announce VIRTIO_F_IN_ORDER support\n>   net/virtio: add VIRTIO_F_IN_ORDER definition\n>   net/virtio-user: add mgr_rxbuf and in_order vdev parameters\n>   net/virtio: free IN_ORDER descriptors\n>   net/virtio: support IN_ORDER Rx and Tx\n>   net/virtio: add IN_ORDER Rx/Tx into selection\n>   net/virtio: annouce VIRTIO_F_IN_ORDER support\n> \n>  drivers/net/virtio/virtio_ethdev.c            |  31 +-\n>  drivers/net/virtio/virtio_ethdev.h            |   7 +\n>  drivers/net/virtio/virtio_pci.h               |   8 +\n>  drivers/net/virtio/virtio_rxtx.c              | 618 ++++++++++++++++--\n>  .../net/virtio/virtio_user/virtio_user_dev.c  |  10 +-\n>  .../net/virtio/virtio_user/virtio_user_dev.h  |   3 +-\n>  drivers/net/virtio/virtio_user_ethdev.c       |  33 +-\n>  drivers/net/virtio/virtqueue.c                |   8 +\n>  drivers/net/virtio/virtqueue.h                |   2 +\n>  lib/librte_vhost/socket.c                     |   4 +\n>  lib/librte_vhost/vhost.h                      |  10 +-\n>  11 files changed, 668 insertions(+), 66 deletions(-)\n> \n> --\n> 2.17.0",
        "headers": {
            "X-BeenThere": "dev@dpdk.org",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "CC": "\"Wang, Zhihong\" <zhihong.wang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "Accept-Language": "zh-CN, en-US",
            "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Thread-Index": "AQHT/sb8VJEL91BnTk++uuVzy0l4MaRVniYw",
            "dlp-product": "dlpe-windows",
            "X-Amp-File-Uploaded": "False",
            "X-MS-TNEF-Correlator": "",
            "Delivered-To": "patchwork@dpdk.org",
            "To": "\"maxime.coquelin@redhat.com\" <maxime.coquelin@redhat.com>, \"Bie, Tiwei\"\n\t<tiwei.bie@intel.com>",
            "Content-Transfer-Encoding": "base64",
            "MIME-Version": "1.0",
            "Thread-Topic": "[PATCH 0/7] support VIRTIO_F_IN_ORDER feature",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E56825592;\n\tFri,  8 Jun 2018 04:11:51 +0200 (CEST)",
                "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id D00BA37A6\n\tfor <dev@dpdk.org>; Fri,  8 Jun 2018 04:11:50 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2018 19:11:49 -0700",
                "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2018 19:11:50 -0700",
                "from fmsmsx117.amr.corp.intel.com (10.18.116.17) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 7 Jun 2018 19:11:49 -0700",
                "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tfmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 7 Jun 2018 19:11:48 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id\n\t14.03.0319.002; Fri, 8 Jun 2018 10:11:46 +0800"
            ],
            "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "Content-Language": "en-US",
            "dlp-reaction": "no-action",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "From": "\"Liu, Yong\" <yong.liu@intel.com>",
            "Subject": "Re: [dpdk-dev] [PATCH 0/7] support VIRTIO_F_IN_ORDER feature",
            "Date": "Fri, 8 Jun 2018 02:11:46 +0000",
            "Message-ID": "<86228AFD5BCD8E4EBFD2B90117B5E81E630BF9B0@SHSMSX103.ccr.corp.intel.com>",
            "X-IronPort-AV": "E=Sophos;i=\"5.49,489,1520924400\"; d=\"scan'208\";a=\"55662018\"",
            "Precedence": "list",
            "References": "<20180608090724.20855-1-yong.liu@intel.com>",
            "In-Reply-To": "<20180608090724.20855-1-yong.liu@intel.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-MS-Has-Attach": "",
            "X-Mailman-Version": "2.1.15",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "dlp-version": "11.0.200.100",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-ExtLoop1": "1",
            "X-Original-To": "patchwork@dpdk.org",
            "Errors-To": "dev-bounces@dpdk.org",
            "x-originating-ip": "[10.239.127.40]",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "x-ctpclassification": "CTP_NT",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGRlYmUzNDktNTM2MC00NWI0LWI2NDUtMGNiYzBkNTNmMDJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMHNVbm1aUTB4VGhvY3gyQkliTWJMMkJqbStmVm5lZTZHZnZwUFhTNnNuaGg3RFMzbnZjMWVlUjZtZ25pNFZzTSJ9"
        }
    }
]