Cover Detail
Show a cover letter.
GET /api/covers/125828/?format=api
{ "id": 125828, "url": "http://patches.dpdk.org/api/covers/125828/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com", "date": "2023-04-06T00:45:08", "name": "[v3,00/11] msvc integration changes", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27633, "url": "http://patches.dpdk.org/api/series/27633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27633", "date": "2023-04-06T00:45:11", "name": "msvc integration changes", "version": 3, "mbox": "http://patches.dpdk.org/series/27633/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/125828/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1224428D0;\n\tThu, 6 Apr 2023 02:45:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3117442BB1;\n\tThu, 6 Apr 2023 02:45:24 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id EC17C40DF6\n for <dev@dpdk.org>; Thu, 6 Apr 2023 02:45:21 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 1E81E210DEF4; Wed, 5 Apr 2023 17:45:21 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 1E81E210DEF4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1680741921;\n bh=0rawZ4d+5R/2cP2JIJIx78BFH3Kq4pG9STbrb9VGzQE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=WuH30FCl5Vjx8ggua/+YIjqvyJKibgcFixROlUri2deUXopIeUebGgLQp3JMhrOAa\n bHIi93kAJTsTzmS0bbWbWdN23wFQ4xgHVI0UqB82wiFrjANLfS6frclGM2BVv7gygY\n 1LMVmvZpDgvxq6Xg5g2k91DHyz+AhtbvK4pShFEA=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n thomas@monjalon.net,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 00/11] msvc integration changes", "Date": "Wed, 5 Apr 2023 17:45:08 -0700", "Message-Id": "<1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In accordance with draft plan\nhttp://mails.dpdk.org/archives/web/2023-February/002023.html\nintroduces conditionally compiled code to enable building with MSVC that\n_does not_ require C99/C11 meaning it can be integrated now.\n\nThis series covers minimal changes for item #2 in draft plan for EAL\ndependencies kvargs, telemetry and consumed EAL public headers.\n\nNote if any patch in the series requires in-depth discussion I'll\ndetach it from this series for separate submission & more focused\ndiscussion so it doesn't block the entire series.\n\n\nv3:\n * v3 does not group together conditional blocks when experimented\n with it didn't reduce conditionals enough to make it worth\n while. once msvc tests are at a running point i suggest\n a narrow targeted discussion about code organization without\n blocking this series\n * v3 does not attempt to refactor to use intrinsics for non-msvc\n compilers. again this should be done as a separate follow-up\n series later if desired\n * fix expansion of likely and unlikely macros\n * remove unnecessary define for rte_smp_{r,w}mb it is sufficient\n for these to be compiler barriers on x86\n * add a new patch to use __cpuid and __cpuidex intrinsics when\n building with msvc\n * add a new patch to use _umonitor, _umwait and _tpause intrinsics\n when building with msvc\nv2:\n * use _mm_{l,s,m}fence intrinsics for rte_smp_{r,w,}mb macros\n are intended to be memory barriers not compiler barriers on\n x86_64.\n\nTyler Retzlaff (11):\n eal: use rdtsc intrinsic when compiling with msvc\n eal: use rtm and xtest intrinsics when compiling with msvc\n eal: use barrier intrinsics when compiling with msvc\n eal: use cpuid and cpuidex intrinsics\n eal: use umonitor umwait and tpause intrinsics\n eal: typedef cpu flag enum as int for msvc\n eal: hide GCC extension based alignment markers\n eal: expand most macros to empty when using msvc\n eal: exclude exposure of rte atomic APIs for MSVC builds\n telemetry: disable json print formatting with msvc\n telemetry: avoid expanding versioned symbol macros on msvc\n\n lib/eal/include/generic/rte_atomic.h | 11 ++++++++++\n lib/eal/include/generic/rte_cpuflags.h | 12 ++++++-----\n lib/eal/include/rte_branch_prediction.h | 8 +++++++\n lib/eal/include/rte_common.h | 37 +++++++++++++++++++++++++++++++++\n lib/eal/include/rte_compat.h | 20 ++++++++++++++++++\n lib/eal/x86/include/rte_atomic.h | 9 +++++++-\n lib/eal/x86/include/rte_cycles.h | 8 +++++++\n lib/eal/x86/include/rte_rtm.h | 19 +++++++++++++++++\n lib/eal/x86/rte_cpuflags.c | 4 ++++\n lib/eal/x86/rte_cpuid.h | 7 +++++++\n lib/eal/x86/rte_cycles.c | 36 ++++++++++++++++++++++++++++++++\n lib/eal/x86/rte_hypervisor.c | 4 ++++\n lib/eal/x86/rte_power_intrinsics.c | 12 +++++++++++\n lib/telemetry/telemetry_data.c | 16 ++++++++++++++\n lib/telemetry/telemetry_json.h | 6 ++++++\n 15 files changed, 203 insertions(+), 6 deletions(-)" }