Cover Detail
Show a cover letter.
GET /api/covers/125818/?format=api
{ "id": 125818, "url": "http://patches.dpdk.org/api/covers/125818/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20230405160326.186921-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230405160326.186921-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230405160326.186921-1-bruce.richardson@intel.com", "date": "2023-04-05T16:03:21", "name": "[v3,0/5] telemetry: remove variable length arrays", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20230405160326.186921-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 27629, "url": "http://patches.dpdk.org/api/series/27629/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27629", "date": "2023-04-05T16:03:21", "name": "telemetry: remove variable length arrays", "version": 3, "mbox": "http://patches.dpdk.org/series/27629/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/125818/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CADD5428D4;\n\tWed, 5 Apr 2023 18:04:38 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B7C042BB1;\n\tWed, 5 Apr 2023 18:04:38 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id E8BCB427E9\n for <dev@dpdk.org>; Wed, 5 Apr 2023 18:04:36 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Apr 2023 09:04:16 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.40])\n by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2023 09:04:14 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1680710677; x=1712246677;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=mdLM/vF+ae3BAxuveH45rUl4ld6HBoqpwv+B6OvrMIY=;\n b=b4q7MBlnf6ufjBqhMkdVb9i5TavAdAm/3u+pYVSdDPRVpy1aDLobe2sp\n 1zJRouH26QsowuJLd3Cu5CGyD3VAZbsVk5bh60FaqJ8ed5phovVWFNJeV\n S5BztN8PApMBNjeMY7A5Px2E2/f4LrhRM3j64eIqWHYLITPHEPVFDVeV9\n 5u+JfHyN+/x3MptExsjsRO8mDB1GYjWfEOZbmjqwqKDObYHjRyI5/Wm8s\n 9HO6yLecrh/x/10Scq3PJktJ6OlN/abiaGHt3q6Ccf/Hn/r4fvpmpmMOQ\n GLw3z4wwBFh6VUNyc2anjiv4s2eyrVyT/FLwynDAfeW6/WCPNXG9Ldsfb A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10671\"; a=\"341218569\"", "E=Sophos;i=\"5.98,321,1673942400\"; d=\"scan'208\";a=\"341218569\"", "E=McAfee;i=\"6600,9927,10671\"; a=\"830405784\"", "E=Sophos;i=\"5.98,321,1673942400\"; d=\"scan'208\";a=\"830405784\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "ciara.power@intel.com, roretzla@linux.microsoft.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 0/5] telemetry: remove variable length arrays", "Date": "Wed, 5 Apr 2023 17:03:21 +0100", "Message-Id": "<20230405160326.186921-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230310181836.162336-1-bruce.richardson@intel.com>", "References": "<20230310181836.162336-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset introduces a series of changes to remove variable-length\narrays from the telemetry code. The first patch replaces a VLA with\nmalloc memory for the serialization of the json objects contained within\nthe main response object, which fixes a crash observed on alpine linux.\n\nSubsequent patches rework the json printing code to avoid the use of\ntemporary buffers where possible, or use malloc-allocated memory where\nnot.\n\nBased off testing with the unit tests for telemetry, json serialization\nfor the telemetry callbacks should always use the path where a temporary\nbuffer is *not* used, but the allocation-case is kept to ensure that any\nunexpected edge-cases are covered too.\n\nV3: remove use of non-standard asprintf function in patch 2.\n\nV2: expand from single fix for Alpine, to general cleanup to remove VLAs\n\nBruce Richardson (5):\n telemetry: fix autotest failures on Alpine\n telemetry: remove variable length array in printf fn\n telemetry: split out body of json string format fn\n telemetry: rename local variables\n telemetry: remove VLA in json string format function\n\n app/test/test_telemetry_json.c | 2 +-\n lib/telemetry/telemetry.c | 21 ++++++-\n lib/telemetry/telemetry_json.h | 111 +++++++++++++++++++++++++--------\n 3 files changed, 104 insertions(+), 30 deletions(-)\n\n--\n2.37.2" }