Cover Detail
Show a cover letter.
GET /api/covers/125812/?format=api
{ "id": 125812, "url": "http://patches.dpdk.org/api/covers/125812/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20230405154414.183915-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230405154414.183915-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230405154414.183915-1-bruce.richardson@intel.com", "date": "2023-04-05T15:44:09", "name": "[v2,0/5] telemetry: remove variable length arrays", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20230405154414.183915-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 27628, "url": "http://patches.dpdk.org/api/series/27628/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27628", "date": "2023-04-05T15:44:09", "name": "telemetry: remove variable length arrays", "version": 2, "mbox": "http://patches.dpdk.org/series/27628/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/125812/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C38E428D4;\n\tWed, 5 Apr 2023 17:44:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 473F0427E9;\n\tWed, 5 Apr 2023 17:44:34 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 63DB941133\n for <dev@dpdk.org>; Wed, 5 Apr 2023 17:44:33 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Apr 2023 08:44:25 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.40])\n by orsmga002.jf.intel.com with ESMTP; 05 Apr 2023 08:44:24 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1680709473; x=1712245473;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=mmfJC07Yk5Du4y0kJIJpE/PA7QDqrWg1Z1GRmzEdht8=;\n b=Hp2l0KPJ1I4/mfRTRI18OhVY7WEfooh5/G7Sk2NCqIEWfH81I05uZ9ca\n mt9ewm9uWNz3YC4jCce82ZVk1OHS4O3poS58ND70lOtI6XTpduLO0wKo/\n 1g/Fiw47+TTrU6n7NaPA3OKF4Ig/KtmmjaYh2xgzyGYdUTygJmgmR7MiI\n UYlm0to7ub0UzD+AsSp49QHBjpGzwiZWzHhDH0aT8fJRU6DYe31Z3QKcm\n O30g1WgCRrYEta0tiKkRWf0nHyNPx7h+Qla9yy+E7l7q8/DpGHbzkw98O\n MJYSGARHixSK1yzAp/GVZ6XXNGrZxKHL2uOAj+ocRIW3ywP7roz8pGkKa Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10671\"; a=\"339980329\"", "E=Sophos;i=\"5.98,321,1673942400\"; d=\"scan'208\";a=\"339980329\"", "E=McAfee;i=\"6600,9927,10671\"; a=\"686790237\"", "E=Sophos;i=\"5.98,321,1673942400\"; d=\"scan'208\";a=\"686790237\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "ciara.power@intel.com, roretzla@linux.microsoft.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v2 0/5] telemetry: remove variable length arrays", "Date": "Wed, 5 Apr 2023 16:44:09 +0100", "Message-Id": "<20230405154414.183915-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230310181836.162336-1-bruce.richardson@intel.com>", "References": "<20230310181836.162336-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset introduces a series of changes to remove variable-length\narrays from the telemetry code. The first patch replaces a VLA with\nmalloc memory for the serialization of the json objects contained within\nthe main response object, which fixes a crash observed on alpine linux.\n\nSubsequent patches rework the json printing code to avoid the use of\ntemporary buffers where possible, or use malloc-allocated memory where\nnot.\n\nBased off testing with the unit tests for telemetry, json serialization\nfor the telemetry callbacks should always use the path where a temporary\nbuffer is *not* used, but the allocation-case is kept to ensure that any\nunexpected edge-cases are covered too.\n\nBruce Richardson (5):\n telemetry: fix autotest failures on Alpine\n telemetry: remove variable length array in printf fn\n telemetry: split out body of json string format fn\n telemetry: rename local variables\n telemetry: remove VLA in json string format function\n\n app/test/test_telemetry_json.c | 2 +-\n lib/telemetry/telemetry.c | 21 ++++++-\n lib/telemetry/telemetry_json.h | 107 +++++++++++++++++++++++++--------\n 3 files changed, 100 insertions(+), 30 deletions(-)\n\n--\n2.37.2" }