Cover Detail
Show a cover letter.
GET /api/covers/117575/?format=api
{ "id": 117575, "url": "http://patches.dpdk.org/api/covers/117575/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru", "date": "2022-10-07T17:29:17", "name": "[v8,0/4] ethdev: support mulitiple mbuf pools per Rx queue", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 25036, "url": "http://patches.dpdk.org/api/series/25036/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25036", "date": "2022-10-07T17:29:17", "name": "ethdev: support mulitiple mbuf pools per Rx queue", "version": 8, "mbox": "http://patches.dpdk.org/series/25036/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/117575/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC7F4A00C4;\n\tFri, 7 Oct 2022 19:29:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B055F40DDC;\n\tFri, 7 Oct 2022 19:29:24 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id AB53540151\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:29:23 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 115)\n id 39B4387; Fri, 7 Oct 2022 20:29:23 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 9A6D67B;\n Fri, 7 Oct 2022 20:29:22 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD\n autolearn=no autolearn_force=no version=3.4.6", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9A6D67B", "Authentication-Results": "shelob.oktetlabs.ru/9A6D67B; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Hanumanth Pothula <hpothula@marvell.com>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>", "Cc": "dev@dpdk.org", "Subject": "[PATCH v8 0/4] ethdev: support mulitiple mbuf pools per Rx queue", "Date": "Fri, 7 Oct 2022 20:29:17 +0300", "Message-Id": "<20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221006170126.1322852-1-hpothula@marvell.com>", "References": "<20221006170126.1322852-1-hpothula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "I'm not sure in testpmd patch. Review would be useful and may be we\nshould postpone it to rc2.\n\nv8:\n - Process review notes\nv7:\n - Drop RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL offload which seems to be\n unnecessary. Positive max_rx_mempools in dev_info is sufficient to\n indicate that the capability is support and positive number of\n mempools in Rx configuration is sufficient to request it.\n - Add helper patch to factor out Rx mempool check to be shared\n for single mempool, buffer split and multiple mempools case.\n - Refine check for a way to provide Rx buffers to be one and only one.\n Either single mempool, or buffer split, or multi mempool.\n - Drop feature advertisement in net/cnxk patch since there is no\n such feature defined yet. I have no strong opinion if a new feature\n is required or not.\nv6:\n - Updated release notes, release_22_11.rst.\nv5:\n - Declared memory pools as struct rte_mempool **rx_mempools rather than\n as struct rte_mempool *mp.\n - Added the feature in release notes.\n - Updated conditions and strings as per review comments.\nv4:\n - Renamed Offload capability name from RTE_ETH_RX_OFFLOAD_BUFFER_SORT\n to RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL.\n - In struct rte_eth_rxconf, defined new pointer, which holds array of\n type struct rte_eth_rx_mempool(memory pools). This array is used\n by PMD to program multiple mempools.\nv3:\n - Implemented Pool Sort capability as new Rx offload capability,\n RTE_ETH_RX_OFFLOAD_BUFFER_SORT.\nv2:\n - Along with spec changes, uploading testpmd and driver changes.\n\nAndrew Rybchenko (1):\n ethdev: factor out helper function to check Rx mempool\n\nHanumanth Pothula (3):\n ethdev: support multiple mbuf pools per Rx queue\n net/cnxk: support mulitiple mbuf pools per Rx queue\n app/testpmd: support mulitiple mbuf pools per Rx queue\n\n app/test-pmd/testpmd.c | 34 ++++--\n app/test-pmd/testpmd.h | 3 +\n app/test-pmd/util.c | 4 +-\n doc/guides/rel_notes/release_22_11.rst | 6 +\n drivers/net/cnxk/cnxk_ethdev.c | 84 +++++++++++--\n drivers/net/cnxk/cnxk_ethdev.h | 2 +\n drivers/net/cnxk/cnxk_ethdev_ops.c | 3 +\n lib/ethdev/rte_ethdev.c | 157 +++++++++++++++++--------\n lib/ethdev/rte_ethdev.h | 29 +++++\n 9 files changed, 253 insertions(+), 69 deletions(-)" }