Cover Detail
Show a cover letter.
GET /api/covers/117336/?format=api
{ "id": 117336, "url": "http://patches.dpdk.org/api/covers/117336/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20221004173709.3482250-1-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221004173709.3482250-1-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221004173709.3482250-1-gakhil@marvell.com", "date": "2022-10-04T17:37:03", "name": "[v8,0/6] crypto/security session framework rework", "submitter": { "id": 2094, "url": "http://patches.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20221004173709.3482250-1-gakhil@marvell.com/mbox/", "series": [ { "id": 24975, "url": "http://patches.dpdk.org/api/series/24975/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24975", "date": "2022-10-04T17:37:03", "name": "crypto/security session framework rework", "version": 8, "mbox": "http://patches.dpdk.org/series/24975/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/117336/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7B6D1A0542;\n\tTue, 4 Oct 2022 19:37:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2BF0A40DDC;\n\tTue, 4 Oct 2022 19:37:30 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 0847D40A79\n for <dev@dpdk.org>; Tue, 4 Oct 2022 19:37:27 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 2948lRCh019108;\n Tue, 4 Oct 2022 10:37:23 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jxn2ptmaq-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 04 Oct 2022 10:37:23 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 4 Oct 2022 10:37:20 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 4 Oct 2022 10:37:20 -0700", "from localhost.localdomain (unknown [10.28.36.102])\n by maili.marvell.com (Postfix) with ESMTP id 9BCB33F7096;\n Tue, 4 Oct 2022 10:37:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=8qnm4/9/kdIMc/F6B5FUznYRfbNWdhYOKrNS84Cl/bI=;\n b=U12Nbk20ISDiwR/09gwFD7Nv793ajCm/pZGMuw+hXPR58hG7tgW7x6ebdc/gjY11X3mJ\n raHdAvcchlWjmHyEY9TyWLcqXyeT0lY+l+/ekWeo51J2UauzPml81pu7JXh7wwWrcBjU\n Fb58TZJ8ZTg03d6GhmuM60FJc5M1nJ54bOhiRvryHckKCzvqyGoCY3Wa92+Mo5YBG7lD\n 92zr4uMyStqEimRHA1ruqWdK+HGRmjwb1LiqzWbsmU8MxP6YSuL9R1iTEUeBFI0b2kHU\n bh0sGYKzPBW1ZWu9MtL8lndUZOpZzVIRnXuQ8m3rI1mQWR1VwmiN3xsA333XY54gdtlL tA==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <hemant.agrawal@nxp.com>, <vattunuru@marvell.com>,\n <ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>,\n <konstantin.v.ananyev@yandex.ru>, <jiawenwu@trustnetic.com>,\n <yisen.zhuang@huawei.com>, <irusskikh@marvell.com>,\n <jerinj@marvell.com>, <adwivedi@marvell.com>,\n <maxime.coquelin@redhat.com>, <chandu@amd.com>, <ruifeng.wang@arm.com>,\n <ajit.khaparde@broadcom.com>, <anoobj@marvell.com>,\n <pablo.de.lara.guarch@intel.com>, <matan@nvidia.com>,\n <g.singh@nxp.com>, <qiming.yang@intel.com>, <wenjun1.wu@intel.com>,\n <jianwang@trustnetic.com>, <jingjing.wu@intel.com>,\n <beilei.xing@intel.com>, <ndabilpuram@marvell.com>,\n <roy.fan.zhang@intel.com>, <lironh@marvell.com>,\n <royzhang1980@gmail.com>, <sunilprakashrao.uttarwar@amd.com>,\n <kai.ji@intel.com>, <rnagadheeraj@marvell.com>,\n <jianjay.zhou@huawei.com>, <radu.nicolau@intel.com>,\n Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH v8 0/6] crypto/security session framework rework", "Date": "Tue, 4 Oct 2022 23:07:03 +0530", "Message-ID": "<20221004173709.3482250-1-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221004111035.3264904-1-gakhil@marvell.com>", "References": "<20221004111035.3264904-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "RVfSavtAbcyhTYNYVkouj37_dhWOhEVi", "X-Proofpoint-GUID": "RVfSavtAbcyhTYNYVkouj37_dhWOhEVi", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1\n definitions=2022-10-04_08,2022-09-29_03,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset reworks the symmetric crypto and security session\ndata structure to use a single virtual/physical contiguous buffer\nfor symmetric crypto/security session and driver private data.\nIn addition the session data structure is now private.\nThe session is represented as an opaque pointer in the application.\n\nWith the change the session is no longer supported to be accessed\nby multiple device drivers. For the same reason\nrte_cryptodev_sym_session_init/clear APIs are deprecated as\nrte_cryptodev_sym_session_create/free will initialize and\nclear the driver specific data field.\n\nThe change was also submitted last year during DPDK 21.11\ntimeframe also[1], but was not applied due to lack of feedback from\ncommunity. Please help in getting this cleanup merged in this cycle.\n\nNow the similar work was already done for asymmetric crypto.\nThis patchset is rebased over current tree and fixes all\nthe issues reported so far.\n\nChanges in v8:\n- fixed security autotest\n\nChanges in v7:\n- fixed build for ixgbe and txgbe\n\nChanges in v6:\n- rebased over TOT\nChanges in v5:\n- rebased over latest dpdk-next-crypto tree\n\nChanges in v4:\n- squashed armv8_crypto fixes.\nhttp://patches.dpdk.org/project/dpdk/cover/20220926100120.3980185-1-ruifeng.wang@arm.com/\n\nChanges in v3:\n- Updated release notes\n- fixed checkpatch issues\n- renamed macro to get sess priv data to align with crypto macro\n- added acked-by/tested-by\n\nChanges in v2:\nThis patchset is a v2 for the patch that was sent by Fan Zhang(Intel)\nwith a few changes\n- Added security session rework also.\n- fixed issues in [2] reported on mailing list.\n- few other fixes.\n\nPlease review and provide feedback as soon as possible\nas this is intended to be merged in DPDK 22.11 RC1.\n\nCurrently the cnxk platform is tested with this change.\nRequest everyone to review and test on their platform.\n\nSpecial note to ixgbe and txgbe maintainers.\nThere is a wrong implementation for flow creation. Please check.\nA hack is added to bypass it. Please fix it separately.\n\n[1] https://patches.dpdk.org/project/dpdk/cover/20211018213452.2734720-1-gakhil@marvell.com/\n[2] https://patches.dpdk.org/project/dpdk/cover/20220829160645.378406-1-roy.fan.zhang@intel.com/\n\n\n\nAkhil Goyal (5):\n cryptodev: rework session framework\n cryptodev: hide sym session structure\n security: remove priv mempool usage\n drivers/crypto: support security session get size op\n security: hide session structure\n\nFan Zhang (1):\n crypto/scheduler: use unified session\n\n app/test-crypto-perf/cperf.h | 1 -\n app/test-crypto-perf/cperf_ops.c | 64 ++--\n app/test-crypto-perf/cperf_ops.h | 6 +-\n app/test-crypto-perf/cperf_test_latency.c | 11 +-\n app/test-crypto-perf/cperf_test_latency.h | 1 -\n .../cperf_test_pmd_cyclecount.c | 12 +-\n .../cperf_test_pmd_cyclecount.h | 1 -\n app/test-crypto-perf/cperf_test_throughput.c | 13 +-\n app/test-crypto-perf/cperf_test_throughput.h | 1 -\n app/test-crypto-perf/cperf_test_verify.c | 11 +-\n app/test-crypto-perf/cperf_test_verify.h | 1 -\n app/test-crypto-perf/main.c | 30 +-\n app/test-eventdev/test_perf_common.c | 43 +--\n app/test-eventdev/test_perf_common.h | 1 -\n app/test/test_cryptodev.c | 354 +++++-------------\n app/test/test_cryptodev_blockcipher.c | 18 +-\n app/test/test_cryptodev_security_ipsec.c | 2 +-\n app/test/test_cryptodev_security_ipsec.h | 2 +-\n app/test/test_event_crypto_adapter.c | 39 +-\n app/test/test_ipsec.c | 49 +--\n app/test/test_ipsec_perf.c | 4 +-\n app/test/test_security.c | 194 ++--------\n app/test/test_security_inline_proto.c | 26 +-\n doc/guides/prog_guide/cryptodev_lib.rst | 16 +-\n doc/guides/rel_notes/deprecation.rst | 9 -\n doc/guides/rel_notes/release_22_11.rst | 14 +\n drivers/crypto/armv8/armv8_pmd_private.h | 2 -\n drivers/crypto/armv8/rte_armv8_pmd.c | 21 +-\n drivers/crypto/armv8/rte_armv8_pmd_ops.c | 35 +-\n drivers/crypto/bcmfs/bcmfs_sym_session.c | 39 +-\n drivers/crypto/bcmfs/bcmfs_sym_session.h | 3 +-\n drivers/crypto/caam_jr/caam_jr.c | 69 +---\n drivers/crypto/ccp/ccp_crypto.c | 56 +--\n drivers/crypto/ccp/ccp_pmd_ops.c | 32 +-\n drivers/crypto/ccp/ccp_pmd_private.h | 2 -\n drivers/crypto/ccp/rte_ccp_pmd.c | 29 +-\n drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 41 +-\n drivers/crypto/cnxk/cn10k_ipsec.c | 45 +--\n drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 38 +-\n drivers/crypto/cnxk/cn9k_ipsec.c | 50 +--\n drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 55 +--\n drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 16 +-\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 70 ++--\n drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 6 +-\n drivers/crypto/dpaa_sec/dpaa_sec.c | 69 +---\n drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 7 +-\n drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 34 +-\n drivers/crypto/ipsec_mb/ipsec_mb_private.h | 41 +-\n drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 48 +--\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 69 +---\n drivers/crypto/ipsec_mb/pmd_chacha_poly.c | 4 -\n drivers/crypto/ipsec_mb/pmd_kasumi.c | 10 +-\n drivers/crypto/ipsec_mb/pmd_snow3g.c | 9 +-\n drivers/crypto/ipsec_mb/pmd_zuc.c | 4 -\n drivers/crypto/mlx5/mlx5_crypto.c | 25 +-\n drivers/crypto/mvsam/rte_mrvl_pmd.c | 11 +-\n drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 49 +--\n drivers/crypto/nitrox/nitrox_sym.c | 39 +-\n drivers/crypto/null/null_crypto_pmd.c | 20 +-\n drivers/crypto/null/null_crypto_pmd_ops.c | 33 +-\n drivers/crypto/null/null_crypto_pmd_private.h | 2 -\n .../crypto/octeontx/otx_cryptodev_hw_access.h | 1 -\n drivers/crypto/octeontx/otx_cryptodev_ops.c | 67 +---\n drivers/crypto/openssl/openssl_pmd_private.h | 2 -\n drivers/crypto/openssl/rte_openssl_pmd.c | 24 +-\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 29 +-\n drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 1 +\n drivers/crypto/qat/qat_sym.c | 15 +-\n drivers/crypto/qat/qat_sym.h | 16 +-\n drivers/crypto/qat/qat_sym_session.c | 73 ++--\n drivers/crypto/qat/qat_sym_session.h | 10 +-\n drivers/crypto/scheduler/scheduler_failover.c | 19 +-\n .../crypto/scheduler/scheduler_multicore.c | 17 +\n .../scheduler/scheduler_pkt_size_distr.c | 81 ++--\n drivers/crypto/scheduler/scheduler_pmd_ops.c | 93 ++++-\n .../crypto/scheduler/scheduler_pmd_private.h | 120 +++++-\n .../crypto/scheduler/scheduler_roundrobin.c | 11 +-\n drivers/crypto/virtio/virtio_cryptodev.c | 40 +-\n drivers/crypto/virtio/virtio_rxtx.c | 3 +-\n drivers/net/cnxk/cn10k_ethdev_sec.c | 38 +-\n drivers/net/cnxk/cn9k_ethdev_sec.c | 41 +-\n drivers/net/iavf/iavf_ipsec_crypto.c | 23 +-\n drivers/net/iavf/iavf_ipsec_crypto.h | 2 +-\n drivers/net/ixgbe/ixgbe_ipsec.c | 31 +-\n drivers/net/txgbe/txgbe_ipsec.c | 32 +-\n examples/fips_validation/fips_dev_self_test.c | 40 +-\n examples/fips_validation/main.c | 37 +-\n examples/ipsec-secgw/ipsec-secgw.c | 44 +--\n examples/ipsec-secgw/ipsec.c | 16 +-\n examples/ipsec-secgw/ipsec.h | 1 -\n examples/ipsec-secgw/ipsec_worker.c | 2 +-\n examples/l2fwd-crypto/main.c | 60 +--\n examples/vhost_crypto/main.c | 16 +-\n lib/cryptodev/cryptodev_pmd.h | 60 +--\n lib/cryptodev/cryptodev_trace_points.c | 9 -\n lib/cryptodev/rte_crypto.h | 3 +-\n lib/cryptodev/rte_crypto_sym.h | 11 +-\n lib/cryptodev/rte_cryptodev.c | 285 +++++---------\n lib/cryptodev/rte_cryptodev.h | 153 +++-----\n lib/cryptodev/rte_cryptodev_trace.h | 42 +--\n lib/cryptodev/version.map | 7 -\n lib/ipsec/rte_ipsec_group.h | 13 +-\n lib/ipsec/ses.c | 5 +-\n lib/pipeline/rte_table_action.c | 10 +-\n lib/security/rte_security.c | 33 +-\n lib/security/rte_security.h | 90 +++--\n lib/security/rte_security_driver.h | 31 +-\n lib/vhost/rte_vhost_crypto.h | 3 -\n lib/vhost/vhost_crypto.c | 28 +-\n 109 files changed, 1301 insertions(+), 2493 deletions(-)" }